René's URL Explorer Experiment


Title: Fix incorrect default value for unsafe_hash. by ericvsmith · Pull Request #5949 · python/cpython · GitHub

Open Graph Title: Fix incorrect default value for unsafe_hash. by ericvsmith · Pull Request #5949 · python/cpython

X Title: Fix incorrect default value for unsafe_hash. by ericvsmith · Pull Request #5949 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The default was None, but should be False. Since None is false-ish, this is okay, but the intent was that it be False, and it's less confusing this way.

X Description: The default was None, but should be False. Since None is false-ish, this is okay, but the intent was that it be False, and it's less confusing this way.

Opengraph URL: https://github.com/python/cpython/pull/5949

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1d93d941-a6c6-bf81-1d0c-22e1ad2e311c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9AAA:34DA5A:313F2D9:4569F33:6A4F817B
html-safe-nonceead0ebb0ed70c7d7ea31f682fb6fa5052a83c86e92efda12dac95e8cfde1e31a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUFBOjM0REE1QTozMTNGMkQ5OjQ1NjlGMzM6NkE0RjgxN0IiLCJ2aXNpdG9yX2lkIjoiMjkzNjc3MTAzOTYwNDk5ODUyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2c847676cd0c85ce96b37edcb97691c9c136d338670391f018a8dece24851e63
hovercard-subject-tagpull_request:172227195
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/5949/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8c3718b489f11604899230505696d0b141792d067897d4137272e5ddda1df780/python/cpython/pull/5949
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c3718b489f11604899230505696d0b141792d067897d4137272e5ddda1df780/python/cpython/pull/5949
og:image:altThe default was None, but should be False. Since None is false-ish, this is okay, but the intent was that it be False, and it's less confusing this way.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericvsmith
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/5949#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5949
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5949
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/5949
Reloadhttps://github.com/python/cpython/pull/5949
Reloadhttps://github.com/python/cpython/pull/5949
Please reload this pagehttps://github.com/python/cpython/pull/5949
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/5949
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
ericvsmithhttps://github.com/ericvsmith
python:masterhttps://github.com/python/cpython/tree/master
Conversationhttps://github.com/python/cpython/pull/5949
Commits16 (16)https://github.com/python/cpython/pull/5949/commits
Checkshttps://github.com/python/cpython/pull/5949/checks
Files changedhttps://github.com/python/cpython/pull/5949/files
Fix incorrect default value for unsafe_hash.https://github.com/python/cpython/pull/5949#top
ericvsmithhttps://github.com/ericvsmith
python:masterhttps://github.com/python/cpython/tree/master
https://github.com/ericvsmith
ericvsmithhttps://github.com/ericvsmith
Mar 1, 2018https://github.com/python/cpython/pull/5949#issue-301391848
Please reload this pagehttps://github.com/python/cpython/pull/5949
ericvsmithhttps://github.com/ericvsmith
January 24, 2018 07:13https://github.com/python/cpython/pull/5949#commits-pushed-5998a25
https://github.com/ericvsmith
Merge remote-tracking branch 'upstream/master'https://github.com/python/cpython/pull/5949/commits/5998a25c95733168da3029faf28d0586f22f71e9
5998a25https://github.com/python/cpython/pull/5949/commits/5998a25c95733168da3029faf28d0586f22f71e9
https://github.com/ericvsmith
Merge branch 'master' of github.com:ericvsmith/cpythonhttps://github.com/python/cpython/pull/5949/commits/900f699f53877e5371e59fb9330f8ca4348d7584
900f699https://github.com/python/cpython/pull/5949/commits/900f699f53877e5371e59fb9330f8ca4348d7584
https://github.com/ericvsmith
Merge branch 'master' of github.com:python/cpythonhttps://github.com/python/cpython/pull/5949/commits/1609d0844c0e072492c9e79fbd0ecf390e93e473
1609d08https://github.com/python/cpython/pull/5949/commits/1609d0844c0e072492c9e79fbd0ecf390e93e473
https://github.com/ericvsmith
Merge branch 'master' of github.com:python/cpythonhttps://github.com/python/cpython/pull/5949/commits/8ae6c477edfa68281c4fb1c8a8ef796f0e9cacae
8ae6c47https://github.com/python/cpython/pull/5949/commits/8ae6c477edfa68281c4fb1c8a8ef796f0e9cacae
https://github.com/ericvsmith
Merge branch 'master' of github.com:python/cpythonhttps://github.com/python/cpython/pull/5949/commits/e0156c8471dcd82bfc98a21b502ddca939fc6a3d
e0156c8https://github.com/python/cpython/pull/5949/commits/e0156c8471dcd82bfc98a21b502ddca939fc6a3d
https://github.com/ericvsmith
Merge branch 'master' of github.com:python/cpythonhttps://github.com/python/cpython/pull/5949/commits/dd9be0de9213b548fb7ae5bddb2d8b3bbcdccb7a
dd9be0dhttps://github.com/python/cpython/pull/5949/commits/dd9be0de9213b548fb7ae5bddb2d8b3bbcdccb7a
https://github.com/ericvsmith
Merge branch 'master' of github.com:python/cpythonhttps://github.com/python/cpython/pull/5949/commits/ef7a3b56a63c8c60d323a76472c39821ef02cc0b
ef7a3b5https://github.com/python/cpython/pull/5949/commits/ef7a3b56a63c8c60d323a76472c39821ef02cc0b
https://github.com/ericvsmith
Merge branch 'master' of github.com:python/cpythonhttps://github.com/python/cpython/pull/5949/commits/356ca29ecf98fd381059c1e67d9be4d3c5958393
356ca29https://github.com/python/cpython/pull/5949/commits/356ca29ecf98fd381059c1e67d9be4d3c5958393
https://github.com/ericvsmith
Merge branch 'master' of github.com:python/cpythonhttps://github.com/python/cpython/pull/5949/commits/5f4a3ccabf9fdcf1c73bd34e30f1b6f26d450da3
5f4a3cchttps://github.com/python/cpython/pull/5949/commits/5f4a3ccabf9fdcf1c73bd34e30f1b6f26d450da3
https://github.com/ericvsmith
Merge remote-tracking branch 'refs/remotes/origin/master'https://github.com/python/cpython/pull/5949/commits/d8ef404b0eecc1387c3955a6be932155022bfc25
d8ef404https://github.com/python/cpython/pull/5949/commits/d8ef404b0eecc1387c3955a6be932155022bfc25
https://github.com/ericvsmith
Merge branch 'master' of github.com:ericvsmith/cpythonhttps://github.com/python/cpython/pull/5949/commits/dda3dbf87b88e20be49300df9fa7b279f0106a6a
dda3dbfhttps://github.com/python/cpython/pull/5949/commits/dda3dbf87b88e20be49300df9fa7b279f0106a6a
https://github.com/ericvsmith
Merge branch 'master' of github.com:python/cpythonhttps://github.com/python/cpython/pull/5949/commits/4916fff35ee39f27bde6df7ffd88ab11fd9b6bbe
4916fffhttps://github.com/python/cpython/pull/5949/commits/4916fff35ee39f27bde6df7ffd88ab11fd9b6bbe
https://github.com/ericvsmith
Merge branch 'master' of github.com:python/cpythonhttps://github.com/python/cpython/pull/5949/commits/9f907d2672f41f27bed36f039f68ced4c5fbb57a
9f907d2https://github.com/python/cpython/pull/5949/commits/9f907d2672f41f27bed36f039f68ced4c5fbb57a
https://github.com/ericvsmith
Merge branch 'master' of github.com:python/cpythonhttps://github.com/python/cpython/pull/5949/commits/50a90929ef578053356ecce2486c8e2a3562b88b
50a9092https://github.com/python/cpython/pull/5949/commits/50a90929ef578053356ecce2486c8e2a3562b88b
https://github.com/ericvsmith
Merge branch 'master' of github.com:ericvsmith/cpythonhttps://github.com/python/cpython/pull/5949/commits/6513c67179a81a5e49309d600b84b5755b09bfb1
6513c67https://github.com/python/cpython/pull/5949/commits/6513c67179a81a5e49309d600b84b5755b09bfb1
https://github.com/ericvsmith
Fixed incorrect default value for unsafe_hash.https://github.com/python/cpython/pull/5949/commits/714d4990758447c25a72821878c5d29b6b329ff9
714d499https://github.com/python/cpython/pull/5949/commits/714d4990758447c25a72821878c5d29b6b329ff9
https://github.com/ericvsmith
ericvsmithhttps://github.com/ericvsmith
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Mar 1, 2018https://github.com/python/cpython/pull/5949#event-1498923244
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Mar 1, 2018https://github.com/python/cpython/pull/5949#event-1498923298
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 1, 2018https://github.com/python/cpython/pull/5949#event-1498923303
https://github.com/ericvsmith
ericvsmithhttps://github.com/ericvsmith
5da8cfbhttps://github.com/python/cpython/commit/5da8cfb838fa1bf3529c085c6dce1adf3d1eaf62
Mar 1, 2018https://github.com/python/cpython/pull/5949#event-1498947111
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 1, 2018https://github.com/python/cpython/pull/5949#issuecomment-369584447
@ericvsmithhttps://github.com/ericvsmith
Please reload this pagehttps://github.com/python/cpython/pull/5949
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 1, 2018https://github.com/python/cpython/pull/5949#event-1498947173
https://github.com/ericvsmith
ericvsmithhttps://github.com/ericvsmith
March 1, 2018 13:01https://github.com/python/cpython/pull/5949#event-1498947255
miss-islingtonhttps://github.com/miss-islington
Mar 1, 2018 https://github.com/python/cpython/pull/5949#ref-commit-2d6ff1a
https://github.com/ericvsmith
https://github.com/miss-islington
Fixed incorrect default value for dataclass unsafe_hash. (https://github.com/miss-islington/cpython/commit/2d6ff1a0dae2f245cd2f1adf8b8aa6ee52ba2f1d
pythonGH-5949https://github.com/python/cpython/pull/5949
)https://github.com/miss-islington/cpython/commit/2d6ff1a0dae2f245cd2f1adf8b8aa6ee52ba2f1d
2d6ff1ahttps://github.com/miss-islington/cpython/commit/2d6ff1a0dae2f245cd2f1adf8b8aa6ee52ba2f1d
5da8cfbhttps://github.com/miss-islington/cpython/commit/5da8cfb838fa1bf3529c085c6dce1adf3d1eaf62
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 1, 2018https://github.com/python/cpython/pull/5949#issuecomment-369584734
GH-5950https://github.com/python/cpython/pull/5950
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/5949
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Mar 1, 2018https://github.com/python/cpython/pull/5949#event-1498949013
ericvsmithhttps://github.com/ericvsmith
Mar 1, 2018 https://github.com/python/cpython/pull/5949#ref-commit-398242a
https://github.com/miss-islington
https://github.com/ericvsmith
Fixed incorrect default value for dataclass unsafe_hash. (https://github.com/python/cpython/commit/398242a5b61067e3171b11964229fba87a251ef7
GH-5949https://github.com/python/cpython/pull/5949
) (https://github.com/python/cpython/commit/398242a5b61067e3171b11964229fba87a251ef7
G…https://github.com/python/cpython/pull/5950
398242ahttps://github.com/python/cpython/commit/398242a5b61067e3171b11964229fba87a251ef7
…H-5950https://github.com/python/cpython/pull/5950
5da8cfbhttps://github.com/python/cpython/commit/5da8cfb838fa1bf3529c085c6dce1adf3d1eaf62
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5949
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/5949
https://github.com/ericvsmith
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.