René's URL Explorer Experiment


Title: bpo-32844: subprocess: Fix a potential misredirection of a low fd to stderr by izbyshev · Pull Request #5689 · python/cpython · GitHub

Open Graph Title: bpo-32844: subprocess: Fix a potential misredirection of a low fd to stderr by izbyshev · Pull Request #5689 · python/cpython

X Title: bpo-32844: subprocess: Fix a potential misredirection of a low fd to stderr by izbyshev · Pull Request #5689 · python/cpython

Description: When redirecting, subprocess attempts to achieve the following state: each fd to be redirected to is less than or equal to the fd it is redirected from, which is necessary because redirection occurs in the ascending order of destination descriptors. It fails to do so in a couple of corner cases, for example, if 1 is redirected to 2 and 0 is closed in the parent. https://bugs.python.org/issue32844

Open Graph Description: When redirecting, subprocess attempts to achieve the following state: each fd to be redirected to is less than or equal to the fd it is redirected from, which is necessary because redirection occur...

X Description: When redirecting, subprocess attempts to achieve the following state: each fd to be redirected to is less than or equal to the fd it is redirected from, which is necessary because redirection occur...

Opengraph URL: https://github.com/python/cpython/pull/5689

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ce1b7a59-16b2-b7ff-db04-700a80abfa6e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id93AA:37E3D3:617ADD5:88AEAE5:6A501338
html-safe-nonce3aea66729912d7a14a534f26ed1400d4aa1a316116ff6b13a3922274c456aa86
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0FBOjM3RTNEMzo2MTdBREQ1Ojg4QUVBRTU6NkE1MDEzMzgiLCJ2aXNpdG9yX2lkIjoiOTcyMjUwODg5NTg1NjkzNDk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2cfebdb704451348a5e7df7e4b72ebc467375c89904357bef48baa0d36ebf663
hovercard-subject-tagpull_request:169224035
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/5689/files
twitter:imagehttps://avatars.githubusercontent.com/u/11427362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11427362?s=400&v=4
og:image:altWhen redirecting, subprocess attempts to achieve the following state: each fd to be redirected to is less than or equal to the fd it is redirected from, which is necessary because redirection occur...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefe4f38b24922a1ce81c1708c3793b47c185599b9144ab94f6ca846b00698058d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release42b6390c91978a16f9196c38c7a00e9bf21f37e7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/5689/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5689%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5689%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/5689/files
Reloadhttps://github.com/python/cpython/pull/5689/files
Reloadhttps://github.com/python/cpython/pull/5689/files
Please reload this pagehttps://github.com/python/cpython/pull/5689/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/5689/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
izbyshev:bpo-32844https://github.com/izbyshev/cpython/tree/bpo-32844
Conversation 10 https://github.com/python/cpython/pull/5689
Commits 4 https://github.com/python/cpython/pull/5689/commits
Checks 0 https://github.com/python/cpython/pull/5689/checks
Files changed https://github.com/python/cpython/pull/5689/files
Please reload this pagehttps://github.com/python/cpython/pull/5689/files
bpo-32844: subprocess: Fix a potential misredirection of a low fd to stderr https://github.com/python/cpython/pull/5689/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/5689/files
b42ff44 bpo-32844: subprocess: Fix a potential misredirection of a low fd to … Feb 14, 2018 https://github.com/python/cpython/pull/5689/commits/b42ff446f68b4135adff0e91582433199041658d
2a591c7 Add NEWS entry Feb 28, 2018 https://github.com/python/cpython/pull/5689/commits/2a591c7d5c2b20288e7fec2c86f1ead0af29acad
19eccf0 Compute an excluded descriptor in clearer manner Mar 25, 2018 https://github.com/python/cpython/pull/5689/commits/19eccf08d8a7db4cf610fdd9948efc04e202dfd1
aa120c2 Add a friendly message for assertion check Mar 25, 2018 https://github.com/python/cpython/pull/5689/commits/aa120c2dc17a283630f1f269a8cda8c079862530
Clear filters https://github.com/python/cpython/pull/5689/files
Please reload this pagehttps://github.com/python/cpython/pull/5689/files
Please reload this pagehttps://github.com/python/cpython/pull/5689/files
test_subprocess.py https://github.com/python/cpython/pull/5689/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
2018-02-28-13-08-00.bpo-32844.u8tnAe.rst https://github.com/python/cpython/pull/5689/files#diff-f1a6ec25798d20303f0f6de47119d788cc908b45176bc9f93241b05f761a28b0
_posixsubprocess.c https://github.com/python/cpython/pull/5689/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
Lib/test/test_subprocess.pyhttps://github.com/python/cpython/pull/5689/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
View file https://github.com/izbyshev/cpython/blob/aa120c2dc17a283630f1f269a8cda8c079862530/Lib/test/test_subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5689/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5689/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
https://github.com/python/cpython/pull/5689/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
https://github.com/python/cpython/pull/5689/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
izbyshevhttps://github.com/izbyshev
Mar 25, 2018https://github.com/python/cpython/pull/5689/files#r176955238
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5689/files
https://github.com/python/cpython/pull/5689/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
Misc/NEWS.d/next/Library/2018-02-28-13-08-00.bpo-32844.u8tnAe.rsthttps://github.com/python/cpython/pull/5689/files#diff-f1a6ec25798d20303f0f6de47119d788cc908b45176bc9f93241b05f761a28b0
View file https://github.com/izbyshev/cpython/blob/aa120c2dc17a283630f1f269a8cda8c079862530/Misc/NEWS.d/next/Library/2018-02-28-13-08-00.bpo-32844.u8tnAe.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5689/{{ revealButtonHref }}
Modules/_posixsubprocess.chttps://github.com/python/cpython/pull/5689/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
View file https://github.com/izbyshev/cpython/blob/aa120c2dc17a283630f1f269a8cda8c079862530/Modules/_posixsubprocess.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5689/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5689/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/5689/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.