| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8ca4fd07-addd-3541-f804-4992c1243ef1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C614:D9FFD:6012F2:8356E3:6A4F3836 |
| html-safe-nonce | 7ecc41a206087404d6ed784db877f992553fa8e50acf8c195e1cfda721f4ed9b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjE0OkQ5RkZEOjYwMTJGMjo4MzU2RTM6NkE0RjM4MzYiLCJ2aXNpdG9yX2lkIjoiODk1MTU0MDg1Njk0MDA4MzI1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 195e197b048a54cfe8a26575c9c4546f8f43e718fff66cbc2dffc280f7923dbc |
| hovercard-subject-tag | pull_request:169224035 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/5689/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/affb0c3d8b1c0e0ff47a3b6e6ef737c1966cdd4404dc24d6d886086ff7aff8bd/python/cpython/pull/5689 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/affb0c3d8b1c0e0ff47a3b6e6ef737c1966cdd4404dc24d6d886086ff7aff8bd/python/cpython/pull/5689 |
| og:image:alt | When redirecting, subprocess attempts to achieve the following state:
each fd to be redirected to is less than or equal to the fd
it is redirected from, which is necessary because redirection
occur... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | izbyshev |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/5689#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5689 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5689 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/5689 |
| Reload | https://github.com/python/cpython/pull/5689 |
| Reload | https://github.com/python/cpython/pull/5689 |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| gpshead | https://github.com/gpshead |
| python:master | https://github.com/python/cpython/tree/master |
| izbyshev:bpo-32844 | https://github.com/izbyshev/cpython/tree/bpo-32844 |
| Conversation | https://github.com/python/cpython/pull/5689 |
| Commits4 (4) | https://github.com/python/cpython/pull/5689/commits |
| Checks | https://github.com/python/cpython/pull/5689/checks |
| Files changed | https://github.com/python/cpython/pull/5689/files |
| bpo-32844: subprocess: Fix a potential misredirection of a low fd to stderr | https://github.com/python/cpython/pull/5689#top |
| gpshead | https://github.com/gpshead |
| python:master | https://github.com/python/cpython/tree/master |
| izbyshev:bpo-32844 | https://github.com/izbyshev/cpython/tree/bpo-32844 |
|
| https://github.com/izbyshev |
| izbyshev | https://github.com/izbyshev |
| Feb 14, 2018 | https://github.com/python/cpython/pull/5689#issue-297247903 |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
| https://bugs.python.org/issue32844 | https://bugs.python.org/issue32844 |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
| bpo-32844: subprocess: Fix a potential misredirection of a low fd to … | https://github.com/python/cpython/pull/5689/commits/b42ff446f68b4135adff0e91582433199041658d |
| b42ff44 | https://github.com/python/cpython/pull/5689/commits/b42ff446f68b4135adff0e91582433199041658d |
| https://github.com/izbyshev |
| izbyshev | https://github.com/izbyshev |
| gpshead | https://github.com/gpshead |
| code owner | https://github.com/python/cpython/blob/7745ec4e356ac1f4eaf43b155f4482c20a907d48/.github/CODEOWNERS#L41 |
| February 14, 2018 21:16 | https://github.com/python/cpython/pull/5689#event-1474712710 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Feb 14, 2018 | https://github.com/python/cpython/pull/5689#event-1474712785 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Feb 14, 2018 | https://github.com/python/cpython/pull/5689#event-1474712804 |
| Add NEWS entry | https://github.com/python/cpython/pull/5689/commits/2a591c7d5c2b20288e7fec2c86f1ead0af29acad |
| 2a591c7 | https://github.com/python/cpython/pull/5689/commits/2a591c7d5c2b20288e7fec2c86f1ead0af29acad |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| Mar 25, 2018 | https://github.com/python/cpython/pull/5689#event-1539735319 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
needs backport to 3.6
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22 |
| Mar 25, 2018 | https://github.com/python/cpython/pull/5689#event-1539735386 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
Mar 25, 2018
| https://github.com/python/cpython/pull/5689#pullrequestreview-106741268 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5689/files/2a591c7d5c2b20288e7fec2c86f1ead0af29acad |
| Lib/test/test_subprocess.py | https://github.com/python/cpython/pull/5689/files/2a591c7d5c2b20288e7fec2c86f1ead0af29acad#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782 |
| gpshead | https://github.com/gpshead |
| Mar 25, 2018 | https://github.com/python/cpython/pull/5689#discussion_r176951710 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
| Lib/test/test_subprocess.py | https://github.com/python/cpython/pull/5689/files/2a591c7d5c2b20288e7fec2c86f1ead0af29acad#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782 |
| gpshead | https://github.com/gpshead |
| Mar 25, 2018 | https://github.com/python/cpython/pull/5689#discussion_r176951767 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Mar 25, 2018 | https://github.com/python/cpython/pull/5689#issuecomment-375998230 |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Mar 25, 2018 | https://github.com/python/cpython/pull/5689#event-1539741164 |
| March 26, 2018 00:31 | https://github.com/python/cpython/pull/5689#commits-pushed-19eccf0 |
| Compute an excluded descriptor in clearer manner | https://github.com/python/cpython/pull/5689/commits/19eccf08d8a7db4cf610fdd9948efc04e202dfd1 |
| 19eccf0 | https://github.com/python/cpython/pull/5689/commits/19eccf08d8a7db4cf610fdd9948efc04e202dfd1 |
| Add a friendly message for assertion check | https://github.com/python/cpython/pull/5689/commits/aa120c2dc17a283630f1f269a8cda8c079862530 |
| aa120c2 | https://github.com/python/cpython/pull/5689/commits/aa120c2dc17a283630f1f269a8cda8c079862530 |
| https://github.com/izbyshev |
| izbyshev | https://github.com/izbyshev |
|
Mar 25, 2018
| https://github.com/python/cpython/pull/5689#pullrequestreview-106744475 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5689/files/19eccf08d8a7db4cf610fdd9948efc04e202dfd1 |
| Lib/test/test_subprocess.py | https://github.com/python/cpython/pull/5689/files/2a591c7d5c2b20288e7fec2c86f1ead0af29acad..19eccf08d8a7db4cf610fdd9948efc04e202dfd1#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782 |
| izbyshev | https://github.com/izbyshev |
| Mar 25, 2018 | https://github.com/python/cpython/pull/5689#discussion_r176955088 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
| https://github.com/izbyshev |
| izbyshev | https://github.com/izbyshev |
|
Mar 25, 2018
| https://github.com/python/cpython/pull/5689#pullrequestreview-106744630 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5689/files/aa120c2dc17a283630f1f269a8cda8c079862530 |
| Lib/test/test_subprocess.py | https://github.com/python/cpython/pull/5689/files/19eccf08d8a7db4cf610fdd9948efc04e202dfd1..aa120c2dc17a283630f1f269a8cda8c079862530#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782 |
| izbyshev | https://github.com/izbyshev |
| Mar 25, 2018 | https://github.com/python/cpython/pull/5689#discussion_r176955238 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
| https://github.com/izbyshev |
| izbyshev | https://github.com/izbyshev |
| Mar 25, 2018 | https://github.com/python/cpython/pull/5689#issuecomment-376006082 |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Mar 25, 2018 | https://github.com/python/cpython/pull/5689#event-1539782483 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Mar 25, 2018 | https://github.com/python/cpython/pull/5689#issuecomment-376006086 |
| @gpshead | https://github.com/gpshead |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting change review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22 |
| Mar 25, 2018 | https://github.com/python/cpython/pull/5689#event-1539782486 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
Mar 26, 2018
| https://github.com/python/cpython/pull/5689#pullrequestreview-107047185 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5689/files/aa120c2dc17a283630f1f269a8cda8c079862530 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting change review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22 |
| Mar 26, 2018 | https://github.com/python/cpython/pull/5689#event-1541713189 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| 0e7144b | https://github.com/python/cpython/commit/0e7144b064a19493a146af94175a087b3888c37b |
| Mar 26, 2018 | https://github.com/python/cpython/pull/5689#event-1541715255 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Mar 26, 2018 | https://github.com/python/cpython/pull/5689#issuecomment-376289569 |
| @izbyshev | https://github.com/izbyshev |
| @gpshead | https://github.com/gpshead |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
needs backport to 3.7
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22 |
| Mar 26, 2018 | https://github.com/python/cpython/pull/5689#event-1541715306 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Mar 26, 2018 | https://github.com/python/cpython/pull/5689#issuecomment-376289637 |
| GH-6262 | https://github.com/python/cpython/pull/6262 |
| 3.7 branch | https://github.com/python/cpython/tree/3.7 |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Mar 26, 2018 | https://github.com/python/cpython/pull/5689#issuecomment-376289904 |
| GH-6263 | https://github.com/python/cpython/pull/6263 |
| 3.6 branch | https://github.com/python/cpython/tree/3.6 |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.6
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22 |
| Mar 26, 2018 | https://github.com/python/cpython/pull/5689#event-1541717382 |
| https://github.com/izbyshev |
| izbyshev | https://github.com/izbyshev |
| March 26, 2018 20:02 | https://github.com/python/cpython/pull/5689#event-1541739510 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5689 |
|
| https://github.com/gpshead |
|
gpshead
| https://github.com/gpshead |
|
| https://github.com/python/cpython/pull/5689/files/aa120c2dc17a283630f1f269a8cda8c079862530 |
|
| https://github.com/gpshead |
|
gpshead
| https://github.com/gpshead |
| Please reload this page | https://github.com/python/cpython/pull/5689 |
|
| https://github.com/izbyshev |
|
| https://github.com/bedevere-bot |
|
| https://github.com/miss-islington |
|
| https://github.com/gpshead |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |