René's URL Explorer Experiment


Title: [2.7] bpo-18533: Avoid RuntimeError from repr() of recursive dictview [GH-4823] by bennorth · Pull Request #5357 · python/cpython · GitHub

Open Graph Title: [2.7] bpo-18533: Avoid RuntimeError from repr() of recursive dictview [GH-4823] by bennorth · Pull Request #5357 · python/cpython

X Title: [2.7] bpo-18533: Avoid RuntimeError from repr() of recursive dictview [GH-4823] by bennorth · Pull Request #5357 · python/cpython

Description: As suggested in a message on BPO, this is a backport of #4823 to the 2.7 branch. Compared to the changes introduced in #4823, this PR: Works with the existing explicit seq_str in dictview_repr(). Uses PyString... (instead of PyUnicode...). Sets up the test-case dictionaries to contain viewvalues() and viewitems() (instead of values() and items()). Checks for RuntimeError (instead of RecursionError). Updates the news entry accordingly. I kept the test on OrderedDict even though 2.7 behaves correctly already; please let me know if it would be cleaner to omit this part. https://bugs.python.org/issue18533

Open Graph Description: As suggested in a message on BPO, this is a backport of #4823 to the 2.7 branch. Compared to the changes introduced in #4823, this PR: Works with the existing explicit seq_str in dictview_repr()....

X Description: As suggested in a message on BPO, this is a backport of #4823 to the 2.7 branch. Compared to the changes introduced in #4823, this PR: Works with the existing explicit seq_str in dictview_repr()....

Opengraph URL: https://github.com/python/cpython/pull/5357

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9fdfd972-5269-e26d-4eb3-25a490a17139
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9176:361874:3922BB:52B0A5:6A4D0DBE
html-safe-noncee8bb4e8518d58f5cc939b0164b2c5fdb5751aadfe9b6919877409f76b3563a1c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTc2OjM2MTg3NDozOTIyQkI6NTJCMEE1OjZBNEQwREJFIiwidmlzaXRvcl9pZCI6IjQ1NDI3ODE5NDQ2NTE0ODM1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4bf5ad1987bc83c314c4e439fbabd20b7816be965cb5a3aa886c047a48dffd07
hovercard-subject-tagpull_request:165511358
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/5357/files
twitter:imagehttps://avatars.githubusercontent.com/u/9059396?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9059396?s=400&v=4
og:image:altAs suggested in a message on BPO, this is a backport of #4823 to the 2.7 branch. Compared to the changes introduced in #4823, this PR: Works with the existing explicit seq_str in dictview_repr()....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebcb4661e6fb4fe8b394c51ea02ccdb2236d40dc59afc75a3bbba50bf6517134c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb70bd3c4b2bec429781b65419e912c66e2d5581
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/5357/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5357%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5357%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/5357/files
Reloadhttps://github.com/python/cpython/pull/5357/files
Reloadhttps://github.com/python/cpython/pull/5357/files
Please reload this pagehttps://github.com/python/cpython/pull/5357/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/5357/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:2.7https://github.com/python/cpython/tree/2.7
bennorth:backport-d7773d9-2.7https://github.com/bennorth/cpython/tree/backport-d7773d9-2.7
Conversation 4 https://github.com/python/cpython/pull/5357
Commits 1 https://github.com/python/cpython/pull/5357/commits
Checks 0 https://github.com/python/cpython/pull/5357/checks
Files changed https://github.com/python/cpython/pull/5357/files
Please reload this pagehttps://github.com/python/cpython/pull/5357/files
[2.7] bpo-18533: Avoid RuntimeError from repr() of recursive dictview [GH-4823] https://github.com/python/cpython/pull/5357/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/5357/files
a27a0d4 bpo-18533: Avoid RuntimeError from repr() of recursive dictview (#4823) bennorth Jan 26, 2018 https://github.com/python/cpython/pull/5357/commits/a27a0d4334d09351c6545fe0a7895cee51d46bcd
Clear filters https://github.com/python/cpython/pull/5357/files
Please reload this pagehttps://github.com/python/cpython/pull/5357/files
Please reload this pagehttps://github.com/python/cpython/pull/5357/files
test_dictviews.py https://github.com/python/cpython/pull/5357/files#diff-4a29dc78e51ef6089955fe3b9d6fb2fd53ce9873b5a6841ea422f7d104021f48
test_ordered_dict.py https://github.com/python/cpython/pull/5357/files#diff-f19d3282864344be60adeaf4a9307e192a8e871155bca771d000449d74aa5639
2017-12-13-16-46-23.bpo-18533.Dlk8d7.rst https://github.com/python/cpython/pull/5357/files#diff-5418b93017dd6a3c3200707e5d7626fd698ea8ec4493f56da27ae97b73d3ddde
dictobject.c https://github.com/python/cpython/pull/5357/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Lib/test/test_dictviews.pyhttps://github.com/python/cpython/pull/5357/files#diff-4a29dc78e51ef6089955fe3b9d6fb2fd53ce9873b5a6841ea422f7d104021f48
View file https://github.com/bennorth/cpython/blob/a27a0d4334d09351c6545fe0a7895cee51d46bcd/Lib/test/test_dictviews.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5357/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5357/files#diff-4a29dc78e51ef6089955fe3b9d6fb2fd53ce9873b5a6841ea422f7d104021f48
https://github.com/python/cpython/pull/5357/files#diff-4a29dc78e51ef6089955fe3b9d6fb2fd53ce9873b5a6841ea422f7d104021f48
https://github.com/python/cpython/pull/5357/files#diff-4a29dc78e51ef6089955fe3b9d6fb2fd53ce9873b5a6841ea422f7d104021f48
Lib/test/test_ordered_dict.pyhttps://github.com/python/cpython/pull/5357/files#diff-f19d3282864344be60adeaf4a9307e192a8e871155bca771d000449d74aa5639
View file https://github.com/bennorth/cpython/blob/a27a0d4334d09351c6545fe0a7895cee51d46bcd/Lib/test/test_ordered_dict.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5357/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5357/files#diff-f19d3282864344be60adeaf4a9307e192a8e871155bca771d000449d74aa5639
https://github.com/python/cpython/pull/5357/files#diff-f19d3282864344be60adeaf4a9307e192a8e871155bca771d000449d74aa5639
Misc/NEWS.d/next/Core and Builtins/2017-12-13-16-46-23.bpo-18533.Dlk8d7.rsthttps://github.com/python/cpython/pull/5357/files#diff-5418b93017dd6a3c3200707e5d7626fd698ea8ec4493f56da27ae97b73d3ddde
View file https://github.com/bennorth/cpython/blob/a27a0d4334d09351c6545fe0a7895cee51d46bcd/Misc/NEWS.d/next/Core%20and%20Builtins/2017-12-13-16-46-23.bpo-18533.Dlk8d7.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5357/{{ revealButtonHref }}
Objects/dictobject.chttps://github.com/python/cpython/pull/5357/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
View file https://github.com/bennorth/cpython/blob/a27a0d4334d09351c6545fe0a7895cee51d46bcd/Objects/dictobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5357/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5357/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/5357/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.