René's URL Explorer Experiment


Title: [2.7] bpo-32304: Fix distutils upload for tar files ending with b'\r' (GH-5264) by bbayles · Pull Request #5331 · python/cpython · GitHub

Open Graph Title: [2.7] bpo-32304: Fix distutils upload for tar files ending with b'\r' (GH-5264) by bbayles · Pull Request #5331 · python/cpython

X Title: [2.7] bpo-32304: Fix distutils upload for tar files ending with b'\r' (GH-5264) by bbayles · Pull Request #5331 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This PR brings #5264, which @merwok merged, to version 2.7. https://bugs.python.org/issue32304

X Description: This PR brings #5264, which @merwok merged, to version 2.7. https://bugs.python.org/issue32304

Opengraph URL: https://github.com/python/cpython/pull/5331

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3e22f3df-a383-de92-35ad-f4790237bbd0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA284:3FF0AC:152A03E:1D363FC:6A4DEE99
html-safe-nonce1ba4be59a74e0170480d4f9ed063383952e8f073ca3d0f06dc4ea739d41c94ad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjg0OjNGRjBBQzoxNTJBMDNFOjFEMzYzRkM6NkE0REVFOTkiLCJ2aXNpdG9yX2lkIjoiMzE4Nzc3MjYyMjA1NTAwOTk0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac493dfeb329d06af1abb3884de428fcf8d84ec554d8c45aa989f23ec04e60e292
hovercard-subject-tagpull_request:165274768
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/5331/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dd1f9f9b9441d18aa58b15f52fd497628b4e6de76bb10d3744e45a6519c704e9/python/cpython/pull/5331
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dd1f9f9b9441d18aa58b15f52fd497628b4e6de76bb10d3744e45a6519c704e9/python/cpython/pull/5331
og:image:altThis PR brings #5264, which @merwok merged, to version 2.7. https://bugs.python.org/issue32304
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebbayles
hostnamegithub.com
expected-hostnamegithub.com
None5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef4bb89367ca678f057d79b1abc45d6675b1bd5b2
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/5331#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5331
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5331
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/5331
Reloadhttps://github.com/python/cpython/pull/5331
Reloadhttps://github.com/python/cpython/pull/5331
Please reload this pagehttps://github.com/python/cpython/pull/5331
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/5331
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
merwokhttps://github.com/merwok
python:2.7https://github.com/python/cpython/tree/2.7
bbayles:backport-2fc98ae-2.7https://github.com/bbayles/cpython/tree/backport-2fc98ae-2.7
Conversationhttps://github.com/python/cpython/pull/5331
Commits4 (4)https://github.com/python/cpython/pull/5331/commits
Checkshttps://github.com/python/cpython/pull/5331/checks
Files changedhttps://github.com/python/cpython/pull/5331/files
[2.7] bpo-32304: Fix distutils upload for tar files ending with b'\r' (GH-5264)https://github.com/python/cpython/pull/5331#top
merwokhttps://github.com/merwok
python:2.7https://github.com/python/cpython/tree/2.7
bbayles:backport-2fc98ae-2.7https://github.com/bbayles/cpython/tree/backport-2fc98ae-2.7
https://github.com/bbayles
bbayleshttps://github.com/bbayles
Jan 26, 2018https://github.com/python/cpython/pull/5331#issue-291777729
Please reload this pagehttps://github.com/python/cpython/pull/5331
#5264https://github.com/python/cpython/pull/5264
@merwokhttps://github.com/merwok
https://bugs.python.org/issue32304https://bugs.python.org/issue32304
Please reload this pagehttps://github.com/python/cpython/pull/5331
https://github.com/bbayles
[2.7] bpo-32304: Fix distutils upload for sdists ending with \x0d (https://github.com/python/cpython/pull/5331/commits/85bb01b584c2026aaf4ff471e262a08d143f58de
py…https://github.com/python/cpython/pull/5264
85bb01bhttps://github.com/python/cpython/pull/5331/commits/85bb01b584c2026aaf4ff471e262a08d143f58de
…thonGH-5264https://github.com/python/cpython/pull/5264
2fc98aehttps://github.com/bbayles/cpython/commit/2fc98ae115e2a2095a0bcf388c27a878aafdb454
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Jan 26, 2018https://github.com/python/cpython/pull/5331#event-1442867355
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 26, 2018 https://github.com/python/cpython/pull/5331#ref-pullrequest-290313168
bpo-32304: Fix distutils upload for tar files ending with b'\r' #5264 https://github.com/python/cpython/pull/5264
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jan 26, 2018https://github.com/python/cpython/pull/5331#event-1442867360
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 26, 2018https://github.com/python/cpython/pull/5331#event-1442867365
https://github.com/merwok
merwokhttps://github.com/merwok
Jan 26, 2018https://github.com/python/cpython/pull/5331#issuecomment-360850988
Please reload this pagehttps://github.com/python/cpython/pull/5331
https://github.com/merwok
merwokhttps://github.com/merwok
Jan 26, 2018 https://github.com/python/cpython/pull/5331#pullrequestreview-91911491
View reviewed changes https://github.com/python/cpython/pull/5331/files/85bb01b584c2026aaf4ff471e262a08d143f58de
Lib/distutils/tests/test_upload.pyhttps://github.com/python/cpython/pull/5331/files/85bb01b584c2026aaf4ff471e262a08d143f58de#diff-884a57e2484f7be025c62d342fc69379828d93f31e8717642750c9e28dd43fd9
merwokhttps://github.com/merwok
Jan 26, 2018https://github.com/python/cpython/pull/5331#discussion_r164173400
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://travis-ci.org/python/cpython/jobs/333550360#L2640-L2647https://travis-ci.org/python/cpython/jobs/333550360#L2640-L2647
Please reload this pagehttps://github.com/python/cpython/pull/5331
bbayleshttps://github.com/bbayles
Jan 26, 2018https://github.com/python/cpython/pull/5331#discussion_r164248317
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
cmd.show_responsehttps://github.com/python/cpython/pull/5331/files/85bb01b584c2026aaf4ff471e262a08d143f58de#diff-560972711f060c4e2db13d7d9067a84bR149
Please reload this pagehttps://github.com/python/cpython/pull/5331
bbayleshttps://github.com/bbayles
January 26, 2018 17:49https://github.com/python/cpython/pull/5331#commits-pushed-0297ab2
https://github.com/bbayles
bpo-32304: Fix up testhttps://github.com/python/cpython/pull/5331/commits/0297ab2fc3903091c92aafea12e04889220677f6
0297ab2https://github.com/python/cpython/pull/5331/commits/0297ab2fc3903091c92aafea12e04889220677f6
https://github.com/bbayles
bpo-32304: Port whatsnewhttps://github.com/python/cpython/pull/5331/commits/233d5444a8533c655e75f9798d3649f2b723793c
233d544https://github.com/python/cpython/pull/5331/commits/233d5444a8533c655e75f9798d3649f2b723793c
https://github.com/merwok
merwokhttps://github.com/merwok
Jan 26, 2018https://github.com/python/cpython/pull/5331#event-1444576074
https://github.com/merwok
merwokhttps://github.com/merwok
Jan 28, 2018 https://github.com/python/cpython/pull/5331#pullrequestreview-92070777
View reviewed changes https://github.com/python/cpython/pull/5331/files/233d5444a8533c655e75f9798d3649f2b723793c
Lib/distutils/tests/test_upload.pyhttps://github.com/python/cpython/pull/5331/files/233d5444a8533c655e75f9798d3649f2b723793c#diff-884a57e2484f7be025c62d342fc69379828d93f31e8717642750c9e28dd43fd9
merwokhttps://github.com/merwok
Jan 28, 2018https://github.com/python/cpython/pull/5331#discussion_r164317149
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5331
bbayleshttps://github.com/bbayles
Jan 28, 2018https://github.com/python/cpython/pull/5331#discussion_r164317496
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5331
merwokhttps://github.com/merwok
Jan 29, 2018https://github.com/python/cpython/pull/5331#discussion_r164446298
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5331
https://github.com/bbayles
Explicitly check for \nhttps://github.com/python/cpython/pull/5331/commits/29a9e7a526c6937189027bff10b72924e17e33f9
29a9e7ahttps://github.com/python/cpython/pull/5331/commits/29a9e7a526c6937189027bff10b72924e17e33f9
https://github.com/merwok
merwokhttps://github.com/merwok
f5a7935https://github.com/python/cpython/commit/f5a793522d539afc84ac7888c9ad189097c43a75
Jan 29, 2018https://github.com/python/cpython/pull/5331#event-1446424608
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 29, 2018https://github.com/python/cpython/pull/5331#event-1446424691
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5331
https://github.com/merwok
merwok https://github.com/merwok
https://github.com/python/cpython/pull/5331/files/233d5444a8533c655e75f9798d3649f2b723793c
https://github.com/merwok
merwok https://github.com/merwok
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/5331
https://github.com/bbayles
https://github.com/merwok
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.