| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:59f55cc4-ec95-9b07-df6a-33e143edd32b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A6F2:446DE:3CD5043:5554D3A:6A503FBC |
| html-safe-nonce | adb3cc140753f77e7f4fd5055e22586cc7730dd4d75a06cee47da47b5d2d224b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkYyOjQ0NkRFOjNDRDUwNDM6NTU1NEQzQTo2QTUwM0ZCQyIsInZpc2l0b3JfaWQiOiI1ODM4NTYxNjM4OTc0NzY3MDM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d110329492f8418c3820a15f91b7a384146af81d83356955058a98f28315ef2f |
| hovercard-subject-tag | pull_request:164454120 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/5273/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/15ea634424466de45d4146b78e7eaef3e0333613338bed61239a1b6e1bc14b1d/python/cpython/pull/5273 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/15ea634424466de45d4146b78e7eaef3e0333613338bed61239a1b6e1bc14b1d/python/cpython/pull/5273 |
| og:image:alt | This implementation is fully functional but there are three remaining issues/questions that I hope we can resolve quickly:
One test still fails. This is because six.with_metaclass (used by pip) do... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d90666eaf032b7eb8975a378efe38e37f4ebb96c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/5273#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5273 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5273 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/5273 |
| Reload | https://github.com/python/cpython/pull/5273 |
| Reload | https://github.com/python/cpython/pull/5273 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/cpython/tree/master |
| ilevkivskyi:c-abc | https://github.com/ilevkivskyi/cpython/tree/c-abc |
| Conversation | https://github.com/python/cpython/pull/5273 |
| Commits103 (103) | https://github.com/python/cpython/pull/5273/commits |
| Checks | https://github.com/python/cpython/pull/5273/checks |
| Files changed | https://github.com/python/cpython/pull/5273/files |
| bpo-31333: Re-implement ABCMeta in C | https://github.com/python/cpython/pull/5273#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/cpython/tree/master |
| ilevkivskyi:c-abc | https://github.com/ilevkivskyi/cpython/tree/c-abc |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#issue-290667563 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| @methane | https://github.com/methane |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| @ned-deily | https://github.com/ned-deily |
| @gvanrossum | https://github.com/gvanrossum |
| https://bugs.python.org/issue31333 | https://bugs.python.org/issue31333 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| July 23, 2017 19:20 | https://github.com/python/cpython/pull/5273#commits-pushed-5c34508 |
|
| https://github.com/ilevkivskyi |
| Initial work on C implementation of ABCMeta | https://github.com/python/cpython/pull/5273/commits/5c34508231058796cbe2ffddf055386960f9a8e5 |
| 5c34508 | https://github.com/python/cpython/pull/5273/commits/5c34508231058796cbe2ffddf055386960f9a8e5 |
|
| https://github.com/ilevkivskyi |
| Basic implementation of ABCMeta.__new__ | https://github.com/python/cpython/pull/5273/commits/cb7ffcf60978781be4a35ee13378dad490ff88c9 |
| cb7ffcf | https://github.com/python/cpython/pull/5273/commits/cb7ffcf60978781be4a35ee13378dad490ff88c9 |
|
| https://github.com/ilevkivskyi |
| Bare-bone implementation of register and subclass checks | https://github.com/python/cpython/pull/5273/commits/b83ee80bf9d58f7e207e31c8c5f28d7b3bbd1ac5 |
| b83ee80 | https://github.com/python/cpython/pull/5273/commits/b83ee80bf9d58f7e207e31c8c5f28d7b3bbd1ac5 |
|
| https://github.com/ilevkivskyi |
| Fix mock failure and silence compiler warnings | https://github.com/python/cpython/pull/5273/commits/181e83f712e5f2d400368de6d08813c606a126cc |
| 181e83f | https://github.com/python/cpython/pull/5273/commits/181e83f712e5f2d400368de6d08813c606a126cc |
|
| https://github.com/ilevkivskyi |
| Provide nicer dump of registry | https://github.com/python/cpython/pull/5273/commits/c084a7fd3c26ea17569ac400264adca843b6c10b |
| c084a7f | https://github.com/python/cpython/pull/5273/commits/c084a7fd3c26ea17569ac400264adca843b6c10b |
|
| https://github.com/ilevkivskyi |
| Add better docstrings | https://github.com/python/cpython/pull/5273/commits/a192d5d6186987ea2706478fe76f500a9106fe24 |
| a192d5d | https://github.com/python/cpython/pull/5273/commits/a192d5d6186987ea2706478fe76f500a9106fe24 |
|
| https://github.com/ilevkivskyi |
| Expose the internal cavhes and registry (backward compatibility) | https://github.com/python/cpython/pull/5273/commits/35a24728420b6d3ca04d1f9323d87d0f34de5896 |
| 35a2472 | https://github.com/python/cpython/pull/5273/commits/35a24728420b6d3ca04d1f9323d87d0f34de5896 |
|
| https://github.com/ilevkivskyi |
| Merge remote-tracking branch 'upstream/master' into c-abc | https://github.com/python/cpython/pull/5273/commits/4812450379e3f96422ed33cd06a1da1860d50dfe |
| 4812450 | https://github.com/python/cpython/pull/5273/commits/4812450379e3f96422ed33cd06a1da1860d50dfe |
| Merge remote-tracking branch 'upstream/master' into c-abc | https://github.com/python/cpython/pull/5273/commits/b9038e2a9aa828854052896c6db94f68accee66b |
| b9038e2 | https://github.com/python/cpython/pull/5273/commits/b9038e2a9aa828854052896c6db94f68accee66b |
| Add _abc to Setup.dist | https://github.com/python/cpython/pull/5273/commits/bbee578440218a46252ddcd405d09e53471324b0 |
| bbee578 | https://github.com/python/cpython/pull/5273/commits/bbee578440218a46252ddcd405d09e53471324b0 |
| Fix _abc in Setup.dist | https://github.com/python/cpython/pull/5273/commits/a3464fdce0d6e0b6b1ba7f92005da38348f40e2d |
| a3464fd | https://github.com/python/cpython/pull/5273/commits/a3464fdce0d6e0b6b1ba7f92005da38348f40e2d |
| Update a comment | https://github.com/python/cpython/pull/5273/commits/947bf7d8043da974794962851f1fff36da040c0f |
| 947bf7d | https://github.com/python/cpython/pull/5273/commits/947bf7d8043da974794962851f1fff36da040c0f |
| Settle the .py version | https://github.com/python/cpython/pull/5273/commits/7ffc59ecd7defbbc6bdec5b4a7e69bc684050fde |
| 7ffc59e | https://github.com/python/cpython/pull/5273/commits/7ffc59ecd7defbbc6bdec5b4a7e69bc684050fde |
| Fix some TODOs and refleaks | https://github.com/python/cpython/pull/5273/commits/41287a7ac3f236dda35c83830a5d651ee3f84ece |
| 41287a7 | https://github.com/python/cpython/pull/5273/commits/41287a7ac3f236dda35c83830a5d651ee3f84ece |
| Fix some more refleaks; use weak refs in registry | https://github.com/python/cpython/pull/5273/commits/569cc447c370031aac5839e8b3896799c476cb8f |
| 569cc44 | https://github.com/python/cpython/pull/5273/commits/569cc447c370031aac5839e8b3896799c476cb8f |
| Some more fixes; add some caching | https://github.com/python/cpython/pull/5273/commits/34665a8ef47b042444169c1b11b799be81cb11aa |
| 34665a8 | https://github.com/python/cpython/pull/5273/commits/34665a8ef47b042444169c1b11b799be81cb11aa |
| Fix a crash due to erroneous DECREF | https://github.com/python/cpython/pull/5273/commits/576acac44dc7bc228b820f92b0fd3abb20382de8 |
| 576acac | https://github.com/python/cpython/pull/5273/commits/576acac44dc7bc228b820f92b0fd3abb20382de8 |
| Simplify some code; reorganize TODOs | https://github.com/python/cpython/pull/5273/commits/30098b4d7f9d0671bfd5e0e340d4713fdf2d08fc |
| 30098b4 | https://github.com/python/cpython/pull/5273/commits/30098b4d7f9d0671bfd5e0e340d4713fdf2d08fc |
| Finish caches; add more comments | https://github.com/python/cpython/pull/5273/commits/51ede5dcd0797c52c81ccc5036a1d23ded0a9453 |
| 51ede5d | https://github.com/python/cpython/pull/5273/commits/51ede5dcd0797c52c81ccc5036a1d23ded0a9453 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#event-1436338230 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#event-1436338233 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#event-1436338556 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-359626539 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-359628905 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-359643443 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/pppery |
| pppery | https://github.com/pppery |
|
Jan 23, 2018
| https://github.com/python/cpython/pull/5273#pullrequestreview-90697871 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5273/files/51ede5dcd0797c52c81ccc5036a1d23ded0a9453 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/51ede5dcd0797c52c81ccc5036a1d23ded0a9453#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| pppery | https://github.com/pppery |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#discussion_r163133516 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/51ede5dcd0797c52c81ccc5036a1d23ded0a9453#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| pppery | https://github.com/pppery |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#discussion_r163133652 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| pppery | https://github.com/pppery |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#discussion_r163133882 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/51ede5dcd0797c52c81ccc5036a1d23ded0a9453#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| pppery | https://github.com/pppery |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#discussion_r163134341 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/51ede5dcd0797c52c81ccc5036a1d23ded0a9453#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| pppery | https://github.com/pppery |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#discussion_r163134449 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/methane |
| methane | https://github.com/methane |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-359726997 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/methane |
| methane | https://github.com/methane |
|
Jan 23, 2018
| https://github.com/python/cpython/pull/5273#pullrequestreview-90752458 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5273/files/51ede5dcd0797c52c81ccc5036a1d23ded0a9453 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/51ede5dcd0797c52c81ccc5036a1d23ded0a9453#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| methane | https://github.com/methane |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#discussion_r163183080 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-359730480 |
| @1st1 | https://github.com/1st1 |
| @methane | https://github.com/methane |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-359730734 |
| @pppery | https://github.com/pppery |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Regenerate clinic | https://github.com/python/cpython/pull/5273/commits/289c41413fdb1ba4f1265e362a203a5f623ac816 |
| 289c414 | https://github.com/python/cpython/pull/5273/commits/289c41413fdb1ba4f1265e362a203a5f623ac816 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#event-1479183123 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#event-1479183244 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-366457041 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-366463484 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Feb 17, 2018
| https://github.com/python/cpython/pull/5273#pullrequestreview-97381245 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5273/files/289c41413fdb1ba4f1265e362a203a5f623ac816 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| https://github.com/python/cpython/pull/5273#pullrequestreview-97381245 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/289c41413fdb1ba4f1265e362a203a5f623ac816#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168928861 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168932114 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/289c41413fdb1ba4f1265e362a203a5f623ac816#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168928960 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168932129 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/289c41413fdb1ba4f1265e362a203a5f623ac816#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168929071 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/289c41413fdb1ba4f1265e362a203a5f623ac816#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168929825 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/289c41413fdb1ba4f1265e362a203a5f623ac816#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168929848 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/289c41413fdb1ba4f1265e362a203a5f623ac816#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168930987 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/289c41413fdb1ba4f1265e362a203a5f623ac816#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168931019 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168933457 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168934222 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168934482 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/289c41413fdb1ba4f1265e362a203a5f623ac816#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168931127 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/289c41413fdb1ba4f1265e362a203a5f623ac816#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168931294 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168932289 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/289c41413fdb1ba4f1265e362a203a5f623ac816#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168931311 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-366469834 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| February 17, 2018 21:19 | https://github.com/python/cpython/pull/5273#commits-pushed-ac0c639 |
| Switch from Python invalidation counter to C long long | https://github.com/python/cpython/pull/5273/commits/ac0c63911e6824a6c5b9231deb633cb9c5d38cc0 |
| ac0c639 | https://github.com/python/cpython/pull/5273/commits/ac0c63911e6824a6c5b9231deb633cb9c5d38cc0 |
| The rest of the comments | https://github.com/python/cpython/pull/5273/commits/079e3be4768361f54a9da78cd261a008da2f579e |
| 079e3be | https://github.com/python/cpython/pull/5273/commits/079e3be4768361f54a9da78cd261a008da2f579e |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#event-1479290084 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#event-1479290419 |
| February 17, 2018 21:45 | https://github.com/python/cpython/pull/5273#commits-pushed-9c49e5a |
| Merge remote-tracking branch 'upstream/master' into c-abc | https://github.com/python/cpython/pull/5273/commits/9c49e5a315a4b9097f5e390b4e6045498f2c64aa |
| 9c49e5a | https://github.com/python/cpython/pull/5273/commits/9c49e5a315a4b9097f5e390b4e6045498f2c64aa |
| Regenerate clinics. | https://github.com/python/cpython/pull/5273/commits/41465888ec5a48b1f45ce9d5c4f296c654b3d65b |
| 4146588 | https://github.com/python/cpython/pull/5273/commits/41465888ec5a48b1f45ce9d5c4f296c654b3d65b |
| Two more comments | https://github.com/python/cpython/pull/5273/commits/c1336051c4d8351f0556d00f05985ecc9f38eb88 |
| c133605 | https://github.com/python/cpython/pull/5273/commits/c1336051c4d8351f0556d00f05985ecc9f38eb88 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-366478131 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/pppery |
| pppery | https://github.com/pppery |
| Feb 17, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-366480744 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-366480834 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/pppery |
| pppery | https://github.com/pppery |
|
Feb 18, 2018
| https://github.com/python/cpython/pull/5273#pullrequestreview-97388457 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5273/files/c1336051c4d8351f0556d00f05985ecc9f38eb88 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/c1336051c4d8351f0556d00f05985ecc9f38eb88#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| pppery | https://github.com/pppery |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168936351 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/c1336051c4d8351f0556d00f05985ecc9f38eb88#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| pppery | https://github.com/pppery |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168936366 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Feb 18, 2018
| https://github.com/python/cpython/pull/5273#pullrequestreview-97396127 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5273/files/c1336051c4d8351f0556d00f05985ecc9f38eb88 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| https://github.com/python/cpython/pull/5273#pullrequestreview-97396127 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/ac0c63911e6824a6c5b9231deb633cb9c5d38cc0..c1336051c4d8351f0556d00f05985ecc9f38eb88#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168944130 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/c1336051c4d8351f0556d00f05985ecc9f38eb88#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168944600 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Modules/_abc.c | https://github.com/python/cpython/pull/5273/files/289c41413fdb1ba4f1265e362a203a5f623ac816..ac0c63911e6824a6c5b9231deb633cb9c5d38cc0#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#discussion_r168944682 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| Few more comments by Serhiy; add Whats New item | https://github.com/python/cpython/pull/5273/commits/f82e04de3374a2729b7b2113f075f3700940a530 |
| f82e04d | https://github.com/python/cpython/pull/5273/commits/f82e04de3374a2729b7b2113f075f3700940a530 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#event-1479468581 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#event-1479468711 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Feb 18, 2018
| https://github.com/python/cpython/pull/5273#pullrequestreview-97400418 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5273/files/f82e04de3374a2729b7b2113f075f3700940a530 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| 03e3c34 | https://github.com/python/cpython/commit/03e3c340a0156891a036d6dbdb9e348108826255 |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#event-1479486774 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-366513385 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#event-1479486791 |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Feb 18, 2018
| https://github.com/python/cpython/pull/5273#ref-commit-91de691 |
|
| https://github.com/ilevkivskyi |
| bpo-31333: Re-implement ABCMeta in C ( | https://github.com/ilevkivskyi/cpython/commit/91de691ad29eb72dfb024c9f08bdf56abc26f846 |
| python#5273 | https://github.com/python/cpython/pull/5273 |
| ) | https://github.com/ilevkivskyi/cpython/commit/91de691ad29eb72dfb024c9f08bdf56abc26f846 |
| 91de691 | https://github.com/ilevkivskyi/cpython/commit/91de691ad29eb72dfb024c9f08bdf56abc26f846 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-366527902 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| @methane | https://github.com/methane |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Feb 18, 2018 | https://github.com/python/cpython/pull/5273#issuecomment-366530811 |
| @1st1 | https://github.com/1st1 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
| https://github.com/tomMoral |
| tomMoral | https://github.com/tomMoral |
|
Aug 16, 2018
| https://github.com/python/cpython/pull/5273#ref-pullrequest-351203621 |
|
FIX pickling for ABC in python3.7
cloudpipe/cloudpickle#189
| https://github.com/cloudpipe/cloudpickle/pull/189 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5273 |
|
| https://github.com/1st1 |
|
1st1
| https://github.com/1st1 |
|
| https://github.com/python/cpython/pull/5273/files/4746211769405fe6e23c00a81613adb7917cf350 |
|
| https://github.com/methane |
|
methane
| https://github.com/methane |
|
| https://github.com/python/cpython/pull/5273/files/a1ae0a7cc0fddb2b7d62caacba770b174bd0c729 |
|
| https://github.com/serhiy-storchaka |
|
serhiy-storchaka
| https://github.com/serhiy-storchaka |
|
| https://github.com/python/cpython/pull/5273/files/f82e04de3374a2729b7b2113f075f3700940a530 |
|
| https://github.com/pppery |
|
pppery
| https://github.com/pppery |
|
| https://github.com/python/cpython/pull/5273/files/c1336051c4d8351f0556d00f05985ecc9f38eb88 |
| Please reload this page | https://github.com/python/cpython/pull/5273 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/1st1 |
|
| https://github.com/methane |
|
| https://github.com/gvanrossum |
|
| https://github.com/pppery |
|
| https://github.com/bedevere-bot |
|
| https://github.com/ned-deily |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |