Title: bpo-32304: Fix distutils upload for tar files ending with b'\r' by bbayles · Pull Request #5264 · python/cpython · GitHub
Open Graph Title: bpo-32304: Fix distutils upload for tar files ending with b'\r' by bbayles · Pull Request #5264 · python/cpython
X Title: bpo-32304: Fix distutils upload for tar files ending with b'\r' by bbayles · Pull Request #5264 · python/cpython
Description: This PR fixes issue 32304, in which distutils's upload command corrupts tar files that end with b'\r' by appending b'\n' to them (here). The original report describes a simple fix, which is endorsed. I've provided that fix here, plus a test that ensures that (1) the "content" doesn't get the newline appended, (2) the other keys do. Of course, one wonders if fixing '\r' without '\n' is so important now that no major OSs use it? https://bugs.python.org/issue32304
Open Graph Description: This PR fixes issue 32304, in which distutils's upload command corrupts tar files that end with b'\r' by appending b'\n' to them (here). The original report describes a simple f...
X Description: This PR fixes issue 32304, in which distutils's upload command corrupts tar files that end with b'\r' by appending b'\n' to them (here). The original report ...
Opengraph URL: https://github.com/python/cpython/pull/5264
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:42b8e853-c296-051a-aa21-a3c536f45412 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9374:20A70:62D806:84305E:6A4D3653 |
| html-safe-nonce | 9a661429295e9a8f1d5be244a364e139f908681c6e82083d8e8af356d1a74a8c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Mzc0OjIwQTcwOjYyRDgwNjo4NDMwNUU6NkE0RDM2NTMiLCJ2aXNpdG9yX2lkIjoiNjc5MzI3MzkwNzU2NDMyODUzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ac61b74c106bc88695bcfb87d58247ac707a6c0a9784e094aa7696d3130ff7df |
| hovercard-subject-tag | pull_request:164199343 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/5264/files |
| twitter:image | https://avatars.githubusercontent.com/u/1922815?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1922815?s=400&v=4 |
| og:image:alt | This PR fixes issue 32304, in which distutils's upload command corrupts tar files that end with b'\r' by appending b'\n' to them (here). The original report describes a simple f... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56fc8347865a14e2ec811533d68f929cf4e0ec19 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width