René's URL Explorer Experiment


Title: bpo-32248 - Implement `ResourceReader` and `get_resource_reader()` for zipimport by warsaw · Pull Request #5248 · python/cpython · GitHub

Open Graph Title: bpo-32248 - Implement `ResourceReader` and `get_resource_reader()` for zipimport by warsaw · Pull Request #5248 · python/cpython

X Title: bpo-32248 - Implement `ResourceReader` and `get_resource_reader()` for zipimport by warsaw · Pull Request #5248 · python/cpython

Description: Here's the implementation of ResourceReader for zipimport. This also removes the fallback hacks for zip files, which we'll no longer need. Before you complain about the trampoline from zipimport's get_resource_reader() into a private function in importlib.resources, @brettcannon and I discussed this and agreed that it's an acceptable hack. See the comments in the .py files for more details. https://bugs.python.org/issue32248

Open Graph Description: Here's the implementation of ResourceReader for zipimport. This also removes the fallback hacks for zip files, which we'll no longer need. Before you complain about the trampoline from zip...

X Description: Here's the implementation of ResourceReader for zipimport. This also removes the fallback hacks for zip files, which we'll no longer need. Before you complain about the trampoline ...

Opengraph URL: https://github.com/python/cpython/pull/5248

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fb107213-c1cb-4b8b-e26b-7f345ea6483c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE5A4:1162D4:7D9D7:B8A8E:6A4DF9B7
html-safe-nonce328db31e88857070cea669f09847d77038e50e25858ebd7bc67bb25b31b23464
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUE0OjExNjJENDo3RDlENzpCOEE4RTo2QTRERjlCNyIsInZpc2l0b3JfaWQiOiIxNjM2MjU5NjcxMTM1MDkxMTI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac343a8bcbcf92ec11c93ba27059685d5f133f21b2a8f43578cc7d918093d8d0e7
hovercard-subject-tagpull_request:164097736
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/5248/files
twitter:imagehttps://avatars.githubusercontent.com/u/210184?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/210184?s=400&v=4
og:image:altHere's the implementation of ResourceReader for zipimport. This also removes the fallback hacks for zip files, which we'll no longer need. Before you complain about the trampoline from zip...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4314b1df11fa8a565684f3a72dc971e3785da365
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/5248/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5248%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5248%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/5248/files
Reloadhttps://github.com/python/cpython/pull/5248/files
Reloadhttps://github.com/python/cpython/pull/5248/files
Please reload this pagehttps://github.com/python/cpython/pull/5248/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/5248/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
warsawhttps://github.com/warsaw
python:masterhttps://github.com/python/cpython/tree/master
warsaw:zipresourceshttps://github.com/warsaw/cpython/tree/zipresources
Conversation 12 https://github.com/python/cpython/pull/5248
Commits 24 https://github.com/python/cpython/pull/5248/commits
Checks 0 https://github.com/python/cpython/pull/5248/checks
Files changed https://github.com/python/cpython/pull/5248/files
Please reload this pagehttps://github.com/python/cpython/pull/5248/files
bpo-32248 - Implement ResourceReader and get_resource_reader() for zipimport https://github.com/python/cpython/pull/5248/files#top
Show all changes 24 commits https://github.com/python/cpython/pull/5248/files
c1d7720 Checkpointing warsaw Jan 5, 2018 https://github.com/python/cpython/pull/5248/commits/c1d7720911241cfccf7d1730604c75d5e076b31e
d645574 Implement get_resource_reader() API warsaw Jan 5, 2018 https://github.com/python/cpython/pull/5248/commits/d6455746ea3108118936a00e87ce57f4f50d0975
fce8017 Checkpointing warsaw Jan 8, 2018 https://github.com/python/cpython/pull/5248/commits/fce8017192cc4c40ce9dd418a1a3880c25e43d3a
ef4f773 Merge branch 'master' into resource-reader warsaw Jan 11, 2018 https://github.com/python/cpython/pull/5248/commits/ef4f7732181d681e45a751e919dc9b1669685d3f
6d347b8 Merge branch 'master' into resource-reader warsaw Jan 12, 2018 https://github.com/python/cpython/pull/5248/commits/6d347b8dafd033d97dabfb9e4f455b994ab2f475
29cc5f7 Revert changes to zipimport; we'll do those separately warsaw Jan 12, 2018 https://github.com/python/cpython/pull/5248/commits/29cc5f74e5d7f05d1ee74580b06010412f2142c8
bec7821 Change the sense to a positive test warsaw Jan 12, 2018 https://github.com/python/cpython/pull/5248/commits/bec7821f0eef6ef2aef78296d4e5dded133a73a7
d5d2446 Merge branch 'master' into resource-reader warsaw Jan 13, 2018 https://github.com/python/cpython/pull/5248/commits/d5d2446d65c377f20a84376b3f0bedb6ac4a86ab
547f078 ResourceReader needs to be an ABC. warsaw Jan 13, 2018 https://github.com/python/cpython/pull/5248/commits/547f07890ee2dfc39adc6e06f4dfb9557626540e
c165144 Merge branch 'master' into resource-reader warsaw Jan 15, 2018 https://github.com/python/cpython/pull/5248/commits/c1651446529780bea4b472757c9588448c8b1404
3ea98cf WIP: restore zip importer work warsaw Jan 15, 2018 https://github.com/python/cpython/pull/5248/commits/3ea98cfe30378db90ab6eb459fae8f7f41cc982c
5ca6bc5 Merge branch 'master' into zipresources warsaw Jan 16, 2018 https://github.com/python/cpython/pull/5248/commits/5ca6bc5dfc3eaeb655c0d4765af2421eabae051a
9f2a284 Merge branch 'master' into zipresources warsaw Jan 17, 2018 https://github.com/python/cpython/pull/5248/commits/9f2a284eb902b5496aed934cce24ba9962b774b0
a70f4e4 Merge branch 'master' into zipresources warsaw Jan 19, 2018 https://github.com/python/cpython/pull/5248/commits/a70f4e41b99abb91d00ea8636c2827abdeb62094
2459adb Hook in ZipImporter.get_resource_reader() warsaw Jan 19, 2018 https://github.com/python/cpython/pull/5248/commits/2459adbd28b259d9837c5253d2fde6236d510fc8
a40d6e7 Flesh out the trampoline warsaw Jan 19, 2018 https://github.com/python/cpython/pull/5248/commits/a40d6e7985f7bef1ab796267bcf5e05d766ef777
d1af1f4 open_resource(), resource_path(), is_resource() warsaw Jan 19, 2018 https://github.com/python/cpython/pull/5248/commits/d1af1f4a1342b7bdacc33ec038b0272975dc6cfc
ba359e1 Complete the implementation for contents() warsaw Jan 20, 2018 https://github.com/python/cpython/pull/5248/commits/ba359e116a7c2da49089a14e32b6d18a0e6cc0ba
0d4ea2a Merge branch 'master' into zipresources warsaw Jan 20, 2018 https://github.com/python/cpython/pull/5248/commits/0d4ea2a9263774a92b8b458ec66b2ef2b518698b
3101ef8 Add news warsaw Jan 20, 2018 https://github.com/python/cpython/pull/5248/commits/3101ef85a10c1f56054c122e095c2681a72c9826
f97bd09 Merge branch 'master' into zipresources warsaw Jan 20, 2018 https://github.com/python/cpython/pull/5248/commits/f97bd09824c246c0239515e14f89849bcd8e3397
b34d15f Merge branch 'master' into zipresources warsaw Jan 24, 2018 https://github.com/python/cpython/pull/5248/commits/b34d15f4c235d01689ff28bd25409ff36eb82417
e5e3879 Shorten the NEWS file entry and expand a bit on the What's New entry. warsaw Jan 24, 2018 https://github.com/python/cpython/pull/5248/commits/e5e387967e658e0bd1fa77a3592a943b009546e5
e2ea845 PyObject_CallMethod() simplifies things warsaw Jan 24, 2018 https://github.com/python/cpython/pull/5248/commits/e2ea8453884758c6bcda5b3a7664548cd6e9f49c
Clear filters https://github.com/python/cpython/pull/5248/files
Please reload this pagehttps://github.com/python/cpython/pull/5248/files
Please reload this pagehttps://github.com/python/cpython/pull/5248/files
3.7.rst https://github.com/python/cpython/pull/5248/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
resources.py https://github.com/python/cpython/pull/5248/files#diff-b5f6dc7e442a38699664db6f9be914f60cdfbd1ee1f97eff87a6b873bff4aaeb
2017-12-15-15-34-12.bpo-32248.zmO8G2.rst https://github.com/python/cpython/pull/5248/files#diff-6afa50f4ace8a20f28ffbb82332f3baaba133139eadb1745c7c2fba921cd85dc
zipimport.c.h https://github.com/python/cpython/pull/5248/files#diff-c1ffe6c74a29f8a096f2ccacfdc5b0acd5ed95ee24a347ff30c622717b68acdb
zipimport.c https://github.com/python/cpython/pull/5248/files#diff-1838e6b1120f7180a5ea08be498a8a3d89dab3cb2f6eb4561fb7e979844d62b2
Doc/whatsnew/3.7.rsthttps://github.com/python/cpython/pull/5248/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
View file https://github.com/warsaw/cpython/blob/e2ea8453884758c6bcda5b3a7664548cd6e9f49c/Doc/whatsnew/3.7.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5248/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5248/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
https://github.com/python/cpython/pull/5248/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
Lib/importlib/resources.pyhttps://github.com/python/cpython/pull/5248/files#diff-b5f6dc7e442a38699664db6f9be914f60cdfbd1ee1f97eff87a6b873bff4aaeb
View file https://github.com/warsaw/cpython/blob/e2ea8453884758c6bcda5b3a7664548cd6e9f49c/Lib/importlib/resources.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5248/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5248/files#diff-b5f6dc7e442a38699664db6f9be914f60cdfbd1ee1f97eff87a6b873bff4aaeb
https://github.com/python/cpython/pull/5248/files#diff-b5f6dc7e442a38699664db6f9be914f60cdfbd1ee1f97eff87a6b873bff4aaeb
https://github.com/python/cpython/pull/5248/files#diff-b5f6dc7e442a38699664db6f9be914f60cdfbd1ee1f97eff87a6b873bff4aaeb
https://github.com/python/cpython/pull/5248/files#diff-b5f6dc7e442a38699664db6f9be914f60cdfbd1ee1f97eff87a6b873bff4aaeb
zoobahttps://github.com/zooba
Jan 23, 2018https://github.com/python/cpython/pull/5248/files#r163164490
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5248/files
warsawhttps://github.com/warsaw
Jan 24, 2018https://github.com/python/cpython/pull/5248/files#r163548954
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
forward slasheshttps://web.archive.org/web/20070928174718/http://www.pkware.com/documents/casestudies/APPNOTE.TXT
Please reload this pagehttps://github.com/python/cpython/pull/5248/files
brettcannonhttps://github.com/brettcannon
Jan 24, 2018https://github.com/python/cpython/pull/5248/files#r163662796
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5248/files
brettcannonhttps://github.com/brettcannon
Jan 24, 2018https://github.com/python/cpython/pull/5248/files#r163663174
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5248/files
warsawhttps://github.com/warsaw
Jan 24, 2018https://github.com/python/cpython/pull/5248/files#r163670460
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5248/files
Misc/NEWS.d/next/Library/2017-12-15-15-34-12.bpo-32248.zmO8G2.rsthttps://github.com/python/cpython/pull/5248/files#diff-6afa50f4ace8a20f28ffbb82332f3baaba133139eadb1745c7c2fba921cd85dc
View file https://github.com/warsaw/cpython/blob/e2ea8453884758c6bcda5b3a7664548cd6e9f49c/Misc/NEWS.d/next/Library/2017-12-15-15-34-12.bpo-32248.zmO8G2.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5248/{{ revealButtonHref }}
Modules/clinic/zipimport.c.hhttps://github.com/python/cpython/pull/5248/files#diff-c1ffe6c74a29f8a096f2ccacfdc5b0acd5ed95ee24a347ff30c622717b68acdb
View file https://github.com/warsaw/cpython/blob/e2ea8453884758c6bcda5b3a7664548cd6e9f49c/Modules/clinic/zipimport.c.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5248/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5248/files#diff-c1ffe6c74a29f8a096f2ccacfdc5b0acd5ed95ee24a347ff30c622717b68acdb
Modules/zipimport.chttps://github.com/python/cpython/pull/5248/files#diff-1838e6b1120f7180a5ea08be498a8a3d89dab3cb2f6eb4561fb7e979844d62b2
View file https://github.com/warsaw/cpython/blob/e2ea8453884758c6bcda5b3a7664548cd6e9f49c/Modules/zipimport.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5248/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5248/files#diff-1838e6b1120f7180a5ea08be498a8a3d89dab3cb2f6eb4561fb7e979844d62b2
https://github.com/python/cpython/pull/5248/files#diff-1838e6b1120f7180a5ea08be498a8a3d89dab3cb2f6eb4561fb7e979844d62b2
https://github.com/python/cpython/pull/5248/files#diff-1838e6b1120f7180a5ea08be498a8a3d89dab3cb2f6eb4561fb7e979844d62b2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.