| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4f460d2d-9f17-2eda-7081-71cdd533a1f7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 862C:CBEA:60C17A:827D70:6A4DA597 |
| html-safe-nonce | b8ede036b84a67ec6bc7a751ba2ea067dca0962f1a4fa5ede150dbbb355927cc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjJDOkNCRUE6NjBDMTdBOjgyN0Q3MDo2QTREQTU5NyIsInZpc2l0b3JfaWQiOiI5MDgwNTU5NDYxNDc1MDU1NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9c9e7eea35f568a7a01078bc7e84d26f5d7e83d4f6e409023923096330f2deda |
| hovercard-subject-tag | pull_request:164097736 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/5248/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a3caff719826c7f823c0b4b6a64549725a0cc39d02a835698bfdc4f06efdc09b/python/cpython/pull/5248 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a3caff719826c7f823c0b4b6a64549725a0cc39d02a835698bfdc4f06efdc09b/python/cpython/pull/5248 |
| og:image:alt | Here's the implementation of ResourceReader for zipimport. This also removes the fallback hacks for zip files, which we'll no longer need.
Before you complain about the trampoline from zip... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | warsaw |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7f13faa65cccc9b729d674da83335d5dcfdfd193 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/5248#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5248 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5248 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/5248 |
| Reload | https://github.com/python/cpython/pull/5248 |
| Reload | https://github.com/python/cpython/pull/5248 |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| warsaw | https://github.com/warsaw |
| python:master | https://github.com/python/cpython/tree/master |
| warsaw:zipresources | https://github.com/warsaw/cpython/tree/zipresources |
| Conversation | https://github.com/python/cpython/pull/5248 |
| Commits24 (24) | https://github.com/python/cpython/pull/5248/commits |
| Checks | https://github.com/python/cpython/pull/5248/checks |
| Files changed | https://github.com/python/cpython/pull/5248/files |
| bpo-32248 - Implement ResourceReader and get_resource_reader() for zipimport | https://github.com/python/cpython/pull/5248#top |
| warsaw | https://github.com/warsaw |
| python:master | https://github.com/python/cpython/tree/master |
| warsaw:zipresources | https://github.com/warsaw/cpython/tree/zipresources |
|
| https://github.com/warsaw |
| warsaw | https://github.com/warsaw |
| Jan 20, 2018 | https://github.com/python/cpython/pull/5248#issue-290145822 |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| @brettcannon | https://github.com/brettcannon |
| https://bugs.python.org/issue32248 | https://bugs.python.org/issue32248 |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| warsaw | https://github.com/warsaw |
| January 4, 2018 20:22 | https://github.com/python/cpython/pull/5248#commits-pushed-c1d7720 |
|
| https://github.com/warsaw |
| Checkpointing | https://github.com/python/cpython/pull/5248/commits/c1d7720911241cfccf7d1730604c75d5e076b31e |
| c1d7720 | https://github.com/python/cpython/pull/5248/commits/c1d7720911241cfccf7d1730604c75d5e076b31e |
|
| https://github.com/warsaw |
| Implement get_resource_reader() API | https://github.com/python/cpython/pull/5248/commits/d6455746ea3108118936a00e87ce57f4f50d0975 |
| d645574 | https://github.com/python/cpython/pull/5248/commits/d6455746ea3108118936a00e87ce57f4f50d0975 |
|
| https://github.com/warsaw |
| Checkpointing | https://github.com/python/cpython/pull/5248/commits/fce8017192cc4c40ce9dd418a1a3880c25e43d3a |
| fce8017 | https://github.com/python/cpython/pull/5248/commits/fce8017192cc4c40ce9dd418a1a3880c25e43d3a |
|
| https://github.com/warsaw |
| Merge branch 'master' into resource-reader | https://github.com/python/cpython/pull/5248/commits/ef4f7732181d681e45a751e919dc9b1669685d3f |
| ef4f773 | https://github.com/python/cpython/pull/5248/commits/ef4f7732181d681e45a751e919dc9b1669685d3f |
|
| https://github.com/warsaw |
| Merge branch 'master' into resource-reader | https://github.com/python/cpython/pull/5248/commits/6d347b8dafd033d97dabfb9e4f455b994ab2f475 |
| 6d347b8 | https://github.com/python/cpython/pull/5248/commits/6d347b8dafd033d97dabfb9e4f455b994ab2f475 |
|
| https://github.com/warsaw |
| Revert changes to zipimport; we'll do those separately | https://github.com/python/cpython/pull/5248/commits/29cc5f74e5d7f05d1ee74580b06010412f2142c8 |
| 29cc5f7 | https://github.com/python/cpython/pull/5248/commits/29cc5f74e5d7f05d1ee74580b06010412f2142c8 |
|
| https://github.com/warsaw |
| Change the sense to a positive test | https://github.com/python/cpython/pull/5248/commits/bec7821f0eef6ef2aef78296d4e5dded133a73a7 |
| bec7821 | https://github.com/python/cpython/pull/5248/commits/bec7821f0eef6ef2aef78296d4e5dded133a73a7 |
|
| https://github.com/warsaw |
| Merge branch 'master' into resource-reader | https://github.com/python/cpython/pull/5248/commits/d5d2446d65c377f20a84376b3f0bedb6ac4a86ab |
| d5d2446 | https://github.com/python/cpython/pull/5248/commits/d5d2446d65c377f20a84376b3f0bedb6ac4a86ab |
|
| https://github.com/warsaw |
| ResourceReader needs to be an ABC. | https://github.com/python/cpython/pull/5248/commits/547f07890ee2dfc39adc6e06f4dfb9557626540e |
| 547f078 | https://github.com/python/cpython/pull/5248/commits/547f07890ee2dfc39adc6e06f4dfb9557626540e |
|
| https://github.com/warsaw |
| Merge branch 'master' into resource-reader | https://github.com/python/cpython/pull/5248/commits/c1651446529780bea4b472757c9588448c8b1404 |
| c165144 | https://github.com/python/cpython/pull/5248/commits/c1651446529780bea4b472757c9588448c8b1404 |
|
| https://github.com/warsaw |
| WIP: restore zip importer work | https://github.com/python/cpython/pull/5248/commits/3ea98cfe30378db90ab6eb459fae8f7f41cc982c |
| 3ea98cf | https://github.com/python/cpython/pull/5248/commits/3ea98cfe30378db90ab6eb459fae8f7f41cc982c |
|
| https://github.com/warsaw |
| Merge branch 'master' into zipresources | https://github.com/python/cpython/pull/5248/commits/5ca6bc5dfc3eaeb655c0d4765af2421eabae051a |
| 5ca6bc5 | https://github.com/python/cpython/pull/5248/commits/5ca6bc5dfc3eaeb655c0d4765af2421eabae051a |
|
| https://github.com/warsaw |
| Merge branch 'master' into zipresources | https://github.com/python/cpython/pull/5248/commits/9f2a284eb902b5496aed934cce24ba9962b774b0 |
| 9f2a284 | https://github.com/python/cpython/pull/5248/commits/9f2a284eb902b5496aed934cce24ba9962b774b0 |
|
| https://github.com/warsaw |
| Merge branch 'master' into zipresources | https://github.com/python/cpython/pull/5248/commits/a70f4e41b99abb91d00ea8636c2827abdeb62094 |
| a70f4e4 | https://github.com/python/cpython/pull/5248/commits/a70f4e41b99abb91d00ea8636c2827abdeb62094 |
|
| https://github.com/warsaw |
| Hook in ZipImporter.get_resource_reader() | https://github.com/python/cpython/pull/5248/commits/2459adbd28b259d9837c5253d2fde6236d510fc8 |
| 2459adb | https://github.com/python/cpython/pull/5248/commits/2459adbd28b259d9837c5253d2fde6236d510fc8 |
|
| https://github.com/warsaw |
| Flesh out the trampoline | https://github.com/python/cpython/pull/5248/commits/a40d6e7985f7bef1ab796267bcf5e05d766ef777 |
| a40d6e7 | https://github.com/python/cpython/pull/5248/commits/a40d6e7985f7bef1ab796267bcf5e05d766ef777 |
|
| https://github.com/warsaw |
| open_resource(), resource_path(), is_resource() | https://github.com/python/cpython/pull/5248/commits/d1af1f4a1342b7bdacc33ec038b0272975dc6cfc |
| d1af1f4 | https://github.com/python/cpython/pull/5248/commits/d1af1f4a1342b7bdacc33ec038b0272975dc6cfc |
|
| https://github.com/warsaw |
| Complete the implementation for contents() | https://github.com/python/cpython/pull/5248/commits/ba359e116a7c2da49089a14e32b6d18a0e6cc0ba |
| ba359e1 | https://github.com/python/cpython/pull/5248/commits/ba359e116a7c2da49089a14e32b6d18a0e6cc0ba |
|
| https://github.com/warsaw |
| Merge branch 'master' into zipresources | https://github.com/python/cpython/pull/5248/commits/0d4ea2a9263774a92b8b458ec66b2ef2b518698b |
| 0d4ea2a | https://github.com/python/cpython/pull/5248/commits/0d4ea2a9263774a92b8b458ec66b2ef2b518698b |
| https://github.com/warsaw |
| warsaw | https://github.com/warsaw |
| January 20, 2018 00:24 | https://github.com/python/cpython/pull/5248#event-1433473546 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jan 20, 2018 | https://github.com/python/cpython/pull/5248#event-1433473563 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Jan 20, 2018 | https://github.com/python/cpython/pull/5248#event-1433473567 |
| https://github.com/warsaw |
| warsaw | https://github.com/warsaw |
| Jan 20, 2018 | https://github.com/python/cpython/pull/5248#event-1433474034 |
|
| https://github.com/warsaw |
| Add news | https://github.com/python/cpython/pull/5248/commits/3101ef85a10c1f56054c122e095c2681a72c9826 |
| 3101ef8 | https://github.com/python/cpython/pull/5248/commits/3101ef85a10c1f56054c122e095c2681a72c9826 |
| https://github.com/warsaw |
| warsaw | https://github.com/warsaw |
| Jan 20, 2018 | https://github.com/python/cpython/pull/5248#event-1433480320 |
| https://github.com/warsaw |
| warsaw | https://github.com/warsaw |
| Jan 20, 2018 | https://github.com/python/cpython/pull/5248#event-1433480483 |
| https://github.com/warsaw |
| warsaw | https://github.com/warsaw |
| Jan 20, 2018 | https://github.com/python/cpython/pull/5248#event-1433481438 |
|
| https://github.com/warsaw |
| Merge branch 'master' into zipresources | https://github.com/python/cpython/pull/5248/commits/f97bd09824c246c0239515e14f89849bcd8e3397 |
| f97bd09 | https://github.com/python/cpython/pull/5248/commits/f97bd09824c246c0239515e14f89849bcd8e3397 |
| https://github.com/zooba |
| zooba | https://github.com/zooba |
|
Jan 23, 2018
| https://github.com/python/cpython/pull/5248#pullrequestreview-90730473 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5248/files/f97bd09824c246c0239515e14f89849bcd8e3397 |
| Misc/NEWS.d/next/Library/2017-12-15-15-34-12.bpo-32248.zmO8G2.rst | https://github.com/python/cpython/pull/5248/files/f97bd09824c246c0239515e14f89849bcd8e3397#diff-6afa50f4ace8a20f28ffbb82332f3baaba133139eadb1745c7c2fba921cd85dc |
| zooba | https://github.com/zooba |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5248#discussion_r163163789 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| warsaw | https://github.com/warsaw |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5248#discussion_r163550940 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| Lib/importlib/resources.py | https://github.com/python/cpython/pull/5248/files/f97bd09824c246c0239515e14f89849bcd8e3397#diff-b5f6dc7e442a38699664db6f9be914f60cdfbd1ee1f97eff87a6b873bff4aaeb |
| zooba | https://github.com/zooba |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5248#discussion_r163164490 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| warsaw | https://github.com/warsaw |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5248#discussion_r163548954 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| forward slashes | https://web.archive.org/web/20070928174718/http://www.pkware.com/documents/casestudies/APPNOTE.TXT |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| brettcannon | https://github.com/brettcannon |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5248#discussion_r163662796 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| brettcannon | https://github.com/brettcannon |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5248#discussion_r163663174 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| warsaw | https://github.com/warsaw |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5248#discussion_r163670460 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| Modules/zipimport.c | https://github.com/python/cpython/pull/5248/files/f97bd09824c246c0239515e14f89849bcd8e3397#diff-1838e6b1120f7180a5ea08be498a8a3d89dab3cb2f6eb4561fb7e979844d62b2 |
| zooba | https://github.com/zooba |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5248#discussion_r163164615 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| zooba | https://github.com/zooba |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5248#discussion_r163166189 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
|
| https://github.com/warsaw |
| Merge branch 'master' into zipresources | https://github.com/python/cpython/pull/5248/commits/b34d15f4c235d01689ff28bd25409ff36eb82417 |
| b34d15f | https://github.com/python/cpython/pull/5248/commits/b34d15f4c235d01689ff28bd25409ff36eb82417 |
|
| https://github.com/warsaw |
| Shorten the NEWS file entry and expand a bit on the What's New entry. | https://github.com/python/cpython/pull/5248/commits/e5e387967e658e0bd1fa77a3592a943b009546e5 |
| e5e3879 | https://github.com/python/cpython/pull/5248/commits/e5e387967e658e0bd1fa77a3592a943b009546e5 |
| https://github.com/warsaw |
| warsaw | https://github.com/warsaw |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5248#issuecomment-360166248 |
| @zooba | https://github.com/zooba |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
|
| https://github.com/warsaw |
| PyObject_CallMethod() simplifies things | https://github.com/python/cpython/pull/5248/commits/e2ea8453884758c6bcda5b3a7664548cd6e9f49c |
| e2ea845 | https://github.com/python/cpython/pull/5248/commits/e2ea8453884758c6bcda5b3a7664548cd6e9f49c |
| https://github.com/brettcannon |
| brettcannon | https://github.com/brettcannon |
|
Jan 24, 2018
| https://github.com/python/cpython/pull/5248#pullrequestreview-91312484 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5248/files/f97bd09824c246c0239515e14f89849bcd8e3397 |
| brettcannon | https://github.com/brettcannon |
| https://github.com/python/cpython/pull/5248#pullrequestreview-91312484 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| Lib/importlib/resources.py | https://github.com/python/cpython/pull/5248/files/f97bd09824c246c0239515e14f89849bcd8e3397#diff-b5f6dc7e442a38699664db6f9be914f60cdfbd1ee1f97eff87a6b873bff4aaeb |
| brettcannon | https://github.com/brettcannon |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5248#discussion_r163662796 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| Lib/importlib/resources.py | https://github.com/python/cpython/pull/5248/files/f97bd09824c246c0239515e14f89849bcd8e3397#diff-b5f6dc7e442a38699664db6f9be914f60cdfbd1ee1f97eff87a6b873bff4aaeb |
| brettcannon | https://github.com/brettcannon |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5248#discussion_r163663174 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| https://github.com/warsaw |
| warsaw | https://github.com/warsaw |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5248#issuecomment-360265027 |
| @brettcannon | https://github.com/brettcannon |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
| https://github.com/warsaw |
| warsaw | https://github.com/warsaw |
| 6f6eb35 | https://github.com/python/cpython/commit/6f6eb35f9bee18f54945f09664344f2d118ed89f |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5248#event-1440349989 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5248#event-1440350035 |
| https://github.com/warsaw |
| warsaw | https://github.com/warsaw |
| January 24, 2018 20:37 | https://github.com/python/cpython/pull/5248#event-1440351147 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5248 |
|
| https://github.com/zooba |
|
zooba
| https://github.com/zooba |
|
| https://github.com/python/cpython/pull/5248/files/f97bd09824c246c0239515e14f89849bcd8e3397 |
|
| https://github.com/brettcannon |
|
brettcannon
| https://github.com/brettcannon |
|
| https://github.com/python/cpython/pull/5248/files/f97bd09824c246c0239515e14f89849bcd8e3397 |
|
| https://github.com/warsaw |
|
warsaw
| https://github.com/warsaw |
| Please reload this page | https://github.com/python/cpython/pull/5248 |
|
| https://github.com/warsaw |
|
| https://github.com/brettcannon |
|
| https://github.com/zooba |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |