René's URL Explorer Experiment


Title: bpo-32526: Closing async generator while it is running does not raise an exception by achimnol · Pull Request #5182 · python/cpython · GitHub

Open Graph Title: bpo-32526: Closing async generator while it is running does not raise an exception by achimnol · Pull Request #5182 · python/cpython

X Title: bpo-32526: Closing async generator while it is running does not raise an exception by achimnol · Pull Request #5182 · python/cpython

Description: Here are my first draft PR to pass the async_generator test case provided by @njsmith. I have reset gi_running value to 1 after gen_send_ex() and _gen_throw() calls in async generators and clear it to 0 when they close. This PR obviously requires more test cases regarding athrow() calls, but I submit at this stage to check if my approach is correct first. https://bugs.python.org/issue32526

Open Graph Description: Here are my first draft PR to pass the async_generator test case provided by @njsmith. I have reset gi_running value to 1 after gen_send_ex() and _gen_throw() calls in async generators and clear it...

X Description: Here are my first draft PR to pass the async_generator test case provided by @njsmith. I have reset gi_running value to 1 after gen_send_ex() and _gen_throw() calls in async generators and clear it...

Opengraph URL: https://github.com/python/cpython/pull/5182

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8aee5a79-7efa-2375-b173-4d7060f5b881
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD536:1A182C:2572D62:3162685:6A5CBE59
html-safe-nonce99d27b43618377cecbe37dfcbcc7a8ad78009a5905bbfb51f663f145f0879515
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTM2OjFBMTgyQzoyNTcyRDYyOjMxNjI2ODU6NkE1Q0JFNTkiLCJ2aXNpdG9yX2lkIjoiNzM1MzE2MDM4NTM2ODQ3MzE3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8923dd4ed797f9a395b2a55f3e6515a0aa1e9e78f458ae4caae24eb16918c6b6
hovercard-subject-tagpull_request:162834436
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/5182/files
twitter:imagehttps://avatars.githubusercontent.com/u/555156?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/555156?s=400&v=4
og:image:altHere are my first draft PR to pass the async_generator test case provided by @njsmith. I have reset gi_running value to 1 after gen_send_ex() and _gen_throw() calls in async generators and clear it...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/5182/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5182%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5182%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/5182/files
Reloadhttps://github.com/python/cpython/pull/5182/files
Reloadhttps://github.com/python/cpython/pull/5182/files
Please reload this pagehttps://github.com/python/cpython/pull/5182/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/5182/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
achimnolhttps://github.com/achimnol
python:masterhttps://github.com/python/cpython/tree/master
achimnol:fix-asyncgen-closinghttps://github.com/achimnol/cpython/tree/fix-asyncgen-closing
Conversation 4 https://github.com/python/cpython/pull/5182
Commits 2 https://github.com/python/cpython/pull/5182/commits
Checks 0 https://github.com/python/cpython/pull/5182/checks
Files changed https://github.com/python/cpython/pull/5182/files
Please reload this pagehttps://github.com/python/cpython/pull/5182/files
bpo-32526: Closing async generator while it is running does not raise an exception https://github.com/python/cpython/pull/5182/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/5182/files
a6e9248 bpo-32526: Add a failing test case achimnol Jan 14, 2018 https://github.com/python/cpython/pull/5182/commits/a6e9248ff24327812f258aa57d27045cc12f86c1
1bf2889 bpo-32526: Keep gi_running state after gen_send_ex/gen_throw calls achimnol Jan 14, 2018 https://github.com/python/cpython/pull/5182/commits/1bf288997472082439329d4f1df8ef8ca44e9b20
Clear filters https://github.com/python/cpython/pull/5182/files
Please reload this pagehttps://github.com/python/cpython/pull/5182/files
Please reload this pagehttps://github.com/python/cpython/pull/5182/files
test_asyncgen.py https://github.com/python/cpython/pull/5182/files#diff-1da5f0220b91e20c669b0e63724b978d4cf603373c850fbdc705abb2d5937f40
genobject.c https://github.com/python/cpython/pull/5182/files#diff-2a0c449b68605ebd0872fd232e60ce7e838a77782a6d2e364764f99514fb508a
Lib/test/test_asyncgen.pyhttps://github.com/python/cpython/pull/5182/files#diff-1da5f0220b91e20c669b0e63724b978d4cf603373c850fbdc705abb2d5937f40
View file https://github.com/achimnol/cpython/blob/1bf288997472082439329d4f1df8ef8ca44e9b20/Lib/test/test_asyncgen.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5182/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5182/files#diff-1da5f0220b91e20c669b0e63724b978d4cf603373c850fbdc705abb2d5937f40
https://github.com/python/cpython/pull/5182/files#diff-1da5f0220b91e20c669b0e63724b978d4cf603373c850fbdc705abb2d5937f40
Objects/genobject.chttps://github.com/python/cpython/pull/5182/files#diff-2a0c449b68605ebd0872fd232e60ce7e838a77782a6d2e364764f99514fb508a
View file https://github.com/achimnol/cpython/blob/1bf288997472082439329d4f1df8ef8ca44e9b20/Objects/genobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5182/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5182/files#diff-2a0c449b68605ebd0872fd232e60ce7e838a77782a6d2e364764f99514fb508a
https://github.com/python/cpython/pull/5182/files#diff-2a0c449b68605ebd0872fd232e60ce7e838a77782a6d2e364764f99514fb508a
https://github.com/python/cpython/pull/5182/files#diff-2a0c449b68605ebd0872fd232e60ce7e838a77782a6d2e364764f99514fb508a
https://github.com/python/cpython/pull/5182/files#diff-2a0c449b68605ebd0872fd232e60ce7e838a77782a6d2e364764f99514fb508a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.