René's URL Explorer Experiment


Title: bpo-32526: Closing async generator while it is running does not raise an exception by achimnol · Pull Request #5182 · python/cpython · GitHub

Open Graph Title: bpo-32526: Closing async generator while it is running does not raise an exception by achimnol · Pull Request #5182 · python/cpython

X Title: bpo-32526: Closing async generator while it is running does not raise an exception by achimnol · Pull Request #5182 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Here are my first draft PR to pass the async_generator test case provided by @njsmith. I have reset gi_running value to 1 after gen_send_ex() and _gen_throw() calls in async generators and clear it...

X Description: Here are my first draft PR to pass the async_generator test case provided by @njsmith. I have reset gi_running value to 1 after gen_send_ex() and _gen_throw() calls in async generators and clear it...

Opengraph URL: https://github.com/python/cpython/pull/5182

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cf180bfe-cef5-86e5-f344-4dde75f3aa3b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBEFA:32AC14:1FE40D:29422D:6A5BEAF6
html-safe-nonce53a4940867b9be8a57c946a782ad7eb8ff8e29bc88bfe87761e5f1f01556a29e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUZBOjMyQUMxNDoxRkU0MEQ6Mjk0MjJEOjZBNUJFQUY2IiwidmlzaXRvcl9pZCI6IjI1MzQ2NTc4MzA2NTg5NzcxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc4aa26fc01cf5fcdedf2adbdb9b89f4176888570c6f4bce03f79ebed6548fa0f
hovercard-subject-tagpull_request:162834436
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/5182/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ce00154f7b5ef14f7863fa65d292668df1168a0af22e84075d9ce6f46fbde3e1/python/cpython/pull/5182
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ce00154f7b5ef14f7863fa65d292668df1168a0af22e84075d9ce6f46fbde3e1/python/cpython/pull/5182
og:image:altHere are my first draft PR to pass the async_generator test case provided by @njsmith. I have reset gi_running value to 1 after gen_send_ex() and _gen_throw() calls in async generators and clear it...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameachimnol
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/5182#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5182
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5182
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/5182
Reloadhttps://github.com/python/cpython/pull/5182
Reloadhttps://github.com/python/cpython/pull/5182
Please reload this pagehttps://github.com/python/cpython/pull/5182
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/5182
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
achimnolhttps://github.com/achimnol
python:masterhttps://github.com/python/cpython/tree/master
achimnol:fix-asyncgen-closinghttps://github.com/achimnol/cpython/tree/fix-asyncgen-closing
Conversationhttps://github.com/python/cpython/pull/5182
Commits2 (2)https://github.com/python/cpython/pull/5182/commits
Checkshttps://github.com/python/cpython/pull/5182/checks
Files changedhttps://github.com/python/cpython/pull/5182/files
bpo-32526: Closing async generator while it is running does not raise an exceptionhttps://github.com/python/cpython/pull/5182#top
achimnolhttps://github.com/achimnol
python:masterhttps://github.com/python/cpython/tree/master
achimnol:fix-asyncgen-closinghttps://github.com/achimnol/cpython/tree/fix-asyncgen-closing
https://github.com/achimnol
achimnolhttps://github.com/achimnol
Jan 14, 2018https://github.com/python/cpython/pull/5182#issue-288424348
Please reload this pagehttps://github.com/python/cpython/pull/5182
@njsmithhttps://github.com/njsmith
https://bugs.python.org/issue32526https://bugs.python.org/issue32526
Please reload this pagehttps://github.com/python/cpython/pull/5182
achimnolhttps://github.com/achimnol
January 15, 2018 00:09https://github.com/python/cpython/pull/5182#commits-pushed-a6e9248
https://github.com/achimnol
bpo-32526: Add a failing test casehttps://github.com/python/cpython/pull/5182/commits/a6e9248ff24327812f258aa57d27045cc12f86c1
a6e9248https://github.com/python/cpython/pull/5182/commits/a6e9248ff24327812f258aa57d27045cc12f86c1
njsmith/async_generator@339fc63https://github.com/njsmith/async_generator/commit/339fc6309aa6c96244e79b517db0b98ba0ccfb2a
https://github.com/achimnol
bpo-32526: Keep gi_running state after gen_send_ex/gen_throw callshttps://github.com/python/cpython/pull/5182/commits/1bf288997472082439329d4f1df8ef8ca44e9b20
1bf2889https://github.com/python/cpython/pull/5182/commits/1bf288997472082439329d4f1df8ef8ca44e9b20
https://github.com/achimnol
achimnolhttps://github.com/achimnol
1st1https://github.com/1st1
code ownerhttps://github.com/python/cpython/blob/d37258dd2e189141906bd234385096cd8e885d8d/.github/CODEOWNERS#L11
January 14, 2018 17:21https://github.com/python/cpython/pull/5182#event-1423380512
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
Jan 14, 2018https://github.com/python/cpython/pull/5182#issuecomment-357527064
PSF contributor agreementhttps://www.python.org/psf/contrib/contrib-form/
the steps outlined in the CPython devguidehttps://devguide.python.org/pullrequest/#licensing
Please reload this pagehttps://github.com/python/cpython/pull/5182
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Jan 14, 2018https://github.com/python/cpython/pull/5182#event-1423380516
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 14, 2018https://github.com/python/cpython/pull/5182#event-1423380520
https://github.com/achimnol
achimnolhttps://github.com/achimnol
Jan 14, 2018https://github.com/python/cpython/pull/5182#issuecomment-357531276
Please reload this pagehttps://github.com/python/cpython/pull/5182
@1st1https://github.com/1st1
@njsmithhttps://github.com/njsmith
Please reload this pagehttps://github.com/python/cpython/pull/5182
https://github.com/achimnol
achimnolhttps://github.com/achimnol
Jan 14, 2018https://github.com/python/cpython/pull/5182#event-1423399743
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Jan 14, 2018https://github.com/python/cpython/pull/5182#issuecomment-357544443
…https://github.com/python/cpython/pull/5182
#5182https://github.com/python/cpython/pull/5182
#5182https://github.com/python/cpython/pull/5182
#5182 (comment)https://github.com/python/cpython/pull/5182#event-1423399743
https://github.com/notifications/unsubscribe-auth/AAlOaOkGFN0dKpMZdCZz2EqrUTriQ4N5ks5tKkdlgaJpZM4Rdqqphttps://github.com/notifications/unsubscribe-auth/AAlOaOkGFN0dKpMZdCZz2EqrUTriQ4N5ks5tKkdlgaJpZM4Rdqqp
Please reload this pagehttps://github.com/python/cpython/pull/5182
https://github.com/1st1
1st1https://github.com/1st1
Jan 14, 2018https://github.com/python/cpython/pull/5182#issuecomment-357544679
Please reload this pagehttps://github.com/python/cpython/pull/5182
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5182
https://github.com/1st1
1st1 https://github.com/1st1
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/5182
https://github.com/achimnol
https://github.com/the-knights-who-say-ni
https://github.com/njsmith
https://github.com/1st1
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.