| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4d4524e7-2429-ed43-c6f5-231a4af3e709 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E468:2C2A02:17DF5CD:2069F9F:6A4F26BB |
| html-safe-nonce | 7cfe9cec9c2a76340fdbda174fcece7d1709c684f4292e897498696edc53da50 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDY4OjJDMkEwMjoxN0RGNUNEOjIwNjlGOUY6NkE0RjI2QkIiLCJ2aXNpdG9yX2lkIjoiMjQ0MzEyNjQ3ODA2MzIxNjMxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d1ce8a3dbb1e66f8f66624e32752066fae33f427c95fc30668ee43f6f77a9c0e |
| hovercard-subject-tag | pull_request:161908918 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/5140/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5461395e82907acb0bca490f4829e4afbc8a1453d04c1b110d33fa0deca7fd8f/python/cpython/pull/5140 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5461395e82907acb0bca490f4829e4afbc8a1453d04c1b110d33fa0deca7fd8f/python/cpython/pull/5140 |
| og:image:alt | This PR provides documentation on correct handling of multiphase initialized modules' traversing.
It also contains a check that, in a debug build (--with-pydebug), does a sanity check for m_tr... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/5140#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5140 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5140 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/5140 |
| Reload | https://github.com/python/cpython/pull/5140 |
| Reload | https://github.com/python/cpython/pull/5140 |
| Please reload this page | https://github.com/python/cpython/pull/5140 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/5140 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| ncoghlan | https://github.com/ncoghlan |
| master | https://github.com/python/cpython/tree/master |
| Conversation | https://github.com/python/cpython/pull/5140 |
| Commits2 (2) | https://github.com/python/cpython/pull/5140/commits |
| Checks | https://github.com/python/cpython/pull/5140/checks |
| Files changed | https://github.com/python/cpython/pull/5140/files |
| bpo-32374: Document that m_traverse for multi-phase initialized modules can be called with m_state=NULL | https://github.com/python/cpython/pull/5140#top |
| ncoghlan | https://github.com/ncoghlan |
| master | https://github.com/python/cpython/tree/master |
|
| https://github.com/ghost |
| ghost | https://github.com/ghost |
| Jan 9, 2018 | https://github.com/python/cpython/pull/5140#issue-287139115 |
| Please reload this page | https://github.com/python/cpython/pull/5140 |
| https://bugs.python.org/issue32374 | https://bugs.python.org/issue32374 |
| Please reload this page | https://github.com/python/cpython/pull/5140 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Jan 9, 2018 | https://github.com/python/cpython/pull/5140#event-1415941544 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jan 9, 2018 | https://github.com/python/cpython/pull/5140#event-1415941587 |
| January 9, 2018 17:14 | https://github.com/python/cpython/pull/5140#commits-pushed-8bbf7c5 |
| Documentation and testing | https://github.com/python/cpython/pull/5140/commits/8bbf7c593ddbf6f7740c43df389681f3d69dfa3c |
| 8bbf7c5 | https://github.com/python/cpython/pull/5140/commits/8bbf7c593ddbf6f7740c43df389681f3d69dfa3c |
| fixes | https://github.com/python/cpython/pull/5140/commits/033521427bee78339680221e34604974719ebc33 |
| 0335214 | https://github.com/python/cpython/pull/5140/commits/033521427bee78339680221e34604974719ebc33 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Mar 15, 2018 | https://github.com/python/cpython/pull/5140#issuecomment-373435049 |
| @ncoghlan | https://github.com/ncoghlan |
| Please reload this page | https://github.com/python/cpython/pull/5140 |
| https://github.com/ncoghlan |
| ncoghlan | https://github.com/ncoghlan |
|
needs backport to 3.6
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22 |
| Mar 17, 2018 | https://github.com/python/cpython/pull/5140#event-1526716425 |
| https://github.com/ncoghlan |
| ncoghlan | https://github.com/ncoghlan |
| Mar 17, 2018 | https://github.com/python/cpython/pull/5140#issuecomment-373896224 |
| Please reload this page | https://github.com/python/cpython/pull/5140 |
| https://github.com/ncoghlan |
| ncoghlan | https://github.com/ncoghlan |
| c2b0b12 | https://github.com/python/cpython/commit/c2b0b12d1a137ada1023ab7c10b8d9a0249d95f9 |
| Mar 17, 2018 | https://github.com/python/cpython/pull/5140#event-1526717020 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Mar 17, 2018 | https://github.com/python/cpython/pull/5140#issuecomment-373896321 |
| @ncoghlan | https://github.com/ncoghlan |
| Please reload this page | https://github.com/python/cpython/pull/5140 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Mar 17, 2018 | https://github.com/python/cpython/pull/5140#event-1526717026 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Mar 17, 2018 | https://github.com/python/cpython/pull/5140#issuecomment-373896338 |
| GH-6128 | https://github.com/python/cpython/pull/6128 |
| 3.7 branch | https://github.com/python/cpython/tree/3.7 |
| Please reload this page | https://github.com/python/cpython/pull/5140 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.7
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22 |
| Mar 17, 2018 | https://github.com/python/cpython/pull/5140#event-1526717121 |
| miss-islington | https://github.com/miss-islington |
|
Mar 17, 2018
| https://github.com/python/cpython/pull/5140#ref-commit-ff557a0 |
|
| https://github.com/miss-islington |
| bpo-32374: m_traverse may be called with m_state=NULL ( | https://github.com/miss-islington/cpython/commit/ff557a0772c8112fb24518d7dfcdf9d4adfdcf54 |
| pythonGH-5140 | https://github.com/python/cpython/pull/5140 |
| ) | https://github.com/miss-islington/cpython/commit/ff557a0772c8112fb24518d7dfcdf9d4adfdcf54 |
| ff557a0 | https://github.com/miss-islington/cpython/commit/ff557a0772c8112fb24518d7dfcdf9d4adfdcf54 |
| c2b0b12 | https://github.com/miss-islington/cpython/commit/c2b0b12d1a137ada1023ab7c10b8d9a0249d95f9 |
| miss-islington | https://github.com/miss-islington |
|
Mar 17, 2018
| https://github.com/python/cpython/pull/5140#ref-commit-ae3980f |
|
| https://github.com/miss-islington |
| bpo-32374: m_traverse may be called with m_state=NULL ( | https://github.com/miss-islington/cpython/commit/ae3980ff9f0a807a80ed66332bd0354b129b1b02 |
| pythonGH-5140 | https://github.com/python/cpython/pull/5140 |
| ) | https://github.com/miss-islington/cpython/commit/ae3980ff9f0a807a80ed66332bd0354b129b1b02 |
| ae3980f | https://github.com/miss-islington/cpython/commit/ae3980ff9f0a807a80ed66332bd0354b129b1b02 |
| c2b0b12 | https://github.com/miss-islington/cpython/commit/c2b0b12d1a137ada1023ab7c10b8d9a0249d95f9 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Mar 17, 2018 | https://github.com/python/cpython/pull/5140#issuecomment-373896365 |
| GH-6129 | https://github.com/python/cpython/pull/6129 |
| 3.6 branch | https://github.com/python/cpython/tree/3.6 |
| Please reload this page | https://github.com/python/cpython/pull/5140 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.6
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22 |
| Mar 17, 2018 | https://github.com/python/cpython/pull/5140#event-1526717312 |
| miss-islington | https://github.com/miss-islington |
|
Mar 17, 2018
| https://github.com/python/cpython/pull/5140#ref-commit-136905f |
|
| https://github.com/miss-islington |
| bpo-32374 | https://bugs.python.org/issue?@action=redirect&bpo=32374 |
| : m_traverse may be called with m_state=NULL ( | https://github.com/python/cpython/commit/136905fffd5f77395f80e3409630c11756b5469c |
| GH-5140 | https://github.com/python/cpython/pull/5140 |
| ) | https://github.com/python/cpython/commit/136905fffd5f77395f80e3409630c11756b5469c |
| 136905f | https://github.com/python/cpython/commit/136905fffd5f77395f80e3409630c11756b5469c |
| c2b0b12 | https://github.com/python/cpython/commit/c2b0b12d1a137ada1023ab7c10b8d9a0249d95f9 |
| miss-islington | https://github.com/miss-islington |
|
Mar 17, 2018
| https://github.com/python/cpython/pull/5140#ref-commit-1da0479 |
|
| https://github.com/miss-islington |
| bpo-32374 | https://bugs.python.org/issue?@action=redirect&bpo=32374 |
| : m_traverse may be called with m_state=NULL ( | https://github.com/python/cpython/commit/1da0479f687613a43620430616f4db87e2ed4423 |
| GH-5140 | https://github.com/python/cpython/pull/5140 |
| ) | https://github.com/python/cpython/commit/1da0479f687613a43620430616f4db87e2ed4423 |
| 1da0479 | https://github.com/python/cpython/commit/1da0479f687613a43620430616f4db87e2ed4423 |
| c2b0b12 | https://github.com/python/cpython/commit/c2b0b12d1a137ada1023ab7c10b8d9a0249d95f9 |
| jo2y | https://github.com/jo2y |
|
Mar 23, 2018
| https://github.com/python/cpython/pull/5140#ref-commit-59ef0a4 |
|
| https://github.com/jo2y |
| bpo-32374: m_traverse may be called with m_state=NULL ( | https://github.com/jo2y/cpython/commit/59ef0a447dc003cd1a024ecb96ef53cf7ca242d0 |
| pythonGH-5140 | https://github.com/python/cpython/pull/5140 |
| ) | https://github.com/jo2y/cpython/commit/59ef0a447dc003cd1a024ecb96ef53cf7ca242d0 |
| 59ef0a4 | https://github.com/jo2y/cpython/commit/59ef0a447dc003cd1a024ecb96ef53cf7ca242d0 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
May 28, 2018
| https://github.com/python/cpython/pull/5140#ref-pullrequest-326953334 |
|
bpo-32374: Fix test_bad_traverse.
#7145
| https://github.com/python/cpython/pull/7145 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5140 |
| Please reload this page | https://github.com/python/cpython/pull/5140 |
|
| https://github.com/encukou |
|
| https://github.com/ncoghlan |
|
| https://github.com/miss-islington |
|
| https://github.com/bedevere-bot |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |