René's URL Explorer Experiment


Title: [bpo-28414] Make all hostnames in SSL module IDN A-labels by tiran · Pull Request #5128 · python/cpython · GitHub

Open Graph Title: [bpo-28414] Make all hostnames in SSL module IDN A-labels by tiran · Pull Request #5128 · python/cpython

X Title: [bpo-28414] Make all hostnames in SSL module IDN A-labels by tiran · Pull Request #5128 · python/cpython

Description: Alternative approach to PR #3010 Really all server_hostname attributes are IDN A-labels SSLContext.set_servername_callback argument is IDN A-label, too Replace all externally replaced certs with proper certs from internal test helper https://bugs.python.org/issue28414

Open Graph Description: Alternative approach to PR #3010 Really all server_hostname attributes are IDN A-labels SSLContext.set_servername_callback argument is IDN A-label, too Replace all externally replaced certs with p...

X Description: Alternative approach to PR #3010 Really all server_hostname attributes are IDN A-labels SSLContext.set_servername_callback argument is IDN A-label, too Replace all externally replaced certs with p...

Opengraph URL: https://github.com/python/cpython/pull/5128

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3767019d-c656-6dcd-682e-fdc43037cdb4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA65C:3985C:D4341D:11F3156:6A4D5B46
html-safe-noncec8a9a02ef6bd9f20b6aa88c700d5e0a78aebcd5b368701e8ac6a86a29169a983
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjVDOjM5ODVDOkQ0MzQxRDoxMUYzMTU2OjZBNEQ1QjQ2IiwidmlzaXRvcl9pZCI6IjE1MDk4MDUwODc5MzI2MzU5NzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac47dea98978fdb04502609d97fc4b27bf711859cb3f59244679fe383699e24d4a
hovercard-subject-tagpull_request:161526724
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/5128/files
twitter:imagehttps://avatars.githubusercontent.com/u/444071?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/444071?s=400&v=4
og:image:altAlternative approach to PR #3010 Really all server_hostname attributes are IDN A-labels SSLContext.set_servername_callback argument is IDN A-label, too Replace all externally replaced certs with p...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2a1443ff9733a3016431263ea73c93d8fe00c195eb4a7670ac30e7848f045441
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3bdd3157ea1f0fd738d408eceeead721acf1dc3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/5128/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5128%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5128%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/5128/files
Reloadhttps://github.com/python/cpython/pull/5128/files
Reloadhttps://github.com/python/cpython/pull/5128/files
Please reload this pagehttps://github.com/python/cpython/pull/5128/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/5128/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
njsmithhttps://github.com/njsmith
python:masterhttps://github.com/python/cpython/tree/master
tiran:die-idna-die-hardhttps://github.com/tiran/cpython/tree/die-idna-die-hard
Conversation 24 https://github.com/python/cpython/pull/5128
Commits 6 https://github.com/python/cpython/pull/5128/commits
Checks 0 https://github.com/python/cpython/pull/5128/checks
Files changed https://github.com/python/cpython/pull/5128/files
Please reload this pagehttps://github.com/python/cpython/pull/5128/files
[bpo-28414] Make all hostnames in SSL module IDN A-labels https://github.com/python/cpython/pull/5128/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/5128/files
b116364 [bpo-28414] In SSL module, store server_hostname as an A-label njsmith Aug 6, 2017 https://github.com/python/cpython/pull/5128/commits/b1163645d6e905bb684090690141c2ee2b507cf2
f985559 Drop trustme certs tiran Jan 7, 2018 https://github.com/python/cpython/pull/5128/commits/f9855596511f82ab30d031a36234bf7069627133
1ec0678 Fix IDN SAN handling tiran Jan 7, 2018 https://github.com/python/cpython/pull/5128/commits/1ec067804bbcf40ed1ec1dd61643a1b78dd70b56
a0e42d4 Small doc updates njsmith Feb 23, 2018 https://github.com/python/cpython/pull/5128/commits/a0e42d4576f5a5a9fc0b05352acb47c76918032f
e5073b5 Update blurb to match what this PR does now njsmith Feb 23, 2018 https://github.com/python/cpython/pull/5128/commits/e5073b5b87d4e82a68cf53baca2e6cfb3abf69a6
8e3c14f Address review comments tiran Feb 23, 2018 https://github.com/python/cpython/pull/5128/commits/8e3c14f685a0e0aff66407de17242a13601d6ea1
Clear filters https://github.com/python/cpython/pull/5128/files
Please reload this pagehttps://github.com/python/cpython/pull/5128/files
Please reload this pagehttps://github.com/python/cpython/pull/5128/files
ssl.rst https://github.com/python/cpython/pull/5128/files#diff-df0c7115ade453321aadb2eb534941f2ec87c4b52563bae70421918dce5435dc
3.7.rst https://github.com/python/cpython/pull/5128/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
ssl.py https://github.com/python/cpython/pull/5128/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
test_ssl.py https://github.com/python/cpython/pull/5128/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
2017-08-06-14-43-45.bpo-28414.mzZ6vD.rst https://github.com/python/cpython/pull/5128/files#diff-2826d6b6523cbeffdcc3f6913d4a29a4d6dfb17f4a414da859969a18235efa17
_ssl.c https://github.com/python/cpython/pull/5128/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
_ssl.c.h https://github.com/python/cpython/pull/5128/files#diff-f1e8bf0ef81915ccc340d8ed854ccc47f0a7f88fbadb261c6b4b4b90dee3b57a
Doc/library/ssl.rsthttps://github.com/python/cpython/pull/5128/files#diff-df0c7115ade453321aadb2eb534941f2ec87c4b52563bae70421918dce5435dc
View file https://github.com/tiran/cpython/blob/8e3c14f685a0e0aff66407de17242a13601d6ea1/Doc/library/ssl.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5128/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5128/files#diff-df0c7115ade453321aadb2eb534941f2ec87c4b52563bae70421918dce5435dc
https://github.com/python/cpython/pull/5128/files#diff-df0c7115ade453321aadb2eb534941f2ec87c4b52563bae70421918dce5435dc
https://github.com/python/cpython/pull/5128/files#diff-df0c7115ade453321aadb2eb534941f2ec87c4b52563bae70421918dce5435dc
https://github.com/python/cpython/pull/5128/files#diff-df0c7115ade453321aadb2eb534941f2ec87c4b52563bae70421918dce5435dc
https://github.com/python/cpython/pull/5128/files#diff-df0c7115ade453321aadb2eb534941f2ec87c4b52563bae70421918dce5435dc
Doc/whatsnew/3.7.rsthttps://github.com/python/cpython/pull/5128/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
View file https://github.com/tiran/cpython/blob/8e3c14f685a0e0aff66407de17242a13601d6ea1/Doc/whatsnew/3.7.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5128/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5128/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
https://github.com/python/cpython/pull/5128/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
Lib/ssl.pyhttps://github.com/python/cpython/pull/5128/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
View file https://github.com/tiran/cpython/blob/8e3c14f685a0e0aff66407de17242a13601d6ea1/Lib/ssl.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5128/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5128/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
njsmithhttps://github.com/njsmith
Feb 22, 2018https://github.com/python/cpython/pull/5128/files#r170119184
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128/files
tiranhttps://github.com/tiran
Feb 23, 2018https://github.com/python/cpython/pull/5128/files#r170229247
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128/files
https://github.com/python/cpython/pull/5128/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
https://github.com/python/cpython/pull/5128/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
https://github.com/python/cpython/pull/5128/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
https://github.com/python/cpython/pull/5128/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
https://github.com/python/cpython/pull/5128/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
https://github.com/python/cpython/pull/5128/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
https://github.com/python/cpython/pull/5128/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
https://github.com/python/cpython/pull/5128/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
https://github.com/python/cpython/pull/5128/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
Lib/test/test_ssl.pyhttps://github.com/python/cpython/pull/5128/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
View file https://github.com/tiran/cpython/blob/8e3c14f685a0e0aff66407de17242a13601d6ea1/Lib/test/test_ssl.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5128/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5128/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/5128/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/5128/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/5128/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/5128/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/5128/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
Misc/NEWS.d/next/Security/2017-08-06-14-43-45.bpo-28414.mzZ6vD.rsthttps://github.com/python/cpython/pull/5128/files#diff-2826d6b6523cbeffdcc3f6913d4a29a4d6dfb17f4a414da859969a18235efa17
View file https://github.com/tiran/cpython/blob/8e3c14f685a0e0aff66407de17242a13601d6ea1/Misc/NEWS.d/next/Security/2017-08-06-14-43-45.bpo-28414.mzZ6vD.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5128/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/5128/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.