René's URL Explorer Experiment


Title: [bpo-28414] Make all hostnames in SSL module IDN A-labels by tiran · Pull Request #5128 · python/cpython · GitHub

Open Graph Title: [bpo-28414] Make all hostnames in SSL module IDN A-labels by tiran · Pull Request #5128 · python/cpython

X Title: [bpo-28414] Make all hostnames in SSL module IDN A-labels by tiran · Pull Request #5128 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Alternative approach to PR #3010 Really all server_hostname attributes are IDN A-labels SSLContext.set_servername_callback argument is IDN A-label, too Replace all externally replaced certs with p...

X Description: Alternative approach to PR #3010 Really all server_hostname attributes are IDN A-labels SSLContext.set_servername_callback argument is IDN A-label, too Replace all externally replaced certs with p...

Opengraph URL: https://github.com/python/cpython/pull/5128

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f9eb2106-d346-ea54-e0c7-fc27fe49fdbe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id874C:7802D:174C4:1E37F:6A4D1477
html-safe-nonce5ba4649ca5d21d1860c91fb5d833ad3512ba39ac52e07f3ee4e74855db761dfc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzRDOjc4MDJEOjE3NEM0OjFFMzdGOjZBNEQxNDc3IiwidmlzaXRvcl9pZCI6IjkwMTA2NTkzOTgxNDIyMDI5OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf6209dab706d60258a3b29f565d52c1fd5874459e4ec9d693145f3a591f416ea
hovercard-subject-tagpull_request:161526724
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/5128/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/76bc024aae5430936cf389af2a347737e77ed7d66da41191d075f6007f503980/python/cpython/pull/5128
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/76bc024aae5430936cf389af2a347737e77ed7d66da41191d075f6007f503980/python/cpython/pull/5128
og:image:altAlternative approach to PR #3010 Really all server_hostname attributes are IDN A-labels SSLContext.set_servername_callback argument is IDN A-label, too Replace all externally replaced certs with p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametiran
hostnamegithub.com
expected-hostnamegithub.com
Nonef02420044fa3730a0607f4a52546bdd73f5ae60187ef57d284ecb6d7f3f1d880
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef0b6a62c1f0be1086cb0b5b077b82cebe520eb42
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/5128#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5128
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5128
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/5128
Reloadhttps://github.com/python/cpython/pull/5128
Reloadhttps://github.com/python/cpython/pull/5128
Please reload this pagehttps://github.com/python/cpython/pull/5128
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/5128
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
njsmithhttps://github.com/njsmith
python:masterhttps://github.com/python/cpython/tree/master
tiran:die-idna-die-hardhttps://github.com/tiran/cpython/tree/die-idna-die-hard
Conversationhttps://github.com/python/cpython/pull/5128
Commits6 (6)https://github.com/python/cpython/pull/5128/commits
Checkshttps://github.com/python/cpython/pull/5128/checks
Files changedhttps://github.com/python/cpython/pull/5128/files
[bpo-28414] Make all hostnames in SSL module IDN A-labelshttps://github.com/python/cpython/pull/5128#top
njsmithhttps://github.com/njsmith
python:masterhttps://github.com/python/cpython/tree/master
tiran:die-idna-die-hardhttps://github.com/tiran/cpython/tree/die-idna-die-hard
https://github.com/tiran
tiranhttps://github.com/tiran
Jan 7, 2018https://github.com/python/cpython/pull/5128#issue-286577863
Please reload this pagehttps://github.com/python/cpython/pull/5128
#3010https://github.com/python/cpython/pull/3010
https://bugs.python.org/issue28414https://bugs.python.org/issue28414
Please reload this pagehttps://github.com/python/cpython/pull/5128
https://github.com/tiran
tiranhttps://github.com/tiran
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
code ownershttps://github.com/python/cpython/blob/e46a8af450210ee5c7f0459ad6beddbc626ae60f/.github/CODEOWNERS#L8
January 7, 2018 15:41https://github.com/python/cpython/pull/5128#event-1412773406
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jan 7, 2018https://github.com/python/cpython/pull/5128#event-1412773425
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 7, 2018https://github.com/python/cpython/pull/5128#event-1412773427
https://github.com/tiran
tiranhttps://github.com/tiran
force-pushedhttps://github.com/python/cpython/compare/134072e215679292c063bb79d84abacbb55619a3..eacb9e9c2ac465c3c9856379d7528e70331840e3
134072ehttps://github.com/python/cpython/commit/134072e215679292c063bb79d84abacbb55619a3
eacb9e9https://github.com/python/cpython/commit/eacb9e9c2ac465c3c9856379d7528e70331840e3
Compare https://github.com/python/cpython/compare/134072e215679292c063bb79d84abacbb55619a3..eacb9e9c2ac465c3c9856379d7528e70331840e3
January 7, 2018 15:42https://github.com/python/cpython/pull/5128#event-1412773733
https://github.com/tiran
tiranhttps://github.com/tiran
Jan 7, 2018 https://github.com/python/cpython/pull/5128#ref-pullrequest-248274102
[bpo-28414] In SSL module, store server_hostname as an A-label #3010 https://github.com/python/cpython/pull/3010
https://github.com/alex
alexhttps://github.com/alex
Jan 7, 2018 https://github.com/python/cpython/pull/5128#pullrequestreview-87102982
View reviewed changes https://github.com/python/cpython/pull/5128/files
Doc/whatsnew/3.7.rsthttps://github.com/python/cpython/pull/5128/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
alexhttps://github.com/alex
Jan 7, 2018https://github.com/python/cpython/pull/5128#discussion_r160053106
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
alexhttps://github.com/alex
Jan 7, 2018https://github.com/python/cpython/pull/5128#discussion_r160053114
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
tiranhttps://github.com/tiran
Jan 7, 2018https://github.com/python/cpython/pull/5128#discussion_r160053348
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
Lib/test/test_asyncio/test_events.pyhttps://github.com/python/cpython/pull/5128/files#diff-b125df0ba39acde9a49ff4ce6a554310cab3daf258a2e77c219fce5a8b17c146
alexhttps://github.com/alex
Jan 7, 2018https://github.com/python/cpython/pull/5128#discussion_r160053137
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
tiranhttps://github.com/tiran
Jan 7, 2018https://github.com/python/cpython/pull/5128#discussion_r160053270
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
https://github.com/tiran
tiranhttps://github.com/tiran
force-pushedhttps://github.com/python/cpython/compare/eacb9e9c2ac465c3c9856379d7528e70331840e3..9bd40df672efab7b19dd2677674d450dc98bb90d
eacb9e9https://github.com/python/cpython/commit/eacb9e9c2ac465c3c9856379d7528e70331840e3
9bd40dfhttps://github.com/python/cpython/commit/9bd40df672efab7b19dd2677674d450dc98bb90d
Compare https://github.com/python/cpython/compare/eacb9e9c2ac465c3c9856379d7528e70331840e3..9bd40df672efab7b19dd2677674d450dc98bb90d
January 7, 2018 16:06https://github.com/python/cpython/pull/5128#event-1412780446
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
Jan 9, 2018 https://github.com/python/cpython/pull/5128#pullrequestreview-87537197
View reviewed changes https://github.com/python/cpython/pull/5128/files
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Jan 10, 2018https://github.com/python/cpython/pull/5128#issuecomment-356756838
https://mail.python.org/pipermail/python-dev/2017-December/151527.htmlhttps://mail.python.org/pipermail/python-dev/2017-December/151527.html
https://straße.dehttps://stra%C3%9Fe.de
Please reload this pagehttps://github.com/python/cpython/pull/5128
https://github.com/tiran
tiranhttps://github.com/tiran
force-pushedhttps://github.com/python/cpython/compare/9bd40df672efab7b19dd2677674d450dc98bb90d..31b862e289febf77791bc3570d9bb013ef824f5d
9bd40dfhttps://github.com/python/cpython/commit/9bd40df672efab7b19dd2677674d450dc98bb90d
31b862ehttps://github.com/python/cpython/commit/31b862e289febf77791bc3570d9bb013ef824f5d
Compare https://github.com/python/cpython/compare/9bd40df672efab7b19dd2677674d450dc98bb90d..31b862e289febf77791bc3570d9bb013ef824f5d
January 13, 2018 19:19https://github.com/python/cpython/pull/5128#event-1423073223
https://github.com/tiran
tiranhttps://github.com/tiran
Jan 13, 2018https://github.com/python/cpython/pull/5128#issuecomment-357460867
Please reload this pagehttps://github.com/python/cpython/pull/5128
https://github.com/tiran
tiranhttps://github.com/tiran
force-pushedhttps://github.com/python/cpython/compare/31b862e289febf77791bc3570d9bb013ef824f5d..0b512f15d55e678866f1b56998a747ea2cbc2103
31b862ehttps://github.com/python/cpython/commit/31b862e289febf77791bc3570d9bb013ef824f5d
0b512f1https://github.com/python/cpython/commit/0b512f15d55e678866f1b56998a747ea2cbc2103
Compare https://github.com/python/cpython/compare/31b862e289febf77791bc3570d9bb013ef824f5d..0b512f15d55e678866f1b56998a747ea2cbc2103
January 14, 2018 00:18https://github.com/python/cpython/pull/5128#event-1423154140
https://github.com/tiran
tiranhttps://github.com/tiran
Jan 19, 2018 https://github.com/python/cpython/pull/5128#ref-pullrequest-289948760
bpo-32598: Use autoconf to detect usable OpenSSL #5242 https://github.com/python/cpython/pull/5242
https://github.com/tiran
tiranhttps://github.com/tiran
force-pushedhttps://github.com/python/cpython/compare/0b512f15d55e678866f1b56998a747ea2cbc2103..428265e5ec9e1ec3828e5b0138e4ea63cf0f2763
0b512f1https://github.com/python/cpython/commit/0b512f15d55e678866f1b56998a747ea2cbc2103
428265ehttps://github.com/python/cpython/commit/428265e5ec9e1ec3828e5b0138e4ea63cf0f2763
Compare https://github.com/python/cpython/compare/0b512f15d55e678866f1b56998a747ea2cbc2103..428265e5ec9e1ec3828e5b0138e4ea63cf0f2763
January 20, 2018 14:23https://github.com/python/cpython/pull/5128#event-1433714565
https://github.com/tiran
tiranhttps://github.com/tiran
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
Jan 26, 2018https://github.com/python/cpython/pull/5128#event-1444254522
https://github.com/tiran
tiranhttps://github.com/tiran
force-pushedhttps://github.com/python/cpython/compare/428265e5ec9e1ec3828e5b0138e4ea63cf0f2763..5ec02e419897b4e229b62e568c1f12bca3de9c2c
428265ehttps://github.com/python/cpython/commit/428265e5ec9e1ec3828e5b0138e4ea63cf0f2763
5ec02e4https://github.com/python/cpython/commit/5ec02e419897b4e229b62e568c1f12bca3de9c2c
Compare https://github.com/python/cpython/compare/428265e5ec9e1ec3828e5b0138e4ea63cf0f2763..5ec02e419897b4e229b62e568c1f12bca3de9c2c
January 28, 2018 19:50https://github.com/python/cpython/pull/5128#event-1445319099
njsmithhttps://github.com/njsmith
February 22, 2018 18:48https://github.com/python/cpython/pull/5128#commits-pushed-b116364
https://github.com/njsmith
https://github.com/tiran
[bpo-28414] In SSL module, store server_hostname as an A-labelhttps://github.com/python/cpython/pull/5128/commits/b1163645d6e905bb684090690141c2ee2b507cf2
b116364https://github.com/python/cpython/pull/5128/commits/b1163645d6e905bb684090690141c2ee2b507cf2
https://github.com/tiran
Drop trustme certshttps://github.com/python/cpython/pull/5128/commits/f9855596511f82ab30d031a36234bf7069627133
f985559https://github.com/python/cpython/pull/5128/commits/f9855596511f82ab30d031a36234bf7069627133
https://github.com/tiran
Fix IDN SAN handlinghttps://github.com/python/cpython/pull/5128/commits/1ec067804bbcf40ed1ec1dd61643a1b78dd70b56
1ec0678https://github.com/python/cpython/pull/5128/commits/1ec067804bbcf40ed1ec1dd61643a1b78dd70b56
https://github.com/tiran
tiranhttps://github.com/tiran
force-pushedhttps://github.com/python/cpython/compare/5ec02e419897b4e229b62e568c1f12bca3de9c2c..1ec067804bbcf40ed1ec1dd61643a1b78dd70b56
5ec02e4https://github.com/python/cpython/commit/5ec02e419897b4e229b62e568c1f12bca3de9c2c
1ec0678https://github.com/python/cpython/commit/1ec067804bbcf40ed1ec1dd61643a1b78dd70b56
Compare https://github.com/python/cpython/compare/5ec02e419897b4e229b62e568c1f12bca3de9c2c..1ec067804bbcf40ed1ec1dd61643a1b78dd70b56
February 22, 2018 18:19https://github.com/python/cpython/pull/5128#event-1487570515
https://github.com/tiran
tiranhttps://github.com/tiran
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
Feb 22, 2018https://github.com/python/cpython/pull/5128#event-1487571770
https://github.com/tiran
tiranhttps://github.com/tiran
Feb 22, 2018https://github.com/python/cpython/pull/5128#event-1487587878
https://github.com/tiran
tiranhttps://github.com/tiran
njsmithhttps://github.com/njsmith
February 22, 2018 18:29https://github.com/python/cpython/pull/5128#event-1487588486
njsmithhttps://github.com/njsmith
February 22, 2018 17:14https://github.com/python/cpython/pull/5128#commits-pushed-a0e42d4
https://github.com/njsmith
Small doc updateshttps://github.com/python/cpython/pull/5128/commits/a0e42d4576f5a5a9fc0b05352acb47c76918032f
a0e42d4https://github.com/python/cpython/pull/5128/commits/a0e42d4576f5a5a9fc0b05352acb47c76918032f
https://github.com/njsmith
Update blurb to match what this PR does nowhttps://github.com/python/cpython/pull/5128/commits/e5073b5b87d4e82a68cf53baca2e6cfb3abf69a6
e5073b5https://github.com/python/cpython/pull/5128/commits/e5073b5b87d4e82a68cf53baca2e6cfb3abf69a6
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Feb 23, 2018 https://github.com/python/cpython/pull/5128#pullrequestreview-98758430
View reviewed changes https://github.com/python/cpython/pull/5128/files/1ec067804bbcf40ed1ec1dd61643a1b78dd70b56
njsmithhttps://github.com/njsmith
https://github.com/python/cpython/pull/5128#pullrequestreview-98758430
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
Lib/ssl.pyhttps://github.com/python/cpython/pull/5128/files/1ec067804bbcf40ed1ec1dd61643a1b78dd70b56#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
njsmithhttps://github.com/njsmith
Feb 22, 2018https://github.com/python/cpython/pull/5128#discussion_r170118813
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
tiranhttps://github.com/tiran
Feb 23, 2018https://github.com/python/cpython/pull/5128#discussion_r170228173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
Lib/ssl.pyhttps://github.com/python/cpython/pull/5128/files/1ec067804bbcf40ed1ec1dd61643a1b78dd70b56#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
njsmithhttps://github.com/njsmith
Feb 22, 2018https://github.com/python/cpython/pull/5128#discussion_r170118986
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
tiranhttps://github.com/tiran
Feb 23, 2018https://github.com/python/cpython/pull/5128#discussion_r170228726
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
Lib/ssl.pyhttps://github.com/python/cpython/pull/5128/files/1ec067804bbcf40ed1ec1dd61643a1b78dd70b56#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
njsmithhttps://github.com/njsmith
Feb 22, 2018https://github.com/python/cpython/pull/5128#discussion_r170119184
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
tiranhttps://github.com/tiran
Feb 23, 2018https://github.com/python/cpython/pull/5128#discussion_r170229247
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
Modules/_ssl.chttps://github.com/python/cpython/pull/5128/files/a0e42d4576f5a5a9fc0b05352acb47c76918032f#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
njsmithhttps://github.com/njsmith
Feb 23, 2018https://github.com/python/cpython/pull/5128#discussion_r170142776
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
tiranhttps://github.com/tiran
Feb 23, 2018https://github.com/python/cpython/pull/5128#discussion_r170229797
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://docs.python.org/3/library/ssl.html#ssl.SSLContext.protocolhttps://docs.python.org/3/library/ssl.html#ssl.SSLContext.protocol
Please reload this pagehttps://github.com/python/cpython/pull/5128
njsmithhttps://github.com/njsmith
Feb 24, 2018https://github.com/python/cpython/pull/5128#discussion_r170404731
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
Modules/_ssl.chttps://github.com/python/cpython/pull/5128/files/a0e42d4576f5a5a9fc0b05352acb47c76918032f#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
njsmithhttps://github.com/njsmith
Feb 23, 2018https://github.com/python/cpython/pull/5128#discussion_r170142902
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
tiranhttps://github.com/tiran
Feb 23, 2018https://github.com/python/cpython/pull/5128#discussion_r170230948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
njsmithhttps://github.com/njsmith
Feb 24, 2018https://github.com/python/cpython/pull/5128#discussion_r170404877
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5128
https://github.com/tiran
Address review commentshttps://github.com/python/cpython/pull/5128/commits/8e3c14f685a0e0aff66407de17242a13601d6ea1
8e3c14fhttps://github.com/python/cpython/pull/5128/commits/8e3c14f685a0e0aff66407de17242a13601d6ea1
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Feb 24, 2018 https://github.com/python/cpython/pull/5128#pullrequestreview-99095766
View reviewed changes https://github.com/python/cpython/pull/5128/files/8e3c14f685a0e0aff66407de17242a13601d6ea1
https://github.com/tiran
tiranhttps://github.com/tiran
Feb 24, 2018https://github.com/python/cpython/pull/5128#issuecomment-368185633
Please reload this pagehttps://github.com/python/cpython/pull/5128
https://github.com/njsmith
njsmithhttps://github.com/njsmith
11a1493https://github.com/python/cpython/commit/11a1493bc4198f1def5e572049485779cf54dc57
Feb 24, 2018https://github.com/python/cpython/pull/5128#event-1490225094
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Feb 24, 2018https://github.com/python/cpython/pull/5128#issuecomment-368185789
@tiranhttps://github.com/tiran
@njsmithhttps://github.com/njsmith
Please reload this pagehttps://github.com/python/cpython/pull/5128
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 24, 2018https://github.com/python/cpython/pull/5128#event-1490225107
miss-islingtonhttps://github.com/miss-islington
Feb 24, 2018 https://github.com/python/cpython/pull/5128#ref-commit-db1dcdf
https://github.com/tiran
https://github.com/miss-islington
[bpo-28414] Make all hostnames in SSL module IDN A-labels (https://github.com/miss-islington/cpython/commit/db1dcdfee025db4ce5cd7f4a11dcf6ac92291471
pythonGH-5128https://github.com/python/cpython/pull/5128
db1dcdfhttps://github.com/miss-islington/cpython/commit/db1dcdfee025db4ce5cd7f4a11dcf6ac92291471
https://github.com/python/cpython/pull/5128
11a1493https://github.com/miss-islington/cpython/commit/11a1493bc4198f1def5e572049485779cf54dc57
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Feb 24, 2018https://github.com/python/cpython/pull/5128#issuecomment-368185816
GH-5843https://github.com/python/cpython/pull/5843
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/5128
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Feb 24, 2018https://github.com/python/cpython/pull/5128#event-1490225240
njsmithhttps://github.com/njsmith
Feb 24, 2018 https://github.com/python/cpython/pull/5128#ref-commit-1c37e27
https://github.com/miss-islington
https://github.com/tiran
https://github.com/njsmith
[https://github.com/python/cpython/commit/1c37e277190565f0e30fc9281caae4c899ac3b50
bpo-28414https://bugs.python.org/issue?@action=redirect&bpo=28414
] Make all hostnames in SSL module IDN A-labels (https://github.com/python/cpython/commit/1c37e277190565f0e30fc9281caae4c899ac3b50
GH-5128https://github.com/python/cpython/pull/5128
) (https://github.com/python/cpython/commit/1c37e277190565f0e30fc9281caae4c899ac3b50
G…https://github.com/python/cpython/pull/5843
1c37e27https://github.com/python/cpython/commit/1c37e277190565f0e30fc9281caae4c899ac3b50
…H-5843https://github.com/python/cpython/pull/5843
11a1493https://github.com/python/cpython/commit/11a1493bc4198f1def5e572049485779cf54dc57
https://github.com/stratakis
stratakishttps://github.com/stratakis
Aug 28, 2020 https://github.com/python/cpython/pull/5128#ref-pullrequest-679371379
[3.6] bpo-41183: Skip ssl tests for disabled versions (GH-16427) #21882 https://github.com/python/cpython/pull/21882
https://github.com/mattip
mattiphttps://github.com/mattip
Dec 15, 2020https://github.com/python/cpython/pull/5128#issuecomment-745158129
Please reload this pagehttps://github.com/python/cpython/pull/5128
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5128
https://github.com/alex
alex https://github.com/alex
https://github.com/python/cpython/pull/5128/files/eacb9e9c2ac465c3c9856379d7528e70331840e3
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/python/cpython/pull/5128/files/9bd40df672efab7b19dd2677674d450dc98bb90d
https://github.com/njsmith
njsmith https://github.com/njsmith
https://github.com/python/cpython/pull/5128/files/8e3c14f685a0e0aff66407de17242a13601d6ea1
https://github.com/1st1
1st1 https://github.com/1st1
Please reload this pagehttps://github.com/python/cpython/pull/5128
https://github.com/tiran
https://github.com/njsmith
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/mattip
https://github.com/alex
https://github.com/asvetlov
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.