| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2dad96d8-9874-82ba-5b49-415054b52c2e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AD6A:2E6B05:4903BCA:65AC360:6A54ED7C |
| html-safe-nonce | 1f0f3845ba77fd8eeaac9d8e1bce0ade4cdb62a5f947173a3988f16c91f54e2e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDZBOjJFNkIwNTo0OTAzQkNBOjY1QUMzNjA6NkE1NEVEN0MiLCJ2aXNpdG9yX2lkIjoiMjg2NTc1MDQ2MDAwMTc2NTA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8440dcd8feac8c75b8200ab2c6a80fcec09e92af0cecdba151faeee4da1f4ce7 |
| hovercard-subject-tag | pull_request:160649389 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/5071/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1595ebff45fb18f8656f78d5e9db49d47262a030f2dceda5c902e79974067469/python/cpython/pull/5071 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1595ebff45fb18f8656f78d5e9db49d47262a030f2dceda5c902e79974067469/python/cpython/pull/5071 |
| og:image:alt | See bpo-17611 for detailed discussion.
This PR:
Handles stack unwinding in the compiler rather than the interpreter, getting rid of "pseudo exceptions".
Deletes a number of overly compli... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | markshannon |
| hostname | github.com |
| expected-hostname | github.com |
| None | eae2aab99907699a22d2c8449aa683ca74454fca87211b98f7c7b722086b2839 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bb1b4ffdc07c66de20ad344214f55df0aa364bd3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/5071#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5071 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5071 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/5071 |
| Reload | https://github.com/python/cpython/pull/5071 |
| Reload | https://github.com/python/cpython/pull/5071 |
| Please reload this page | https://github.com/python/cpython/pull/5071 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/5071 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| markshannon | https://github.com/markshannon |
| python:master | https://github.com/python/cpython/tree/master |
| markshannon:unwind-stack-in-compiler | https://github.com/markshannon/cpython/tree/unwind-stack-in-compiler |
| Conversation | https://github.com/python/cpython/pull/5071 |
| Commits12 (12) | https://github.com/python/cpython/pull/5071/commits |
| Checks | https://github.com/python/cpython/pull/5071/checks |
| Files changed | https://github.com/python/cpython/pull/5071/files |
| bpo-17611. Move unwinding of stack for "pseudo exceptions" from interpreter to compiler. | https://github.com/python/cpython/pull/5071#top |
| markshannon | https://github.com/markshannon |
| python:master | https://github.com/python/cpython/tree/master |
| markshannon:unwind-stack-in-compiler | https://github.com/markshannon/cpython/tree/unwind-stack-in-compiler |
|
| https://github.com/markshannon |
| markshannon | https://github.com/markshannon |
| Jan 1, 2018 | https://github.com/python/cpython/pull/5071#issue-285309298 |
| Please reload this page | https://github.com/python/cpython/pull/5071 |
| bpo-17611 | https://bugs.python.org/issue?@action=redirect&bpo=17611 |
| https://bugs.python.org/issue17611 | https://bugs.python.org/issue17611 |
| Please reload this page | https://github.com/python/cpython/pull/5071 |
| markshannon | https://github.com/markshannon |
| December 29, 2017 12:01 | https://github.com/python/cpython/pull/5071#commits-pushed-5473b29 |
|
| https://github.com/markshannon |
| bpo-17611: Move unwinding of stack from interpreter to compiler | https://github.com/python/cpython/pull/5071/commits/5473b291437f8b45ece516aa297d5df200315b2e |
| 5473b29 | https://github.com/python/cpython/pull/5071/commits/5473b291437f8b45ece516aa297d5df200315b2e |
|
| https://github.com/pitrou |
|
| https://github.com/markshannon |
| Cleanup | https://github.com/python/cpython/pull/5071/commits/b9c381d9f4ef9c53c2334dec64bb12185e73e8b8 |
| b9c381d | https://github.com/python/cpython/pull/5071/commits/b9c381d9f4ef9c53c2334dec64bb12185e73e8b8 |
| https://github.com/markshannon |
| markshannon | https://github.com/markshannon |
| 1st1 | https://github.com/1st1 |
| code owner | https://github.com/python/cpython/blob/14709144b521b9916f798a43aac9dc44fd44f6ca/.github/CODEOWNERS#L11 |
| January 1, 2018 14:09 | https://github.com/python/cpython/pull/5071#event-1405556237 |
| https://github.com/markshannon |
| markshannon | https://github.com/markshannon |
| January 1, 2018 14:09 | https://github.com/python/cpython/pull/5071#event-1405556238 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Jan 1, 2018 | https://github.com/python/cpython/pull/5071#event-1405556245 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jan 1, 2018 | https://github.com/python/cpython/pull/5071#event-1405556246 |
| markshannon | https://github.com/markshannon |
| January 2, 2018 09:48 | https://github.com/python/cpython/pull/5071#commits-pushed-79d87aa |
|
| https://github.com/markshannon |
| Add JUMP_FINALLY/END_FINALLY bytecodes to implement JSR-style finally… | https://github.com/python/cpython/pull/5071/commits/79d87aa8e2e65355c74786432012bffe61f908ce |
| 79d87aa | https://github.com/python/cpython/pull/5071/commits/79d87aa8e2e65355c74786432012bffe61f908ce |
|
| https://github.com/markshannon |
| Remove WITH_CLEANUP_START and WITH_CLEANUP_FINISH bytecodes. | https://github.com/python/cpython/pull/5071/commits/ec6fbd66a3d2189452131b7fe29f062787cb96b7 |
| ec6fbd6 | https://github.com/python/cpython/pull/5071/commits/ec6fbd66a3d2189452131b7fe29f062787cb96b7 |
|
| https://github.com/markshannon |
| Remove WITH_EXCEPT_FINISH bytecode. | https://github.com/python/cpython/pull/5071/commits/8e874795781b928b1b24d49585aa0c3a75db44e6 |
| 8e87479 | https://github.com/python/cpython/pull/5071/commits/8e874795781b928b1b24d49585aa0c3a75db44e6 |
|
| https://github.com/markshannon |
| Add test to verify that unwinding in the compiler works for nested fi… | https://github.com/python/cpython/pull/5071/commits/37191f690dec123213df3a567a0f7527b0f90be5 |
| 37191f6 | https://github.com/python/cpython/pull/5071/commits/37191f690dec123213df3a567a0f7527b0f90be5 |
|
| https://github.com/markshannon |
| Add SETUP_WITH bytecode to push a block with stack offset of -1. Used… | https://github.com/python/cpython/pull/5071/commits/f37efd02226f205885722cfe2702e947ee8a3e2c |
| f37efd0 | https://github.com/python/cpython/pull/5071/commits/f37efd02226f205885722cfe2702e947ee8a3e2c |
|
| https://github.com/markshannon |
| Combine all 'type's of try-block handlers. Remove SETUP_FINALLY bytec… | https://github.com/python/cpython/pull/5071/commits/fc358448eb1ea96b2e534cf2762e1492184acae0 |
| fc35844 | https://github.com/python/cpython/pull/5071/commits/fc358448eb1ea96b2e534cf2762e1492184acae0 |
|
| https://github.com/markshannon |
| Tidy up compile.c | https://github.com/python/cpython/pull/5071/commits/15357860dff212e205fecba0fe0444b56b872424 |
| 1535786 | https://github.com/python/cpython/pull/5071/commits/15357860dff212e205fecba0fe0444b56b872424 |
|
| https://github.com/markshannon |
| Rename ENTER_WITH to BEGIN_WITH for consistency with BEFORE_ASYNC_WITH. | https://github.com/python/cpython/pull/5071/commits/ef9623aac6bf4eb082479e08af1368d0faefbe25 |
| ef9623a | https://github.com/python/cpython/pull/5071/commits/ef9623aac6bf4eb082479e08af1368d0faefbe25 |
|
| https://github.com/markshannon |
| Avoid code duplication. | https://github.com/python/cpython/pull/5071/commits/e22251d07cd16ea4f3bc10cdc7ca693356ec8710 |
| e22251d | https://github.com/python/cpython/pull/5071/commits/e22251d07cd16ea4f3bc10cdc7ca693356ec8710 |
|
| https://github.com/markshannon |
| Update stack depth calculation to account for new style of finally bl… | https://github.com/python/cpython/pull/5071/commits/400d574ab5bbbffaf14ec54f4f00f7a8387358d9 |
| 400d574 | https://github.com/python/cpython/pull/5071/commits/400d574ab5bbbffaf14ec54f4f00f7a8387358d9 |
| https://github.com/markshannon |
| markshannon | https://github.com/markshannon |
| force-pushed | https://github.com/python/cpython/compare/bb69075690d5124bd96ad060953b9a6136dcb012..400d574ab5bbbffaf14ec54f4f00f7a8387358d9 |
| bb69075 | https://github.com/python/cpython/commit/bb69075690d5124bd96ad060953b9a6136dcb012 |
| 400d574 | https://github.com/python/cpython/commit/400d574ab5bbbffaf14ec54f4f00f7a8387358d9 |
|
Compare
| https://github.com/python/cpython/compare/bb69075690d5124bd96ad060953b9a6136dcb012..400d574ab5bbbffaf14ec54f4f00f7a8387358d9 |
| January 2, 2018 14:08 | https://github.com/python/cpython/pull/5071#event-1406279405 |
| https://github.com/pitrou |
| pitrou | https://github.com/pitrou |
| Jan 2, 2018 | https://github.com/python/cpython/pull/5071#issuecomment-354779700 |
| Please reload this page | https://github.com/python/cpython/pull/5071 |
| https://github.com/nascheme |
| nascheme | https://github.com/nascheme |
| Jan 2, 2018 | https://github.com/python/cpython/pull/5071#issuecomment-354830803 |
| Please reload this page | https://github.com/python/cpython/pull/5071 |
| https://github.com/brettcannon |
| brettcannon | https://github.com/brettcannon |
| January 2, 2018 20:22 | https://github.com/python/cpython/pull/5071#event-1406861720 |
| https://github.com/markshannon |
| markshannon | https://github.com/markshannon |
| Jan 6, 2018 | https://github.com/python/cpython/pull/5071#issuecomment-355755890 |
| #5006 | https://github.com/python/cpython/pull/5006 |
| #5112 | https://github.com/python/cpython/pull/5112 |
| Please reload this page | https://github.com/python/cpython/pull/5071 |
| https://github.com/markshannon |
| markshannon | https://github.com/markshannon |
| Jan 6, 2018 | https://github.com/python/cpython/pull/5071#event-1412440642 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5071 |
|
| https://github.com/1st1 |
|
1st1
| https://github.com/1st1 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Please reload this page | https://github.com/python/cpython/pull/5071 |
|
| https://github.com/markshannon |
|
| https://github.com/pitrou |
|
| https://github.com/nascheme |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |