| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3c84c504-a395-ad0a-f411-feda17e2874d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C1B6:2E23E:1055525:15F91B3:6A507530 |
| html-safe-nonce | 77a66c2797df171de392e3de7443a23706eed186d853909bfde691daf5a646fb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUI2OjJFMjNFOjEwNTU1MjU6MTVGOTFCMzo2QTUwNzUzMCIsInZpc2l0b3JfaWQiOiIzNTAxNjY4MjQ1Mjk5MDMzMzkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 121d06d931733a4819661ba0da84c49ab958e77277d9c5bc67bb4b962b43fda2 |
| hovercard-subject-tag | pull_request:160584633 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/5048/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/100e1ec322cc8aff44efd7e51b3a1cf953bfa9cf9cdeb287009999627b5f8839/python/cpython/pull/5048 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/100e1ec322cc8aff44efd7e51b3a1cf953bfa9cf9cdeb287009999627b5f8839/python/cpython/pull/5048 |
| og:image:alt | Add close(fd) function to the socket module
Signed-off-by: Christian Heimes christian@python.org
NOTE The PR also documents the previously undocumented socket.close function.
https://bugs.python.o... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tiran |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/5048#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5048 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5048 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/5048 |
| Reload | https://github.com/python/cpython/pull/5048 |
| Reload | https://github.com/python/cpython/pull/5048 |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| tiran | https://github.com/tiran |
| python:master | https://github.com/python/cpython/tree/master |
| tiran:socket_closefd | https://github.com/tiran/cpython/tree/socket_closefd |
| Conversation | https://github.com/python/cpython/pull/5048 |
| Commits1 (1) | https://github.com/python/cpython/pull/5048/commits |
| Checks | https://github.com/python/cpython/pull/5048/checks |
| Files changed | https://github.com/python/cpython/pull/5048/files |
| bpo-32454: socket closefd | https://github.com/python/cpython/pull/5048#top |
| tiran | https://github.com/tiran |
| python:master | https://github.com/python/cpython/tree/master |
| tiran:socket_closefd | https://github.com/tiran/cpython/tree/socket_closefd |
|
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| Dec 30, 2017 | https://github.com/python/cpython/pull/5048#issue-285194037 |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| https://bugs.python.org/issue32454 | https://bugs.python.org/issue32454 |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
|
type-feature
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature |
| Dec 30, 2017 | https://github.com/python/cpython/pull/5048#event-1405049728 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Dec 30, 2017 | https://github.com/python/cpython/pull/5048#event-1405049736 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Dec 30, 2017 | https://github.com/python/cpython/pull/5048#event-1405049737 |
| https://github.com/eryksun |
| eryksun | https://github.com/eryksun |
|
Dec 30, 2017
| https://github.com/python/cpython/pull/5048#pullrequestreview-86028965 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5048/files |
| Modules/socketmodule.c | https://github.com/python/cpython/pull/5048/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29 |
| eryksun | https://github.com/eryksun |
| Dec 30, 2017 | https://github.com/python/cpython/pull/5048#discussion_r159121134 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| tiran | https://github.com/tiran |
| Dec 30, 2017 | https://github.com/python/cpython/pull/5048#discussion_r159123187 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| https://github.com/pitrou |
| pitrou | https://github.com/pitrou |
|
Dec 30, 2017
| https://github.com/python/cpython/pull/5048#pullrequestreview-86029354 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5048/files |
| Doc/library/socket.rst | https://github.com/python/cpython/pull/5048/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943 |
| pitrou | https://github.com/pitrou |
| Dec 30, 2017 | https://github.com/python/cpython/pull/5048#discussion_r159121492 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| tiran | https://github.com/tiran |
| Dec 30, 2017 | https://github.com/python/cpython/pull/5048#discussion_r159123201 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| https://github.com/pitrou |
| pitrou | https://github.com/pitrou |
|
Dec 30, 2017
| https://github.com/python/cpython/pull/5048#pullrequestreview-86029366 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5048/files |
| Lib/test/test_socket.py | https://github.com/python/cpython/pull/5048/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
| pitrou | https://github.com/pitrou |
| Dec 30, 2017 | https://github.com/python/cpython/pull/5048#discussion_r159121505 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| pitrou | https://github.com/pitrou |
| Jan 26, 2018 | https://github.com/python/cpython/pull/5048#discussion_r164210232 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| tiran | https://github.com/tiran |
| Jan 26, 2018 | https://github.com/python/cpython/pull/5048#discussion_r164224360 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| https://github.com/pitrou |
| pitrou | https://github.com/pitrou |
|
Dec 30, 2017
| https://github.com/python/cpython/pull/5048#pullrequestreview-86029370 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5048/files |
| Lib/test/test_socket.py | https://github.com/python/cpython/pull/5048/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389 |
| pitrou | https://github.com/pitrou |
| Dec 30, 2017 | https://github.com/python/cpython/pull/5048#discussion_r159121508 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| tiran | https://github.com/tiran |
| Dec 30, 2017 | https://github.com/python/cpython/pull/5048#discussion_r159127764 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| pitrou | https://github.com/pitrou |
| Dec 30, 2017 | https://github.com/python/cpython/pull/5048#discussion_r159127779 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| force-pushed | https://github.com/python/cpython/compare/e8578d444839563c8b45bb638f3a4473e1d3c7cb..df760d22e8c330539ac5d86a5fddfba0e626ade4 |
| e8578d4 | https://github.com/python/cpython/commit/e8578d444839563c8b45bb638f3a4473e1d3c7cb |
| df760d2 | https://github.com/python/cpython/commit/df760d22e8c330539ac5d86a5fddfba0e626ade4 |
|
Compare
| https://github.com/python/cpython/compare/e8578d444839563c8b45bb638f3a4473e1d3c7cb..df760d22e8c330539ac5d86a5fddfba0e626ade4 |
| January 14, 2018 15:47 | https://github.com/python/cpython/pull/5048#event-1423351079 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
|
Jan 16, 2018
| https://github.com/python/cpython/pull/5048#ref-pullrequest-225167130 |
|
bpo-28134: Auto-detect socket values from file descriptor
#1349
| https://github.com/python/cpython/pull/1349 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| Jan 26, 2018 | https://github.com/python/cpython/pull/5048#issuecomment-360885396 |
| @eryksun | https://github.com/eryksun |
| @pitrou | https://github.com/pitrou |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
|
| https://github.com/tiran |
| bpo-32454: socket closefd | https://github.com/python/cpython/pull/5048/commits/2b317dcdc9df057770827dd26f6271d683a04438 |
| 2b317dc | https://github.com/python/cpython/pull/5048/commits/2b317dcdc9df057770827dd26f6271d683a04438 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| force-pushed | https://github.com/python/cpython/compare/df760d22e8c330539ac5d86a5fddfba0e626ade4..2b317dcdc9df057770827dd26f6271d683a04438 |
| df760d2 | https://github.com/python/cpython/commit/df760d22e8c330539ac5d86a5fddfba0e626ade4 |
| 2b317dc | https://github.com/python/cpython/commit/2b317dcdc9df057770827dd26f6271d683a04438 |
|
Compare
| https://github.com/python/cpython/compare/df760d22e8c330539ac5d86a5fddfba0e626ade4..2b317dcdc9df057770827dd26f6271d683a04438 |
| January 26, 2018 21:41 | https://github.com/python/cpython/pull/5048#event-1444417005 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| Jan 26, 2018 | https://github.com/python/cpython/pull/5048#issuecomment-360912202 |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| https://github.com/pitrou |
| pitrou | https://github.com/pitrou |
|
Jan 27, 2018
| https://github.com/python/cpython/pull/5048#pullrequestreview-92021087 |
|
View reviewed changes
| https://github.com/python/cpython/pull/5048/files/2b317dcdc9df057770827dd26f6271d683a04438 |
| pitrou | https://github.com/pitrou |
| https://github.com/python/cpython/pull/5048#pullrequestreview-92021087 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| d0e31b9 | https://github.com/python/cpython/commit/d0e31b980f18101738d0ec518cb991a5fb73fe93 |
| Jan 27, 2018 | https://github.com/python/cpython/pull/5048#event-1444750321 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Jan 27, 2018 | https://github.com/python/cpython/pull/5048#issuecomment-360970857 |
| @tiran | https://github.com/tiran |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jan 27, 2018 | https://github.com/python/cpython/pull/5048#event-1444750328 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| January 27, 2018 08:54 | https://github.com/python/cpython/pull/5048#event-1444750338 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| Jan 27, 2018 | https://github.com/python/cpython/pull/5048#issuecomment-360970881 |
| @pitrou | https://github.com/pitrou |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5048 |
|
| https://github.com/eryksun |
|
eryksun
| https://github.com/eryksun |
|
| https://github.com/python/cpython/pull/5048/files/e8578d444839563c8b45bb638f3a4473e1d3c7cb |
|
| https://github.com/pitrou |
|
pitrou
| https://github.com/pitrou |
|
| https://github.com/python/cpython/pull/5048/files/2b317dcdc9df057770827dd26f6271d683a04438 |
|
type-feature
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature |
| Please reload this page | https://github.com/python/cpython/pull/5048 |
|
| https://github.com/tiran |
|
| https://github.com/bedevere-bot |
|
| https://github.com/eryksun |
|
| https://github.com/pitrou |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |