| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:09412145-59e4-df64-839e-6457564de5ea |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C112:3EE845:68C029B:92CB1CD:6A4FC085 |
| html-safe-nonce | eee0c0775ada8bdcfadfa82c50fc17b2281057173be2edda208e2d5dd586db3e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTEyOjNFRTg0NTo2OEMwMjlCOjkyQ0IxQ0Q6NkE0RkMwODUiLCJ2aXNpdG9yX2lkIjoiNjczOTUxMjQxNDY0NjAyNjM3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b267ca284564157b71db407d054f50e84defa387155a4ab4647d73d6ed19ca99 |
| hovercard-subject-tag | pull_request:160438044 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/5032/files |
| twitter:image | https://avatars.githubusercontent.com/u/1377457?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1377457?s=400&v=4 |
| og:image:alt | This adds C API access to timezone and the timezone.UTC singleton, per bpo-10381.
@abalkin I didn't totally understand what you meant by "I am not sure whether PyDateTime_TimeZone details ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d8f8209b188a80e19a6957836ab9229715797be5db1a04163963c674ccc33f6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ea848e83cf3bf3613dd7b13d52965a684fd23ec5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/5032/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5032%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5032%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/5032/files |
| Reload | https://github.com/python/cpython/pull/5032/files |
| Reload | https://github.com/python/cpython/pull/5032/files |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| abalkin | https://github.com/abalkin |
| python:master | https://github.com/python/cpython/tree/master |
| pganssle:timezone_api | https://github.com/pganssle/cpython/tree/timezone_api |
|
Conversation
24
| https://github.com/python/cpython/pull/5032 |
|
Commits
8
| https://github.com/python/cpython/pull/5032/commits |
|
Checks
0
| https://github.com/python/cpython/pull/5032/checks |
|
Files changed
| https://github.com/python/cpython/pull/5032/files |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
|
bpo-10381: Add timezone to datetime C API
| https://github.com/python/cpython/pull/5032/files#top |
|
Show all changes
8 commits
| https://github.com/python/cpython/pull/5032/files |
|
7f1878b
Add timezone to datetime C API
pganssle Dec 28, 2017
| https://github.com/python/cpython/pull/5032/commits/7f1878b2efde491665cc54191030e5965bd2b70d |
|
20676ae
Add documentation for timezone C API macros
pganssle Dec 28, 2017
| https://github.com/python/cpython/pull/5032/commits/20676ae546ad0e47419445e19f5b35fb6f628ff5 |
|
4a1bab6
Add dedicated tests for datetime type check macros
pganssle Dec 29, 2017
| https://github.com/python/cpython/pull/5032/commits/4a1bab62f0590d6f8a9c033a9adfd3f913834376 |
|
8728bd7
Remove superfluous C API test
pganssle Dec 29, 2017
| https://github.com/python/cpython/pull/5032/commits/8728bd7bcec5c05862dfdfa2c5074912e2db9336 |
|
2c20871
Drop support for TimeZoneType in datetime C API
pganssle Jan 12, 2018
| https://github.com/python/cpython/pull/5032/commits/2c208713dcf067997cb61443ae91981cd40648c3 |
|
0398e3c
Expose UTC singleton to the datetime C API
pganssle Jan 16, 2018
| https://github.com/python/cpython/pull/5032/commits/0398e3c2ecf6345eee60d2e287b979cddc46e5d3 |
|
70642af
Update datetime C-API documentation to include links
pganssle Jan 20, 2018
| https://github.com/python/cpython/pull/5032/commits/70642af03d4208e706856aecf9408d6846e410ed |
|
9303050
Add reference count information for timezone constructors
pganssle Jan 24, 2018
| https://github.com/python/cpython/pull/5032/commits/930305077a3d6f4eceb1acda3b035560b1d70457 |
|
Clear filters
| https://github.com/python/cpython/pull/5032/files |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
|
datetime.rst
| https://github.com/python/cpython/pull/5032/files#diff-377158f0cc0f8e7ad3bba0f1a070fb4561821a4107394531c15c3a2be2d9391e |
|
refcounts.dat
| https://github.com/python/cpython/pull/5032/files#diff-8ff1c587ae684b63fa94170a8defe58fde39ef0a7d296afffc5d89e3afb95725 |
|
datetime.h
| https://github.com/python/cpython/pull/5032/files#diff-960a2fb1acbfba484b637864e42213a0ab18eb282a90ab53310a95fbe5da64a9 |
|
datetimetester.py
| https://github.com/python/cpython/pull/5032/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
2017-12-28-15-22-05.bpo-10381.a1E6aF.rst
| https://github.com/python/cpython/pull/5032/files#diff-85f2c9e5889088ffacfdd5cb47768614b785be9948886fbfbed33c466717d150 |
|
_datetimemodule.c
| https://github.com/python/cpython/pull/5032/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
_testcapimodule.c
| https://github.com/python/cpython/pull/5032/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f |
| Doc/c-api/datetime.rst | https://github.com/python/cpython/pull/5032/files#diff-377158f0cc0f8e7ad3bba0f1a070fb4561821a4107394531c15c3a2be2d9391e |
|
View file
| https://github.com/pganssle/cpython/blob/930305077a3d6f4eceb1acda3b035560b1d70457/Doc/c-api/datetime.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/5032/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/5032/files#diff-377158f0cc0f8e7ad3bba0f1a070fb4561821a4107394531c15c3a2be2d9391e |
| pganssle | https://github.com/pganssle |
| Jan 17, 2018 | https://github.com/python/cpython/pull/5032/files#r162083447 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @abalkin | https://github.com/abalkin |
| @vadmium | https://github.com/vadmium |
| #4699 | https://github.com/python/cpython/pull/4699 |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
|
| https://github.com/python/cpython/pull/5032/files#diff-377158f0cc0f8e7ad3bba0f1a070fb4561821a4107394531c15c3a2be2d9391e |
|
| https://github.com/python/cpython/pull/5032/files#diff-377158f0cc0f8e7ad3bba0f1a070fb4561821a4107394531c15c3a2be2d9391e |
| pganssle | https://github.com/pganssle |
| Jan 20, 2018 | https://github.com/python/cpython/pull/5032/files#r162788808 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
| abalkin | https://github.com/abalkin |
| Jan 23, 2018 | https://github.com/python/cpython/pull/5032/files#r163333740 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
| pganssle | https://github.com/pganssle |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5032/files#r163646053 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @abalkin | https://github.com/abalkin |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
| abalkin | https://github.com/abalkin |
| Jan 24, 2018 | https://github.com/python/cpython/pull/5032/files#r163698904 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
|
| https://github.com/python/cpython/pull/5032/files#diff-377158f0cc0f8e7ad3bba0f1a070fb4561821a4107394531c15c3a2be2d9391e |
|
| https://github.com/python/cpython/pull/5032/files#diff-377158f0cc0f8e7ad3bba0f1a070fb4561821a4107394531c15c3a2be2d9391e |
| Doc/data/refcounts.dat | https://github.com/python/cpython/pull/5032/files#diff-8ff1c587ae684b63fa94170a8defe58fde39ef0a7d296afffc5d89e3afb95725 |
|
View file
| https://github.com/pganssle/cpython/blob/930305077a3d6f4eceb1acda3b035560b1d70457/Doc/data/refcounts.dat |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/5032/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/5032/files#diff-8ff1c587ae684b63fa94170a8defe58fde39ef0a7d296afffc5d89e3afb95725 |
|
| https://github.com/python/cpython/pull/5032/files#diff-8ff1c587ae684b63fa94170a8defe58fde39ef0a7d296afffc5d89e3afb95725 |
| Include/datetime.h | https://github.com/python/cpython/pull/5032/files#diff-960a2fb1acbfba484b637864e42213a0ab18eb282a90ab53310a95fbe5da64a9 |
|
View file
| https://github.com/pganssle/cpython/blob/930305077a3d6f4eceb1acda3b035560b1d70457/Include/datetime.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/5032/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/5032/files#diff-960a2fb1acbfba484b637864e42213a0ab18eb282a90ab53310a95fbe5da64a9 |
| abalkin | https://github.com/abalkin |
| Jan 16, 2018 | https://github.com/python/cpython/pull/5032/files#r161826932 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
| pganssle | https://github.com/pganssle |
| Jan 16, 2018 | https://github.com/python/cpython/pull/5032/files#r161850415 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
|
| https://github.com/python/cpython/pull/5032/files#diff-960a2fb1acbfba484b637864e42213a0ab18eb282a90ab53310a95fbe5da64a9 |
|
| https://github.com/python/cpython/pull/5032/files#diff-960a2fb1acbfba484b637864e42213a0ab18eb282a90ab53310a95fbe5da64a9 |
|
| https://github.com/python/cpython/pull/5032/files#diff-960a2fb1acbfba484b637864e42213a0ab18eb282a90ab53310a95fbe5da64a9 |
|
| https://github.com/python/cpython/pull/5032/files#diff-960a2fb1acbfba484b637864e42213a0ab18eb282a90ab53310a95fbe5da64a9 |
|
| https://github.com/python/cpython/pull/5032/files#diff-960a2fb1acbfba484b637864e42213a0ab18eb282a90ab53310a95fbe5da64a9 |
| Lib/test/datetimetester.py | https://github.com/python/cpython/pull/5032/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
View file
| https://github.com/pganssle/cpython/blob/930305077a3d6f4eceb1acda3b035560b1d70457/Lib/test/datetimetester.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/5032/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/5032/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/5032/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/5032/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
| vadmium | https://github.com/vadmium |
| Jan 19, 2018 | https://github.com/python/cpython/pull/5032/files#r162733137 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
| pganssle | https://github.com/pganssle |
| Jan 20, 2018 | https://github.com/python/cpython/pull/5032/files#r162787991 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
|
| https://github.com/python/cpython/pull/5032/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
| Misc/NEWS.d/next/C API/2017-12-28-15-22-05.bpo-10381.a1E6aF.rst | https://github.com/python/cpython/pull/5032/files#diff-85f2c9e5889088ffacfdd5cb47768614b785be9948886fbfbed33c466717d150 |
|
View file
| https://github.com/pganssle/cpython/blob/930305077a3d6f4eceb1acda3b035560b1d70457/Misc/NEWS.d/next/C%20API/2017-12-28-15-22-05.bpo-10381.a1E6aF.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/5032/{{ revealButtonHref }} |
| Modules/_datetimemodule.c | https://github.com/python/cpython/pull/5032/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
View file
| https://github.com/pganssle/cpython/blob/930305077a3d6f4eceb1acda3b035560b1d70457/Modules/_datetimemodule.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/5032/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/5032/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
| https://github.com/python/cpython/pull/5032/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
| https://github.com/python/cpython/pull/5032/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
| https://github.com/python/cpython/pull/5032/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
| Please reload this page | https://github.com/python/cpython/pull/5032/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |