René's URL Explorer Experiment


Title: bpo-25942: make subprocess more graceful on ^C by gpshead · Pull Request #5026 · python/cpython · GitHub

Open Graph Title: bpo-25942: make subprocess more graceful on ^C by gpshead · Pull Request #5026 · python/cpython

X Title: bpo-25942: make subprocess more graceful on ^C by gpshead · Pull Request #5026 · python/cpython

Description: In Python 3.3-3.6 subprocess.call and subprocess.run would immediately SIGKILL the child process upon receiving a SIGINT (which raises a KeyboardInterrupt). We now give the child a small amount of time to exit gracefully before resorting to a SIGKILL. This is also the case for subprocess.Popen.__exit__ which would previously block indefinitely waiting for the child to die. This was hidden from many users by virtue of subprocess.call and subprocess.run sending the signal immediately. Behavior change: subprocess.Popen.__exit__ will not block indefinitely when the exiting exception is a KeyboardInterrupt. This is done for user friendliness as people expect their ^C to actually happen. This could cause occasional orphaned Popen objects when not using call or run with a child process that hasn't exited. Internal refactoring: The Popen.wait method deals with the KeyboardInterrupt. The existing platform specific internal methods have been renamed to _wait() which it calls. https://bugs.python.org/issue25942

Open Graph Description: In Python 3.3-3.6 subprocess.call and subprocess.run would immediately SIGKILL the child process upon receiving a SIGINT (which raises a KeyboardInterrupt). We now give the child a small amount of...

X Description: In Python 3.3-3.6 subprocess.call and subprocess.run would immediately SIGKILL the child process upon receiving a SIGINT (which raises a KeyboardInterrupt). We now give the child a small amount of...

Opengraph URL: https://github.com/python/cpython/pull/5026

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:912b5ab9-866f-a20c-9a53-b5134429b072
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC194:1255E3:1D0F683:29CDDF2:6A58D339
html-safe-noncecc893ec2b8c0fa191c6bae2d8ac4dd7f3e721e31319b03db56dd8c81e8830cc0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTk0OjEyNTVFMzoxRDBGNjgzOjI5Q0RERjI6NkE1OEQzMzkiLCJ2aXNpdG9yX2lkIjoiODk3MTA4MjM1Njg0MjA5MTMyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac06963a30eb94d277fbbf956c68c7a4af59ce2046b03ed52e585101639262aeea
hovercard-subject-tagpull_request:160329953
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/5026/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altIn Python 3.3-3.6 subprocess.call and subprocess.run would immediately SIGKILL the child process upon receiving a SIGINT (which raises a KeyboardInterrupt). We now give the child a small amount of...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/5026/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5026%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5026%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/5026/files
Reloadhttps://github.com/python/cpython/pull/5026/files
Reloadhttps://github.com/python/cpython/pull/5026/files
Please reload this pagehttps://github.com/python/cpython/pull/5026/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/5026/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
gpshead:issue25942https://github.com/gpshead/cpython/tree/issue25942
Conversation 10 https://github.com/python/cpython/pull/5026
Commits 9 https://github.com/python/cpython/pull/5026/commits
Checks 0 https://github.com/python/cpython/pull/5026/checks
Files changed https://github.com/python/cpython/pull/5026/files
Please reload this pagehttps://github.com/python/cpython/pull/5026/files
bpo-25942: make subprocess more graceful on ^C https://github.com/python/cpython/pull/5026/files#top
Show all changes 9 commits https://github.com/python/cpython/pull/5026/files
84e68de Don't SIGKILL children upon KeyboardInterrupt. gpshead Dec 23, 2017 https://github.com/python/cpython/pull/5026/commits/84e68dee9b1ce06b7e5efd6306f3686b25f9e956
4ee70f7 bpo-25942: subprocess is more graceful on SIGINT gpshead Dec 28, 2017 https://github.com/python/cpython/pull/5026/commits/4ee70f7c5c1ae7e02b00e2dcbbc5a636a50ca52b
5190fe4 Mention the purpose of 0.125. gpshead Dec 28, 2017 https://github.com/python/cpython/pull/5026/commits/5190fe4779f6b4751d0966351abb945870dd3069
1c7cabb remove some leftover unneeded new lines. gpshead Dec 28, 2017 https://github.com/python/cpython/pull/5026/commits/1c7cabb9ae0bf419406b15c6ee4530754cf7fcb0
3bd1021 correct a new comment in run gpshead Dec 28, 2017 https://github.com/python/cpython/pull/5026/commits/3bd102104355c8e953d17f24e29ba5e341e96f7b
ba5235b Add a NEWS entry gpshead Dec 28, 2017 https://github.com/python/cpython/pull/5026/commits/ba5235bcb825446afde241e14a356668a592e356
db44980 Simplify call and run logic. gpshead Dec 28, 2017 https://github.com/python/cpython/pull/5026/commits/db4498013ba30c4db09b46600bd708695cc8240a
424de82 Change the arbitrary small delay to another. gpshead Dec 28, 2017 https://github.com/python/cpython/pull/5026/commits/424de820d1732e5602675f44b35f575d02527496
4acf172 clarify a couple of comments. gpshead Jan 30, 2018 https://github.com/python/cpython/pull/5026/commits/4acf172b234d4c26b85acdc97d83224d0acf7774
Clear filters https://github.com/python/cpython/pull/5026/files
Please reload this pagehttps://github.com/python/cpython/pull/5026/files
Please reload this pagehttps://github.com/python/cpython/pull/5026/files
subprocess.py https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
test_subprocess.py https://github.com/python/cpython/pull/5026/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
2017-12-27-20-15-51.bpo-25942.Giyr8v.rst https://github.com/python/cpython/pull/5026/files#diff-d4067e99cd607734109e176adbc97888d167ef85d09eda46a611bdca5c7e5076
Lib/subprocess.pyhttps://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
View file https://github.com/gpshead/cpython/blob/4acf172b234d4c26b85acdc97d83224d0acf7774/Lib/subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5026/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
pitrouhttps://github.com/pitrou
Dec 29, 2017https://github.com/python/cpython/pull/5026/files#r159067977
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://www.random.org/analysis/dilbert.jpghttps://www.random.org/analysis/dilbert.jpg
Please reload this pagehttps://github.com/python/cpython/pull/5026/files
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
pitrouhttps://github.com/pitrou
Dec 29, 2017https://github.com/python/cpython/pull/5026/files#r159068243
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5026/files
gpsheadhttps://github.com/gpshead
Dec 29, 2017https://github.com/python/cpython/pull/5026/files#r159092310
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5026/files
pitrouhttps://github.com/pitrou
Dec 29, 2017https://github.com/python/cpython/pull/5026/files#r159093167
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/5026/files
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/5026/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
Lib/test/test_subprocess.pyhttps://github.com/python/cpython/pull/5026/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
View file https://github.com/gpshead/cpython/blob/4acf172b234d4c26b85acdc97d83224d0acf7774/Lib/test/test_subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5026/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5026/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
https://github.com/python/cpython/pull/5026/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
Misc/NEWS.d/next/Library/2017-12-27-20-15-51.bpo-25942.Giyr8v.rsthttps://github.com/python/cpython/pull/5026/files#diff-d4067e99cd607734109e176adbc97888d167ef85d09eda46a611bdca5c7e5076
View file https://github.com/gpshead/cpython/blob/4acf172b234d4c26b85acdc97d83224d0acf7774/Misc/NEWS.d/next/Library/2017-12-27-20-15-51.bpo-25942.Giyr8v.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5026/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.