| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:78b9e77e-653d-f168-848d-95a9019ef006 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8504:1EA4:2C8FE6D:3FF5FCA:6A4FC553 |
| html-safe-nonce | 799408385bff82da27e995347411135ef81f2be1930bc2a889ded19656721404 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTA0OjFFQTQ6MkM4RkU2RDozRkY1RkNBOjZBNEZDNTUzIiwidmlzaXRvcl9pZCI6IjY2MzU4Nzc4ODE3NDU0OTEyODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fd9628271113001bd274827efa161e3f557a73811a6b920440bdc54d340e3731 |
| hovercard-subject-tag | pull_request:159978497 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/4993/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fc3e2d152485de13d0f8b4bd5c97b371e613ba59a8b918ef86e3fa017b193f3e/python/cpython/pull/4993 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fc3e2d152485de13d0f8b4bd5c97b371e613ba59a8b918ef86e3fa017b193f3e/python/cpython/pull/4993 |
| og:image:alt | This fixes bpo-32403 and bpo-32404. The first one is a performance enhancement, the second is a bugfix.
Using this script to benchmark the alternate constructors, I see significant improvements in ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pganssle |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60b2ae4c725f51e2dac275d0ac5e9233e5967a61cdfaebd732f63da67ff1b71c |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 06fb64e1cb36b9a7a2e3f0e6c14af40ef9f439d4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/4993#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4993 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4993 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/4993 |
| Reload | https://github.com/python/cpython/pull/4993 |
| Reload | https://github.com/python/cpython/pull/4993 |
| Please reload this page | https://github.com/python/cpython/pull/4993 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/4993 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| abalkin | https://github.com/abalkin |
| python:master | https://github.com/python/cpython/tree/master |
| pganssle:faster_datetime_constructors | https://github.com/pganssle/cpython/tree/faster_datetime_constructors |
| Conversation | https://github.com/python/cpython/pull/4993 |
| Commits6 (6) | https://github.com/python/cpython/pull/4993/commits |
| Checks | https://github.com/python/cpython/pull/4993/checks |
| Files changed | https://github.com/python/cpython/pull/4993/files |
| bpo-32403: Faster date and datetime constructors | https://github.com/python/cpython/pull/4993#top |
| abalkin | https://github.com/abalkin |
| python:master | https://github.com/python/cpython/tree/master |
| pganssle:faster_datetime_constructors | https://github.com/pganssle/cpython/tree/faster_datetime_constructors |
|
| https://github.com/pganssle |
| pganssle | https://github.com/pganssle |
| Dec 23, 2017 | https://github.com/python/cpython/pull/4993#issue-284324124 |
| Please reload this page | https://github.com/python/cpython/pull/4993 |
| bpo-32403 | https://bugs.python.org/issue32403 |
| bpo-32404 | https://bugs.python.org/issue32404 |
| this script to benchmark the alternate constructors | https://gist.github.com/pganssle/15875840f31be893e7c98958730657bb |
| https://bugs.python.org/issue32403 | https://bugs.python.org/issue32403 |
| Please reload this page | https://github.com/python/cpython/pull/4993 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Dec 23, 2017 | https://github.com/python/cpython/pull/4993#event-1400474510 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Dec 23, 2017 | https://github.com/python/cpython/pull/4993#event-1400474511 |
| https://github.com/pganssle |
| pganssle | https://github.com/pganssle |
|
Dec 24, 2017
| https://github.com/python/cpython/pull/4993#pullrequestreview-85446339 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4993/files |
| Modules/_datetimemodule.c | https://github.com/python/cpython/pull/4993/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
| pganssle | https://github.com/pganssle |
| Dec 24, 2017 | https://github.com/python/cpython/pull/4993#discussion_r158607137 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4993 |
| abalkin | https://github.com/abalkin |
| Jan 9, 2018 | https://github.com/python/cpython/pull/4993#discussion_r160482598 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4993 |
| https://github.com/abalkin |
| abalkin | https://github.com/abalkin |
|
Jan 12, 2018
| https://github.com/python/cpython/pull/4993#pullrequestreview-87607715 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4993/files |
| Modules/_datetimemodule.c | https://github.com/python/cpython/pull/4993/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
| abalkin | https://github.com/abalkin |
| Jan 9, 2018 | https://github.com/python/cpython/pull/4993#discussion_r160482472 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4993 |
| Modules/_datetimemodule.c | https://github.com/python/cpython/pull/4993/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
| abalkin | https://github.com/abalkin |
| Jan 9, 2018 | https://github.com/python/cpython/pull/4993#discussion_r160482598 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4993 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Jan 12, 2018 | https://github.com/python/cpython/pull/4993#issuecomment-357310957 |
| Please reload this page | https://github.com/python/cpython/pull/4993 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jan 12, 2018 | https://github.com/python/cpython/pull/4993#event-1422246749 |
| https://github.com/abalkin |
| abalkin | https://github.com/abalkin |
| Jan 12, 2018 | https://github.com/python/cpython/pull/4993#event-1422284775 |
| https://github.com/pganssle |
| pganssle | https://github.com/pganssle |
| force-pushed | https://github.com/python/cpython/compare/6c6115c2d9245f2595a9b097989c695f75b65f1c..92ac0c4622a49330b1bd4e8681188e53a0df9f30 |
| 6c6115c | https://github.com/python/cpython/commit/6c6115c2d9245f2595a9b097989c695f75b65f1c |
| 92ac0c4 | https://github.com/python/cpython/commit/92ac0c4622a49330b1bd4e8681188e53a0df9f30 |
|
Compare
| https://github.com/python/cpython/compare/6c6115c2d9245f2595a9b097989c695f75b65f1c..92ac0c4622a49330b1bd4e8681188e53a0df9f30 |
| January 13, 2018 17:36 | https://github.com/python/cpython/pull/4993#event-1423042873 |
| pganssle | https://github.com/pganssle |
| January 13, 2018 12:37 | https://github.com/python/cpython/pull/4993#commits-pushed-5147013 |
|
| https://github.com/pganssle |
| Add tests for date subclass alternate constructors | https://github.com/python/cpython/pull/4993/commits/5147013cda578044dfa8eff318a424bb1896bd85 |
| 5147013 | https://github.com/python/cpython/pull/4993/commits/5147013cda578044dfa8eff318a424bb1896bd85 |
|
| https://github.com/pganssle |
| Switch over alternate date constructors to fast path | https://github.com/python/cpython/pull/4993/commits/587986718781a4156195d413eac1c208a7d64403 |
| 5879867 | https://github.com/python/cpython/pull/4993/commits/587986718781a4156195d413eac1c208a7d64403 |
|
| https://github.com/pganssle |
| Switch datetime constructors to fastpath, fix bpo-32404 | https://github.com/python/cpython/pull/4993/commits/2e47897470eab878649f0675df0d4588f7589e65 |
| 2e47897 | https://github.com/python/cpython/pull/4993/commits/2e47897470eab878649f0675df0d4588f7589e65 |
|
| https://github.com/pganssle |
| Add fast path for datetime in date subclass constructor | https://github.com/python/cpython/pull/4993/commits/a64e9675abf35d07bb38f314b53ddce17aa2b91d |
| a64e967 | https://github.com/python/cpython/pull/4993/commits/a64e9675abf35d07bb38f314b53ddce17aa2b91d |
|
| https://github.com/pganssle |
| Set fold in constructor in datetime.combine | https://github.com/python/cpython/pull/4993/commits/62b52f6215e18b4d0f3122f4be6af358c099dfac |
| 62b52f6 | https://github.com/python/cpython/pull/4993/commits/62b52f6215e18b4d0f3122f4be6af358c099dfac |
|
| https://github.com/pganssle |
| Add news entries. | https://github.com/python/cpython/pull/4993/commits/b438cbec71ae203c3ed889f7cd930174ed11090a |
| b438cbe | https://github.com/python/cpython/pull/4993/commits/b438cbec71ae203c3ed889f7cd930174ed11090a |
| https://github.com/pganssle |
| pganssle | https://github.com/pganssle |
| force-pushed | https://github.com/python/cpython/compare/92ac0c4622a49330b1bd4e8681188e53a0df9f30..b438cbec71ae203c3ed889f7cd930174ed11090a |
| 92ac0c4 | https://github.com/python/cpython/commit/92ac0c4622a49330b1bd4e8681188e53a0df9f30 |
| b438cbe | https://github.com/python/cpython/commit/b438cbec71ae203c3ed889f7cd930174ed11090a |
|
Compare
| https://github.com/python/cpython/compare/92ac0c4622a49330b1bd4e8681188e53a0df9f30..b438cbec71ae203c3ed889f7cd930174ed11090a |
| January 13, 2018 17:39 | https://github.com/python/cpython/pull/4993#event-1423043824 |
| https://github.com/pganssle |
| pganssle | https://github.com/pganssle |
| Jan 13, 2018 | https://github.com/python/cpython/pull/4993#issuecomment-357469617 |
| @abalkin | https://github.com/abalkin |
| Please reload this page | https://github.com/python/cpython/pull/4993 |
| https://github.com/abalkin |
| abalkin | https://github.com/abalkin |
|
Jan 16, 2018
| https://github.com/python/cpython/pull/4993#pullrequestreview-89192679 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4993/files/b438cbec71ae203c3ed889f7cd930174ed11090a |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Jan 16, 2018 | https://github.com/python/cpython/pull/4993#event-1426718005 |
| https://github.com/abalkin |
| abalkin | https://github.com/abalkin |
| 9f1b7b9 | https://github.com/python/cpython/commit/9f1b7b93f5f0ef589e7b272e127cacf4ce5d23f1 |
| Jan 16, 2018 | https://github.com/python/cpython/pull/4993#event-1426718694 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jan 16, 2018 | https://github.com/python/cpython/pull/4993#event-1426718750 |
| https://github.com/pganssle |
| pganssle | https://github.com/pganssle |
|
Feb 22, 2018
| https://github.com/python/cpython/pull/4993#ref-pullrequest-299421368 |
|
bpo-10381, bpo-32403: What's new entries for changes to datetime
#5814
| https://github.com/python/cpython/pull/5814 |
| https://github.com/pganssle |
| pganssle | https://github.com/pganssle |
| October 25, 2018 14:29 | https://github.com/python/cpython/pull/4993#event-1926408318 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4993 |
|
| https://github.com/abalkin |
|
abalkin
| https://github.com/abalkin |
|
| https://github.com/python/cpython/pull/4993/files/b438cbec71ae203c3ed889f7cd930174ed11090a |
|
| https://github.com/abalkin |
|
abalkin
| https://github.com/abalkin |
| Please reload this page | https://github.com/python/cpython/pull/4993 |
|
| https://github.com/pganssle |
|
| https://github.com/bedevere-bot |
|
| https://github.com/abalkin |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |