René's URL Explorer Experiment


Title: bpo-32243: Use monotonic clock for thread timeouts; more flexibility for very small switch intervals by embray · Pull Request #4964 · python/cpython · GitHub

Open Graph Title: bpo-32243: Use monotonic clock for thread timeouts; more flexibility for very small switch intervals by embray · Pull Request #4964 · python/cpython

X Title: bpo-32243: Use monotonic clock for thread timeouts; more flexibility for very small switch intervals by embray · Pull Request #4964 · python/cpython

Description: This is the work I did toward fixing bpo-32243 (and might be better broken into separate PRs--we'll see). This updates @vstinner's patch from bpo-23428, and on top of it adds a fix to PyCOND_TIMEDWAIT that makes small adjustments, if needed, to the timeout (in microseconds) if it's so short that the deadline is always in the past. My experience in profiling the latter fix (just with some print statements) was that on a slow VM, with setting sys.setswitchinterval(1e-6) on a slow system, this would typically go through the while loop I added to PyCOND_TIMEDWAIT twice (i.e. it would increase the timeout once). On rarer occasions it would go through three times. With sys.setswitchinterval(1e-5) it would sometimes go through the loop twice--usually just once. And for longer switch intervals than that it would always go through the loop only once. This does all unfortunately come at the cost of an unconditional extra call GETTIME(). https://bugs.python.org/issue32243

Open Graph Description: This is the work I did toward fixing bpo-32243 (and might be better broken into separate PRs--we'll see). This updates @vstinner's patch from bpo-23428, and on top of it adds a fix to PyCON...

X Description: This is the work I did toward fixing bpo-32243 (and might be better broken into separate PRs--we'll see). This updates @vstinner's patch from bpo-23428, and on top of it adds a fix ...

Opengraph URL: https://github.com/python/cpython/pull/4964

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f348f873-c437-27da-7769-45c99639fc68
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA9E:9775E:C05A36:104D31D:6A4ED703
html-safe-nonce9bd117ad42289a006f21c3b48b93d7662e3c64aa9ab6b59cb770d37115589348
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTlFOjk3NzVFOkMwNUEzNjoxMDREMzFEOjZBNEVENzAzIiwidmlzaXRvcl9pZCI6Ijk5ODc0MzgxMTIzNTQzNjI5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaad4547d9ba01981495b481fdac3678c1f38516e3622d6dedb2bdd2fada81e20
hovercard-subject-tagpull_request:159706940
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/4964/files
twitter:imagehttps://avatars.githubusercontent.com/u/676149?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/676149?s=400&v=4
og:image:altThis is the work I did toward fixing bpo-32243 (and might be better broken into separate PRs--we'll see). This updates @vstinner's patch from bpo-23428, and on top of it adds a fix to PyCON...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec37fe3e3f5f306900bd5b6bee97463f66c938b2c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/4964/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4964%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4964%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4964/files
Reloadhttps://github.com/python/cpython/pull/4964/files
Reloadhttps://github.com/python/cpython/pull/4964/files
Please reload this pagehttps://github.com/python/cpython/pull/4964/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/4964/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
embrayhttps://github.com/embray
python:masterhttps://github.com/python/cpython/tree/master
embray:thread-timehttps://github.com/embray/cpython/tree/thread-time
Conversation 10 https://github.com/python/cpython/pull/4964
Commits 4 https://github.com/python/cpython/pull/4964/commits
Checks 0 https://github.com/python/cpython/pull/4964/checks
Files changed https://github.com/python/cpython/pull/4964/files
Please reload this pagehttps://github.com/python/cpython/pull/4964/files
bpo-32243: Use monotonic clock for thread timeouts; more flexibility for very small switch intervals https://github.com/python/cpython/pull/4964/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/4964/files
3497cc8 Attempt at adapting Victor's patch from https://bugs.python.org/issue… embray Dec 7, 2017 https://github.com/python/cpython/pull/4964/commits/3497cc848ee1cb995f048e9f8b69071d6cfb459a
523e89d In PyCOND_TIMEDWAIT dynamically increase the timeout from the request… embray Dec 21, 2017 https://github.com/python/cpython/pull/4964/commits/523e89d1c29ba6c807270be42270031312c22472
4432ff8 don't define MONOTONIC unless we have pthread_condattr_setclock embray Jan 31, 2019 https://github.com/python/cpython/pull/4964/commits/4432ff8b73adf49ead659132ea4179a1f9456158
5b248ad update configure embray Jan 31, 2019 https://github.com/python/cpython/pull/4964/commits/5b248ad7ef42c02c87899b8c3f6097498da1d667
Clear filters https://github.com/python/cpython/pull/4964/files
Please reload this pagehttps://github.com/python/cpython/pull/4964/files
Please reload this pagehttps://github.com/python/cpython/pull/4964/files
Makefile.pre.in https://github.com/python/cpython/pull/4964/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
condvar.h https://github.com/python/cpython/pull/4964/files#diff-a09448839fef4181d15ba8403e83749a359fc9ea5bd3e956fbb593514566a032
thread_pthread.h https://github.com/python/cpython/pull/4964/files#diff-6bd490c2d033ab2a6384697027bed62ac2aa77d7833a2fd822e5e7ab84aa861f
configure https://github.com/python/cpython/pull/4964/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
configure.ac https://github.com/python/cpython/pull/4964/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
Makefile.pre.inhttps://github.com/python/cpython/pull/4964/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
View file https://github.com/embray/cpython/blob/5b248ad7ef42c02c87899b8c3f6097498da1d667/Makefile.pre.in
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4964/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4964/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/4964/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/4964/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/4964/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
Python/condvar.hhttps://github.com/python/cpython/pull/4964/files#diff-a09448839fef4181d15ba8403e83749a359fc9ea5bd3e956fbb593514566a032
View file https://github.com/embray/cpython/blob/5b248ad7ef42c02c87899b8c3f6097498da1d667/Python/condvar.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4964/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4964/files#diff-a09448839fef4181d15ba8403e83749a359fc9ea5bd3e956fbb593514566a032
https://github.com/python/cpython/pull/4964/files#diff-a09448839fef4181d15ba8403e83749a359fc9ea5bd3e956fbb593514566a032
Python/thread_pthread.hhttps://github.com/python/cpython/pull/4964/files#diff-6bd490c2d033ab2a6384697027bed62ac2aa77d7833a2fd822e5e7ab84aa861f
View file https://github.com/embray/cpython/blob/5b248ad7ef42c02c87899b8c3f6097498da1d667/Python/thread_pthread.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4964/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4964/files#diff-6bd490c2d033ab2a6384697027bed62ac2aa77d7833a2fd822e5e7ab84aa861f
https://github.com/python/cpython/pull/4964/files#diff-6bd490c2d033ab2a6384697027bed62ac2aa77d7833a2fd822e5e7ab84aa861f
https://github.com/python/cpython/pull/4964/files#diff-6bd490c2d033ab2a6384697027bed62ac2aa77d7833a2fd822e5e7ab84aa861f
https://github.com/python/cpython/pull/4964/files#diff-6bd490c2d033ab2a6384697027bed62ac2aa77d7833a2fd822e5e7ab84aa861f
https://github.com/python/cpython/pull/4964/files#diff-6bd490c2d033ab2a6384697027bed62ac2aa77d7833a2fd822e5e7ab84aa861f
https://github.com/python/cpython/pull/4964/files#diff-6bd490c2d033ab2a6384697027bed62ac2aa77d7833a2fd822e5e7ab84aa861f
configurehttps://github.com/python/cpython/pull/4964/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
View file https://github.com/embray/cpython/blob/5b248ad7ef42c02c87899b8c3f6097498da1d667/configure
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4964/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4964/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
https://github.com/python/cpython/pull/4964/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
configure.achttps://github.com/python/cpython/pull/4964/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
View file https://github.com/embray/cpython/blob/5b248ad7ef42c02c87899b8c3f6097498da1d667/configure.ac
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4964/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4964/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
https://github.com/python/cpython/pull/4964/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.