René's URL Explorer Experiment


Title: bpo-29970: Make ssh_handshake_timeout None by default by asvetlov · Pull Request #4939 · python/cpython · GitHub

Open Graph Title: bpo-29970: Make ssh_handshake_timeout None by default by asvetlov · Pull Request #4939 · python/cpython

X Title: bpo-29970: Make ssh_handshake_timeout None by default by asvetlov · Pull Request #4939 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Float default prevents checking for passing ssh_handshake_timeout with plain socket connection. Raise ValueError if ssh_handshake_timeout is specified without ssl. Postfix for #4825 https://bugs.p...

X Description: Float default prevents checking for passing ssh_handshake_timeout with plain socket connection. Raise ValueError if ssh_handshake_timeout is specified without ssl. Postfix for #4825 https://bugs.p...

Opengraph URL: https://github.com/python/cpython/pull/4939

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3afa4eaa-c41e-44b5-4182-778f172f0826
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC152:5D9CC:232CBBD:2F4FD2A:6A599B51
html-safe-nonce6702c4a1f3ec4013bf56e3478e0f90dcb41d7678ef25af67c27913a90abba569
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTUyOjVEOUNDOjIzMkNCQkQ6MkY0RkQyQTo2QTU5OUI1MSIsInZpc2l0b3JfaWQiOiI1MTY5NTk0MTg1MDg2NDQ2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc032ad330c16a26b41a27a08ea3688c8d7fa328e045fd0cd6d17e144ab901b9c
hovercard-subject-tagpull_request:159382703
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/4939/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/def4901260408a7224192a4bcebf7e6cc78309c1dc4ce6cdb590961b79088ce7/python/cpython/pull/4939
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/def4901260408a7224192a4bcebf7e6cc78309c1dc4ce6cdb590961b79088ce7/python/cpython/pull/4939
og:image:altFloat default prevents checking for passing ssh_handshake_timeout with plain socket connection. Raise ValueError if ssh_handshake_timeout is specified without ssl. Postfix for #4825 https://bugs.p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameasvetlov
hostnamegithub.com
expected-hostnamegithub.com
Nonea540949572872b935b393b36db38922db390ae71c859537d741b8f3eb7e545b5
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release737e0bf019c29d8431b268ae84d528b052789210
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/4939#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4939
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4939
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4939
Reloadhttps://github.com/python/cpython/pull/4939
Reloadhttps://github.com/python/cpython/pull/4939
Please reload this pagehttps://github.com/python/cpython/pull/4939
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/4939
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
asvetlovhttps://github.com/asvetlov
python:masterhttps://github.com/python/cpython/tree/master
asvetlov:ssl_handshake_timeouthttps://github.com/asvetlov/cpython/tree/ssl_handshake_timeout
Conversationhttps://github.com/python/cpython/pull/4939
Commits7 (7)https://github.com/python/cpython/pull/4939/commits
Checkshttps://github.com/python/cpython/pull/4939/checks
Files changedhttps://github.com/python/cpython/pull/4939/files
bpo-29970: Make ssh_handshake_timeout None by defaulthttps://github.com/python/cpython/pull/4939#top
asvetlovhttps://github.com/asvetlov
python:masterhttps://github.com/python/cpython/tree/master
asvetlov:ssl_handshake_timeouthttps://github.com/asvetlov/cpython/tree/ssl_handshake_timeout
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
Dec 20, 2017https://github.com/python/cpython/pull/4939#issue-283518724
Please reload this pagehttps://github.com/python/cpython/pull/4939
#4825https://github.com/python/cpython/pull/4825
https://bugs.python.org/issue29970https://bugs.python.org/issue29970
Please reload this pagehttps://github.com/python/cpython/pull/4939
https://github.com/asvetlov
Make ssh_handshake_timeout None by default.https://github.com/python/cpython/pull/4939/commits/a4b641caa1d2347610992ea4096a0bc53b891e5a
a4b641chttps://github.com/python/cpython/pull/4939/commits/a4b641caa1d2347610992ea4096a0bc53b891e5a
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
1st1https://github.com/1st1
code ownerhttps://github.com/python/cpython/blob/776407fe893fd42972c7e3f71423d9d86741d07c/.github/CODEOWNERS#L8
December 20, 2017 10:36https://github.com/python/cpython/pull/4939#event-1395836423
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Dec 20, 2017https://github.com/python/cpython/pull/4939#event-1395836451
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Dec 20, 2017https://github.com/python/cpython/pull/4939#event-1395836454
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
Dec 20, 2017https://github.com/python/cpython/pull/4939#event-1395837412
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
Dec 20, 2017https://github.com/python/cpython/pull/4939#event-1395838489
https://github.com/asvetlov
Add testshttps://github.com/python/cpython/pull/4939/commits/2bf980089d5189a2d71cb598aa01c27893a20bc4
2bf9800https://github.com/python/cpython/pull/4939/commits/2bf980089d5189a2d71cb598aa01c27893a20bc4
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
Dec 20, 2017https://github.com/python/cpython/pull/4939#event-1396081972
https://github.com/1st1
1st1https://github.com/1st1
Dec 20, 2017 https://github.com/python/cpython/pull/4939#pullrequestreview-84813979
View reviewed changes https://github.com/python/cpython/pull/4939/files/2bf980089d5189a2d71cb598aa01c27893a20bc4
Lib/asyncio/base_events.pyhttps://github.com/python/cpython/pull/4939/files/2bf980089d5189a2d71cb598aa01c27893a20bc4#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
1st1https://github.com/1st1
Dec 20, 2017https://github.com/python/cpython/pull/4939#discussion_r158066228
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4939
asvetlovhttps://github.com/asvetlov
Dec 20, 2017https://github.com/python/cpython/pull/4939#discussion_r158068366
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4939
https://github.com/1st1
1st1https://github.com/1st1
Dec 20, 2017https://github.com/python/cpython/pull/4939#issuecomment-353107201
Please reload this pagehttps://github.com/python/cpython/pull/4939
https://github.com/asvetlov
Fix typohttps://github.com/python/cpython/pull/4939/commits/b6b28f88bd3da6630de8db12343fa3ae0e5aa923
b6b28f8https://github.com/python/cpython/pull/4939/commits/b6b28f88bd3da6630de8db12343fa3ae0e5aa923
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
Dec 20, 2017https://github.com/python/cpython/pull/4939#issuecomment-353109831
Please reload this pagehttps://github.com/python/cpython/pull/4939
https://github.com/1st1
1st1https://github.com/1st1
Dec 20, 2017https://github.com/python/cpython/pull/4939#issuecomment-353110221
Please reload this pagehttps://github.com/python/cpython/pull/4939
https://github.com/1st1
1st1https://github.com/1st1
Dec 20, 2017https://github.com/python/cpython/pull/4939#issuecomment-353111872
Please reload this pagehttps://github.com/python/cpython/pull/4939
Please reload this pagehttps://github.com/python/cpython/pull/4939
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
Dec 20, 2017https://github.com/python/cpython/pull/4939#issuecomment-353112029
Please reload this pagehttps://github.com/python/cpython/pull/4939
https://github.com/asvetlov
Raise ValueError if ssl_handshake_timeout<=0https://github.com/python/cpython/pull/4939/commits/099cf5f796cfa9f03471080ee383d383bd4608a0
099cf5fhttps://github.com/python/cpython/pull/4939/commits/099cf5f796cfa9f03471080ee383d383bd4608a0
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
Dec 20, 2017https://github.com/python/cpython/pull/4939#issuecomment-353121536
Please reload this pagehttps://github.com/python/cpython/pull/4939
https://github.com/1st1
1st1https://github.com/1st1
Dec 20, 2017 https://github.com/python/cpython/pull/4939#pullrequestreview-84833400
View reviewed changes https://github.com/python/cpython/pull/4939/files/099cf5f796cfa9f03471080ee383d383bd4608a0
https://github.com/1st1
1st1https://github.com/1st1
Dec 20, 2017 https://github.com/python/cpython/pull/4939#pullrequestreview-84833616
View reviewed changes https://github.com/python/cpython/pull/4939/files/099cf5f796cfa9f03471080ee383d383bd4608a0
Lib/test/test_asyncio/test_sslproto.pyhttps://github.com/python/cpython/pull/4939/files/099cf5f796cfa9f03471080ee383d383bd4608a0#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
1st1https://github.com/1st1
Dec 20, 2017https://github.com/python/cpython/pull/4939#discussion_r158082185
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4939
https://github.com/1st1
1st1https://github.com/1st1
Dec 20, 2017https://github.com/python/cpython/pull/4939#issuecomment-353124087
Please reload this pagehttps://github.com/python/cpython/pull/4939
asvetlovhttps://github.com/asvetlov
December 20, 2017 19:19https://github.com/python/cpython/pull/4939#commits-pushed-2f76ef9
https://github.com/asvetlov
Merge branch 'master' into ssl_handshake_timeouthttps://github.com/python/cpython/pull/4939/commits/2f76ef9e15b537607f822ccb7aa085e06b717a92
2f76ef9https://github.com/python/cpython/pull/4939/commits/2f76ef9e15b537607f822ccb7aa085e06b717a92
https://github.com/asvetlov
Fix resource warninghttps://github.com/python/cpython/pull/4939/commits/67a2b9f002a55975afac69d0d6ce84a3926e39ec
67a2b9fhttps://github.com/python/cpython/pull/4939/commits/67a2b9f002a55975afac69d0d6ce84a3926e39ec
https://github.com/asvetlov
assertRaises -> asserRaisesRegexhttps://github.com/python/cpython/pull/4939/commits/81daa605a89c2542268d005948c0f3322bfe2832
81daa60https://github.com/python/cpython/pull/4939/commits/81daa605a89c2542268d005948c0f3322bfe2832
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
51eb1c6https://github.com/python/cpython/commit/51eb1c6b9c0b382dfd6e0428eacff0c7891a6fc3
Dec 20, 2017https://github.com/python/cpython/pull/4939#event-1396643267
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Dec 20, 2017https://github.com/python/cpython/pull/4939#event-1396643314
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
December 20, 2017 18:24https://github.com/python/cpython/pull/4939#event-1396643364
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4939
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/python/cpython/pull/4939/files/099cf5f796cfa9f03471080ee383d383bd4608a0
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/4939
https://github.com/asvetlov
https://github.com/1st1
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.