| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:38cf11b2-01a4-f31c-1447-e06caa95c628 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9488:134698:42BA44:5A4C07:6A51E245 |
| html-safe-nonce | 6e59c6ebfd9e72765ab9f4f42d819ec2a103a7ca1953cfe993a481cf32aaf663 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDg4OjEzNDY5ODo0MkJBNDQ6NUE0QzA3OjZBNTFFMjQ1IiwidmlzaXRvcl9pZCI6Ijc3ODM0NTk5Mzg4NDQ2NjQzODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2d78799a00a00a988361fba8b905af64be32dde121c4d7ce022c7d7e4daaf882 |
| hovercard-subject-tag | pull_request:158517642 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/4877/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/52cd08f5cc913cc0de41362e3dd4646787fb5c33b877e2405ab328ad149d0242/python/cpython/pull/4877 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/52cd08f5cc913cc0de41362e3dd4646787fb5c33b877e2405ab328ad149d0242/python/cpython/pull/4877 |
| og:image:alt | https://bugs.python.org/issue32331 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | 1st1 |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/4877#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4877 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4877 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/4877 |
| Reload | https://github.com/python/cpython/pull/4877 |
| Reload | https://github.com/python/cpython/pull/4877 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.7k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| 1st1 | https://github.com/1st1 |
| python:master | https://github.com/python/cpython/tree/master |
| 1st1:fix_sock_type | https://github.com/1st1/cpython/tree/fix_sock_type |
| Conversation | https://github.com/python/cpython/pull/4877 |
| Commits8 (8) | https://github.com/python/cpython/pull/4877/commits |
| Checks | https://github.com/python/cpython/pull/4877/checks |
| Files changed | https://github.com/python/cpython/pull/4877/files |
| bpo-32331: Fix socket.type on Linux; expose SOCK_TYPE_MASK. | https://github.com/python/cpython/pull/4877#top |
| 1st1 | https://github.com/1st1 |
| python:master | https://github.com/python/cpython/tree/master |
| 1st1:fix_sock_type | https://github.com/1st1/cpython/tree/fix_sock_type |
|
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#issue-282311739 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://bugs.python.org/issue32331 | https://bugs.python.org/issue32331 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| asvetlov | https://github.com/asvetlov |
| methane | https://github.com/methane |
| pitrou | https://github.com/pitrou |
| vstinner | https://github.com/vstinner |
| December 15, 2017 03:45 | https://github.com/python/cpython/pull/4877#event-1388941954 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#event-1388941971 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#event-1388941988 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| force-pushed | https://github.com/python/cpython/compare/267a57dda323b0b63682dfacb519c787d7c5803e..72e278654d4b0dcd005c967dde8c5734f6ed6f01 |
| 267a57d | https://github.com/python/cpython/commit/267a57dda323b0b63682dfacb519c787d7c5803e |
| 72e2786 | https://github.com/python/cpython/commit/72e278654d4b0dcd005c967dde8c5734f6ed6f01 |
|
Compare
| https://github.com/python/cpython/compare/267a57dda323b0b63682dfacb519c787d7c5803e..72e278654d4b0dcd005c967dde8c5734f6ed6f01 |
| December 15, 2017 03:47 | https://github.com/python/cpython/pull/4877#event-1388943510 |
| https://github.com/asvetlov |
| asvetlov | https://github.com/asvetlov |
|
Dec 15, 2017
| https://github.com/python/cpython/pull/4877#pullrequestreview-83721944 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4877/files |
| Doc/library/socket.rst | https://github.com/python/cpython/pull/4877/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943 |
| asvetlov | https://github.com/asvetlov |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157128731 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| 1st1 | https://github.com/1st1 |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157129090 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| 1st1 | https://github.com/1st1 |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157129154 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| asvetlov | https://github.com/asvetlov |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157132330 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/asvetlov |
| asvetlov | https://github.com/asvetlov |
|
Dec 15, 2017
| https://github.com/python/cpython/pull/4877#pullrequestreview-83722091 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4877/files |
| asvetlov | https://github.com/asvetlov |
| https://github.com/python/cpython/pull/4877#pullrequestreview-83722091 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/methane |
| methane | https://github.com/methane |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-351964525 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/asvetlov |
| asvetlov | https://github.com/asvetlov |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-351965157 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Dec 15, 2017
| https://github.com/python/cpython/pull/4877#pullrequestreview-83765951 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4877/files |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/4877#pullrequestreview-83765951 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @pitrou | https://github.com/pitrou |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-351968158 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#event-1389335502 |
| https://github.com/pitrou |
| pitrou | https://github.com/pitrou |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-351969564 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-352017528 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Dec 15, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-352051421 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| force-pushed | https://github.com/python/cpython/compare/72e278654d4b0dcd005c967dde8c5734f6ed6f01..90bbae16bc1b3af1703294c999b89904faf20ecf |
| 72e2786 | https://github.com/python/cpython/commit/72e278654d4b0dcd005c967dde8c5734f6ed6f01 |
| 90bbae1 | https://github.com/python/cpython/commit/90bbae16bc1b3af1703294c999b89904faf20ecf |
|
Compare
| https://github.com/python/cpython/compare/72e278654d4b0dcd005c967dde8c5734f6ed6f01..90bbae16bc1b3af1703294c999b89904faf20ecf |
| December 16, 2017 00:04 | https://github.com/python/cpython/pull/4877#event-1390522246 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Dec 16, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-352141969 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Dec 16, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-352145678 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| force-pushed | https://github.com/python/cpython/compare/90bbae16bc1b3af1703294c999b89904faf20ecf..95bd98dbc45f0ec14f5d7ceef489644fbe962bfe |
| 90bbae1 | https://github.com/python/cpython/commit/90bbae16bc1b3af1703294c999b89904faf20ecf |
| 95bd98d | https://github.com/python/cpython/commit/95bd98dbc45f0ec14f5d7ceef489644fbe962bfe |
|
Compare
| https://github.com/python/cpython/compare/90bbae16bc1b3af1703294c999b89904faf20ecf..95bd98dbc45f0ec14f5d7ceef489644fbe962bfe |
| December 16, 2017 05:07 | https://github.com/python/cpython/pull/4877#event-1390629479 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Dec 16, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-352161766 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/njsmith |
| njsmith | https://github.com/njsmith |
| Dec 16, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-352162874 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/njsmith |
| njsmith | https://github.com/njsmith |
| Dec 16, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-352162899 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| force-pushed | https://github.com/python/cpython/compare/4b11ac4edfc5eb5d51feaec8aac2f8f00dd3381b..c1806d6fb460ade6f537619cf5a5558bd011f3f8 |
| 4b11ac4 | https://github.com/python/cpython/commit/4b11ac4edfc5eb5d51feaec8aac2f8f00dd3381b |
| c1806d6 | https://github.com/python/cpython/commit/c1806d6fb460ade6f537619cf5a5558bd011f3f8 |
|
Compare
| https://github.com/python/cpython/compare/4b11ac4edfc5eb5d51feaec8aac2f8f00dd3381b..c1806d6fb460ade6f537619cf5a5558bd011f3f8 |
| December 16, 2017 05:46 | https://github.com/python/cpython/pull/4877#event-1390636640 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Dec 16, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-352163191 |
| https://bugs.python.org/issue32318 | https://bugs.python.org/issue32318 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| bpo-32331: Don't obstruct socket.type with SOCK_NONBLOCK and SOCK_CLO… | https://github.com/python/cpython/pull/4877/commits/3d9ca1f73c03d09bd293d5dfe8a5c960c44e8967 |
| 3d9ca1f | https://github.com/python/cpython/pull/4877/commits/3d9ca1f73c03d09bd293d5dfe8a5c960c44e8967 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| force-pushed | https://github.com/python/cpython/compare/c1806d6fb460ade6f537619cf5a5558bd011f3f8..3d9ca1f73c03d09bd293d5dfe8a5c960c44e8967 |
| c1806d6 | https://github.com/python/cpython/commit/c1806d6fb460ade6f537619cf5a5558bd011f3f8 |
| 3d9ca1f | https://github.com/python/cpython/commit/3d9ca1f73c03d09bd293d5dfe8a5c960c44e8967 |
|
Compare
| https://github.com/python/cpython/compare/c1806d6fb460ade6f537619cf5a5558bd011f3f8..3d9ca1f73c03d09bd293d5dfe8a5c960c44e8967 |
| December 16, 2017 05:51 | https://github.com/python/cpython/pull/4877#event-1390637462 |
| https://github.com/vadmium |
| vadmium | https://github.com/vadmium |
|
Dec 17, 2017
| https://github.com/python/cpython/pull/4877#pullrequestreview-84012357 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4877/files/3d9ca1f73c03d09bd293d5dfe8a5c960c44e8967 |
| Doc/library/socket.rst | https://github.com/python/cpython/pull/4877/files/3d9ca1f73c03d09bd293d5dfe8a5c960c44e8967#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943 |
| vadmium | https://github.com/vadmium |
| Dec 17, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157380975 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| 1st1 | https://github.com/1st1 |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157558617 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| Add a comment; fix docs | https://github.com/python/cpython/pull/4877/commits/dae478425fde4977bab1258629d86424ac9f261a |
| dae4784 | https://github.com/python/cpython/pull/4877/commits/dae478425fde4977bab1258629d86424ac9f261a |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Dec 18, 2017
| https://github.com/python/cpython/pull/4877#pullrequestreview-84286288 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4877/files/dae478425fde4977bab1258629d86424ac9f261a |
| Modules/socketmodule.c | https://github.com/python/cpython/pull/4877/files/dae478425fde4977bab1258629d86424ac9f261a#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29 |
| vstinner | https://github.com/vstinner |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157614389 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| 1st1 | https://github.com/1st1 |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157615435 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| vstinner | https://github.com/vstinner |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157616270 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| vstinner | https://github.com/vstinner |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157616491 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| 1st1 | https://github.com/1st1 |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157616612 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| 1st1 | https://github.com/1st1 |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157617533 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| vstinner | https://github.com/vstinner |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157618930 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| bpo-32331 | https://bugs.python.org/issue?@action=redirect&bpo=32331 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Dec 18, 2017
| https://github.com/python/cpython/pull/4877#pullrequestreview-84286421 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4877/files/dae478425fde4977bab1258629d86424ac9f261a |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/4877#pullrequestreview-84286421 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://docs.python.org/dev/whatsnew/3.7.html#changes-in-the-python-api | https://docs.python.org/dev/whatsnew/3.7.html#changes-in-the-python-api |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| Address Victor's feedback | https://github.com/python/cpython/pull/4877/commits/ed40d775436b276c67ac4b1c82ae2859f329def1 |
| ed40d77 | https://github.com/python/cpython/pull/4877/commits/ed40d775436b276c67ac4b1c82ae2859f329def1 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-352577828 |
| @vstinner | https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| December 18, 2017 17:27 | https://github.com/python/cpython/pull/4877#commits-pushed-ee6a024 |
| Another small update of what's new | https://github.com/python/cpython/pull/4877/commits/ee6a0240d27cb129563e7e5a419803d83727937a |
| ee6a024 | https://github.com/python/cpython/pull/4877/commits/ee6a0240d27cb129563e7e5a419803d83727937a |
| Don't use ifdef __linux__; reset SOCK_* flags explicitly | https://github.com/python/cpython/pull/4877/commits/8e5bd2b16519c9e1b3db35b31be5c6e3fa030946 |
| 8e5bd2b | https://github.com/python/cpython/pull/4877/commits/8e5bd2b16519c9e1b3db35b31be5c6e3fa030946 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Dec 18, 2017
| https://github.com/python/cpython/pull/4877#pullrequestreview-84293588 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4877/files/ee6a0240d27cb129563e7e5a419803d83727937a |
| Modules/socketmodule.c | https://github.com/python/cpython/pull/4877/files/ee6a0240d27cb129563e7e5a419803d83727937a#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29 |
| vstinner | https://github.com/vstinner |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157620793 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| 1st1 | https://github.com/1st1 |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157620913 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-352582484 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-352583463 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Dec 18, 2017
| https://github.com/python/cpython/pull/4877#pullrequestreview-84307529 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4877/files/8e5bd2b16519c9e1b3db35b31be5c6e3fa030946 |
| Doc/library/socket.rst | https://github.com/python/cpython/pull/4877/files/8e5bd2b16519c9e1b3db35b31be5c6e3fa030946#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943 |
| vstinner | https://github.com/vstinner |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157632868 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| Doc/library/socket.rst | https://github.com/python/cpython/pull/4877/files/8e5bd2b16519c9e1b3db35b31be5c6e3fa030946#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943 |
| vstinner | https://github.com/vstinner |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157632931 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| Doc/library/socket.rst | https://github.com/python/cpython/pull/4877/files/8e5bd2b16519c9e1b3db35b31be5c6e3fa030946#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943 |
| vstinner | https://github.com/vstinner |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157632986 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| Doc/whatsnew/3.7.rst | https://github.com/python/cpython/pull/4877/files/8e5bd2b16519c9e1b3db35b31be5c6e3fa030946#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52 |
| vstinner | https://github.com/vstinner |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157633076 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| Misc/NEWS.d/next/Library/2017-12-15-23-48-43.bpo-32331.fIg1Uc.rst | https://github.com/python/cpython/pull/4877/files/8e5bd2b16519c9e1b3db35b31be5c6e3fa030946#diff-ca3d6fea49df819b906961dfb67b857e87694ca75d8e97e0799a1b5c483de2c0 |
| vstinner | https://github.com/vstinner |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157633302 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| Modules/socketmodule.c | https://github.com/python/cpython/pull/4877/files/8e5bd2b16519c9e1b3db35b31be5c6e3fa030946#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29 |
| vstinner | https://github.com/vstinner |
| Dec 18, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157633379 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| More fixes per Victor's review. | https://github.com/python/cpython/pull/4877/commits/7e9eb5339be196366ffe45f6ec1d8ea4239dfc6e |
| 7e9eb53 | https://github.com/python/cpython/pull/4877/commits/7e9eb5339be196366ffe45f6ec1d8ea4239dfc6e |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Dec 19, 2017 | https://github.com/python/cpython/pull/4877#issuecomment-352597770 |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| @vstinner | https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Dec 19, 2017
| https://github.com/python/cpython/pull/4877#pullrequestreview-84310472 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4877/files/7e9eb5339be196366ffe45f6ec1d8ea4239dfc6e |
| Lib/socket.py | https://github.com/python/cpython/pull/4877/files/7e9eb5339be196366ffe45f6ec1d8ea4239dfc6e#diff-081d33d48e9390350bb1ef860c52de799d1647b58e33b07173ae2549532cbfbe |
| vstinner | https://github.com/vstinner |
| Dec 19, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157635486 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| 1st1 | https://github.com/1st1 |
| Dec 19, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157635828 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| vstinner | https://github.com/vstinner |
| Dec 19, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157636266 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| 1st1 | https://github.com/1st1 |
| Dec 19, 2017 | https://github.com/python/cpython/pull/4877#discussion_r157636385 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| Don't cleanup SocketKind; we'll do it in a separate PR | https://github.com/python/cpython/pull/4877/commits/7b628035b8778b3f5e8edbdd7fac4d719b24396e |
| 7b62803 | https://github.com/python/cpython/pull/4877/commits/7b628035b8778b3f5e8edbdd7fac4d719b24396e |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| force-pushed | https://github.com/python/cpython/compare/cdbc60a03bb50878d2e959a115e066dd92b89e1b..7b628035b8778b3f5e8edbdd7fac4d719b24396e |
| cdbc60a | https://github.com/python/cpython/commit/cdbc60a03bb50878d2e959a115e066dd92b89e1b |
| 7b62803 | https://github.com/python/cpython/commit/7b628035b8778b3f5e8edbdd7fac4d719b24396e |
|
Compare
| https://github.com/python/cpython/compare/cdbc60a03bb50878d2e959a115e066dd92b89e1b..7b628035b8778b3f5e8edbdd7fac4d719b24396e |
| December 19, 2017 00:22 | https://github.com/python/cpython/pull/4877#event-1393208892 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Dec 19, 2017
| https://github.com/python/cpython/pull/4877#pullrequestreview-84311882 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4877/files/7b628035b8778b3f5e8edbdd7fac4d719b24396e |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/4877#pullrequestreview-84311882 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Dec 19, 2017 | https://github.com/python/cpython/pull/4877#event-1393210158 |
| Fix test_uknown_socket_family_repr test | https://github.com/python/cpython/pull/4877/commits/ad998e428d5ee1cca94b95fe447d5456a30ed1d0 |
| ad998e4 | https://github.com/python/cpython/pull/4877/commits/ad998e428d5ee1cca94b95fe447d5456a30ed1d0 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| 9818142 | https://github.com/python/cpython/commit/9818142b1bd20243733a953fb8aa2c7be314c47c |
| Dec 19, 2017 | https://github.com/python/cpython/pull/4877#event-1393246577 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Dec 19, 2017 | https://github.com/python/cpython/pull/4877#event-1393246591 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| December 19, 2017 01:02 | https://github.com/python/cpython/pull/4877#event-1393246618 |
| https://github.com/snemes |
| snemes | https://github.com/snemes |
|
Aug 5, 2019
| https://github.com/python/cpython/pull/4877#ref-pullrequest-477039979 |
|
Workaround for a bug in Python 3.5 and 3.6 affecting UDP proxying
Anorov/PySocks#128
| https://github.com/Anorov/PySocks/pull/128 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4877 |
|
| https://github.com/asvetlov |
|
asvetlov
| https://github.com/asvetlov |
|
| https://github.com/python/cpython/pull/4877/files/72e278654d4b0dcd005c967dde8c5734f6ed6f01 |
|
| https://github.com/vadmium |
|
vadmium
| https://github.com/vadmium |
|
| https://github.com/python/cpython/pull/4877/files/3d9ca1f73c03d09bd293d5dfe8a5c960c44e8967 |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
| https://github.com/python/cpython/pull/4877/files/7b628035b8778b3f5e8edbdd7fac4d719b24396e |
|
| https://github.com/methane |
|
methane
| https://github.com/methane |
|
| https://github.com/pitrou |
|
pitrou
| https://github.com/pitrou |
| Please reload this page | https://github.com/python/cpython/pull/4877 |
|
| https://github.com/1st1 |
|
| https://github.com/methane |
|
| https://github.com/asvetlov |
|
| https://github.com/bedevere-bot |
|
| https://github.com/pitrou |
|
| https://github.com/vstinner |
|
| https://github.com/njsmith |
|
| https://github.com/vadmium |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |