René's URL Explorer Experiment


Title: bpo-17852: Fix PR #3372, flush BufferedWriter objects on exit. by nascheme · Pull Request #4847 · python/cpython · GitHub

Open Graph Title: bpo-17852: Fix PR #3372, flush BufferedWriter objects on exit. by nascheme · Pull Request #4847 · python/cpython

X Title: bpo-17852: Fix PR #3372, flush BufferedWriter objects on exit. by nascheme · Pull Request #4847 · python/cpython

Description: New version of PR #3372, which was reverted by 317def9. We can't use _Py_PyAtExit() as it only supports registering a single callback. It is used by the atexit module and so we can't use it. We can't use Py_AtExit() either because it calls functions too late in the interpreter shutdown process. Instead, create io._flush_all_buffers. In io.py, register it with the atexit module. https://bugs.python.org/issue17852

Open Graph Description: New version of PR #3372, which was reverted by 317def9. We can't use _Py_PyAtExit() as it only supports registering a single callback. It is used by the atexit module and so we can't use i...

X Description: New version of PR #3372, which was reverted by 317def9. We can't use _Py_PyAtExit() as it only supports registering a single callback. It is used by the atexit module and so we can&#39...

Opengraph URL: https://github.com/python/cpython/pull/4847

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d4ccaaa5-15ea-c270-158d-89c1486eb112
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3C8:275A80:604440:8298FD:6A4D4183
html-safe-nonceaf713b237d9b540164c2cfb5846285d01bbf66af1bd61fa0411ced0d6c6a9913
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0M4OjI3NUE4MDo2MDQ0NDA6ODI5OEZEOjZBNEQ0MTgzIiwidmlzaXRvcl9pZCI6IjczNTQxNzEzMTgwNTc0MDgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7002b5ff1a4b82bd1fb23b956ed5c6cbf21eb361c22afc023d24f19b52d0114d
hovercard-subject-tagpull_request:158181512
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/4847/files
twitter:imagehttps://avatars.githubusercontent.com/u/690853?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/690853?s=400&v=4
og:image:altNew version of PR #3372, which was reverted by 317def9. We can't use _Py_PyAtExit() as it only supports registering a single callback. It is used by the atexit module and so we can't use i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56fc8347865a14e2ec811533d68f929cf4e0ec19
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/4847/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4847%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4847%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4847/files
Reloadhttps://github.com/python/cpython/pull/4847/files
Reloadhttps://github.com/python/cpython/pull/4847/files
Please reload this pagehttps://github.com/python/cpython/pull/4847/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/4847/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
naschemehttps://github.com/nascheme
python:masterhttps://github.com/python/cpython/tree/master
nascheme:atexit_flush_buffers_fixhttps://github.com/nascheme/cpython/tree/atexit_flush_buffers_fix
Conversation 9 https://github.com/python/cpython/pull/4847
Commits 2 https://github.com/python/cpython/pull/4847/commits
Checks 0 https://github.com/python/cpython/pull/4847/checks
Files changed https://github.com/python/cpython/pull/4847/files
Please reload this pagehttps://github.com/python/cpython/pull/4847/files
bpo-17852: Fix PR #3372, flush BufferedWriter objects on exit. https://github.com/python/cpython/pull/4847/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/4847/files
23c8801 Fix PR #3372, flush BufferedWriter objects on exit. nascheme Dec 13, 2017 https://github.com/python/cpython/pull/4847/commits/23c8801c2fd059e0eefcbde6365a8d7439b15a59
a959aee Change bare try/except. nascheme Dec 14, 2017 https://github.com/python/cpython/pull/4847/commits/a959aee258bc46a4a5fe7215bdb6386a7204e6dd
Clear filters https://github.com/python/cpython/pull/4847/files
Please reload this pagehttps://github.com/python/cpython/pull/4847/files
Please reload this pagehttps://github.com/python/cpython/pull/4847/files
_pyio.py https://github.com/python/cpython/pull/4847/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
io.py https://github.com/python/cpython/pull/4847/files#diff-2828caacf5c85c7bd6023ea0e4a381cc5c65179a9822398534c5e9ad9ccbd90d
2017-12-13-00-00-37.bpo-17852.Q8BP8N.rst https://github.com/python/cpython/pull/4847/files#diff-09bea50f0f10abf7db516153c40a659e2ba0f0074c4bbf20d97230013cf7945d
_iomodule.c https://github.com/python/cpython/pull/4847/files#diff-0501b143a2f566e8a760abc20a88fd2533b1f230e5322831f400a0263b8c0253
_iomodule.h https://github.com/python/cpython/pull/4847/files#diff-5316ec91b4e6cbcf680b208755cf8e7efce11e2a6682efb569ade29d6465a55b
bufferedio.c https://github.com/python/cpython/pull/4847/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
_iomodule.c.h https://github.com/python/cpython/pull/4847/files#diff-47321bceea2a1cea184101fcb900d88e94ba2ce7a7116edf0cdd63c490be8519
Lib/_pyio.pyhttps://github.com/python/cpython/pull/4847/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
View file https://github.com/nascheme/cpython/blob/a959aee258bc46a4a5fe7215bdb6386a7204e6dd/Lib/_pyio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4847/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4847/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/4847/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/4847/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
Lib/io.pyhttps://github.com/python/cpython/pull/4847/files#diff-2828caacf5c85c7bd6023ea0e4a381cc5c65179a9822398534c5e9ad9ccbd90d
View file https://github.com/nascheme/cpython/blob/a959aee258bc46a4a5fe7215bdb6386a7204e6dd/Lib/io.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4847/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4847/files#diff-2828caacf5c85c7bd6023ea0e4a381cc5c65179a9822398534c5e9ad9ccbd90d
Misc/NEWS.d/next/Library/2017-12-13-00-00-37.bpo-17852.Q8BP8N.rsthttps://github.com/python/cpython/pull/4847/files#diff-09bea50f0f10abf7db516153c40a659e2ba0f0074c4bbf20d97230013cf7945d
View file https://github.com/nascheme/cpython/blob/a959aee258bc46a4a5fe7215bdb6386a7204e6dd/Misc/NEWS.d/next/Library/2017-12-13-00-00-37.bpo-17852.Q8BP8N.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4847/{{ revealButtonHref }}
Modules/_io/_iomodule.chttps://github.com/python/cpython/pull/4847/files#diff-0501b143a2f566e8a760abc20a88fd2533b1f230e5322831f400a0263b8c0253
View file https://github.com/nascheme/cpython/blob/a959aee258bc46a4a5fe7215bdb6386a7204e6dd/Modules/_io/_iomodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4847/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4847/files#diff-0501b143a2f566e8a760abc20a88fd2533b1f230e5322831f400a0263b8c0253
https://github.com/python/cpython/pull/4847/files#diff-0501b143a2f566e8a760abc20a88fd2533b1f230e5322831f400a0263b8c0253
https://github.com/python/cpython/pull/4847/files#diff-0501b143a2f566e8a760abc20a88fd2533b1f230e5322831f400a0263b8c0253
Modules/_io/_iomodule.hhttps://github.com/python/cpython/pull/4847/files#diff-5316ec91b4e6cbcf680b208755cf8e7efce11e2a6682efb569ade29d6465a55b
View file https://github.com/nascheme/cpython/blob/a959aee258bc46a4a5fe7215bdb6386a7204e6dd/Modules/_io/_iomodule.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4847/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4847/files#diff-5316ec91b4e6cbcf680b208755cf8e7efce11e2a6682efb569ade29d6465a55b
Modules/_io/bufferedio.chttps://github.com/python/cpython/pull/4847/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
View file https://github.com/nascheme/cpython/blob/a959aee258bc46a4a5fe7215bdb6386a7204e6dd/Modules/_io/bufferedio.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4847/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4847/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/4847/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/4847/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/4847/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/4847/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/4847/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/4847/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/4847/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
Modules/_io/clinic/_iomodule.c.hhttps://github.com/python/cpython/pull/4847/files#diff-47321bceea2a1cea184101fcb900d88e94ba2ce7a7116edf0cdd63c490be8519
View file https://github.com/nascheme/cpython/blob/a959aee258bc46a4a5fe7215bdb6386a7204e6dd/Modules/_io/clinic/_iomodule.c.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4847/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4847/files#diff-47321bceea2a1cea184101fcb900d88e94ba2ce7a7116edf0cdd63c490be8519
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.