René's URL Explorer Experiment


Title: bpo-32282: Remove incorrect gate for `VersionHelpers.h` in `socketmodule.c` on Windows by maxbelanger · Pull Request #4805 · python/cpython · GitHub

Open Graph Title: bpo-32282: Remove incorrect gate for `VersionHelpers.h` in `socketmodule.c` on Windows by maxbelanger · Pull Request #4805 · python/cpython

X Title: bpo-32282: Remove incorrect gate for `VersionHelpers.h` in `socketmodule.c` on Windows by maxbelanger · Pull Request #4805 · python/cpython

Description: _MSC_VER is insufficient to detect this header's presence, it's also important to ensure the XP-compatible toolset is not in use. https://bugs.python.org/issue32282

Open Graph Description: _MSC_VER is insufficient to detect this header's presence, it's also important to ensure the XP-compatible toolset is not in use. https://bugs.python.org/issue32282

X Description: _MSC_VER is insufficient to detect this header's presence, it's also important to ensure the XP-compatible toolset is not in use. https://bugs.python.org/issue32282

Opengraph URL: https://github.com/python/cpython/pull/4805

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5013b261-5ee4-b389-39d8-218ae8a3cd91
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C56:FB1CA:12F2ED1:1A4F20D:6A4DE6BC
html-safe-nonce425da8ca1aeb2079851a2fbf9bea3281d0c556ed3ce4a8fabc2e71009ca1dd56
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzU2OkZCMUNBOjEyRjJFRDE6MUE0RjIwRDo2QTRERTZCQyIsInZpc2l0b3JfaWQiOiIxNDYzMTM2MTQwNzk4MDYwMjIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca4a31e2d21105fb080e419d2503628abc68ba5770577230a89acccf2e6fcb003
hovercard-subject-tagpull_request:157704276
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/4805/files
twitter:imagehttps://avatars.githubusercontent.com/u/79831?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/79831?s=400&v=4
og:image:alt_MSC_VER is insufficient to detect this header's presence, it's also important to ensure the XP-compatible toolset is not in use. https://bugs.python.org/issue32282
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/4805/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4805%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4805%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4805/files
Reloadhttps://github.com/python/cpython/pull/4805/files
Reloadhttps://github.com/python/cpython/pull/4805/files
Please reload this pagehttps://github.com/python/cpython/pull/4805/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/4805/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zoobahttps://github.com/zooba
python:masterhttps://github.com/python/cpython/tree/master
maxbelanger:fix-xp-toolsethttps://github.com/maxbelanger/cpython/tree/fix-xp-toolset
Conversation 1 https://github.com/python/cpython/pull/4805
Commits 4 https://github.com/python/cpython/pull/4805/commits
Checks 0 https://github.com/python/cpython/pull/4805/checks
Files changed https://github.com/python/cpython/pull/4805/files
Please reload this pagehttps://github.com/python/cpython/pull/4805/files
bpo-32282: Remove incorrect gate for VersionHelpers.h in socketmodule.c on Windows https://github.com/python/cpython/pull/4805/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/4805/files
a5e2444 bpo-32282: Properly gate the include of `VersionHelpers.h` on Windows maxbelanger Dec 12, 2017 https://github.com/python/cpython/pull/4805/commits/a5e2444f0f4986ad0c88af66506c8843cd0aff80
c70f817 just remove incorrect ifdefs maxbelanger Dec 12, 2017 https://github.com/python/cpython/pull/4805/commits/c70f817ce52d647fb1191dfa873f116dcafd1f22
29a5e92 add blurb maxbelanger Dec 12, 2017 https://github.com/python/cpython/pull/4805/commits/29a5e92b8a6f071ace1b32a4b897ec908de8cf53
329d4a8 remove the else case maxbelanger Dec 12, 2017 https://github.com/python/cpython/pull/4805/commits/329d4a850c62546d53a0d354a3e9e673f02ee4ad
Clear filters https://github.com/python/cpython/pull/4805/files
Please reload this pagehttps://github.com/python/cpython/pull/4805/files
Please reload this pagehttps://github.com/python/cpython/pull/4805/files
2017-12-12-14-02-28.bpo-32282.xFVMTn.rst https://github.com/python/cpython/pull/4805/files#diff-abb6b77b4e894b4e944a870dc1689e624c753474c16a6267c7f5b6b34af72e3c
socketmodule.c https://github.com/python/cpython/pull/4805/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
Misc/NEWS.d/next/Core and Builtins/2017-12-12-14-02-28.bpo-32282.xFVMTn.rsthttps://github.com/python/cpython/pull/4805/files#diff-abb6b77b4e894b4e944a870dc1689e624c753474c16a6267c7f5b6b34af72e3c
View file https://github.com/maxbelanger/cpython/blob/329d4a850c62546d53a0d354a3e9e673f02ee4ad/Misc/NEWS.d/next/Core%20and%20Builtins/2017-12-12-14-02-28.bpo-32282.xFVMTn.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4805/{{ revealButtonHref }}
Modules/socketmodule.chttps://github.com/python/cpython/pull/4805/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
View file https://github.com/maxbelanger/cpython/blob/329d4a850c62546d53a0d354a3e9e673f02ee4ad/Modules/socketmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4805/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4805/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/4805/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/4805/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/4805/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.