René's URL Explorer Experiment


Title: bpo-30050: Allow disabling full buffer warnings in signal.set_wakeup_fd by njsmith · Pull Request #4792 · python/cpython · GitHub

Open Graph Title: bpo-30050: Allow disabling full buffer warnings in signal.set_wakeup_fd by njsmith · Pull Request #4792 · python/cpython

X Title: bpo-30050: Allow disabling full buffer warnings in signal.set_wakeup_fd by njsmith · Pull Request #4792 · python/cpython

Description: Previously, if the wakeup fd's buffer overflowed, Python would unconditionally print a warning on stderr. But for many of set_wakeup_fd's users (e.g. Twisted, Tornado, and Trio), this is incorrect: the way they use set_wakeup_fd, a full buffer is a totally normal and unexceptional condition. On the other hand, for asyncio and curio, a full buffer causes signals to be lost, so they really want to issue a warning (at the least!). This change lets the caller of set_wakeup_fd choose whether they would like this warning to be printed or not. https://bugs.python.org/issue30050

Open Graph Description: Previously, if the wakeup fd's buffer overflowed, Python would unconditionally print a warning on stderr. But for many of set_wakeup_fd's users (e.g. Twisted, Tornado, and Trio), this is in...

X Description: Previously, if the wakeup fd's buffer overflowed, Python would unconditionally print a warning on stderr. But for many of set_wakeup_fd's users (e.g. Twisted, Tornado, and Trio), th...

Opengraph URL: https://github.com/python/cpython/pull/4792

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c30eb31a-d863-bebf-2ecb-3bda186ac9d3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD20:77702:1C281:28A07:6A4DF840
html-safe-nonce9886abdcc380c7e8f092eaa39d461dedbcb739758f3f038e117cbfb90853a198
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDIwOjc3NzAyOjFDMjgxOjI4QTA3OjZBNERGODQwIiwidmlzaXRvcl9pZCI6Ijg1ODQ5ODg1NTIzOTUwOTQwODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacef46e3fa1ad28ce51ed8fe806ab9eb07c2e9539a8ef08c71fe875f0d85fdca66
hovercard-subject-tagpull_request:157496848
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/4792/files
twitter:imagehttps://avatars.githubusercontent.com/u/609896?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/609896?s=400&v=4
og:image:altPreviously, if the wakeup fd's buffer overflowed, Python would unconditionally print a warning on stderr. But for many of set_wakeup_fd's users (e.g. Twisted, Tornado, and Trio), this is in...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4314b1df11fa8a565684f3a72dc971e3785da365
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/4792/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4792%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4792%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4792/files
Reloadhttps://github.com/python/cpython/pull/4792/files
Reloadhttps://github.com/python/cpython/pull/4792/files
Please reload this pagehttps://github.com/python/cpython/pull/4792/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/4792/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
1st1https://github.com/1st1
python:masterhttps://github.com/python/cpython/tree/master
njsmith:bpo-30050https://github.com/njsmith/cpython/tree/bpo-30050
Conversation 28 https://github.com/python/cpython/pull/4792
Commits 9 https://github.com/python/cpython/pull/4792/commits
Checks 0 https://github.com/python/cpython/pull/4792/checks
Files changed https://github.com/python/cpython/pull/4792/files
Please reload this pagehttps://github.com/python/cpython/pull/4792/files
bpo-30050: Allow disabling full buffer warnings in signal.set_wakeup_fd https://github.com/python/cpython/pull/4792/files#top
Show all changes 9 commits https://github.com/python/cpython/pull/4792/files
4e6297b signalmodule.c refactor: share more code between Windows and POSIX njsmith Dec 11, 2017 https://github.com/python/cpython/pull/4792/commits/4e6297b6dad5507ea61aa14b38b7a6e6233197a2
f7cdf02 refactor: remove redundant variable assignment njsmith Dec 11, 2017 https://github.com/python/cpython/pull/4792/commits/f7cdf022d783829c52535c961b8f88759ccd62b9
d12750c signalmodule.c refactor: Windows send() does not set errno njsmith Dec 11, 2017 https://github.com/python/cpython/pull/4792/commits/d12750cbccf054d6619300522b6b7f8500b2cc27
3a9ebe3 signalmodule.c: Add warn_on_full_buffer support njsmith Dec 11, 2017 https://github.com/python/cpython/pull/4792/commits/3a9ebe371540798703e4b15beb64a25523562314
73a5391 Add test for set_wakeup_fd(..., warn_on_full_buffer=True/False) njsmith Dec 11, 2017 https://github.com/python/cpython/pull/4792/commits/73a5391927883f79f04dfdde4e4e55031403ac13
1eca2f3 Document set_wakeup_fd(..., warn_on_full_buffer=True/False) njsmith Dec 11, 2017 https://github.com/python/cpython/pull/4792/commits/1eca2f30e0d739ca026898df987b299a8f6d45eb
3c2cd18 Address @vstinner's review comments njsmith Dec 11, 2017 https://github.com/python/cpython/pull/4792/commits/3c2cd186ae7a2841966fa690ea970d9463e094ce
f8ac672 Fix windows build njsmith Dec 12, 2017 https://github.com/python/cpython/pull/4792/commits/f8ac672c8463cfb5de62f9a3b91ea0943c72b1ac
99b34ee Address @vstinner's second round of review comments njsmith Dec 12, 2017 https://github.com/python/cpython/pull/4792/commits/99b34ee359d899aa9a7fd1d4ab18efd25b2d2bc2
Clear filters https://github.com/python/cpython/pull/4792/files
Please reload this pagehttps://github.com/python/cpython/pull/4792/files
Please reload this pagehttps://github.com/python/cpython/pull/4792/files
signal.rst https://github.com/python/cpython/pull/4792/files#diff-22a34e88338be85d7f5e32d552c734f247d9c5e26beb0815e805780e60d552df
test_signal.py https://github.com/python/cpython/pull/4792/files#diff-d2af8fb561277f84d7a1c0274aca37955e9f515d0d73be58933abe191df1cca9
2017-12-10-23-44-56.bpo-30050.4SZ3lY.rst https://github.com/python/cpython/pull/4792/files#diff-e1151ed532744101a1ff5fe4693ab15b88787c5bcd8ab2cffea44abbb26e43b7
signalmodule.c https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
Doc/library/signal.rsthttps://github.com/python/cpython/pull/4792/files#diff-22a34e88338be85d7f5e32d552c734f247d9c5e26beb0815e805780e60d552df
View file https://github.com/njsmith/cpython/blob/99b34ee359d899aa9a7fd1d4ab18efd25b2d2bc2/Doc/library/signal.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4792/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4792/files#diff-22a34e88338be85d7f5e32d552c734f247d9c5e26beb0815e805780e60d552df
https://github.com/python/cpython/pull/4792/files#diff-22a34e88338be85d7f5e32d552c734f247d9c5e26beb0815e805780e60d552df
https://github.com/python/cpython/pull/4792/files#diff-22a34e88338be85d7f5e32d552c734f247d9c5e26beb0815e805780e60d552df
Lib/test/test_signal.pyhttps://github.com/python/cpython/pull/4792/files#diff-d2af8fb561277f84d7a1c0274aca37955e9f515d0d73be58933abe191df1cca9
View file https://github.com/njsmith/cpython/blob/99b34ee359d899aa9a7fd1d4ab18efd25b2d2bc2/Lib/test/test_signal.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4792/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4792/files#diff-d2af8fb561277f84d7a1c0274aca37955e9f515d0d73be58933abe191df1cca9
https://github.com/python/cpython/pull/4792/files#diff-d2af8fb561277f84d7a1c0274aca37955e9f515d0d73be58933abe191df1cca9
https://github.com/python/cpython/pull/4792/files#diff-d2af8fb561277f84d7a1c0274aca37955e9f515d0d73be58933abe191df1cca9
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792/files#r156010397
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792/files
njsmithhttps://github.com/njsmith
Dec 11, 2017https://github.com/python/cpython/pull/4792/files#r156032342
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792/files
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792/files#r156050306
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792/files
https://github.com/python/cpython/pull/4792/files#diff-d2af8fb561277f84d7a1c0274aca37955e9f515d0d73be58933abe191df1cca9
Misc/NEWS.d/next/Library/2017-12-10-23-44-56.bpo-30050.4SZ3lY.rsthttps://github.com/python/cpython/pull/4792/files#diff-e1151ed532744101a1ff5fe4693ab15b88787c5bcd8ab2cffea44abbb26e43b7
View file https://github.com/njsmith/cpython/blob/99b34ee359d899aa9a7fd1d4ab18efd25b2d2bc2/Misc/NEWS.d/next/Library/2017-12-10-23-44-56.bpo-30050.4SZ3lY.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4792/{{ revealButtonHref }}
Modules/signalmodule.chttps://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
View file https://github.com/njsmith/cpython/blob/99b34ee359d899aa9a7fd1d4ab18efd25b2d2bc2/Modules/signalmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4792/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792/files#r156010504
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792/files
njsmithhttps://github.com/njsmith
Dec 11, 2017https://github.com/python/cpython/pull/4792/files#r156032744
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792/files
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/4792/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.