René's URL Explorer Experiment


Title: bpo-30050: Allow disabling full buffer warnings in signal.set_wakeup_fd by njsmith · Pull Request #4792 · python/cpython · GitHub

Open Graph Title: bpo-30050: Allow disabling full buffer warnings in signal.set_wakeup_fd by njsmith · Pull Request #4792 · python/cpython

X Title: bpo-30050: Allow disabling full buffer warnings in signal.set_wakeup_fd by njsmith · Pull Request #4792 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Previously, if the wakeup fd's buffer overflowed, Python would unconditionally print a warning on stderr. But for many of set_wakeup_fd's users (e.g. Twisted, Tornado, and Trio), this is in...

X Description: Previously, if the wakeup fd's buffer overflowed, Python would unconditionally print a warning on stderr. But for many of set_wakeup_fd's users (e.g. Twisted, Tornado, and Trio), th...

Opengraph URL: https://github.com/python/cpython/pull/4792

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0a7a6a31-b200-dcf0-c5c0-e1c69214832b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC768:3DD3FA:12A680F:199A187:6A4DE678
html-safe-nonceb38ac1769f4d4878830c88e9d0b0f5bd64cb09ec8030ba4c26ade2af976cab95
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzY4OjNERDNGQToxMkE2ODBGOjE5OUExODc6NkE0REU2NzgiLCJ2aXNpdG9yX2lkIjoiMzIyNTQzNzI2MzYxNDM3ODE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6adca79c3a8b6c0120d6a67ef8419e4c4d2762553106dbe8951c2d8c9b7e6f43
hovercard-subject-tagpull_request:157496848
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/4792/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/525c833c69c511eae1f81cbb5d8c45238b3ef76c9170435f52b84c4e31e5c1b4/python/cpython/pull/4792
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/525c833c69c511eae1f81cbb5d8c45238b3ef76c9170435f52b84c4e31e5c1b4/python/cpython/pull/4792
og:image:altPreviously, if the wakeup fd's buffer overflowed, Python would unconditionally print a warning on stderr. But for many of set_wakeup_fd's users (e.g. Twisted, Tornado, and Trio), this is in...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenjsmith
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/4792#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4792
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4792
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4792
Reloadhttps://github.com/python/cpython/pull/4792
Reloadhttps://github.com/python/cpython/pull/4792
Please reload this pagehttps://github.com/python/cpython/pull/4792
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/4792
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
1st1https://github.com/1st1
python:masterhttps://github.com/python/cpython/tree/master
njsmith:bpo-30050https://github.com/njsmith/cpython/tree/bpo-30050
Conversationhttps://github.com/python/cpython/pull/4792
Commits9 (9)https://github.com/python/cpython/pull/4792/commits
Checkshttps://github.com/python/cpython/pull/4792/checks
Files changedhttps://github.com/python/cpython/pull/4792/files
bpo-30050: Allow disabling full buffer warnings in signal.set_wakeup_fdhttps://github.com/python/cpython/pull/4792#top
1st1https://github.com/1st1
python:masterhttps://github.com/python/cpython/tree/master
njsmith:bpo-30050https://github.com/njsmith/cpython/tree/bpo-30050
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Dec 11, 2017https://github.com/python/cpython/pull/4792#issue-280922888
Please reload this pagehttps://github.com/python/cpython/pull/4792
https://bugs.python.org/issue30050https://bugs.python.org/issue30050
Please reload this pagehttps://github.com/python/cpython/pull/4792
njsmithhttps://github.com/njsmith
December 10, 2017 21:57https://github.com/python/cpython/pull/4792#commits-pushed-4e6297b
https://github.com/njsmith
signalmodule.c refactor: share more code between Windows and POSIXhttps://github.com/python/cpython/pull/4792/commits/4e6297b6dad5507ea61aa14b38b7a6e6233197a2
4e6297bhttps://github.com/python/cpython/pull/4792/commits/4e6297b6dad5507ea61aa14b38b7a6e6233197a2
https://github.com/njsmith
refactor: remove redundant variable assignmenthttps://github.com/python/cpython/pull/4792/commits/f7cdf022d783829c52535c961b8f88759ccd62b9
f7cdf02https://github.com/python/cpython/pull/4792/commits/f7cdf022d783829c52535c961b8f88759ccd62b9
https://github.com/njsmith
signalmodule.c refactor: Windows send() does not set errnohttps://github.com/python/cpython/pull/4792/commits/d12750cbccf054d6619300522b6b7f8500b2cc27
d12750chttps://github.com/python/cpython/pull/4792/commits/d12750cbccf054d6619300522b6b7f8500b2cc27
https://msdn.microsoft.com/en-us/library/windows/desktop/ms740149(v=vs.85).aspxhttps://msdn.microsoft.com/en-us/library/windows/desktop/ms740149(v=vs.85).aspx
https://github.com/njsmith
signalmodule.c: Add warn_on_full_buffer supporthttps://github.com/python/cpython/pull/4792/commits/3a9ebe371540798703e4b15beb64a25523562314
3a9ebe3https://github.com/python/cpython/pull/4792/commits/3a9ebe371540798703e4b15beb64a25523562314
https://github.com/njsmith
Add test for set_wakeup_fd(..., warn_on_full_buffer=True/False)https://github.com/python/cpython/pull/4792/commits/73a5391927883f79f04dfdde4e4e55031403ac13
73a5391https://github.com/python/cpython/pull/4792/commits/73a5391927883f79f04dfdde4e4e55031403ac13
https://github.com/njsmith
Document set_wakeup_fd(..., warn_on_full_buffer=True/False)https://github.com/python/cpython/pull/4792/commits/1eca2f30e0d739ca026898df987b299a8f6d45eb
1eca2f3https://github.com/python/cpython/pull/4792/commits/1eca2f30e0d739ca026898df987b299a8f6d45eb
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Dec 11, 2017https://github.com/python/cpython/pull/4792#event-1380883589
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 11, 2017https://github.com/python/cpython/pull/4792#event-1380883595
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Dec 11, 2017https://github.com/python/cpython/pull/4792#issuecomment-350647173
Please reload this pagehttps://github.com/python/cpython/pull/4792
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Dec 11, 2017 https://github.com/python/cpython/pull/4792#pullrequestreview-82413629
View reviewed changes https://github.com/python/cpython/pull/4792/files/1eca2f30e0d739ca026898df987b299a8f6d45eb
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/4792#pullrequestreview-82413629
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
Modules/signalmodule.chttps://github.com/python/cpython/pull/4792/files/1eca2f30e0d739ca026898df987b299a8f6d45eb#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156006814
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
njsmithhttps://github.com/njsmith
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156032668
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
Modules/signalmodule.chttps://github.com/python/cpython/pull/4792/files/1eca2f30e0d739ca026898df987b299a8f6d45eb#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156006891
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
njsmithhttps://github.com/njsmith
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156032699
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
Doc/library/signal.rsthttps://github.com/python/cpython/pull/4792/files/1eca2f30e0d739ca026898df987b299a8f6d45eb#diff-22a34e88338be85d7f5e32d552c734f247d9c5e26beb0815e805780e60d552df
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156009121
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
njsmithhttps://github.com/njsmith
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156031893
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
Modules/signalmodule.chttps://github.com/python/cpython/pull/4792/files/1eca2f30e0d739ca026898df987b299a8f6d45eb#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156009195
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
njsmithhttps://github.com/njsmith
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156032712
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
Lib/test/test_signal.pyhttps://github.com/python/cpython/pull/4792/files/1eca2f30e0d739ca026898df987b299a8f6d45eb#diff-d2af8fb561277f84d7a1c0274aca37955e9f515d0d73be58933abe191df1cca9
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156009794
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
njsmithhttps://github.com/njsmith
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156032489
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
Lib/test/test_signal.pyhttps://github.com/python/cpython/pull/4792/files/1eca2f30e0d739ca026898df987b299a8f6d45eb#diff-d2af8fb561277f84d7a1c0274aca37955e9f515d0d73be58933abe191df1cca9
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156010026
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
njsmithhttps://github.com/njsmith
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156032643
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
Lib/test/test_signal.pyhttps://github.com/python/cpython/pull/4792/files/1eca2f30e0d739ca026898df987b299a8f6d45eb#diff-d2af8fb561277f84d7a1c0274aca37955e9f515d0d73be58933abe191df1cca9
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156010397
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
njsmithhttps://github.com/njsmith
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156032342
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156050306
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
Modules/signalmodule.chttps://github.com/python/cpython/pull/4792/files/1eca2f30e0d739ca026898df987b299a8f6d45eb#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156010504
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
njsmithhttps://github.com/njsmith
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156032744
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#issuecomment-350659665
@pitrouhttps://github.com/pitrou
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/4792
https://github.com/njsmith
Addresshttps://github.com/python/cpython/pull/4792/commits/3c2cd186ae7a2841966fa690ea970d9463e094ce
@vstinnerhttps://github.com/vstinner
's review commentshttps://github.com/python/cpython/pull/4792/commits/3c2cd186ae7a2841966fa690ea970d9463e094ce
3c2cd18https://github.com/python/cpython/pull/4792/commits/3c2cd186ae7a2841966fa690ea970d9463e094ce
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Dec 11, 2017 https://github.com/python/cpython/pull/4792#pullrequestreview-82462014
View reviewed changes https://github.com/python/cpython/pull/4792/files/3c2cd186ae7a2841966fa690ea970d9463e094ce
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/4792#pullrequestreview-82462014
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
Doc/library/signal.rsthttps://github.com/python/cpython/pull/4792/files/3c2cd186ae7a2841966fa690ea970d9463e094ce#diff-22a34e88338be85d7f5e32d552c734f247d9c5e26beb0815e805780e60d552df
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156049675
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
Lib/test/test_signal.pyhttps://github.com/python/cpython/pull/4792/files/3c2cd186ae7a2841966fa690ea970d9463e094ce#diff-d2af8fb561277f84d7a1c0274aca37955e9f515d0d73be58933abe191df1cca9
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156049959
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
Lib/test/test_signal.pyhttps://github.com/python/cpython/pull/4792/files/3c2cd186ae7a2841966fa690ea970d9463e094ce#diff-d2af8fb561277f84d7a1c0274aca37955e9f515d0d73be58933abe191df1cca9
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156050108
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
Lib/test/test_signal.pyhttps://github.com/python/cpython/pull/4792/files/1eca2f30e0d739ca026898df987b299a8f6d45eb#diff-d2af8fb561277f84d7a1c0274aca37955e9f515d0d73be58933abe191df1cca9
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#discussion_r156050306
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 11, 2017https://github.com/python/cpython/pull/4792#event-1381252759
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Dec 11, 2017https://github.com/python/cpython/pull/4792#issuecomment-350701097
Please reload this pagehttps://github.com/python/cpython/pull/4792
njsmithhttps://github.com/njsmith
December 11, 2017 21:48https://github.com/python/cpython/pull/4792#commits-pushed-f8ac672
https://github.com/njsmith
Fix windows buildhttps://github.com/python/cpython/pull/4792/commits/f8ac672c8463cfb5de62f9a3b91ea0943c72b1ac
f8ac672https://github.com/python/cpython/pull/4792/commits/f8ac672c8463cfb5de62f9a3b91ea0943c72b1ac
https://github.com/njsmith
Addresshttps://github.com/python/cpython/pull/4792/commits/99b34ee359d899aa9a7fd1d4ab18efd25b2d2bc2
@vstinnerhttps://github.com/vstinner
's second round of review commentshttps://github.com/python/cpython/pull/4792/commits/99b34ee359d899aa9a7fd1d4ab18efd25b2d2bc2
99b34eehttps://github.com/python/cpython/pull/4792/commits/99b34ee359d899aa9a7fd1d4ab18efd25b2d2bc2
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Dec 12, 2017https://github.com/python/cpython/pull/4792#issuecomment-350952530
Please reload this pagehttps://github.com/python/cpython/pull/4792
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Dec 12, 2017https://github.com/python/cpython/pull/4792#issuecomment-350983565
Please reload this pagehttps://github.com/python/cpython/pull/4792
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Dec 12, 2017 https://github.com/python/cpython/pull/4792#pullrequestreview-82753540
View reviewed changes https://github.com/python/cpython/pull/4792/files/99b34ee359d899aa9a7fd1d4ab18efd25b2d2bc2
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/4792#pullrequestreview-82753540
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4792
https://github.com/1st1
1st1https://github.com/1st1
Dec 18, 2017 https://github.com/python/cpython/pull/4792#pullrequestreview-84031954
View reviewed changes https://github.com/python/cpython/pull/4792/files/99b34ee359d899aa9a7fd1d4ab18efd25b2d2bc2
https://github.com/1st1
1st1https://github.com/1st1
902ab80https://github.com/python/cpython/commit/902ab80b590e474bb2077b1fae8aac497b856d66
Dec 18, 2017https://github.com/python/cpython/pull/4792#event-1391400100
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Dec 18, 2017https://github.com/python/cpython/pull/4792#event-1391400109
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Jan 18, 2018 https://github.com/python/cpython/pull/4792#ref-issue-215935234
Maybe use signal.set_wakeup_fd on unix-likes python-trio/trio#109 https://github.com/python-trio/trio/issues/109
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4792
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/4792/files/99b34ee359d899aa9a7fd1d4ab18efd25b2d2bc2
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/python/cpython/pull/4792/files/99b34ee359d899aa9a7fd1d4ab18efd25b2d2bc2
Please reload this pagehttps://github.com/python/cpython/pull/4792
https://github.com/njsmith
https://github.com/vstinner
https://github.com/1st1
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.