Title: bpo-31940: Reject faulty lchmod implementations by asottile · Pull Request #4783 · python/cpython · GitHub
Open Graph Title: bpo-31940: Reject faulty lchmod implementations by asottile · Pull Request #4783 · python/cpython
X Title: bpo-31940: Reject faulty lchmod implementations by asottile · Pull Request #4783 · python/cpython
Description: This is a runtime attempt at implementing #4267 A few notes: During review it was suggested to cache the failed lchmod attempts, however I don't think this is doable: lchmod is used for both symlinks and not symlinks if follow_symlinks=False -- it works fine for normal files detecting whether something is a symlink up front throws away all benefits of caching whether it fails as you still make a syscall the code for fchmodat adjacent to the lchmod code serves as precedent for both of these decisions https://bugs.python.org/issue31940
Open Graph Description: This is a runtime attempt at implementing #4267 A few notes: During review it was suggested to cache the failed lchmod attempts, however I don't think this is doable: lchmod is used for both ...
X Description: This is a runtime attempt at implementing #4267 A few notes: During review it was suggested to cache the failed lchmod attempts, however I don't think this is doable: lchmod is used for b...
Opengraph URL: https://github.com/python/cpython/pull/4783
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:75ef4aea-7137-9f66-639a-6aa18e6ff0d2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9810:A6D52:27DF009:378055F:6A4F54F7 |
| html-safe-nonce | 6378d9c792e066ab4722f05ab3ea24c91d931b0f41d463d8251842bd3cd48183 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODEwOkE2RDUyOjI3REYwMDk6Mzc4MDU1Rjo2QTRGNTRGNyIsInZpc2l0b3JfaWQiOiIxNjgwOTk1MjEyOTcxNjkzMzAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f809bf67eeecde6bf9da0d44f89a45131a07d8e61d006b2f2d6714dc7e0ba0b4 |
| hovercard-subject-tag | pull_request:157446288 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/4783/files |
| twitter:image | https://avatars.githubusercontent.com/u/1810591?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1810591?s=400&v=4 |
| og:image:alt | This is a runtime attempt at implementing #4267 A few notes: During review it was suggested to cache the failed lchmod attempts, however I don't think this is doable: lchmod is used for both ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width