| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cf2efb5b-82cf-ee2d-0878-5cee5d001b03 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D16C:135B7:EFB847:145D268:6A4DD385 |
| html-safe-nonce | d43223f8acabd1807a76469f465845a37ec6ac73f5ce865f68a7fb5b9f784238 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTZDOjEzNUI3OkVGQjg0NzoxNDVEMjY4OjZBNEREMzg1IiwidmlzaXRvcl9pZCI6Ijg3MjE0MDk4NjA2MTA5Mzc3MzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 457c256114db64f9f9e3bbbb6340130362a0e34b95cffdf95252991797bfb239 |
| hovercard-subject-tag | pull_request:156570259 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/4732/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3b564b578fb6829c6c9729477bf19f0fbe7a111318db06740587de6e860005d9/python/cpython/pull/4732 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3b564b578fb6829c6c9729477bf19f0fbe7a111318db06740587de6e860005d9/python/cpython/pull/4732 |
| og:image:alt | This is a basic implementation of the PEP. Suggestions are welcome.
@gvanrossum @serhiy-storchaka Can one of you (or both?) please review?
cc: @markshannon IIRC you are interested in implementation... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/4732#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4732 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4732 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/4732 |
| Reload | https://github.com/python/cpython/pull/4732 |
| Reload | https://github.com/python/cpython/pull/4732 |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/cpython/tree/master |
| ilevkivskyi:base-subclass | https://github.com/ilevkivskyi/cpython/tree/base-subclass |
| Conversation | https://github.com/python/cpython/pull/4732 |
| Commits40 (40) | https://github.com/python/cpython/pull/4732/commits |
| Checks | https://github.com/python/cpython/pull/4732/checks |
| Files changed | https://github.com/python/cpython/pull/4732/files |
| bpo-32226: Implementation of PEP 560 (core components) | https://github.com/python/cpython/pull/4732#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/cpython/tree/master |
| ilevkivskyi:base-subclass | https://github.com/ilevkivskyi/cpython/tree/base-subclass |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 5, 2017 | https://github.com/python/cpython/pull/4732#issue-279525248 |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| @gvanrossum | https://github.com/gvanrossum |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| @markshannon | https://github.com/markshannon |
| https://bugs.python.org/issue32226 | https://bugs.python.org/issue32226 |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| November 11, 2017 10:01 | https://github.com/python/cpython/pull/4732#commits-pushed-26afdc6 |
|
| https://github.com/ilevkivskyi |
| POC implementation of __base_subclass__ | https://github.com/python/cpython/pull/4732/commits/26afdc6639a8c03113e4fefae1ff7298eeb161df |
| 26afdc6 | https://github.com/python/cpython/pull/4732/commits/26afdc6639a8c03113e4fefae1ff7298eeb161df |
|
| https://github.com/ilevkivskyi |
| POC implementation of __class_getitem__ | https://github.com/python/cpython/pull/4732/commits/3285fb6898739dfb844412f04d7638136e39d747 |
| 3285fb6 | https://github.com/python/cpython/pull/4732/commits/3285fb6898739dfb844412f04d7638136e39d747 |
|
| https://github.com/ilevkivskyi |
| Modify __base_subclass__ API to support dynamic evaluation and base r… | https://github.com/python/cpython/pull/4732/commits/779f85dcba319311d788e8aa7e6b87c923bf9935 |
| 779f85d | https://github.com/python/cpython/pull/4732/commits/779f85dcba319311d788e8aa7e6b87c923bf9935 |
|
| https://github.com/ilevkivskyi |
| Make __base_subclass__ faster and safer | https://github.com/python/cpython/pull/4732/commits/5d5211d9172660913f5b1507183117d837c26ba3 |
| 5d5211d | https://github.com/python/cpython/pull/4732/commits/5d5211d9172660913f5b1507183117d837c26ba3 |
|
| https://github.com/ilevkivskyi |
| Factor out base update in a separate helper | https://github.com/python/cpython/pull/4732/commits/41fa7e9ce186efb3953ce99d0094f71f38fdc18f |
| 41fa7e9 | https://github.com/python/cpython/pull/4732/commits/41fa7e9ce186efb3953ce99d0094f71f38fdc18f |
|
| https://github.com/ilevkivskyi |
| Formatting | https://github.com/python/cpython/pull/4732/commits/5aeebab8950d5efc3f2c6c36c3e1e7a78e7d146d |
| 5aeebab | https://github.com/python/cpython/pull/4732/commits/5aeebab8950d5efc3f2c6c36c3e1e7a78e7d146d |
|
| https://github.com/ilevkivskyi |
| Also make __class_getitem__ safer | https://github.com/python/cpython/pull/4732/commits/e858ea7501b6bf0ccee2a4afd3104c8b7b6da7bc |
| e858ea7 | https://github.com/python/cpython/pull/4732/commits/e858ea7501b6bf0ccee2a4afd3104c8b7b6da7bc |
|
| https://github.com/ilevkivskyi |
| Simplify some code | https://github.com/python/cpython/pull/4732/commits/5b8d45367b2adb0015c37e7d592f00bba32d973a |
| 5b8d453 | https://github.com/python/cpython/pull/4732/commits/5b8d45367b2adb0015c37e7d592f00bba32d973a |
|
| https://github.com/ilevkivskyi |
| Initial work on typing2 | https://github.com/python/cpython/pull/4732/commits/b3e52f12341fb840811cddd03c97e4bfe53ac8fe |
| b3e52f1 | https://github.com/python/cpython/pull/4732/commits/b3e52f12341fb840811cddd03c97e4bfe53ac8fe |
|
| https://github.com/ilevkivskyi |
| Remove test implementation for typing | https://github.com/python/cpython/pull/4732/commits/6e7b575273aed0a4c5f181fde1825d82d9924b8d |
| 6e7b575 | https://github.com/python/cpython/pull/4732/commits/6e7b575273aed0a4c5f181fde1825d82d9924b8d |
|
| https://github.com/ilevkivskyi |
| Rename base_subclass to subclass_base | https://github.com/python/cpython/pull/4732/commits/a8437fa175c437cede74aadfd3b60cbf0de3fcd6 |
| a8437fa | https://github.com/python/cpython/pull/4732/commits/a8437fa175c437cede74aadfd3b60cbf0de3fcd6 |
|
| https://github.com/ilevkivskyi |
| Start adding tests | https://github.com/python/cpython/pull/4732/commits/c2d8ac2f8dd8c53ba6c655544f10b33b957305cd |
| c2d8ac2 | https://github.com/python/cpython/pull/4732/commits/c2d8ac2f8dd8c53ba6c655544f10b33b957305cd |
|
| https://github.com/ilevkivskyi |
| Add tests for __subclass_base__ | https://github.com/python/cpython/pull/4732/commits/bc06c6b3fa22d2ec00c672b386ab808579b691bb |
| bc06c6b | https://github.com/python/cpython/pull/4732/commits/bc06c6b3fa22d2ec00c672b386ab808579b691bb |
|
| https://github.com/ilevkivskyi |
| Add tests for __class_getitem__ | https://github.com/python/cpython/pull/4732/commits/86c5d615fd1c1660a1325300f3e0199c6a276225 |
| 86c5d61 | https://github.com/python/cpython/pull/4732/commits/86c5d615fd1c1660a1325300f3e0199c6a276225 |
|
| https://github.com/ilevkivskyi |
| Fix trailing whitespace | https://github.com/python/cpython/pull/4732/commits/2cef78ae92353ca667730d2a1d7a81f36f9501a9 |
| 2cef78a | https://github.com/python/cpython/pull/4732/commits/2cef78ae92353ca667730d2a1d7a81f36f9501a9 |
|
| https://github.com/ilevkivskyi |
| Alternative implementation of __class_getitem__ | https://github.com/python/cpython/pull/4732/commits/b9bbf7c569027cc9bd16d731683a08ea3838ecde |
| b9bbf7c | https://github.com/python/cpython/pull/4732/commits/b9bbf7c569027cc9bd16d731683a08ea3838ecde |
|
| https://github.com/ilevkivskyi |
| Simplify code and fix reference counting | https://github.com/python/cpython/pull/4732/commits/2495e942c7f90ff7b2292ef44ec5d82bf2281619 |
| 2495e94 | https://github.com/python/cpython/pull/4732/commits/2495e942c7f90ff7b2292ef44ec5d82bf2281619 |
|
| https://github.com/ilevkivskyi |
| Rename __base_subclass__ to __mro_entry__ | https://github.com/python/cpython/pull/4732/commits/9ca8dfca2357d5f1556966c23f346b6d609b98c1 |
| 9ca8dfc | https://github.com/python/cpython/pull/4732/commits/9ca8dfca2357d5f1556966c23f346b6d609b98c1 |
|
| https://github.com/ilevkivskyi |
| Add types.resolve_bases | https://github.com/python/cpython/pull/4732/commits/74bd36f8a4cbcb4bc822a56dab701c58fe77f2ec |
| 74bd36f | https://github.com/python/cpython/pull/4732/commits/74bd36f8a4cbcb4bc822a56dab701c58fe77f2ec |
|
| https://github.com/ilevkivskyi |
| Make Python and C versions as similar as possible | https://github.com/python/cpython/pull/4732/commits/6f20c4518bc4220f8f71ca9725e084ddbf976d2b |
| 6f20c45 | https://github.com/python/cpython/pull/4732/commits/6f20c4518bc4220f8f71ca9725e084ddbf976d2b |
|
| https://github.com/ilevkivskyi |
| More tests | https://github.com/python/cpython/pull/4732/commits/bcfbcf60fc9db8cbf09e1c308aa64bc8126be727 |
| bcfbcf6 | https://github.com/python/cpython/pull/4732/commits/bcfbcf60fc9db8cbf09e1c308aa64bc8126be727 |
|
| https://github.com/ilevkivskyi |
| Fail fast in type.__new__ | https://github.com/python/cpython/pull/4732/commits/d7bd63080d25ca50fcd1101839dea0202ad7d0c2 |
| d7bd630 | https://github.com/python/cpython/pull/4732/commits/d7bd63080d25ca50fcd1101839dea0202ad7d0c2 |
|
| https://github.com/ilevkivskyi |
| Fix a test | https://github.com/python/cpython/pull/4732/commits/29e54c334dc00427644db08fdad2a73bcb2dc8bd |
| 29e54c3 | https://github.com/python/cpython/pull/4732/commits/29e54c334dc00427644db08fdad2a73bcb2dc8bd |
|
| https://github.com/ilevkivskyi |
| Test error message | https://github.com/python/cpython/pull/4732/commits/cba2a58f8417fa44993c5a5f6113b6476875cb4f |
| cba2a58 | https://github.com/python/cpython/pull/4732/commits/cba2a58f8417fa44993c5a5f6113b6476875cb4f |
|
| https://github.com/ilevkivskyi |
| Test error message | https://github.com/python/cpython/pull/4732/commits/966a9ea754e38b34a97b55a7e4b7b46d75cccbcd |
| 966a9ea | https://github.com/python/cpython/pull/4732/commits/966a9ea754e38b34a97b55a7e4b7b46d75cccbcd |
|
| https://github.com/ilevkivskyi |
| Test error message | https://github.com/python/cpython/pull/4732/commits/734c7e9a79796c6f2f685bde1de188ff0b439446 |
| 734c7e9 | https://github.com/python/cpython/pull/4732/commits/734c7e9a79796c6f2f685bde1de188ff0b439446 |
| Allow expansion to multiple bases | https://github.com/python/cpython/pull/4732/commits/152d2f6352d3eb70b3b364d4ee020b1bd126663e |
| 152d2f6 | https://github.com/python/cpython/pull/4732/commits/152d2f6352d3eb70b3b364d4ee020b1bd126663e |
|
| https://github.com/ilevkivskyi |
| Prohibit returning non-tuple | https://github.com/python/cpython/pull/4732/commits/1a218e0c42faa7e8d9b34795dc6e3f2f4ccd5fb0 |
| 1a218e0 | https://github.com/python/cpython/pull/4732/commits/1a218e0c42faa7e8d9b34795dc6e3f2f4ccd5fb0 |
|
| https://github.com/ilevkivskyi |
| Rename to __mro_entries__ | https://github.com/python/cpython/pull/4732/commits/7cc8d8ff0b1f54bbb4ecb131098e74afedf95032 |
| 7cc8d8f | https://github.com/python/cpython/pull/4732/commits/7cc8d8ff0b1f54bbb4ecb131098e74afedf95032 |
|
| https://github.com/ilevkivskyi |
| Merge remote-tracking branch 'upstream/master' into base-subclass | https://github.com/python/cpython/pull/4732/commits/57f477cebee6eea8403cf4fa820c1e7beaacf862 |
| 57f477c | https://github.com/python/cpython/pull/4732/commits/57f477cebee6eea8403cf4fa820c1e7beaacf862 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Dec 7, 2017 | https://github.com/python/cpython/pull/4732#event-1375959881 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 7, 2017 | https://github.com/python/cpython/pull/4732#issuecomment-349824044 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| December 8, 2017 01:27 | https://github.com/python/cpython/pull/4732#commits-pushed-978588c |
|
| https://github.com/ilevkivskyi |
| Address CR (part 1) | https://github.com/python/cpython/pull/4732/commits/978588ca1d79ea5941f17c2bc3c71477ca59f979 |
| 978588c | https://github.com/python/cpython/pull/4732/commits/978588ca1d79ea5941f17c2bc3c71477ca59f979 |
|
| https://github.com/ilevkivskyi |
| Address CR (part 2) use a temporary tuple instead of modifying args i… | https://github.com/python/cpython/pull/4732/commits/7bff68d365889a83eb415d590ef09102a6666ac4 |
| 7bff68d | https://github.com/python/cpython/pull/4732/commits/7bff68d365889a83eb415d590ef09102a6666ac4 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 8, 2017 | https://github.com/python/cpython/pull/4732#issuecomment-350143564 |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting change review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22 |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Dec 8, 2017 | https://github.com/python/cpython/pull/4732#event-1378054409 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Dec 8, 2017 | https://github.com/python/cpython/pull/4732#issuecomment-350143567 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
|
| https://github.com/ilevkivskyi |
| Remove checks for callability of special methods | https://github.com/python/cpython/pull/4732/commits/b3d85ff6ebf117ce0008cedb2813da3d1203c4a0 |
| b3d85ff | https://github.com/python/cpython/pull/4732/commits/b3d85ff6ebf117ce0008cedb2813da3d1203c4a0 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 10, 2017 | https://github.com/python/cpython/pull/4732#issuecomment-350581410 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| #4731 (comment) | https://github.com/python/cpython/pull/4731#discussion_r155949450 |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 10, 2017 | https://github.com/python/cpython/pull/4732#issuecomment-350581784 |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Dec 11, 2017
| https://github.com/python/cpython/pull/4732#pullrequestreview-82593196 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4732/files/b3d85ff6ebf117ce0008cedb2813da3d1203c4a0 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b3d85ff6ebf117ce0008cedb2813da3d1203c4a0#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 11, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156160153 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b3d85ff6ebf117ce0008cedb2813da3d1203c4a0#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 11, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156166470 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b3d85ff6ebf117ce0008cedb2813da3d1203c4a0#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 11, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156171022 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156241286 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b3d85ff6ebf117ce0008cedb2813da3d1203c4a0#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 11, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156172776 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b3d85ff6ebf117ce0008cedb2813da3d1203c4a0#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 11, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156173088 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| December 12, 2017 00:06 | https://github.com/python/cpython/pull/4732#commits-pushed-687e1e7 |
|
| https://github.com/ilevkivskyi |
| Some simplifications | https://github.com/python/cpython/pull/4732/commits/687e1e7ca29134141fcac758dd487384015a0d90 |
| 687e1e7 | https://github.com/python/cpython/pull/4732/commits/687e1e7ca29134141fcac758dd487384015a0d90 |
|
| https://github.com/ilevkivskyi |
| More simplifications: use single pass | https://github.com/python/cpython/pull/4732/commits/4426e8cfbdf36ed01c1704494fbdde33e052402b |
| 4426e8c | https://github.com/python/cpython/pull/4732/commits/4426e8cfbdf36ed01c1704494fbdde33e052402b |
|
| https://github.com/ilevkivskyi |
| Some fixes + performance | https://github.com/python/cpython/pull/4732/commits/b7d28d839540d5bc3ff095d80b9627e6cb8ec6ff |
| b7d28d8 | https://github.com/python/cpython/pull/4732/commits/b7d28d839540d5bc3ff095d80b9627e6cb8ec6ff |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#issuecomment-350903999 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
|
| https://github.com/ilevkivskyi |
| Merge remote-tracking branch 'upstream/master' into base-subclass | https://github.com/python/cpython/pull/4732/commits/dce0218b9120c5d62b37976e8f5e64b8661a1f9c |
| dce0218 | https://github.com/python/cpython/pull/4732/commits/dce0218b9120c5d62b37976e8f5e64b8661a1f9c |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#issuecomment-350972829 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Dec 12, 2017
| https://github.com/python/cpython/pull/4732#pullrequestreview-82693487 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4732/files/b7d28d839540d5bc3ff095d80b9627e6cb8ec6ff |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b7d28d839540d5bc3ff095d80b9627e6cb8ec6ff#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156247422 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b7d28d839540d5bc3ff095d80b9627e6cb8ec6ff#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156288077 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b7d28d839540d5bc3ff095d80b9627e6cb8ec6ff#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156288411 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b7d28d839540d5bc3ff095d80b9627e6cb8ec6ff#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156288597 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b7d28d839540d5bc3ff095d80b9627e6cb8ec6ff#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156289844 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156366261 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b7d28d839540d5bc3ff095d80b9627e6cb8ec6ff#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156289999 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b7d28d839540d5bc3ff095d80b9627e6cb8ec6ff#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156290749 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b7d28d839540d5bc3ff095d80b9627e6cb8ec6ff#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156291805 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| bpo-32240 | https://bugs.python.org/issue32240 |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Python/bltinmodule.c | https://github.com/python/cpython/pull/4732/files/b7d28d839540d5bc3ff095d80b9627e6cb8ec6ff#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 12, 2017 | https://github.com/python/cpython/pull/4732#discussion_r156292077 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| Re-organize code and fix formatting | https://github.com/python/cpython/pull/4732/commits/caf923898257a51b2c3c6575c98ae4a1e25738b5 |
| caf9238 | https://github.com/python/cpython/pull/4732/commits/caf923898257a51b2c3c6575c98ae4a1e25738b5 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 14, 2017 | https://github.com/python/cpython/pull/4732#issuecomment-351689849 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| https://bugs.python.org/issue32226#msg308171 | https://bugs.python.org/issue32226#msg308171 |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Dec 14, 2017
| https://github.com/python/cpython/pull/4732#pullrequestreview-83485448 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4732/files/caf923898257a51b2c3c6575c98ae4a1e25738b5 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| https://github.com/python/cpython/pull/4732#pullrequestreview-83485448 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting change review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22 |
| Dec 14, 2017 | https://github.com/python/cpython/pull/4732#event-1387571364 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 14, 2017 | https://github.com/python/cpython/pull/4732#issuecomment-351856172 |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| 2b5fd1e | https://github.com/python/cpython/commit/2b5fd1e9ca9318673989e6ccac2c8acadc3809cd |
| Dec 14, 2017 | https://github.com/python/cpython/pull/4732#event-1388652919 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Dec 14, 2017 | https://github.com/python/cpython/pull/4732#event-1388652951 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| December 14, 2017 22:33 | https://github.com/python/cpython/pull/4732#event-1388653115 |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
|
Aug 3, 2024
| https://github.com/python/cpython/pull/4732#ref-issue-2445903987 |
|
__class_getitem__ Unexpectedly Falls Back to the Metaclass
#122634
| https://github.com/python/cpython/issues/122634 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4732 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/cpython/pull/4732/files/d0c088950096ad7843d976d99142804fc5214314 |
|
| https://github.com/serhiy-storchaka |
|
serhiy-storchaka
| https://github.com/serhiy-storchaka |
|
| https://github.com/python/cpython/pull/4732/files/caf923898257a51b2c3c6575c98ae4a1e25738b5 |
| Please reload this page | https://github.com/python/cpython/pull/4732 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/bedevere-bot |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |