| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1b376956-e0a4-a887-5b18-86bdeceb5e70 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 966A:16195D:A89822:E1F755:6A4ECEF9 |
| html-safe-nonce | 9da7dc09a9e88e58c3bc321df9371f3c5f60da1a03cea5088ae1e1e7e0757ff3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjZBOjE2MTk1RDpBODk4MjI6RTFGNzU1OjZBNEVDRUY5IiwidmlzaXRvcl9pZCI6IjE5MzIwMzkyMDgyMjM4MjE1NjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 53e9cb5fa1c44861798837bb15b25ace5f278012d8766808c9ab241197df21eb |
| hovercard-subject-tag | pull_request:156565263 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/4731/files |
| twitter:image | https://avatars.githubusercontent.com/u/12005495?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/12005495?s=400&v=4 |
| og:image:alt | This is a basic implementation of the PEP. Suggestions are welcome.
@gvanrossum @serhiy-storchaka Can one of you (or both?) please review?
https://bugs.python.org/issue32225 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/4731/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4731%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4731%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/4731/files |
| Reload | https://github.com/python/cpython/pull/4731/files |
| Reload | https://github.com/python/cpython/pull/4731/files |
| Please reload this page | https://github.com/python/cpython/pull/4731/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/4731/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/cpython/tree/master |
| ilevkivskyi:module-getattr | https://github.com/ilevkivskyi/cpython/tree/module-getattr |
|
Conversation
28
| https://github.com/python/cpython/pull/4731 |
|
Commits
13
| https://github.com/python/cpython/pull/4731/commits |
|
Checks
0
| https://github.com/python/cpython/pull/4731/checks |
|
Files changed
| https://github.com/python/cpython/pull/4731/files |
| Please reload this page | https://github.com/python/cpython/pull/4731/files |
|
bpo-32225: Implementation of PEP 562
| https://github.com/python/cpython/pull/4731/files#top |
|
Show all changes
13 commits
| https://github.com/python/cpython/pull/4731/files |
|
119edbe
Implement module __getattr__
ilevkivskyi Sep 9, 2017
| https://github.com/python/cpython/pull/4731/commits/119edbe46e87d23d234909d9e7eeb70cd9c85c5a |
|
c2ec3c1
Add tests
ilevkivskyi Sep 9, 2017
| https://github.com/python/cpython/pull/4731/commits/c2ec3c1ec400687e1390d2250e5fdf075c1a76a5 |
|
f657a7e
Clean-up after tests
ilevkivskyi Sep 9, 2017
| https://github.com/python/cpython/pull/4731/commits/f657a7e9bfe5cf88b3d98d8acc4cbbe48fd261dc |
|
8aa052f
Fix test clean-up in refleak hunting mode
ilevkivskyi Sep 10, 2017
| https://github.com/python/cpython/pull/4731/commits/8aa052f6174f6307ed9c33508dbf3c9b7d90bfe9 |
|
32d092f
Add module __dir__ (with tests)
ilevkivskyi Nov 14, 2017
| https://github.com/python/cpython/pull/4731/commits/32d092f49b0abf60b887b047560caba73690c785 |
|
68703f0
Merge remote-tracking branch 'upstream/master' into module-getattr
ilevkivskyi Dec 5, 2017
| https://github.com/python/cpython/pull/4731/commits/68703f07fc4857b262a772ebca624ad168e2ae06 |
|
4fa4b1b
Add news entry
ilevkivskyi Dec 5, 2017
| https://github.com/python/cpython/pull/4731/commits/4fa4b1be6ca254cd0d9331f87087777d25663009 |
|
d1ada11
Address CR
ilevkivskyi Dec 7, 2017
| https://github.com/python/cpython/pull/4731/commits/d1ada1172972a26ac837598a1461e916a4134cd2 |
|
a9f7d4a
Fix whitespace
ilevkivskyi Dec 7, 2017
| https://github.com/python/cpython/pull/4731/commits/a9f7d4aa56b2f0d8682241238e2363f637c16100 |
|
f93b168
Simplify the tricky test
ilevkivskyi Dec 7, 2017
| https://github.com/python/cpython/pull/4731/commits/f93b16812ac1e7ff85c70ab8f0c19c7d05cabebf |
|
c720cfd
Fix rst formatting
Dec 7, 2017
| https://github.com/python/cpython/pull/4731/commits/c720cfd40454ae8daa6d7a804c0e294e79c7e621 |
|
fd2f02f
Add docs; minor comment by Serhiy
ilevkivskyi Dec 10, 2017
| https://github.com/python/cpython/pull/4731/commits/fd2f02f22003b5d2cdefbf5d3452f660e298b67a |
|
e4b53d9
Add what's new entry, and index items
ilevkivskyi Dec 10, 2017
| https://github.com/python/cpython/pull/4731/commits/e4b53d9c22e5adc01200f34ce091d8531bc1ca9a |
|
Clear filters
| https://github.com/python/cpython/pull/4731/files |
| Please reload this page | https://github.com/python/cpython/pull/4731/files |
| Please reload this page | https://github.com/python/cpython/pull/4731/files |
|
datamodel.rst
| https://github.com/python/cpython/pull/4731/files#diff-9125871b063a1ef80aa4bd3e46d7060921032c8437160c7cb8c1497756b02d61 |
|
3.7.rst
| https://github.com/python/cpython/pull/4731/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52 |
|
bad_getattr.py
| https://github.com/python/cpython/pull/4731/files#diff-4f7ecb18586aab578aed178f9d33aa1fc2cf06d4ae79abfe0fdbb5613bc73757 |
|
bad_getattr2.py
| https://github.com/python/cpython/pull/4731/files#diff-7503f5455fcbaf44321aa75d4edff19fbef03689ea19ccdd9fbe5fd4be41a0da |
|
bad_getattr3.py
| https://github.com/python/cpython/pull/4731/files#diff-29b6c06dfda0a714c2ed037820fff968fa05f23c0fcfc490e65406017f5950c7 |
|
good_getattr.py
| https://github.com/python/cpython/pull/4731/files#diff-42e96cec2146ce27f0b262e1a98b71e1192559cd4776e4e18c5a16229a6125d5 |
|
test_module.py
| https://github.com/python/cpython/pull/4731/files#diff-9c0ae6e468115715b32ee1cf0ba1ab11be8d5fd9a73f1927c616869e88ac6fe4 |
|
2017-12-05-21-33-47.bpo-32225.ucKjvw.rst
| https://github.com/python/cpython/pull/4731/files#diff-c6f9df97864bf2b40c6020091d73812b11e0acfb27eefd0422b9448fbbb6959a |
|
moduleobject.c
| https://github.com/python/cpython/pull/4731/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5 |
| Doc/reference/datamodel.rst | https://github.com/python/cpython/pull/4731/files#diff-9125871b063a1ef80aa4bd3e46d7060921032c8437160c7cb8c1497756b02d61 |
|
View file
| https://github.com/ilevkivskyi/cpython/blob/e4b53d9c22e5adc01200f34ce091d8531bc1ca9a/Doc/reference/datamodel.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/4731/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/4731/files#diff-9125871b063a1ef80aa4bd3e46d7060921032c8437160c7cb8c1497756b02d61 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 10, 2017 | https://github.com/python/cpython/pull/4731/files#r155960944 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4731/files |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 10, 2017 | https://github.com/python/cpython/pull/4731/files#r155961226 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4731/files |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 10, 2017 | https://github.com/python/cpython/pull/4731/files#r155963557 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4731/files |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 10, 2017 | https://github.com/python/cpython/pull/4731/files#r155964422 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4731/files |
| csabella | https://github.com/csabella |
| Dec 11, 2017 | https://github.com/python/cpython/pull/4731/files#r156086186 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4731/files |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 11, 2017 | https://github.com/python/cpython/pull/4731/files#r156150782 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4731/files |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Dec 11, 2017 | https://github.com/python/cpython/pull/4731/files#r156187596 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ncoghlan | https://github.com/ncoghlan |
| Please reload this page | https://github.com/python/cpython/pull/4731/files |
|
| https://github.com/python/cpython/pull/4731/files#diff-9125871b063a1ef80aa4bd3e46d7060921032c8437160c7cb8c1497756b02d61 |
| Doc/whatsnew/3.7.rst | https://github.com/python/cpython/pull/4731/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52 |
|
View file
| https://github.com/ilevkivskyi/cpython/blob/e4b53d9c22e5adc01200f34ce091d8531bc1ca9a/Doc/whatsnew/3.7.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/4731/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/4731/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52 |
|
| https://github.com/python/cpython/pull/4731/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52 |
| Lib/test/bad_getattr.py | https://github.com/python/cpython/pull/4731/files#diff-4f7ecb18586aab578aed178f9d33aa1fc2cf06d4ae79abfe0fdbb5613bc73757 |
|
View file
| https://github.com/ilevkivskyi/cpython/blob/e4b53d9c22e5adc01200f34ce091d8531bc1ca9a/Lib/test/bad_getattr.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/4731/{{ revealButtonHref }} |
| Lib/test/bad_getattr2.py | https://github.com/python/cpython/pull/4731/files#diff-7503f5455fcbaf44321aa75d4edff19fbef03689ea19ccdd9fbe5fd4be41a0da |
|
View file
| https://github.com/ilevkivskyi/cpython/blob/e4b53d9c22e5adc01200f34ce091d8531bc1ca9a/Lib/test/bad_getattr2.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/4731/{{ revealButtonHref }} |
| Lib/test/bad_getattr3.py | https://github.com/python/cpython/pull/4731/files#diff-29b6c06dfda0a714c2ed037820fff968fa05f23c0fcfc490e65406017f5950c7 |
|
View file
| https://github.com/ilevkivskyi/cpython/blob/e4b53d9c22e5adc01200f34ce091d8531bc1ca9a/Lib/test/bad_getattr3.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/4731/{{ revealButtonHref }} |
| Lib/test/good_getattr.py | https://github.com/python/cpython/pull/4731/files#diff-42e96cec2146ce27f0b262e1a98b71e1192559cd4776e4e18c5a16229a6125d5 |
|
View file
| https://github.com/ilevkivskyi/cpython/blob/e4b53d9c22e5adc01200f34ce091d8531bc1ca9a/Lib/test/good_getattr.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/4731/{{ revealButtonHref }} |
| Lib/test/test_module.py | https://github.com/python/cpython/pull/4731/files#diff-9c0ae6e468115715b32ee1cf0ba1ab11be8d5fd9a73f1927c616869e88ac6fe4 |
|
View file
| https://github.com/ilevkivskyi/cpython/blob/e4b53d9c22e5adc01200f34ce091d8531bc1ca9a/Lib/test/test_module.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/4731/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/4731/files#diff-9c0ae6e468115715b32ee1cf0ba1ab11be8d5fd9a73f1927c616869e88ac6fe4 |
|
| https://github.com/python/cpython/pull/4731/files#diff-9c0ae6e468115715b32ee1cf0ba1ab11be8d5fd9a73f1927c616869e88ac6fe4 |
| Misc/NEWS.d/next/Core and Builtins/2017-12-05-21-33-47.bpo-32225.ucKjvw.rst | https://github.com/python/cpython/pull/4731/files#diff-c6f9df97864bf2b40c6020091d73812b11e0acfb27eefd0422b9448fbbb6959a |
|
View file
| https://github.com/ilevkivskyi/cpython/blob/e4b53d9c22e5adc01200f34ce091d8531bc1ca9a/Misc/NEWS.d/next/Core%20and%20Builtins/2017-12-05-21-33-47.bpo-32225.ucKjvw.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/4731/{{ revealButtonHref }} |
| Objects/moduleobject.c | https://github.com/python/cpython/pull/4731/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5 |
|
View file
| https://github.com/ilevkivskyi/cpython/blob/e4b53d9c22e5adc01200f34ce091d8531bc1ca9a/Objects/moduleobject.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/4731/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/4731/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5 |
|
| https://github.com/python/cpython/pull/4731/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5 |
|
| https://github.com/python/cpython/pull/4731/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5 |
|
| https://github.com/python/cpython/pull/4731/files#diff-8c2a0fd137780a0ee11c19aae8e46e8490f7667698cd78a5bde466bc995a08c5 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |