René's URL Explorer Experiment


Title: bpo-28503: _crypt: fix implicit declaration of crypt(), use crypt_r() if available. by EdSchouten · Pull Request #4691 · python/cpython · GitHub

Open Graph Title: bpo-28503: _crypt: fix implicit declaration of crypt(), use crypt_r() if available. by EdSchouten · Pull Request #4691 · python/cpython

X Title: bpo-28503: _crypt: fix implicit declaration of crypt(), use crypt_r() if available. by EdSchouten · Pull Request #4691 · python/cpython

Description: The '_crypt' module provides a binding to the C crypt(3) function. It is used by the crypt.crypt() function. Looking at the C code, there are a couple of things we can improve: Because crypt() only depends on primitive C types, we currently get away with calling it without it being declared. Ensure that we include , which is the POSIX header file declaring this. The disadvantage of crypt() is that it's thread-unsafe. Systems like Linux and recent versions of FreeBSD nowadays provide crypt_r() as a replacement. This function allows you to pass in a 'crypt_data' object that will hold the resulting string for you. Extend the code to use this function when available. This patch is actually needed to make this module build on CloudABI (https://mail.python.org/pipermail/python-dev/2016-July/145708.html). CloudABI's C library doesn't provide any thread-unsafe functions, meaning that crypt_r() is the only way you can crypt passwords. https://bugs.python.org/issue28503

Open Graph Description: The '_crypt' module provides a binding to the C crypt(3) function. It is used by the crypt.crypt() function. Looking at the C code, there are a couple of things we can improve: Because cr...

X Description: The '_crypt' module provides a binding to the C crypt(3) function. It is used by the crypt.crypt() function. Looking at the C code, there are a couple of things we can improve: Be...

Opengraph URL: https://github.com/python/cpython/pull/4691

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7cb1c1cb-7e60-fdf4-7cc7-ff3c3df830d0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CB8:153FD3:1B5824:244F82:6A52E546
html-safe-nonce9f6c589ef8daf041da2011f7da21837927147dad41e0bb9a8840d5517170495f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0I4OjE1M0ZEMzoxQjU4MjQ6MjQ0RjgyOjZBNTJFNTQ2IiwidmlzaXRvcl9pZCI6IjQxOTYzMDkzMzgwNjg2Nzc4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacee8a1440c33960d8fe19986f3e50082cd2f48020ca1774bd694fa6ade4380374
hovercard-subject-tagpull_request:156080899
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/4691/files
twitter:imagehttps://avatars.githubusercontent.com/u/736085?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/736085?s=400&v=4
og:image:altThe '_crypt' module provides a binding to the C crypt(3) function. It is used by the crypt.crypt() function. Looking at the C code, there are a couple of things we can improve: Because cr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/4691/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4691%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4691%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4691/files
Reloadhttps://github.com/python/cpython/pull/4691/files
Reloadhttps://github.com/python/cpython/pull/4691/files
Please reload this pagehttps://github.com/python/cpython/pull/4691/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/4691/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
EdSchoutenhttps://github.com/EdSchouten
python:masterhttps://github.com/python/cpython/tree/master
EdSchouten:issue28503https://github.com/EdSchouten/cpython/tree/issue28503
Conversation 7 https://github.com/python/cpython/pull/4691
Commits 1 https://github.com/python/cpython/pull/4691/commits
Checks 0 https://github.com/python/cpython/pull/4691/checks
Files changed https://github.com/python/cpython/pull/4691/files
Please reload this pagehttps://github.com/python/cpython/pull/4691/files
bpo-28503: _crypt: fix implicit declaration of crypt(), use crypt_r() if available. https://github.com/python/cpython/pull/4691/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/4691/files
f8e4237 _crypt: fix implicit declaration of crypt(), use crypt_r() if available. EdSchouten Dec 3, 2017 https://github.com/python/cpython/pull/4691/commits/f8e4237bc2a37ebd6b7adc1da02bb5386f91d19f
Clear filters https://github.com/python/cpython/pull/4691/files
Please reload this pagehttps://github.com/python/cpython/pull/4691/files
Please reload this pagehttps://github.com/python/cpython/pull/4691/files
2017-12-03-21-25-10.bpo-28503.D93bf3.rst https://github.com/python/cpython/pull/4691/files#diff-89513c4c9a81e93a5bd974dfe38a82220aa74cbf962cd9e329e4e397eae56969
_cryptmodule.c https://github.com/python/cpython/pull/4691/files#diff-ead1009bc9bbe5d9681626f08d79c02a40bb9551c5a4248d5b3100d5cad83e35
configure https://github.com/python/cpython/pull/4691/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
configure.ac https://github.com/python/cpython/pull/4691/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
pyconfig.h.in https://github.com/python/cpython/pull/4691/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
Misc/NEWS.d/next/Library/2017-12-03-21-25-10.bpo-28503.D93bf3.rsthttps://github.com/python/cpython/pull/4691/files#diff-89513c4c9a81e93a5bd974dfe38a82220aa74cbf962cd9e329e4e397eae56969
View file https://github.com/EdSchouten/cpython/blob/f8e4237bc2a37ebd6b7adc1da02bb5386f91d19f/Misc/NEWS.d/next/Library/2017-12-03-21-25-10.bpo-28503.D93bf3.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4691/{{ revealButtonHref }}
Modules/_cryptmodule.chttps://github.com/python/cpython/pull/4691/files#diff-ead1009bc9bbe5d9681626f08d79c02a40bb9551c5a4248d5b3100d5cad83e35
View file https://github.com/EdSchouten/cpython/blob/f8e4237bc2a37ebd6b7adc1da02bb5386f91d19f/Modules/_cryptmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4691/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4691/files#diff-ead1009bc9bbe5d9681626f08d79c02a40bb9551c5a4248d5b3100d5cad83e35
https://github.com/python/cpython/pull/4691/files#diff-ead1009bc9bbe5d9681626f08d79c02a40bb9551c5a4248d5b3100d5cad83e35
https://github.com/python/cpython/pull/4691/files#diff-ead1009bc9bbe5d9681626f08d79c02a40bb9551c5a4248d5b3100d5cad83e35
https://github.com/python/cpython/pull/4691/files#diff-ead1009bc9bbe5d9681626f08d79c02a40bb9551c5a4248d5b3100d5cad83e35
configurehttps://github.com/python/cpython/pull/4691/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
View file https://github.com/EdSchouten/cpython/blob/f8e4237bc2a37ebd6b7adc1da02bb5386f91d19f/configure
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4691/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4691/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
https://github.com/python/cpython/pull/4691/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
https://github.com/python/cpython/pull/4691/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
https://github.com/python/cpython/pull/4691/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
https://github.com/python/cpython/pull/4691/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
https://github.com/python/cpython/pull/4691/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
configure.achttps://github.com/python/cpython/pull/4691/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
View file https://github.com/EdSchouten/cpython/blob/f8e4237bc2a37ebd6b7adc1da02bb5386f91d19f/configure.ac
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4691/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4691/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
https://github.com/python/cpython/pull/4691/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
https://github.com/python/cpython/pull/4691/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
berkerpeksaghttps://github.com/berkerpeksag
Dec 5, 2017https://github.com/python/cpython/pull/4691/files#r154841307
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4691/files
https://github.com/python/cpython/pull/4691/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
https://github.com/python/cpython/pull/4691/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
https://github.com/python/cpython/pull/4691/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
pyconfig.h.inhttps://github.com/python/cpython/pull/4691/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
View file https://github.com/EdSchouten/cpython/blob/f8e4237bc2a37ebd6b7adc1da02bb5386f91d19f/pyconfig.h.in
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4691/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4691/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
https://github.com/python/cpython/pull/4691/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
https://github.com/python/cpython/pull/4691/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
https://github.com/python/cpython/pull/4691/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.