René's URL Explorer Experiment


Title: bpo-1104: msilib.SummaryInfo.GetProperty() truncates the string by one character by uranusjr · Pull Request #4517 · python/cpython · GitHub

Open Graph Title: bpo-1104: msilib.SummaryInfo.GetProperty() truncates the string by one character by uranusjr · Pull Request #4517 · python/cpython

X Title: bpo-1104: msilib.SummaryInfo.GetProperty() truncates the string by one character by uranusjr · Pull Request #4517 · python/cpython

Description: Based on the patch in bpo-1104 by Anthony Tuininga (atuining) and Mark Mc Mahon (markm). Unfortunately Microsoft has deemed it necessary to return the size of the string without the null termination character but insists upon the size including it when passing it in. Arggh! — Anthony, on the fix https://bugs.python.org/issue1104

Open Graph Description: Based on the patch in bpo-1104 by Anthony Tuininga (atuining) and Mark Mc Mahon (markm). Unfortunately Microsoft has deemed it necessary to return the size of the string without the null terminati...

X Description: Based on the patch in bpo-1104 by Anthony Tuininga (atuining) and Mark Mc Mahon (markm). Unfortunately Microsoft has deemed it necessary to return the size of the string without the null terminati...

Opengraph URL: https://github.com/python/cpython/pull/4517

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e826671d-eece-4d58-160b-1fe27041f7fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9288:C8AE2:26F589F:35B3DCC:6A4EF242
html-safe-nonce077c7b73cdb0370e5317b90723570b763118eb76f0d996a8d6bfb349cb746c7b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Mjg4OkM4QUUyOjI2RjU4OUY6MzVCM0RDQzo2QTRFRjI0MiIsInZpc2l0b3JfaWQiOiI0MjE4ODM1ODE1NTk2MjI1MDkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac99da8fbdd29d5382524b013feee31e9e909134c8962df48c4ff9966d882897b5
hovercard-subject-tagpull_request:154333700
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/4517/files
twitter:imagehttps://avatars.githubusercontent.com/u/605277?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/605277?s=400&v=4
og:image:altBased on the patch in bpo-1104 by Anthony Tuininga (atuining) and Mark Mc Mahon (markm). Unfortunately Microsoft has deemed it necessary to return the size of the string without the null terminati...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/4517/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4517%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4517%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4517/files
Reloadhttps://github.com/python/cpython/pull/4517/files
Reloadhttps://github.com/python/cpython/pull/4517/files
Please reload this pagehttps://github.com/python/cpython/pull/4517/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/4517/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zoobahttps://github.com/zooba
python:masterhttps://github.com/python/cpython/tree/master
uranusjr:bpo-1104-msilib-getproperty-truncationhttps://github.com/uranusjr/cpython/tree/bpo-1104-msilib-getproperty-truncation
Conversation 5 https://github.com/python/cpython/pull/4517
Commits 3 https://github.com/python/cpython/pull/4517/commits
Checks 0 https://github.com/python/cpython/pull/4517/checks
Files changed https://github.com/python/cpython/pull/4517/files
Please reload this pagehttps://github.com/python/cpython/pull/4517/files
bpo-1104: msilib.SummaryInfo.GetProperty() truncates the string by one character https://github.com/python/cpython/pull/4517/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/4517/files
6e4a70f Add one char to MsiSummaryInfoGetProperty() output uranusjr Nov 23, 2017 https://github.com/python/cpython/pull/4517/commits/6e4a70ff435fce4c269113ca92f8d9fb3c66001e
5291f2c Improve malloc/free call in summary_getproperty() uranusjr Nov 23, 2017 https://github.com/python/cpython/pull/4517/commits/5291f2c995827820d90045a85c84cea26605f8bc
68ee77a Merge branch 'master' into bpo-1104-msilib-getproperty-truncation zooba Feb 2, 2019 https://github.com/python/cpython/pull/4517/commits/68ee77a064d6184e1d720fb144e93db77ac4fbc8
Clear filters https://github.com/python/cpython/pull/4517/files
Please reload this pagehttps://github.com/python/cpython/pull/4517/files
Please reload this pagehttps://github.com/python/cpython/pull/4517/files
test_msilib.py https://github.com/python/cpython/pull/4517/files#diff-81a73be4ee5ea1875bb2e327e525e3451940cd532e0ab6634c492ba49cd9095c
2017-11-24-12-53-54.bpo-1104.1CWSZp.rst https://github.com/python/cpython/pull/4517/files#diff-2dd3e4c4a5be9a4af90059ce3513d9d220e66a3c544d6de96cc7defc652b4afa
_msi.c https://github.com/python/cpython/pull/4517/files#diff-0ecad841121777dc107149891b22aecd1d273a2dc6b91b2a905dc98c60797766
Lib/test/test_msilib.pyhttps://github.com/python/cpython/pull/4517/files#diff-81a73be4ee5ea1875bb2e327e525e3451940cd532e0ab6634c492ba49cd9095c
View file https://github.com/uranusjr/cpython/blob/68ee77a064d6184e1d720fb144e93db77ac4fbc8/Lib/test/test_msilib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4517/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4517/files#diff-81a73be4ee5ea1875bb2e327e525e3451940cd532e0ab6634c492ba49cd9095c
https://github.com/python/cpython/pull/4517/files#diff-81a73be4ee5ea1875bb2e327e525e3451940cd532e0ab6634c492ba49cd9095c
https://github.com/python/cpython/pull/4517/files#diff-81a73be4ee5ea1875bb2e327e525e3451940cd532e0ab6634c492ba49cd9095c
https://github.com/python/cpython/pull/4517/files#diff-81a73be4ee5ea1875bb2e327e525e3451940cd532e0ab6634c492ba49cd9095c
https://github.com/python/cpython/pull/4517/files#diff-81a73be4ee5ea1875bb2e327e525e3451940cd532e0ab6634c492ba49cd9095c
Misc/NEWS.d/next/Windows/2017-11-24-12-53-54.bpo-1104.1CWSZp.rsthttps://github.com/python/cpython/pull/4517/files#diff-2dd3e4c4a5be9a4af90059ce3513d9d220e66a3c544d6de96cc7defc652b4afa
View file https://github.com/uranusjr/cpython/blob/68ee77a064d6184e1d720fb144e93db77ac4fbc8/Misc/NEWS.d/next/Windows/2017-11-24-12-53-54.bpo-1104.1CWSZp.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4517/{{ revealButtonHref }}
PC/_msi.chttps://github.com/python/cpython/pull/4517/files#diff-0ecad841121777dc107149891b22aecd1d273a2dc6b91b2a905dc98c60797766
View file https://github.com/uranusjr/cpython/blob/68ee77a064d6184e1d720fb144e93db77ac4fbc8/PC/_msi.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4517/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4517/files#diff-0ecad841121777dc107149891b22aecd1d273a2dc6b91b2a905dc98c60797766
https://github.com/python/cpython/pull/4517/files#diff-0ecad841121777dc107149891b22aecd1d273a2dc6b91b2a905dc98c60797766
https://github.com/python/cpython/pull/4517/files#diff-0ecad841121777dc107149891b22aecd1d273a2dc6b91b2a905dc98c60797766
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.