René's URL Explorer Experiment


Title: bpo-25942: Added new parameter to subprocess.run(): cleanup_timeout by stuarteberg · Pull Request #4283 · python/cpython · GitHub

Open Graph Title: bpo-25942: Added new parameter to subprocess.run(): cleanup_timeout by stuarteberg · Pull Request #4283 · python/cpython

X Title: bpo-25942: Added new parameter to subprocess.run(): cleanup_timeout by stuarteberg · Pull Request #4283 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: EDIT: This PR was ultimately superseded by #5026 Summary: subprocess.call() (and now also subprocess.run()) behave badly in the event of SIGINT, i.e. a user hitting Ctrl+C while the subprocess is ...

X Description: EDIT: This PR was ultimately superseded by #5026 Summary: subprocess.call() (and now also subprocess.run()) behave badly in the event of SIGINT, i.e. a user hitting Ctrl+C while the subprocess is ...

Opengraph URL: https://github.com/python/cpython/pull/4283

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:bdc939d0-9c68-2d59-8bd9-f03dc327db50
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id80E0:3F72ED:2D866C:3D18AD:6A5819D9
html-safe-nonce68982412cf5f41324c7ef6f131cf1238d99558b2b50f24a42fb29be6283432ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEUwOjNGNzJFRDoyRDg2NkM6M0QxOEFEOjZBNTgxOUQ5IiwidmlzaXRvcl9pZCI6IjI5MzI4MTc1NjA4NjQyOTk0ODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac02b7b0ca6aafe095b80b63b6da6d0c90ec871ea1b2ec5f2e132de07e90cfa1ff
hovercard-subject-tagpull_request:150699553
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/4283/commits
twitter:imagehttps://opengraph.githubassets.com/571ccc0c0e3bb4d7b2dd62969e039a6411bfa5a0df5d9104439b2f51e8aa6265/python/cpython/pull/4283
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/571ccc0c0e3bb4d7b2dd62969e039a6411bfa5a0df5d9104439b2f51e8aa6265/python/cpython/pull/4283
og:image:altEDIT: This PR was ultimately superseded by #5026 Summary: subprocess.call() (and now also subprocess.run()) behave badly in the event of SIGINT, i.e. a user hitting Ctrl+C while the subprocess is ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamestuarteberg
hostnamegithub.com
expected-hostnamegithub.com
None49c8c15fabcbf356d607a90ca115c13b273e42ff8b74155de050fd229a9b0121
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3fb1f684e7a833eb1b2d01d39875a2b52cb4fe9b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/4283/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4283%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4283%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4283/commits
Reloadhttps://github.com/python/cpython/pull/4283/commits
Reloadhttps://github.com/python/cpython/pull/4283/commits
Please reload this pagehttps://github.com/python/cpython/pull/4283/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/4283/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
stuarteberghttps://github.com/stuarteberg
python:masterhttps://github.com/python/cpython/tree/master
stuarteberg:fix-bpo-25942-subprocess-callhttps://github.com/stuarteberg/cpython/tree/fix-bpo-25942-subprocess-call
Conversationhttps://github.com/python/cpython/pull/4283
Commits11 (11)https://github.com/python/cpython/pull/4283/commits
Checkshttps://github.com/python/cpython/pull/4283/checks
Files changedhttps://github.com/python/cpython/pull/4283/files
bpo-25942: Added new parameter to subprocess.run(): cleanup_timeouthttps://github.com/python/cpython/pull/4283/commits#top
stuarteberghttps://github.com/stuarteberg
python:masterhttps://github.com/python/cpython/tree/master
stuarteberg:fix-bpo-25942-subprocess-callhttps://github.com/stuarteberg/cpython/tree/fix-bpo-25942-subprocess-call
subprocess.call() merely calls subprocess.run()https://github.com/python/cpython/pull/4283/commits/d16a2e6643f7de043845fc9d24336cb18fef6e70
https://github.com/stuarteberg
stuarteberghttps://github.com/python/cpython/commits?author=stuarteberg
d16a2e6https://github.com/python/cpython/pull/4283/commits/d16a2e6643f7de043845fc9d24336cb18fef6e70
https://github.com/python/cpython/tree/d16a2e6643f7de043845fc9d24336cb18fef6e70
bpo-25942: Added new parameter to run(): cleanup_timeouthttps://github.com/python/cpython/pull/4283/commits/bebd8d349a8e64dbb01172a76c0c71c3521845f8
https://github.com/stuarteberg
stuarteberghttps://github.com/python/cpython/commits?author=stuarteberg
bebd8d3https://github.com/python/cpython/pull/4283/commits/bebd8d349a8e64dbb01172a76c0c71c3521845f8
https://github.com/python/cpython/tree/bebd8d349a8e64dbb01172a76c0c71c3521845f8
subprocess.run(): Actually kill the child process if KeyboardInterrupt cleanup takes too long.https://github.com/python/cpython/pull/4283/commits/ff62b7b5878eadd3f3f5879197fcb180e0951b87
https://github.com/stuarteberg
stuarteberghttps://github.com/python/cpython/commits?author=stuarteberg
ff62b7bhttps://github.com/python/cpython/pull/4283/commits/ff62b7b5878eadd3f3f5879197fcb180e0951b87
https://github.com/python/cpython/tree/ff62b7b5878eadd3f3f5879197fcb180e0951b87
subprocess.call(): Fix copy/paste errorhttps://github.com/python/cpython/pull/4283/commits/f7280e00427008ec17ca5d3816b5341fabe95de9
https://github.com/stuarteberg
stuarteberghttps://github.com/python/cpython/commits?author=stuarteberg
f7280e0https://github.com/python/cpython/pull/4283/commits/f7280e00427008ec17ca5d3816b5341fabe95de9
https://github.com/python/cpython/tree/f7280e00427008ec17ca5d3816b5341fabe95de9
test_subprocess: Removed unused variablehttps://github.com/python/cpython/pull/4283/commits/e0d3cbe2af28bb24ebc065a3039258fb0167116e
https://github.com/stuarteberg
stuarteberghttps://github.com/python/cpython/commits?author=stuarteberg
e0d3cbehttps://github.com/python/cpython/pull/4283/commits/e0d3cbe2af28bb24ebc065a3039258fb0167116e
https://github.com/python/cpython/tree/e0d3cbe2af28bb24ebc065a3039258fb0167116e
test_subprocess: Call join() on helper threadhttps://github.com/python/cpython/pull/4283/commits/d1a4dac7cfd2fe990dc2410ff4980cb34979d55b
https://github.com/stuarteberg
stuarteberghttps://github.com/python/cpython/commits?author=stuarteberg
d1a4dachttps://github.com/python/cpython/pull/4283/commits/d1a4dac7cfd2fe990dc2410ff4980cb34979d55b
https://github.com/python/cpython/tree/d1a4dac7cfd2fe990dc2410ff4980cb34979d55b
test_subprocess: Explicitly close file during cleanup test.https://github.com/python/cpython/pull/4283/commits/b83180150f5d42e2e108bb348b3ceaa21f845b7b
https://github.com/stuarteberg
stuarteberghttps://github.com/python/cpython/commits?author=stuarteberg
b831801https://github.com/python/cpython/pull/4283/commits/b83180150f5d42e2e108bb348b3ceaa21f845b7b
https://github.com/python/cpython/tree/b83180150f5d42e2e108bb348b3ceaa21f845b7b
subprocess: Remove print()https://github.com/python/cpython/pull/4283/commits/22b030acd6ef0f367c1f7a552b9c6f1cdfc829de
https://github.com/stuarteberg
stuarteberghttps://github.com/python/cpython/commits?author=stuarteberg
22b030ahttps://github.com/python/cpython/pull/4283/commits/22b030acd6ef0f367c1f7a552b9c6f1cdfc829de
https://github.com/python/cpython/tree/22b030acd6ef0f367c1f7a552b9c6f1cdfc829de
Fix whitespace formattinghttps://github.com/python/cpython/pull/4283/commits/2e990ea03b3395e02dc8c9d295f4efeb320922af
https://github.com/stuarteberg
stuarteberghttps://github.com/python/cpython/commits?author=stuarteberg
2e990eahttps://github.com/python/cpython/pull/4283/commits/2e990ea03b3395e02dc8c9d295f4efeb320922af
https://github.com/python/cpython/tree/2e990ea03b3395e02dc8c9d295f4efeb320922af
test_subprocess: Simulate Ctrl+C via separate SIGINT signals to parent and child,https://github.com/python/cpython/pull/4283/commits/b7971615b3f1e382b0c6d0f6a22b73485020c3cc
https://github.com/stuarteberg
stuarteberghttps://github.com/python/cpython/commits?author=stuarteberg
b797161https://github.com/python/cpython/pull/4283/commits/b7971615b3f1e382b0c6d0f6a22b73485020c3cc
https://github.com/python/cpython/tree/b7971615b3f1e382b0c6d0f6a22b73485020c3cc
subprocess.run(): Changes to exception handling as requested in review:https://github.com/python/cpython/pull/4283/commits/220b40f5613377a908e9bfe863def6179f86a3ef
https://github.com/stuarteberg
stuarteberghttps://github.com/python/cpython/commits?author=stuarteberg
220b40fhttps://github.com/python/cpython/pull/4283/commits/220b40f5613377a908e9bfe863def6179f86a3ef
https://github.com/python/cpython/tree/220b40f5613377a908e9bfe863def6179f86a3ef
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.