| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:445d7750-4b8d-1e7e-345b-4d57defcaf58 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 96BA:C7CE3:445E45:5E8540:6A57CFF1 |
| html-safe-nonce | 9bef700b74bda542c1d30b7a8587f50d023b9662a734bfe2b4f1580d5c4a8a34 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkJBOkM3Q0UzOjQ0NUU0NTo1RTg1NDA6NkE1N0NGRjEiLCJ2aXNpdG9yX2lkIjoiMjY0NDk1MzgxNjAwNTg1NzI2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2e082224ea0f1e6f457d21cf0d5a71c670c631dfa3debc58b0b59c3ce57b2265 |
| hovercard-subject-tag | pull_request:150699553 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/4283/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/571ccc0c0e3bb4d7b2dd62969e039a6411bfa5a0df5d9104439b2f51e8aa6265/python/cpython/pull/4283 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/571ccc0c0e3bb4d7b2dd62969e039a6411bfa5a0df5d9104439b2f51e8aa6265/python/cpython/pull/4283 |
| og:image:alt | EDIT: This PR was ultimately superseded by #5026
Summary:
subprocess.call() (and now also subprocess.run()) behave badly in the event of SIGINT, i.e. a user hitting Ctrl+C while the subprocess is ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | stuarteberg |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5bf9f84655de1d0e9aa064cd3b2bc9703556c68ae53b94e21b872b7e9f1f7cc1 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f76ee5bea8be15c2aede06f855f5c4c808f6eaf5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/4283#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4283 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4283 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/4283 |
| Reload | https://github.com/python/cpython/pull/4283 |
| Reload | https://github.com/python/cpython/pull/4283 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| stuarteberg | https://github.com/stuarteberg |
| python:master | https://github.com/python/cpython/tree/master |
| stuarteberg:fix-bpo-25942-subprocess-call | https://github.com/stuarteberg/cpython/tree/fix-bpo-25942-subprocess-call |
| Conversation | https://github.com/python/cpython/pull/4283 |
| Commits11 (11) | https://github.com/python/cpython/pull/4283/commits |
| Checks | https://github.com/python/cpython/pull/4283/checks |
| Files changed | https://github.com/python/cpython/pull/4283/files |
| bpo-25942: Added new parameter to subprocess.run(): cleanup_timeout | https://github.com/python/cpython/pull/4283#top |
| stuarteberg | https://github.com/stuarteberg |
| python:master | https://github.com/python/cpython/tree/master |
| stuarteberg:fix-bpo-25942-subprocess-call | https://github.com/stuarteberg/cpython/tree/fix-bpo-25942-subprocess-call |
|
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| Nov 4, 2017 | https://github.com/python/cpython/pull/4283#issue-271234536 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| #5026 | https://github.com/python/cpython/pull/5026 |
| @pilcrow | https://github.com/pilcrow |
| bpo-25942 | https://bugs.python.org/issue25942 |
| 1 | https://bugs.python.org/issue25942 |
| @vadmium | https://github.com/vadmium |
| @pilcrow | https://github.com/pilcrow |
| @Haypo | https://github.com/Haypo |
| @Haypo | https://github.com/Haypo |
| @vadmium | https://github.com/vadmium |
| sends SIGINT to all processes in the foreground process group | https://unix.stackexchange.com/a/149756/109091 |
| https://bugs.python.org/issue25942 | https://bugs.python.org/issue25942 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| gpshead | https://github.com/gpshead |
| code owner | https://github.com/python/cpython/blob/aafece7a9e010075fff4420cfbb16f1ec0342698/.github/CODEOWNERS#L34 |
| November 4, 2017 23:24 | https://github.com/python/cpython/pull/4283#event-1326260880 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Nov 4, 2017 | https://github.com/python/cpython/pull/4283#event-1326260887 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Nov 4, 2017 | https://github.com/python/cpython/pull/4283#event-1326260892 |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| Nov 4, 2017 | https://github.com/python/cpython/pull/4283#event-1326261248 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| Nov 5, 2017 | https://github.com/python/cpython/pull/4283#event-1326314163 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| Nov 5, 2017 | https://github.com/python/cpython/pull/4283#issuecomment-341950063 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| force-pushed | https://github.com/python/cpython/compare/f2b80d29c9a22278518af3aa39c3975f3d121f0f..0a1687c9a69c4be023647bbec6bb061919f78422 |
| f2b80d2 | https://github.com/python/cpython/commit/f2b80d29c9a22278518af3aa39c3975f3d121f0f |
| 0a1687c | https://github.com/python/cpython/commit/0a1687c9a69c4be023647bbec6bb061919f78422 |
|
Compare
| https://github.com/python/cpython/compare/f2b80d29c9a22278518af3aa39c3975f3d121f0f..0a1687c9a69c4be023647bbec6bb061919f78422 |
| November 5, 2017 14:15 | https://github.com/python/cpython/pull/4283#event-1326492429 |
|
| https://github.com/stuarteberg |
| subprocess.call() merely calls subprocess.run() | https://github.com/python/cpython/pull/4283/commits/d16a2e6643f7de043845fc9d24336cb18fef6e70 |
| d16a2e6 | https://github.com/python/cpython/pull/4283/commits/d16a2e6643f7de043845fc9d24336cb18fef6e70 |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| force-pushed | https://github.com/python/cpython/compare/0a1687c9a69c4be023647bbec6bb061919f78422..6d3035bb6b8d957ffc59cf8449e88ed983d210c6 |
| 0a1687c | https://github.com/python/cpython/commit/0a1687c9a69c4be023647bbec6bb061919f78422 |
| 6d3035b | https://github.com/python/cpython/commit/6d3035bb6b8d957ffc59cf8449e88ed983d210c6 |
|
Compare
| https://github.com/python/cpython/compare/0a1687c9a69c4be023647bbec6bb061919f78422..6d3035bb6b8d957ffc59cf8449e88ed983d210c6 |
| November 5, 2017 16:34 | https://github.com/python/cpython/pull/4283#event-1326568256 |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| Nov 5, 2017 | https://github.com/python/cpython/pull/4283#event-1326569809 |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| force-pushed | https://github.com/python/cpython/compare/7cffd2d1ed38120bd90ded1a45edce6d1eca7de9..00f2ad2594e21ae5e307abe48061ada2424395c3 |
| 7cffd2d | https://github.com/python/cpython/commit/7cffd2d1ed38120bd90ded1a45edce6d1eca7de9 |
| 00f2ad2 | https://github.com/python/cpython/commit/00f2ad2594e21ae5e307abe48061ada2424395c3 |
|
Compare
| https://github.com/python/cpython/compare/7cffd2d1ed38120bd90ded1a45edce6d1eca7de9..00f2ad2594e21ae5e307abe48061ada2424395c3 |
| November 5, 2017 18:22 | https://github.com/python/cpython/pull/4283#event-1326604854 |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| Nov 5, 2017 | https://github.com/python/cpython/pull/4283#issuecomment-341995569 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| @gpshead | https://github.com/gpshead |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| force-pushed | https://github.com/python/cpython/compare/dc8199bfb6e31e93b0a1dd00375e880601e89cc4..bf3efdd0e6f108001d990d2dd1d382654b752119 |
| dc8199b | https://github.com/python/cpython/commit/dc8199bfb6e31e93b0a1dd00375e880601e89cc4 |
| bf3efdd | https://github.com/python/cpython/commit/bf3efdd0e6f108001d990d2dd1d382654b752119 |
|
Compare
| https://github.com/python/cpython/compare/dc8199bfb6e31e93b0a1dd00375e880601e89cc4..bf3efdd0e6f108001d990d2dd1d382654b752119 |
| November 5, 2017 19:39 | https://github.com/python/cpython/pull/4283#event-1326629436 |
|
| https://github.com/stuarteberg |
| bpo-25942: Added new parameter to run(): cleanup_timeout | https://github.com/python/cpython/pull/4283/commits/bebd8d349a8e64dbb01172a76c0c71c3521845f8 |
| bebd8d3 | https://github.com/python/cpython/pull/4283/commits/bebd8d349a8e64dbb01172a76c0c71c3521845f8 |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| force-pushed | https://github.com/python/cpython/compare/bf3efdd0e6f108001d990d2dd1d382654b752119..bebd8d349a8e64dbb01172a76c0c71c3521845f8 |
| bf3efdd | https://github.com/python/cpython/commit/bf3efdd0e6f108001d990d2dd1d382654b752119 |
| bebd8d3 | https://github.com/python/cpython/commit/bebd8d349a8e64dbb01172a76c0c71c3521845f8 |
|
Compare
| https://github.com/python/cpython/compare/bf3efdd0e6f108001d990d2dd1d382654b752119..bebd8d349a8e64dbb01172a76c0c71c3521845f8 |
| November 5, 2017 19:50 | https://github.com/python/cpython/pull/4283#event-1326632843 |
| https://github.com/vadmium |
| vadmium | https://github.com/vadmium |
|
Nov 6, 2017
| https://github.com/python/cpython/pull/4283#pullrequestreview-74312514 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4283/files/bebd8d349a8e64dbb01172a76c0c71c3521845f8 |
| Lib/subprocess.py | https://github.com/python/cpython/pull/4283/files/bebd8d349a8e64dbb01172a76c0c71c3521845f8#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a |
| vadmium | https://github.com/vadmium |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r148987911 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149046550 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Lib/test/test_subprocess.py | https://github.com/python/cpython/pull/4283/files/bebd8d349a8e64dbb01172a76c0c71c3521845f8#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782 |
| vadmium | https://github.com/vadmium |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r148988820 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149049259 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Lib/test/test_subprocess.py | https://github.com/python/cpython/pull/4283/files/bebd8d349a8e64dbb01172a76c0c71c3521845f8#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782 |
| vadmium | https://github.com/vadmium |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r148988971 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149046884 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Lib/test/test_subprocess.py | https://github.com/python/cpython/pull/4283/files/bebd8d349a8e64dbb01172a76c0c71c3521845f8#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782 |
| vadmium | https://github.com/vadmium |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r148989239 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149047851 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Doc/library/subprocess.rst | https://github.com/python/cpython/pull/4283/files/bebd8d349a8e64dbb01172a76c0c71c3521845f8#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d |
| vadmium | https://github.com/vadmium |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r148989986 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149046347 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Lib/subprocess.py | https://github.com/python/cpython/pull/4283/files/bebd8d349a8e64dbb01172a76c0c71c3521845f8#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a |
| vadmium | https://github.com/vadmium |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r148990356 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149056326 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Doc/library/subprocess.rst | https://github.com/python/cpython/pull/4283/files/bebd8d349a8e64dbb01172a76c0c71c3521845f8#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d |
| vadmium | https://github.com/vadmium |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r148990474 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| https://github.com/vadmium |
| vadmium | https://github.com/vadmium |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#issuecomment-342045331 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| November 6, 2017 05:41 | https://github.com/python/cpython/pull/4283#commits-pushed-ff62b7b |
|
| https://github.com/stuarteberg |
| subprocess.run(): Actually kill the child process if KeyboardInterrup… | https://github.com/python/cpython/pull/4283/commits/ff62b7b5878eadd3f3f5879197fcb180e0951b87 |
| ff62b7b | https://github.com/python/cpython/pull/4283/commits/ff62b7b5878eadd3f3f5879197fcb180e0951b87 |
|
| https://github.com/stuarteberg |
| subprocess.call(): Fix copy/paste error | https://github.com/python/cpython/pull/4283/commits/f7280e00427008ec17ca5d3816b5341fabe95de9 |
| f7280e0 | https://github.com/python/cpython/pull/4283/commits/f7280e00427008ec17ca5d3816b5341fabe95de9 |
|
| https://github.com/stuarteberg |
| test_subprocess: Removed unused variable | https://github.com/python/cpython/pull/4283/commits/e0d3cbe2af28bb24ebc065a3039258fb0167116e |
| e0d3cbe | https://github.com/python/cpython/pull/4283/commits/e0d3cbe2af28bb24ebc065a3039258fb0167116e |
| stuarteberg | https://github.com/stuarteberg |
| November 6, 2017 05:50 | https://github.com/python/cpython/pull/4283#commits-pushed-d1a4dac |
|
| https://github.com/stuarteberg |
| test_subprocess: Call join() on helper thread | https://github.com/python/cpython/pull/4283/commits/d1a4dac7cfd2fe990dc2410ff4980cb34979d55b |
| d1a4dac | https://github.com/python/cpython/pull/4283/commits/d1a4dac7cfd2fe990dc2410ff4980cb34979d55b |
|
| https://github.com/stuarteberg |
| test_subprocess: Explicitly close file during cleanup test. | https://github.com/python/cpython/pull/4283/commits/b83180150f5d42e2e108bb348b3ceaa21f845b7b |
| b831801 | https://github.com/python/cpython/pull/4283/commits/b83180150f5d42e2e108bb348b3ceaa21f845b7b |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Nov 6, 2017
| https://github.com/python/cpython/pull/4283#pullrequestreview-74381615 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4283/files/b83180150f5d42e2e108bb348b3ceaa21f845b7b |
| Lib/subprocess.py | https://github.com/python/cpython/pull/4283/files/b83180150f5d42e2e108bb348b3ceaa21f845b7b#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a |
| vstinner | https://github.com/vstinner |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149049302 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149049650 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| November 6, 2017 05:58 | https://github.com/python/cpython/pull/4283#commits-pushed-22b030a |
|
| https://github.com/stuarteberg |
| subprocess: Remove print() | https://github.com/python/cpython/pull/4283/commits/22b030acd6ef0f367c1f7a552b9c6f1cdfc829de |
| 22b030a | https://github.com/python/cpython/pull/4283/commits/22b030acd6ef0f367c1f7a552b9c6f1cdfc829de |
|
| https://github.com/stuarteberg |
| Fix whitespace formatting | https://github.com/python/cpython/pull/4283/commits/2e990ea03b3395e02dc8c9d295f4efeb320922af |
| 2e990ea | https://github.com/python/cpython/pull/4283/commits/2e990ea03b3395e02dc8c9d295f4efeb320922af |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#issuecomment-342119422 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#issuecomment-342123206 |
| @vadmium | https://github.com/vadmium |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Nov 6, 2017
| https://github.com/python/cpython/pull/4283#pullrequestreview-74408267 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4283/files/2e990ea03b3395e02dc8c9d295f4efeb320922af |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/4283#pullrequestreview-74408267 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Lib/subprocess.py | https://github.com/python/cpython/pull/4283/files/2e990ea03b3395e02dc8c9d295f4efeb320922af#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a |
| vstinner | https://github.com/vstinner |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149072283 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Lib/subprocess.py | https://github.com/python/cpython/pull/4283/files/2e990ea03b3395e02dc8c9d295f4efeb320922af#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a |
| vstinner | https://github.com/vstinner |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149072454 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Lib/subprocess.py | https://github.com/python/cpython/pull/4283/files/2e990ea03b3395e02dc8c9d295f4efeb320922af#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a |
| vstinner | https://github.com/vstinner |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149072814 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Lib/subprocess.py | https://github.com/python/cpython/pull/4283/files/2e990ea03b3395e02dc8c9d295f4efeb320922af#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a |
| vstinner | https://github.com/vstinner |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149072857 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Lib/test/test_subprocess.py | https://github.com/python/cpython/pull/4283/files/2e990ea03b3395e02dc8c9d295f4efeb320922af#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782 |
| vstinner | https://github.com/vstinner |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#discussion_r149073354 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#issuecomment-342143105 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Nov 6, 2017 | https://github.com/python/cpython/pull/4283#event-1327534992 |
|
| https://github.com/stuarteberg |
| test_subprocess: Simulate Ctrl+C via separate SIGINT signals to paren… | https://github.com/python/cpython/pull/4283/commits/b7971615b3f1e382b0c6d0f6a22b73485020c3cc |
| b797161 | https://github.com/python/cpython/pull/4283/commits/b7971615b3f1e382b0c6d0f6a22b73485020c3cc |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| Nov 7, 2017 | https://github.com/python/cpython/pull/4283#issuecomment-342339296 |
| @Haypo | https://github.com/Haypo |
| @vadmium | https://github.com/vadmium |
| mysql | https://github.com/django/django/blob/master/django/db/backends/mysql/client.py#L48 |
| sqlite3 | https://github.com/django/django/blob/master/django/db/backends/sqlite3/client.py#L12 |
| postgresql | https://github.com/django/django/blob/master/django/db/backends/postgresql/client.py#L59-L61 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| Nov 7, 2017 | https://github.com/python/cpython/pull/4283#issuecomment-342339409 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting change review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22 |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Nov 7, 2017 | https://github.com/python/cpython/pull/4283#event-1328774499 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Nov 7, 2017 | https://github.com/python/cpython/pull/4283#issuecomment-342339416 |
| @Haypo | https://github.com/Haypo |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
|
| https://github.com/stuarteberg |
| subprocess.run(): Changes to exception handling as requested in review: | https://github.com/python/cpython/pull/4283/commits/220b40f5613377a908e9bfe863def6179f86a3ef |
| 220b40f | https://github.com/python/cpython/pull/4283/commits/220b40f5613377a908e9bfe863def6179f86a3ef |
| https://github.com/stuarteberg |
| stuarteberg | https://github.com/stuarteberg |
| force-pushed | https://github.com/python/cpython/compare/f0d8550d57f622cc4d2cfb76b87bd7fee228bf95..220b40f5613377a908e9bfe863def6179f86a3ef |
| f0d8550 | https://github.com/python/cpython/commit/f0d8550d57f622cc4d2cfb76b87bd7fee228bf95 |
| 220b40f | https://github.com/python/cpython/commit/220b40f5613377a908e9bfe863def6179f86a3ef |
|
Compare
| https://github.com/python/cpython/compare/f0d8550d57f622cc4d2cfb76b87bd7fee228bf95..220b40f5613377a908e9bfe863def6179f86a3ef |
| November 7, 2017 15:03 | https://github.com/python/cpython/pull/4283#event-1329869412 |
| https://github.com/nirs |
| nirs | https://github.com/nirs |
|
Nov 9, 2017
| https://github.com/python/cpython/pull/4283#pullrequestreview-75619096 |
|
View reviewed changes
| https://github.com/python/cpython/pull/4283/files/220b40f5613377a908e9bfe863def6179f86a3ef |
| Lib/subprocess.py | https://github.com/python/cpython/pull/4283/files/220b40f5613377a908e9bfe863def6179f86a3ef#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a |
| nirs | https://github.com/nirs |
| Nov 9, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150114377 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150129307 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150300325 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| pilcrow | https://github.com/pilcrow |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150308214 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| "terminal interrupt signal" | http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| nirs | https://github.com/nirs |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150332143 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150344097 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| nirs | https://github.com/nirs |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150350821 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150353884 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| nirs | https://github.com/nirs |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150357767 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Lib/subprocess.py | https://github.com/python/cpython/pull/4283/files/220b40f5613377a908e9bfe863def6179f86a3ef#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a |
| nirs | https://github.com/nirs |
| Nov 9, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150115925 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| pilcrow | https://github.com/pilcrow |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150134963 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150238487 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| pilcrow | https://github.com/pilcrow |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150270313 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150274985 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Misc/NEWS.d/next/Library/2017-11-05-11-42-56.bpo-25942.o5lBhR.rst | https://github.com/python/cpython/pull/4283/files/220b40f5613377a908e9bfe863def6179f86a3ef#diff-58a1e5cfed6608779c0e52ca0a9f943717a78d72a4e6a32ea2c65d1fed1d2ae8 |
| nirs | https://github.com/nirs |
| Nov 9, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150116134 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150129314 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Doc/library/subprocess.rst | https://github.com/python/cpython/pull/4283/files/220b40f5613377a908e9bfe863def6179f86a3ef#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d |
| nirs | https://github.com/nirs |
| Nov 9, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150116848 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| Lib/subprocess.py | https://github.com/python/cpython/pull/4283/files/220b40f5613377a908e9bfe863def6179f86a3ef#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a |
| nirs | https://github.com/nirs |
| Nov 9, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150118344 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| stuarteberg | https://github.com/stuarteberg |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150129301 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| nirs | https://github.com/nirs |
| Nov 10, 2017 | https://github.com/python/cpython/pull/4283#discussion_r150331498 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @stuarteberg | https://github.com/stuarteberg |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| Jan 30, 2018 | https://github.com/python/cpython/pull/4283#issuecomment-361482945 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| Jan 30, 2018 | https://github.com/python/cpython/pull/4283#event-1447823799 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4283 |
|
| https://github.com/vadmium |
|
vadmium
| https://github.com/vadmium |
|
| https://github.com/python/cpython/pull/4283/files/bebd8d349a8e64dbb01172a76c0c71c3521845f8 |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
| https://github.com/python/cpython/pull/4283/files/2e990ea03b3395e02dc8c9d295f4efeb320922af |
|
| https://github.com/gpshead |
|
gpshead
| https://github.com/gpshead |
|
| https://github.com/pilcrow |
|
pilcrow
| https://github.com/pilcrow |
|
| https://github.com/python/cpython/pull/4283/files/220b40f5613377a908e9bfe863def6179f86a3ef |
|
| https://github.com/nirs |
|
nirs
| https://github.com/nirs |
|
| https://github.com/python/cpython/pull/4283/files/220b40f5613377a908e9bfe863def6179f86a3ef |
|
| https://github.com/gpshead |
|
gpshead
| https://github.com/gpshead |
|
awaiting change review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22 |
| Please reload this page | https://github.com/python/cpython/pull/4283 |
|
| https://github.com/stuarteberg |
|
| https://github.com/gpshead |
|
| https://github.com/vadmium |
|
| https://github.com/bedevere-bot |
|
| https://github.com/pilcrow |
|
| https://github.com/vstinner |
|
| https://github.com/nirs |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |