Title: bpo-25720: Fix the method for checking pad state of curses WINDOW by ma8ma · Pull Request #4164 · python/cpython · GitHub
Open Graph Title: bpo-25720: Fix the method for checking pad state of curses WINDOW by ma8ma · Pull Request #4164 · python/cpython
X Title: bpo-25720: Fix the method for checking pad state of curses WINDOW by ma8ma · Pull Request #4164 · python/cpython
Description: Highlights of changes Modify configure check for the WINDOW _flags field. Add configure check for is_pad function/macro. Remove the definition of NCURSES_OPAQUE for Apple-specific. Define NCURSES_OPAQUE as zero in the case of no is_pad() and having WINDOW _flags. Modify the requirement for defining WINDOW_HAS_FLAGS when having ncurses.h. Add requirement for defining HAVE_CURSES_IS_PAD when having ncurses.h. Define py_is_pad() macro if HAVE_CURSES_IS_PAD or WINDOW_HAS_FLAGS are defined. Change conditional compilation: replace WINDOW_HAS_FLAGS with py_is_pad. Motivation WINDOW_HAS_FLAGS will be defined by configure check, but if your platform has ncurses.h, defines the macro always. Therefore, codes which check the WINDOW _flags field are enabled regardless of NCURSES_OPAQUE (added since ncurses 5.7), and a compile error occurs on platforms where WINDOW is actually opaque. For this reason, these codes are modified to use ncurses is_pad() instead of checking the field. If your platform does not provide the is_pad() (added since ncurses 5.8 as a ncurses-specific feature), the existing way that checks the field will be enabled. In this case, NCURSES_OPAQUE is defined as zero before including [n]curses.h, for exposing WINDOW fields regardless of the configuraton. Note: This change does not drop support for platforms where do not have both WINDOW _flags field and is_pad(). https://bugs.python.org/issue25720
Open Graph Description: Highlights of changes Modify configure check for the WINDOW _flags field. Add configure check for is_pad function/macro. Remove the definition of NCURSES_OPAQUE for Apple-specific. Define NCURSES_...
X Description: Highlights of changes Modify configure check for the WINDOW _flags field. Add configure check for is_pad function/macro. Remove the definition of NCURSES_OPAQUE for Apple-specific. Define NCURSES_...
Opengraph URL: https://github.com/python/cpython/pull/4164
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:116ae8ab-ab56-f0ff-b476-efb4efd386dc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 90C8:47EDE:322A64B:47BB4DE:6A4FC095 |
| html-safe-nonce | ce785287fae1437578e749ac7b7f003cceb2798212adb45c6c51d8cbcd471b99 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEM4OjQ3RURFOjMyMkE2NEI6NDdCQjRERTo2QTRGQzA5NSIsInZpc2l0b3JfaWQiOiI1MTg3NzUzMjg5MDg1NTk5ODkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 95f54e2b9d4f5d430b95a9443ba5762467f41f6356246daa59a2cf49f61ed232 |
| hovercard-subject-tag | pull_request:149375056 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/4164/files |
| twitter:image | https://avatars.githubusercontent.com/u/15698961?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15698961?s=400&v=4 |
| og:image:alt | Highlights of changes Modify configure check for the WINDOW _flags field. Add configure check for is_pad function/macro. Remove the definition of NCURSES_OPAQUE for Apple-specific. Define NCURSES_... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d8f8209b188a80e19a6957836ab9229715797be5db1a04163963c674ccc33f6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ea848e83cf3bf3613dd7b13d52965a684fd23ec5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width