René's URL Explorer Experiment


Title: bpo-31878: Fix _socket module compilation on Cygwin by embray · Pull Request #4137 · python/cpython · GitHub

Open Graph Title: bpo-31878: Fix _socket module compilation on Cygwin by embray · Pull Request #4137 · python/cpython

X Title: bpo-31878: Fix _socket module compilation on Cygwin by embray · Pull Request #4137 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: In Cygwin, as on OSX, ioctl() is declared in sys/ioctl.h, and so needs this include. This is necessary for the _socket module to compile successfully on that platform. https://bugs.python.org/iss...

X Description: In Cygwin, as on OSX, ioctl() is declared in sys/ioctl.h, and so needs this include. This is necessary for the _socket module to compile successfully on that platform. https://bugs.python.org/iss...

Opengraph URL: https://github.com/python/cpython/pull/4137

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7834a9c9-9312-4ce7-dce4-501419594084
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD9C4:2DB422:48B58B:629D1C:6A4DA5B3
html-safe-noncec6ded84269a027ec63d9585b9c026399e9554f3e3afa4454f8d5062695ac45ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUM0OjJEQjQyMjo0OEI1OEI6NjI5RDFDOjZBNERBNUIzIiwidmlzaXRvcl9pZCI6IjU2MjcwNzM1OTY3MzM4OTIwMTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1ed11e1970742af50ebf236a2b50e99ce19ea36a95802f20b4fe8b3d10c8f162
hovercard-subject-tagpull_request:148973381
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/4137/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6445c6a9b2e65224c9e575ce7c5c998db02ff87c01f77061b4075fa73f8aa5c4/python/cpython/pull/4137
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6445c6a9b2e65224c9e575ce7c5c998db02ff87c01f77061b4075fa73f8aa5c4/python/cpython/pull/4137
og:image:altIn Cygwin, as on OSX, ioctl() is declared in sys/ioctl.h, and so needs this include. This is necessary for the _socket module to compile successfully on that platform. https://bugs.python.org/iss...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameembray
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7f13faa65cccc9b729d674da83335d5dcfdfd193
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/4137#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4137
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4137
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4137
Reloadhttps://github.com/python/cpython/pull/4137
Reloadhttps://github.com/python/cpython/pull/4137
Please reload this pagehttps://github.com/python/cpython/pull/4137
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/4137
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
embray:bpo-31878https://github.com/embray/cpython/tree/bpo-31878
Conversationhttps://github.com/python/cpython/pull/4137
Commits1 (1)https://github.com/python/cpython/pull/4137/commits
Checkshttps://github.com/python/cpython/pull/4137/checks
Files changedhttps://github.com/python/cpython/pull/4137/files
bpo-31878: Fix _socket module compilation on Cygwinhttps://github.com/python/cpython/pull/4137#top
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
embray:bpo-31878https://github.com/embray/cpython/tree/bpo-31878
https://github.com/embray
embrayhttps://github.com/embray
Oct 26, 2017https://github.com/python/cpython/pull/4137#issue-268813225
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://bugs.python.org/issue31878https://bugs.python.org/issue31878
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Oct 26, 2017https://github.com/python/cpython/pull/4137#event-1312261977
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 26, 2017https://github.com/python/cpython/pull/4137#event-1312261992
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 26, 2017https://github.com/python/cpython/pull/4137#issuecomment-339740398
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 26, 2017https://github.com/python/cpython/pull/4137#issuecomment-339740745
bpo-16135https://bugs.python.org/issue?@action=redirect&bpo=16135
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 26, 2017https://github.com/python/cpython/pull/4137#issuecomment-339743662
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/embray
embrayhttps://github.com/embray
Oct 27, 2017https://github.com/python/cpython/pull/4137#issuecomment-339905461
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/embray
Cygwin: ioctl is found in sys/ioctl.hhttps://github.com/python/cpython/pull/4137/commits/d96fe0730fe573872794d688eb2ffc19eed8fee1
d96fe07https://github.com/python/cpython/pull/4137/commits/d96fe0730fe573872794d688eb2ffc19eed8fee1
https://github.com/embray
embrayhttps://github.com/embray
force-pushedhttps://github.com/python/cpython/compare/7cc28eb9ba7f38573ac1a2c93689b4b41b96aa1e..d96fe0730fe573872794d688eb2ffc19eed8fee1
7cc28ebhttps://github.com/python/cpython/commit/7cc28eb9ba7f38573ac1a2c93689b4b41b96aa1e
d96fe07https://github.com/python/cpython/commit/d96fe0730fe573872794d688eb2ffc19eed8fee1
Compare https://github.com/python/cpython/compare/7cc28eb9ba7f38573ac1a2c93689b4b41b96aa1e..d96fe0730fe573872794d688eb2ffc19eed8fee1
October 27, 2017 08:20https://github.com/python/cpython/pull/4137#event-1313464413
https://github.com/embray
embrayhttps://github.com/embray
Oct 27, 2017https://github.com/python/cpython/pull/4137#issuecomment-339906218
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 27, 2017 https://github.com/python/cpython/pull/4137#pullrequestreview-72433527
View reviewed changes https://github.com/python/cpython/pull/4137/files/d96fe0730fe573872794d688eb2ffc19eed8fee1
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/4137#pullrequestreview-72433527
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 27, 2017https://github.com/python/cpython/pull/4137#event-1313471273
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Oct 27, 2017https://github.com/python/cpython/pull/4137#event-1313471615
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 27, 2017 https://github.com/python/cpython/pull/4137#pullrequestreview-72433972
View reviewed changes https://github.com/python/cpython/pull/4137/files/d96fe0730fe573872794d688eb2ffc19eed8fee1
https://github.com/embray
embrayhttps://github.com/embray
Oct 27, 2017https://github.com/python/cpython/pull/4137#issuecomment-339908577
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
63ae044https://github.com/python/cpython/commit/63ae04461fb0cc93ca57cd151103a8dd295581d6
Oct 27, 2017https://github.com/python/cpython/pull/4137#event-1313626920
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 27, 2017https://github.com/python/cpython/pull/4137#issuecomment-339929575
@embrayhttps://github.com/embray
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 27, 2017https://github.com/python/cpython/pull/4137#event-1313626974
miss-islingtonhttps://github.com/miss-islington
Oct 27, 2017 https://github.com/python/cpython/pull/4137#ref-commit-67a2b0b
https://github.com/embray
https://github.com/miss-islington
Fix _socket module compilation on Cygwin. (https://github.com/miss-islington/cpython/commit/67a2b0b7713e40dea7762b7d7764ae18fe967561
pythonGH-4137https://github.com/python/cpython/pull/4137
)https://github.com/miss-islington/cpython/commit/67a2b0b7713e40dea7762b7d7764ae18fe967561
67a2b0bhttps://github.com/miss-islington/cpython/commit/67a2b0b7713e40dea7762b7d7764ae18fe967561
63ae044https://github.com/miss-islington/cpython/commit/63ae04461fb0cc93ca57cd151103a8dd295581d6
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 27, 2017https://github.com/python/cpython/pull/4137#issuecomment-339929630
GH-4145https://github.com/python/cpython/pull/4145
3.6 branchhttps://github.com/python/cpython/tree/3.6
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Oct 27, 2017https://github.com/python/cpython/pull/4137#event-1313627518
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 27, 2017https://github.com/python/cpython/pull/4137#issuecomment-339936683
GH-4145https://github.com/python/cpython/pull/4145
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 27, 2017https://github.com/python/cpython/pull/4137#issuecomment-339937094
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/embray
embrayhttps://github.com/embray
October 27, 2017 11:36https://github.com/python/cpython/pull/4137#event-1313754778
https://github.com/embray
embrayhttps://github.com/embray
Oct 27, 2017 https://github.com/python/cpython/pull/4137#ref-pullrequest-269079996
bpo-16135: Cleanup: Code rot left over from OS/2 support #4147 https://github.com/python/cpython/pull/4147
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
needs backport to 2.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%202.7%22
Nov 4, 2017https://github.com/python/cpython/pull/4137#event-1325984782
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Nov 4, 2017https://github.com/python/cpython/pull/4137#issuecomment-341880281
@embrayhttps://github.com/embray
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Nov 4, 2017https://github.com/python/cpython/pull/4137#issuecomment-341880337
@embrayhttps://github.com/embray
@serhiy-storchakahttps://github.com/serhiy-storchaka
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
needs backport to 2.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%202.7%22
Nov 4, 2017https://github.com/python/cpython/pull/4137#event-1325986451
serhiy-storchakahttps://github.com/serhiy-storchaka
Feb 26, 2018 https://github.com/python/cpython/pull/4137#ref-commit-e650fd3
https://github.com/miss-islington
https://github.com/serhiy-storchaka
Fix _socket module compilation on Cygwin. (https://github.com/python/cpython/commit/e650fd362ee7753ca906e1d92121a165ce45ecb6
GH-4137https://github.com/python/cpython/pull/4137
) (https://github.com/python/cpython/commit/e650fd362ee7753ca906e1d92121a165ce45ecb6
GH-4145https://github.com/python/cpython/pull/4145
)https://github.com/python/cpython/commit/e650fd362ee7753ca906e1d92121a165ce45ecb6
e650fd3https://github.com/python/cpython/commit/e650fd362ee7753ca906e1d92121a165ce45ecb6
63ae044https://github.com/python/cpython/commit/63ae04461fb0cc93ca57cd151103a8dd295581d6
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4137
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/4137/files/d96fe0730fe573872794d688eb2ffc19eed8fee1
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/4137/files/d96fe0730fe573872794d688eb2ffc19eed8fee1
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/4137
https://github.com/embray
https://github.com/serhiy-storchaka
https://github.com/vstinner
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.