René's URL Explorer Experiment


Title: [3.6] bpo-31852: Fix segfault caused by using the async soft keyword by pablogsal · Pull Request #4122 · python/cpython · GitHub

Open Graph Title: [3.6] bpo-31852: Fix segfault caused by using the async soft keyword by pablogsal · Pull Request #4122 · python/cpython

X Title: [3.6] bpo-31852: Fix segfault caused by using the async soft keyword by pablogsal · Pull Request #4122 · python/cpython

Description: This PR solves a segmentation fault in Python 3.6 caused by a combination of the async soft keyword and continuation lines. Steps to reproduce: >>> async \ ... File "", line 1 \ufffd\ufffdF\ufffd\ufffd ^ SyntaxError: invalid syntax >>> async \ Segmentation fault As @Haypo mentioned in the issue you can use this file to use the issue in the tokenizer to induce a buffer overflow. This PR solves this issue as well. The current implementation checks if the current token is ASYNC and sets a sentient value (2) in the tok->async_def before looking for the token ahead (which is the step where the segfault happens). The value of tok->async_def gets overwritten after the lookahead by the usual value (1). As this particular issues are fixed by #1669 in the current master (3.7) this PR acts as a mere patch. https://bugs.python.org/issue31852

Open Graph Description: This PR solves a segmentation fault in Python 3.6 caused by a combination of the async soft keyword and continuation lines. Steps to reproduce: >>> async \ ... File "<stdin>&q...

X Description: This PR solves a segmentation fault in Python 3.6 caused by a combination of the async soft keyword and continuation lines. Steps to reproduce: &gt;&gt;&gt; async \ ... File &quot...

Opengraph URL: https://github.com/python/cpython/pull/4122

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a1a8e71f-cfa3-034c-7b49-f5b5b0e3d75f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC574:26D4A7:815AEF:AACDFD:6A5421A0
html-safe-nonce21e6df43607ab0ddfdb01bc61b272c76f59e0dbc7db5ef73a47bd6b3f43b9115
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTc0OjI2RDRBNzo4MTVBRUY6QUFDREZEOjZBNTQyMUEwIiwidmlzaXRvcl9pZCI6IjI0MjA2MTUzMjE4MDk1OTI3MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacafe1b1ea2ffa3e982065915eac624da7a9ca8d7735fea90a5963d8696e877fc4
hovercard-subject-tagpull_request:148795751
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/4122/files
twitter:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
og:image:altThis PR solves a segmentation fault in Python 3.6 caused by a combination of the async soft keyword and continuation lines. Steps to reproduce: >>> async \ ... File "<stdin>&q...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/4122/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4122%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4122%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4122/files
Reloadhttps://github.com/python/cpython/pull/4122/files
Reloadhttps://github.com/python/cpython/pull/4122/files
Please reload this pagehttps://github.com/python/cpython/pull/4122/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/4122/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:3.6https://github.com/python/cpython/tree/3.6
pablogsal:bpo31852https://github.com/pablogsal/cpython/tree/bpo31852
Conversation 9 https://github.com/python/cpython/pull/4122
Commits 4 https://github.com/python/cpython/pull/4122/commits
Checks 0 https://github.com/python/cpython/pull/4122/checks
Files changed https://github.com/python/cpython/pull/4122/files
Please reload this pagehttps://github.com/python/cpython/pull/4122/files
[3.6] bpo-31852: Fix segfault caused by using the async soft keyword https://github.com/python/cpython/pull/4122/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/4122/files
aab5c79 Fix a segfault caused by using continuation lines and the async soft … pablogsal Oct 25, 2017 https://github.com/python/cpython/pull/4122/commits/aab5c792fdf7dd73801848af4b7161fa4fae6f68
7684af5 Reset previous value of tok->async_def if next token is invalid pablogsal Oct 25, 2017 https://github.com/python/cpython/pull/4122/commits/7684af537f5970e447da3d42b4b309cf33dc8a38
7518077 Fix spacing pablogsal Oct 26, 2017 https://github.com/python/cpython/pull/4122/commits/7518077f03d2579959a60f36ac6902c85767b289
e5b1993 Add News entry pablogsal Oct 27, 2017 https://github.com/python/cpython/pull/4122/commits/e5b1993c815518f0ceef6f9e86142bf86968455f
Clear filters https://github.com/python/cpython/pull/4122/files
Please reload this pagehttps://github.com/python/cpython/pull/4122/files
Please reload this pagehttps://github.com/python/cpython/pull/4122/files
test_tokenize.py https://github.com/python/cpython/pull/4122/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
2017-10-27-19-18-44.bpo-31852.P_4cVr.rst https://github.com/python/cpython/pull/4122/files#diff-cceebc93b1196efe933eff8960a00fc5d7f3f02af538f08a64b64478a19a3f63
tokenizer.c https://github.com/python/cpython/pull/4122/files#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
Lib/test/test_tokenize.pyhttps://github.com/python/cpython/pull/4122/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
View file https://github.com/pablogsal/cpython/blob/e5b1993c815518f0ceef6f9e86142bf86968455f/Lib/test/test_tokenize.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4122/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4122/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
https://github.com/python/cpython/pull/4122/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
Misc/NEWS.d/next/Core and Builtins/2017-10-27-19-18-44.bpo-31852.P_4cVr.rsthttps://github.com/python/cpython/pull/4122/files#diff-cceebc93b1196efe933eff8960a00fc5d7f3f02af538f08a64b64478a19a3f63
View file https://github.com/pablogsal/cpython/blob/e5b1993c815518f0ceef6f9e86142bf86968455f/Misc/NEWS.d/next/Core%20and%20Builtins/2017-10-27-19-18-44.bpo-31852.P_4cVr.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4122/{{ revealButtonHref }}
Parser/tokenizer.chttps://github.com/python/cpython/pull/4122/files#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
View file https://github.com/pablogsal/cpython/blob/e5b1993c815518f0ceef6f9e86142bf86968455f/Parser/tokenizer.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4122/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4122/files#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
https://github.com/python/cpython/pull/4122/files#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
https://github.com/python/cpython/pull/4122/files#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
https://github.com/python/cpython/pull/4122/files#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
https://github.com/python/cpython/pull/4122/files#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.