René's URL Explorer Experiment


Title: bpo-31457: Don't omit inner `process()` calls with nested LogAdapters by ambv · Pull Request #4044 · python/cpython · GitHub

Open Graph Title: bpo-31457: Don't omit inner `process()` calls with nested LogAdapters by ambv · Pull Request #4044 · python/cpython

X Title: bpo-31457: Don't omit inner `process()` calls with nested LogAdapters by ambv · Pull Request #4044 · python/cpython

Description: This used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not execute their process() method. This patch fixes the issue. Also, now proxying name, too, to make repr() work with nested log adapters. New tests added. https://bugs.python.org/issue31457

Open Graph Description: This used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not...

X Description: This used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not...

Opengraph URL: https://github.com/python/cpython/pull/4044

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:365da447-d29b-d711-66a7-38a8640e9396
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBFD8:2B21DE:69447B:8ED041:6B0077B1
html-safe-noncec5103e6c0c3c53f47e83d758823d943e13445ffa1ac94e0a8304606748fa3b22
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkQ4OjJCMjFERTo2OTQ0N0I6OEVEMDQxOjZCMDA3N0IxIiwidmlzaXRvcl9pZCI6IjkxMzE3ODQyOTYzMDkyMjUzOTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdc8cbc8504e9422b6f0509f6cc5a6cfbe09e9100e9f385db086f5fe74eab7771
hovercard-subject-tagpull_request:147452371
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/4044/files
twitter:imagehttps://avatars.githubusercontent.com/u/55281?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55281?s=400&v=4
og:image:altThis used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None75c2b65dd205f26961d0c29afed1a8d0bb7cca9f05780571dfd1ef93eb539d16
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84e563eb4b55f8fa102f325f117533cee9e3df4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/4044/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4044%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4044%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4044/files
Reloadhttps://github.com/python/cpython/pull/4044/files
Reloadhttps://github.com/python/cpython/pull/4044/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:masterhttps://github.com/python/cpython/tree/master
ambv:nestedfixfixfixhttps://github.com/ambv/cpython/tree/nestedfixfixfix
Conversation 3 https://github.com/python/cpython/pull/4044
Commits 1 https://github.com/python/cpython/pull/4044/commits
Checks 0 https://github.com/python/cpython/pull/4044/checks
Files changed https://github.com/python/cpython/pull/4044/files
Please reload this pagehttps://github.com/python/cpython/pull/4044/files
bpo-31457: Don't omit inner process() calls with nested LogAdapters https://github.com/python/cpython/pull/4044/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/4044/files
f683657 bpo-31457: Don't omit inner ``process()`` calls with nested LogAdapters Oct 19, 2017 https://github.com/python/cpython/pull/4044/commits/f683657bd3bb7984ecc031e45b438d6dfb2f9cb4
Clear filters https://github.com/python/cpython/pull/4044/files
Please reload this pagehttps://github.com/python/cpython/pull/4044/files
Please reload this pagehttps://github.com/python/cpython/pull/4044/files
__init__.py https://github.com/python/cpython/pull/4044/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
test_logging.py https://github.com/python/cpython/pull/4044/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
2017-10-18-19-05-17.bpo-31457.KlE6r8.rst https://github.com/python/cpython/pull/4044/files#diff-ec8bc1e17d7fb76ab52f677b3edfe7d6be7c875923cd7527ac915f3f27e2de26
Lib/logging/__init__.pyhttps://github.com/python/cpython/pull/4044/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
View file https://github.com/ambv/cpython/blob/f683657bd3bb7984ecc031e45b438d6dfb2f9cb4/Lib/logging/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4044/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4044/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/4044/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/4044/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/4044/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
Lib/test/test_logging.pyhttps://github.com/python/cpython/pull/4044/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
View file https://github.com/ambv/cpython/blob/f683657bd3bb7984ecc031e45b438d6dfb2f9cb4/Lib/test/test_logging.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4044/{{ revealButtonHref }}
https://github.com/python/cpython/pull/4044/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
https://github.com/python/cpython/pull/4044/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
https://github.com/python/cpython/pull/4044/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
https://github.com/python/cpython/pull/4044/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
Misc/NEWS.d/next/Library/2017-10-18-19-05-17.bpo-31457.KlE6r8.rsthttps://github.com/python/cpython/pull/4044/files#diff-ec8bc1e17d7fb76ab52f677b3edfe7d6be7c875923cd7527ac915f3f27e2de26
View file https://github.com/ambv/cpython/blob/f683657bd3bb7984ecc031e45b438d6dfb2f9cb4/Misc/NEWS.d/next/Library/2017-10-18-19-05-17.bpo-31457.KlE6r8.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/4044/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.