René's URL Explorer Experiment


Title: bpo-31457: Don't omit inner `process()` calls with nested LogAdapters by ambv · Pull Request #4044 · python/cpython · GitHub

Open Graph Title: bpo-31457: Don't omit inner `process()` calls with nested LogAdapters by ambv · Pull Request #4044 · python/cpython

X Title: bpo-31457: Don't omit inner `process()` calls with nested LogAdapters by ambv · Pull Request #4044 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not...

X Description: This used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not...

Opengraph URL: https://github.com/python/cpython/pull/4044

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1906e06c-92a3-045c-cf70-4fa66242aafe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC266:1E02C1:31CAA2:4589CE:6B006C91
html-safe-nonce083f85b6bd65afe152df695a7617c11c141699cd639780334a24691251fad657
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjY2OjFFMDJDMTozMUNBQTI6NDU4OUNFOjZCMDA2QzkxIiwidmlzaXRvcl9pZCI6IjE4MzQxNDk1NTkxNjU1NDU2MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbebf7ac4706c3c14d3eacae8bf2443b0f6f06554af165e5e5901dc2430df6645
hovercard-subject-tagpull_request:147452371
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/4044/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1d0446e1e30b6ad7b5ce07f29bc33f3af125e84c4a941f4f64a9d2bf5ab266cf/python/cpython/pull/4044
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1d0446e1e30b6ad7b5ce07f29bc33f3af125e84c4a941f4f64a9d2bf5ab266cf/python/cpython/pull/4044
og:image:altThis used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameambv
hostnamegithub.com
expected-hostnamegithub.com
None6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/4044#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4044
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4044
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4044
Reloadhttps://github.com/python/cpython/pull/4044
Reloadhttps://github.com/python/cpython/pull/4044
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
ambvhttps://github.com/ambv
python:masterhttps://github.com/python/cpython/tree/master
ambv:nestedfixfixfixhttps://github.com/ambv/cpython/tree/nestedfixfixfix
Conversationhttps://github.com/python/cpython/pull/4044
Commits1 (1)https://github.com/python/cpython/pull/4044/commits
Checkshttps://github.com/python/cpython/pull/4044/checks
Files changedhttps://github.com/python/cpython/pull/4044/files
bpo-31457: Don't omit inner process() calls with nested LogAdaptershttps://github.com/python/cpython/pull/4044#top
ambvhttps://github.com/ambv
python:masterhttps://github.com/python/cpython/tree/master
ambv:nestedfixfixfixhttps://github.com/ambv/cpython/tree/nestedfixfixfix
https://github.com/ambv
ambvhttps://github.com/ambv
Oct 19, 2017https://github.com/python/cpython/pull/4044#issue-266698395
Please reload this pagehttps://github.com/python/cpython/pull/4044
212b590https://github.com/python/cpython/commit/212b590e118e3650b596917021ed9612a918180b
https://bugs.python.org/issue31457https://bugs.python.org/issue31457
Please reload this pagehttps://github.com/python/cpython/pull/4044
bpo-31457: Don't omit inner process() calls with nested LogAdaptershttps://github.com/python/cpython/pull/4044/commits/f683657bd3bb7984ecc031e45b438d6dfb2f9cb4
f683657https://github.com/python/cpython/pull/4044/commits/f683657bd3bb7984ecc031e45b438d6dfb2f9cb4
212b590https://github.com/ambv/cpython/commit/212b590e118e3650b596917021ed9612a918180b
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 19, 2017https://github.com/python/cpython/pull/4044#event-1300253885
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Oct 19, 2017https://github.com/python/cpython/pull/4044#event-1300253887
https://github.com/ambv
ambvhttps://github.com/ambv
vsajiphttps://github.com/vsajip
October 19, 2017 02:10https://github.com/python/cpython/pull/4044#event-1300253957
https://github.com/ambv
ambvhttps://github.com/ambv
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Oct 19, 2017https://github.com/python/cpython/pull/4044#event-1300254075
https://github.com/vsajip
vsajiphttps://github.com/vsajip
Oct 19, 2017 https://github.com/python/cpython/pull/4044#pullrequestreview-70440883
View reviewed changes https://github.com/python/cpython/pull/4044/files/f683657bd3bb7984ecc031e45b438d6dfb2f9cb4
https://github.com/ambv
ambvhttps://github.com/ambv
ce9e625https://github.com/python/cpython/commit/ce9e62544571e7ade7186697d5dd065fb4c5243f
Oct 19, 2017https://github.com/python/cpython/pull/4044#event-1301554861
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 19, 2017https://github.com/python/cpython/pull/4044#issuecomment-337978461
@ambvhttps://github.com/ambv
Please reload this pagehttps://github.com/python/cpython/pull/4044
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 19, 2017https://github.com/python/cpython/pull/4044#event-1301554905
miss-islingtonhttps://github.com/miss-islington
Oct 19, 2017 https://github.com/python/cpython/pull/4044#ref-commit-fee0475
https://github.com/ambv
https://github.com/miss-islington
bpo-31457: Don't omit inner process() calls with nested LogAdapte…https://github.com/miss-islington/cpython/commit/fee0475bf285a2886f98a7422ceef0dc3ac46525
fee0475https://github.com/miss-islington/cpython/commit/fee0475bf285a2886f98a7422ceef0dc3ac46525
pythonGH-4044https://github.com/python/cpython/pull/4044
212b590https://github.com/miss-islington/cpython/commit/212b590e118e3650b596917021ed9612a918180b
ce9e625https://github.com/miss-islington/cpython/commit/ce9e62544571e7ade7186697d5dd065fb4c5243f
Mariattahttps://github.com/Mariatta
Oct 19, 2017 https://github.com/python/cpython/pull/4044#ref-commit-4d9a8f2
https://github.com/miss-islington
https://github.com/Mariatta
bpo-31457https://bugs.python.org/issue?@action=redirect&bpo=31457
: Don't omit innerhttps://github.com/python/cpython/commit/4d9a8f22999de489ede9216ff983d4359d837760
process()https://github.com/python/cpython/commit/4d9a8f22999de489ede9216ff983d4359d837760
calls with nested LogAdapte…https://github.com/python/cpython/commit/4d9a8f22999de489ede9216ff983d4359d837760
4d9a8f2https://github.com/python/cpython/commit/4d9a8f22999de489ede9216ff983d4359d837760
GH-4044https://github.com/python/cpython/pull/4044
GH-4050https://github.com/python/cpython/pull/4050
212b590https://github.com/python/cpython/commit/212b590e118e3650b596917021ed9612a918180b
ce9e625https://github.com/python/cpython/commit/ce9e62544571e7ade7186697d5dd065fb4c5243f
https://github.com/ambv
ambvhttps://github.com/ambv
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Apr 22, 2018https://github.com/python/cpython/pull/4044#event-1588022500
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Apr 22, 2018https://github.com/python/cpython/pull/4044#issuecomment-383415259
@ambvhttps://github.com/ambv
Please reload this pagehttps://github.com/python/cpython/pull/4044
miss-islingtonhttps://github.com/miss-islington
Apr 22, 2018 https://github.com/python/cpython/pull/4044#ref-commit-c03380b
https://github.com/ambv
https://github.com/miss-islington
bpo-31457: Don't omit inner process() calls with nested LogAdapte…https://github.com/miss-islington/cpython/commit/c03380bba48b97e2613166f211ad1f5be78975fc
c03380bhttps://github.com/miss-islington/cpython/commit/c03380bba48b97e2613166f211ad1f5be78975fc
pythonGH-4044https://github.com/python/cpython/pull/4044
212b590https://github.com/miss-islington/cpython/commit/212b590e118e3650b596917021ed9612a918180b
ce9e625https://github.com/miss-islington/cpython/commit/ce9e62544571e7ade7186697d5dd065fb4c5243f
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 22, 2018https://github.com/python/cpython/pull/4044#issuecomment-383415268
GH-6568https://github.com/python/cpython/pull/6568
3.6 branchhttps://github.com/python/cpython/tree/3.6
Please reload this pagehttps://github.com/python/cpython/pull/4044
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Apr 22, 2018https://github.com/python/cpython/pull/4044#event-1588022668
ambvhttps://github.com/ambv
Apr 22, 2018 https://github.com/python/cpython/pull/4044#ref-commit-26c289d
https://github.com/miss-islington
https://github.com/ambv
bpo-31457https://bugs.python.org/issue?@action=redirect&bpo=31457
: Don't omit innerhttps://github.com/python/cpython/commit/26c289dd76ed07dbf37494bfa483c525f6828bd9
process()https://github.com/python/cpython/commit/26c289dd76ed07dbf37494bfa483c525f6828bd9
calls with nested LogAdapte…https://github.com/python/cpython/commit/26c289dd76ed07dbf37494bfa483c525f6828bd9
26c289dhttps://github.com/python/cpython/commit/26c289dd76ed07dbf37494bfa483c525f6828bd9
GH-4044https://github.com/python/cpython/pull/4044
#6568https://github.com/python/cpython/pull/6568
212b590https://github.com/python/cpython/commit/212b590e118e3650b596917021ed9612a918180b
ce9e625https://github.com/python/cpython/commit/ce9e62544571e7ade7186697d5dd065fb4c5243f
https://github.com/ambv
ambvhttps://github.com/ambv
July 12, 2021 11:23https://github.com/python/cpython/pull/4044#event-5006897419
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4044
https://github.com/vsajip
vsajip https://github.com/vsajip
https://github.com/python/cpython/pull/4044/files/f683657bd3bb7984ecc031e45b438d6dfb2f9cb4
Please reload this pagehttps://github.com/python/cpython/pull/4044
Please reload this pagehttps://github.com/python/cpython/pull/4044
https://github.com/ambv
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/vsajip
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.