René's URL Explorer Experiment


Title: bpo-31457: Make the `LoggerAdapter.manager` property settable by ambv · Pull Request #4042 · python/cpython · GitHub

Open Graph Title: bpo-31457: Make the `LoggerAdapter.manager` property settable by ambv · Pull Request #4042 · python/cpython

X Title: bpo-31457: Make the `LoggerAdapter.manager` property settable by ambv · Pull Request #4042 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Due to a bug in the initial fix, the setter was in fact creating a different property. This is now fixed. https://bugs.python.org/issue31457

X Description: Due to a bug in the initial fix, the setter was in fact creating a different property. This is now fixed. https://bugs.python.org/issue31457

Opengraph URL: https://github.com/python/cpython/pull/4042

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0050edf8-c318-0ba5-255c-be5067a81355
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEBE:23EEA8:2FB107:4329D6:6B006C96
html-safe-nonceaf951967b7b3e885ce11f75026a47f4c84bac92928f9f9171c48ccea83594872
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUJFOjIzRUVBODoyRkIxMDc6NDMyOUQ2OjZCMDA2Qzk2IiwidmlzaXRvcl9pZCI6IjIwMzk0MTkyMTg5MDYwODI0NTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3255aef14826dae2ba7f186b76c8bcab95f1998784de58a4d0f416902e80dff0
hovercard-subject-tagpull_request:147438138
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/4042/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ca559670f70a585bd52670c30070d603e284e53d7c19fe3480d2c6d03c3c05d1/python/cpython/pull/4042
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ca559670f70a585bd52670c30070d603e284e53d7c19fe3480d2c6d03c3c05d1/python/cpython/pull/4042
og:image:altDue to a bug in the initial fix, the setter was in fact creating a different property. This is now fixed. https://bugs.python.org/issue31457
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameambv
hostnamegithub.com
expected-hostnamegithub.com
None6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/4042#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4042
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4042
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/4042
Reloadhttps://github.com/python/cpython/pull/4042
Reloadhttps://github.com/python/cpython/pull/4042
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
ambvhttps://github.com/ambv
python:masterhttps://github.com/python/cpython/tree/master
ambv:loggeradapterfixfixhttps://github.com/ambv/cpython/tree/loggeradapterfixfix
Conversationhttps://github.com/python/cpython/pull/4042
Commits1 (1)https://github.com/python/cpython/pull/4042/commits
Checkshttps://github.com/python/cpython/pull/4042/checks
Files changedhttps://github.com/python/cpython/pull/4042/files
bpo-31457: Make the LoggerAdapter.manager property settablehttps://github.com/python/cpython/pull/4042#top
ambvhttps://github.com/ambv
python:masterhttps://github.com/python/cpython/tree/master
ambv:loggeradapterfixfixhttps://github.com/ambv/cpython/tree/loggeradapterfixfix
https://github.com/ambv
ambvhttps://github.com/ambv
Oct 18, 2017https://github.com/python/cpython/pull/4042#issue-266678533
Please reload this pagehttps://github.com/python/cpython/pull/4042
https://bugs.python.org/issue31457https://bugs.python.org/issue31457
Please reload this pagehttps://github.com/python/cpython/pull/4042
bpo-31457: Make the LoggerAdapter.manager property settablehttps://github.com/python/cpython/pull/4042/commits/0236b6f279262208a7cd3701a7a223f5e064eb69
0236b6fhttps://github.com/python/cpython/pull/4042/commits/0236b6f279262208a7cd3701a7a223f5e064eb69
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Oct 18, 2017https://github.com/python/cpython/pull/4042#event-1300141154
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 18, 2017https://github.com/python/cpython/pull/4042#event-1300141155
https://github.com/ambv
ambvhttps://github.com/ambv
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Oct 19, 2017https://github.com/python/cpython/pull/4042#event-1300173848
https://github.com/ambv
ambvhttps://github.com/ambv
0b6a118https://github.com/python/cpython/commit/0b6a118a45ac2eded1348fea6ed300d5651f7471
Oct 19, 2017https://github.com/python/cpython/pull/4042#event-1300173897
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 19, 2017https://github.com/python/cpython/pull/4042#issuecomment-337765223
@ambvhttps://github.com/ambv
Please reload this pagehttps://github.com/python/cpython/pull/4042
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 19, 2017https://github.com/python/cpython/pull/4042#event-1300173912
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 19, 2017https://github.com/python/cpython/pull/4042#issuecomment-337765393
GH-4043https://github.com/python/cpython/pull/4043
3.6 branchhttps://github.com/python/cpython/tree/3.6
Please reload this pagehttps://github.com/python/cpython/pull/4042
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Oct 19, 2017https://github.com/python/cpython/pull/4042#event-1300175196
miss-islingtonhttps://github.com/miss-islington
Oct 19, 2017 https://github.com/python/cpython/pull/4042#ref-commit-e0eb5b3
https://github.com/ambv
https://github.com/miss-islington
[3.6] bpo-31457: Make thehttps://github.com/miss-islington/cpython/commit/e0eb5b3341b34b2b01b97c01019a727220bddc91
LoggerAdapter.managerhttps://github.com/miss-islington/cpython/commit/e0eb5b3341b34b2b01b97c01019a727220bddc91
property settable (https://github.com/miss-islington/cpython/commit/e0eb5b3341b34b2b01b97c01019a727220bddc91
p…https://github.com/python/cpython/pull/4042
e0eb5b3https://github.com/miss-islington/cpython/commit/e0eb5b3341b34b2b01b97c01019a727220bddc91
…ythonGH-4042https://github.com/python/cpython/pull/4042
0b6a118https://github.com/miss-islington/cpython/commit/0b6a118a45ac2eded1348fea6ed300d5651f7471
ambvhttps://github.com/ambv
Oct 19, 2017 https://github.com/python/cpython/pull/4042#ref-commit-537ed75
https://github.com/miss-islington
https://github.com/ambv
[3.6]https://github.com/python/cpython/commit/537ed75291ed8a640887f199f98e2e5076ef87b6
bpo-31457https://bugs.python.org/issue?@action=redirect&bpo=31457
: Make thehttps://github.com/python/cpython/commit/537ed75291ed8a640887f199f98e2e5076ef87b6
LoggerAdapter.managerhttps://github.com/python/cpython/commit/537ed75291ed8a640887f199f98e2e5076ef87b6
property settable (https://github.com/python/cpython/commit/537ed75291ed8a640887f199f98e2e5076ef87b6
G…https://github.com/python/cpython/pull/4042
537ed75https://github.com/python/cpython/commit/537ed75291ed8a640887f199f98e2e5076ef87b6
…H-4042https://github.com/python/cpython/pull/4042
#4043https://github.com/python/cpython/pull/4043
0b6a118https://github.com/python/cpython/commit/0b6a118a45ac2eded1348fea6ed300d5651f7471
https://github.com/ambv
ambvhttps://github.com/ambv
July 12, 2021 11:23https://github.com/python/cpython/pull/4042#event-5006896802
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F4042
Please reload this pagehttps://github.com/python/cpython/pull/4042
Please reload this pagehttps://github.com/python/cpython/pull/4042
https://github.com/ambv
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.