René's URL Explorer Experiment


Title: bpo-31758: Prevent reference leaks in __setstate__() and __init__() of _elementtree.Element by orenmn · Pull Request #3956 · python/cpython · GitHub

Open Graph Title: bpo-31758: Prevent reference leaks in __setstate__() and __init__() of _elementtree.Element by orenmn · Pull Request #3956 · python/cpython

X Title: bpo-31758: Prevent reference leaks in __setstate__() and __init__() of _elementtree.Element by orenmn · Pull Request #3956 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: In addition, add a test to test_xml_etree_c, to make sure that the refleaks in __setstate__() are no more. https://bugs.python.org/issue31758

X Description: In addition, add a test to test_xml_etree_c, to make sure that the refleaks in __setstate__() are no more. https://bugs.python.org/issue31758

Opengraph URL: https://github.com/python/cpython/pull/3956

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3a35d067-612e-13c7-e12d-27317bd1e0d0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id888E:262ECC:1F9E052:2A876B1:6A598C4D
html-safe-nonceb357d7f17b307f27cea37f5bf54df389c2c141644214a6d0b1d3e3eba062992f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODhFOjI2MkVDQzoxRjlFMDUyOjJBODc2QjE6NkE1OThDNEQiLCJ2aXNpdG9yX2lkIjoiNDEyNTEzMjAxMjEzNjM1MzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacaaf5c8308460cae424c0a6da7596ee649888c471dc34642c7c34fb8947ec05e7
hovercard-subject-tagpull_request:146008187
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/3956/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7a32787d1f5eb58cccb6543042b8df9c83e16fff758b537e064b15383ca8c6e5/python/cpython/pull/3956
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7a32787d1f5eb58cccb6543042b8df9c83e16fff758b537e064b15383ca8c6e5/python/cpython/pull/3956
og:image:altIn addition, add a test to test_xml_etree_c, to make sure that the refleaks in __setstate__() are no more. https://bugs.python.org/issue31758
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameorenmn
hostnamegithub.com
expected-hostnamegithub.com
Nonea540949572872b935b393b36db38922db390ae71c859537d741b8f3eb7e545b5
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624bb50a7497aa346bef8cc3743af408a9ea10ca
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3956#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3956
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3956
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3956
Reloadhttps://github.com/python/cpython/pull/3956
Reloadhttps://github.com/python/cpython/pull/3956
Please reload this pagehttps://github.com/python/cpython/pull/3956
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3956
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
orenmnhttps://github.com/orenmn
python:masterhttps://github.com/python/cpython/tree/master
orenmn:bpo31758-fix-refleakshttps://github.com/orenmn/cpython/tree/bpo31758-fix-refleaks
Conversationhttps://github.com/python/cpython/pull/3956
Commits6 (6)https://github.com/python/cpython/pull/3956/commits
Checkshttps://github.com/python/cpython/pull/3956/checks
Files changedhttps://github.com/python/cpython/pull/3956/files
bpo-31758: Prevent reference leaks in __setstate__() and __init__() of _elementtree.Elementhttps://github.com/python/cpython/pull/3956#top
orenmnhttps://github.com/orenmn
python:masterhttps://github.com/python/cpython/tree/master
orenmn:bpo31758-fix-refleakshttps://github.com/orenmn/cpython/tree/bpo31758-fix-refleaks
https://github.com/orenmn
orenmnhttps://github.com/orenmn
Oct 11, 2017https://github.com/python/cpython/pull/3956#issue-264664546
Please reload this pagehttps://github.com/python/cpython/pull/3956
https://bugs.python.org/issue31758https://bugs.python.org/issue31758
Please reload this pagehttps://github.com/python/cpython/pull/3956
orenmnhttps://github.com/orenmn
October 11, 2017 19:35https://github.com/python/cpython/pull/3956#commits-pushed-9e6116a
https://github.com/orenmn
init commithttps://github.com/python/cpython/pull/3956/commits/9e6116af2b0f9a90c7920226d3a4988364243b2b
9e6116ahttps://github.com/python/cpython/pull/3956/commits/9e6116af2b0f9a90c7920226d3a4988364243b2b
https://github.com/orenmn
improve the test.https://github.com/python/cpython/pull/3956/commits/24a251b1efe1b5cdca8222e9ee59b2cbe6213f6c
24a251bhttps://github.com/python/cpython/pull/3956/commits/24a251b1efe1b5cdca8222e9ee59b2cbe6213f6c
https://github.com/orenmn
small fix to the testhttps://github.com/python/cpython/pull/3956/commits/eede715fbd3b220b5dd0497e07dbb0f2aac3971f
eede715https://github.com/python/cpython/pull/3956/commits/eede715fbd3b220b5dd0497e07dbb0f2aac3971f
https://github.com/orenmn
yet another fix to the testhttps://github.com/python/cpython/pull/3956/commits/505294d59ca6db948824165a6f94f9e2ab76afa8
505294dhttps://github.com/python/cpython/pull/3956/commits/505294d59ca6db948824165a6f94f9e2ab76afa8
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Oct 11, 2017https://github.com/python/cpython/pull/3956#event-1288645588
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 11, 2017https://github.com/python/cpython/pull/3956#event-1288645610
https://github.com/orenmn
run the test only if gettotalrefcount() is available.https://github.com/python/cpython/pull/3956/commits/cb064924875791d1ed433c7d7820fc9576ee9849
cb06492https://github.com/python/cpython/pull/3956/commits/cb064924875791d1ed433c7d7820fc9576ee9849
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 13, 2017 https://github.com/python/cpython/pull/3956#pullrequestreview-69231766
View reviewed changes https://github.com/python/cpython/pull/3956/files/cb064924875791d1ed433c7d7820fc9576ee9849
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/3956#pullrequestreview-69231766
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3956
Modules/_elementtree.chttps://github.com/python/cpython/pull/3956/files/cb064924875791d1ed433c7d7820fc9576ee9849#diff-72f80c6ac0294ae74c7b014c12bcf229e9df089ab19018ea35fd61c58fdb69ac
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 13, 2017https://github.com/python/cpython/pull/3956#discussion_r144557413
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3956
Modules/_elementtree.chttps://github.com/python/cpython/pull/3956/files/cb064924875791d1ed433c7d7820fc9576ee9849#diff-72f80c6ac0294ae74c7b014c12bcf229e9df089ab19018ea35fd61c58fdb69ac
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 13, 2017https://github.com/python/cpython/pull/3956#discussion_r144561987
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3956
orenmnhttps://github.com/orenmn
Oct 13, 2017https://github.com/python/cpython/pull/3956#discussion_r144580672
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3956
https://github.com/orenmn
orenmnhttps://github.com/orenmn
Oct 13, 2017https://github.com/python/cpython/pull/3956#issuecomment-336479667
Please reload this pagehttps://github.com/python/cpython/pull/3956
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 13, 2017https://github.com/python/cpython/pull/3956#event-1292473316
https://github.com/orenmn
orenmnhttps://github.com/orenmn
Oct 20, 2017 https://github.com/python/cpython/pull/3956#pullrequestreview-70800062
View reviewed changes https://github.com/python/cpython/pull/3956/files/cb064924875791d1ed433c7d7820fc9576ee9849
Lib/test/test_xml_etree_c.pyhttps://github.com/python/cpython/pull/3956/files/cb064924875791d1ed433c7d7820fc9576ee9849#diff-f6a8b0add3c473134d7ff3bebba5693bb02a850fcfa6e27800925f849e221285
orenmnhttps://github.com/orenmn
Oct 20, 2017https://github.com/python/cpython/pull/3956#discussion_r145927278
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3956
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Feb 26, 2018https://github.com/python/cpython/pull/3956#event-1492941036
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Feb 26, 2018https://github.com/python/cpython/pull/3956#event-1492941601
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Jan 10, 2019https://github.com/python/cpython/pull/3956#event-2066287342
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jan 10, 2019https://github.com/python/cpython/pull/3956#issuecomment-453151264
https://devguide.python.org/#status-of-python-brancheshttps://devguide.python.org/#status-of-python-branches
Please reload this pagehttps://github.com/python/cpython/pull/3956
https://github.com/scoder
Merge branch 'master' into bpo31758-fix-refleakshttps://github.com/python/cpython/pull/3956/commits/d6d575e105b1d4094959f2ce39b00217eaaa0007
d6d575ehttps://github.com/python/cpython/pull/3956/commits/d6d575e105b1d4094959f2ce39b00217eaaa0007
https://github.com/scoder
scoderhttps://github.com/scoder
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Sep 10, 2019https://github.com/python/cpython/pull/3956#event-2622627038
https://github.com/scoder
scoderhttps://github.com/scoder
Sep 10, 2019https://github.com/python/cpython/pull/3956#issuecomment-529983172
@orenmnhttps://github.com/orenmn
Please reload this pagehttps://github.com/python/cpython/pull/3956
https://github.com/orenmn
orenmnhttps://github.com/orenmn
Sep 10, 2019https://github.com/python/cpython/pull/3956#issuecomment-530019609
@orenmnhttps://github.com/orenmn
Please reload this pagehttps://github.com/python/cpython/pull/3956
https://github.com/csabella
csabellahttps://github.com/csabella
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Feb 4, 2020https://github.com/python/cpython/pull/3956#event-3004406235
https://github.com/csabella
csabellahttps://github.com/csabella
May 27, 2020https://github.com/python/cpython/pull/3956#issuecomment-634628189
#3997https://github.com/python/cpython/pull/3997
Please reload this pagehttps://github.com/python/cpython/pull/3956
https://github.com/csabella
csabellahttps://github.com/csabella
May 27, 2020https://github.com/python/cpython/pull/3956#event-3377891353
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 29, 2024https://github.com/python/cpython/pull/3956#event-14444829291
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3956
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/3956/files/cb064924875791d1ed433c7d7820fc9576ee9849
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/3956
https://github.com/orenmn
https://github.com/vstinner
https://github.com/scoder
https://github.com/csabella
https://github.com/serhiy-storchaka
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.