René's URL Explorer Experiment


Title: bpo-28129: fix ctypes crashes by orenmn · Pull Request #386 · python/cpython · GitHub

Open Graph Title: bpo-28129: fix ctypes crashes by orenmn · Pull Request #386 · python/cpython

X Title: bpo-28129: fix ctypes crashes by orenmn · Pull Request #386 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: bpo-28129: replace some assertion failures in ctypes (mentioned in http://bugs.python.org/issue28129) with if statements add tests to verify these changes

X Description: bpo-28129: replace some assertion failures in ctypes (mentioned in http://bugs.python.org/issue28129) with if statements add tests to verify these changes

Opengraph URL: https://github.com/python/cpython/pull/386

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:771cf81c-2e65-97c6-ed85-1622edf30a8c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8BA:322E35:4697093:63ED531:6A4FC50A
html-safe-nonce18528e1f4032eac09c73882fb2cf176398064160dad72ddb6d2d54213e9210f9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEJBOjMyMkUzNTo0Njk3MDkzOjYzRUQ1MzE6NkE0RkM1MEEiLCJ2aXNpdG9yX2lkIjoiNTM1NDAxNjU0MTE3NTE3MDMxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdc2e700298387336f27265cb103f443dcc987522bffdf0461283685aa88f7c05
hovercard-subject-tagpull_request:108657183
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/386/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4116f50a926b391b3592485df02455d5977ff9b5b1e1294417d9b45e0361b9a5/python/cpython/pull/386
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4116f50a926b391b3592485df02455d5977ff9b5b1e1294417d9b45e0361b9a5/python/cpython/pull/386
og:image:altbpo-28129: replace some assertion failures in ctypes (mentioned in http://bugs.python.org/issue28129) with if statements add tests to verify these changes
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameorenmn
hostnamegithub.com
expected-hostnamegithub.com
None7d8f8209b188a80e19a6957836ab9229715797be5db1a04163963c674ccc33f6
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseea848e83cf3bf3613dd7b13d52965a684fd23ec5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/386#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F386
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F386
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/386
Reloadhttps://github.com/python/cpython/pull/386
Reloadhttps://github.com/python/cpython/pull/386
Please reload this pagehttps://github.com/python/cpython/pull/386
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/386
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
orenmn:bpo28129-fix-ctypes-crasheshttps://github.com/orenmn/cpython/tree/bpo28129-fix-ctypes-crashes
Conversationhttps://github.com/python/cpython/pull/386
Commits6 (6)https://github.com/python/cpython/pull/386/commits
Checkshttps://github.com/python/cpython/pull/386/checks
Files changedhttps://github.com/python/cpython/pull/386/files
bpo-28129: fix ctypes crasheshttps://github.com/python/cpython/pull/386#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
orenmn:bpo28129-fix-ctypes-crasheshttps://github.com/orenmn/cpython/tree/bpo28129-fix-ctypes-crashes
https://github.com/orenmn
orenmnhttps://github.com/orenmn
Mar 1, 2017https://github.com/python/cpython/pull/386#issue-211247361
bpo-28129https://bugs.python.org/issue?@action=redirect&bpo=28129
http://bugs.python.org/issue28129http://bugs.python.org/issue28129
Please reload this pagehttps://github.com/python/cpython/pull/386
February 28, 2017 18:18https://github.com/python/cpython/pull/386#commits-pushed-66074b5
init commit, with initial tests for from_param and fields __set__ and…https://github.com/python/cpython/pull/386/commits/66074b5cd9b5980113c5b74d29c3a8d786661bd1
66074b5https://github.com/python/cpython/pull/386/commits/66074b5cd9b5980113c5b74d29c3a8d786661bd1
https://github.com/orenmn
added the rest of tests and patches. probably only a first draft.https://github.com/python/cpython/pull/386/commits/365a9c479d2076172b9411988267eb17ddcf9ba5
365a9c4https://github.com/python/cpython/pull/386/commits/365a9c479d2076172b9411988267eb17ddcf9ba5
https://github.com/orenmn
removed trailing spaceshttps://github.com/python/cpython/pull/386/commits/c9e0ddf87d4a602fe4e1a57090fbd225714485d0
c9e0ddfhttps://github.com/python/cpython/pull/386/commits/c9e0ddf87d4a602fe4e1a57090fbd225714485d0
https://github.com/orenmn
Merge branch 'master' ofhttps://github.com/python/cpython/pull/386/commits/7cbe79cb4016f3b83df97926daa7c9e9bf1471de
https://github.com/python/cpythonhttps://github.com/python/cpython
into bpo28…https://github.com/python/cpython/pull/386/commits/7cbe79cb4016f3b83df97926daa7c9e9bf1471de
7cbe79chttps://github.com/python/cpython/pull/386/commits/7cbe79cb4016f3b83df97926daa7c9e9bf1471de
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
Mar 1, 2017https://github.com/python/cpython/pull/386#issuecomment-283511531
PSF contributor agreementhttps://www.python.org/psf/contrib/contrib-form/
bugs.python.orghttp://bugs.python.org/
create onehttp://bugs.python.org/user?@template=register
"Your Details" at b.p.ohttps://cloud.githubusercontent.com/assets/2680980/23276970/d14a380c-f9d1-11e6-883d-e13b6b211239.png
PSF contributor agreementhttps://www.python.org/psf/contrib/contrib-form/
bugs.python.orghttps://bugs.python.org/
Please reload this pagehttps://github.com/python/cpython/pull/386
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Mar 1, 2017https://github.com/python/cpython/pull/386#event-982828911
https://github.com/orenmn
orenmnhttps://github.com/orenmn
Mar 2, 2017https://github.com/python/cpython/pull/386#issuecomment-283513109
https://www.python.org/psf/contrib/contrib-form/https://www.python.org/psf/contrib/contrib-form/
https://cloud.githubusercontent.com/assets/2680980/23276970/d14a380c-f9d1-11e6-883d-e13b6b211239.pnghttps://cloud.githubusercontent.com/assets/2680980/23276970/d14a380c-f9d1-11e6-883d-e13b6b211239.png
https://www.python.org/psf/contrib/contrib-form/https://www.python.org/psf/contrib/contrib-form/
#386 (comment)https://github.com/python/cpython/pull/386#issuecomment-283511531
https://github.com/notifications/unsubscribe-auth/AJrT9IW4Wcrd9VKQ0s6gIQ_WCeW-_1hmks5rhgXegaJpZM4MQXoDhttps://github.com/notifications/unsubscribe-auth/AJrT9IW4Wcrd9VKQ0s6gIQ_WCeW-_1hmks5rhgXegaJpZM4MQXoD
…https://github.com/python/cpython/pull/386
Please reload this pagehttps://github.com/python/cpython/pull/386
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Mar 2, 2017https://github.com/python/cpython/pull/386#event-983394535
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Mar 2, 2017https://github.com/python/cpython/pull/386#event-983394560
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 2, 2017 https://github.com/python/cpython/pull/386#pullrequestreview-24695461
View reviewed changes https://github.com/python/cpython/pull/386/files/7cbe79cb4016f3b83df97926daa7c9e9bf1471de
Modules/_ctypes/cfield.chttps://github.com/python/cpython/pull/386/files/7cbe79cb4016f3b83df97926daa7c9e9bf1471de#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
vstinnerhttps://github.com/vstinner
Mar 2, 2017https://github.com/python/cpython/pull/386#discussion_r103891803
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/386
Modules/_ctypes/cfield.chttps://github.com/python/cpython/pull/386/files/7cbe79cb4016f3b83df97926daa7c9e9bf1471de#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
vstinnerhttps://github.com/vstinner
Mar 2, 2017https://github.com/python/cpython/pull/386#discussion_r103891820
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/386
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 2, 2017https://github.com/python/cpython/pull/386#issuecomment-283614714
Please reload this pagehttps://github.com/python/cpython/pull/386
https://github.com/orenmn
replace ctype with ctypes in error messageshttps://github.com/python/cpython/pull/386/commits/6f0029c0b1f61c18c8cc45185cefaa60ae5bd1e7
6f0029chttps://github.com/python/cpython/pull/386/commits/6f0029c0b1f61c18c8cc45185cefaa60ae5bd1e7
https://github.com/orenmn
orenmnhttps://github.com/orenmn
Mar 2, 2017https://github.com/python/cpython/pull/386#issuecomment-283623393
Please reload this pagehttps://github.com/python/cpython/pull/386
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 2, 2017https://github.com/python/cpython/pull/386#issuecomment-283633667
Please reload this pagehttps://github.com/python/cpython/pull/386
https://github.com/orenmn
orenmnhttps://github.com/orenmn
Mar 2, 2017https://github.com/python/cpython/pull/386#issuecomment-283657290
https://docs.python.org/3.7/library/ctypes.htmlhttps://docs.python.org/3.7/library/ctypes.html
Please reload this pagehttps://github.com/python/cpython/pull/386
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 2, 2017https://github.com/python/cpython/pull/386#issuecomment-283662750
Please reload this pagehttps://github.com/python/cpython/pull/386
https://github.com/orenmn
change back from ctypes instance to ctype instancehttps://github.com/python/cpython/pull/386/commits/bb75d81897084d4597f96d570a5d8c38e7bb2b0c
bb75d81https://github.com/python/cpython/pull/386/commits/bb75d81897084d4597f96d570a5d8c38e7bb2b0c
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 2, 2017 https://github.com/python/cpython/pull/386#pullrequestreview-24753657
View reviewed changes https://github.com/python/cpython/pull/386/files/bb75d81897084d4597f96d570a5d8c38e7bb2b0c
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
1bea762https://github.com/python/cpython/commit/1bea762d9ec823544c530d567330a47f64d93d4f
Mar 2, 2017https://github.com/python/cpython/pull/386#event-984084638
https://github.com/tiran
tiranhttps://github.com/tiran
Mar 2, 2017https://github.com/python/cpython/pull/386#issuecomment-283796679
#403https://github.com/python/cpython/pull/403
Please reload this pagehttps://github.com/python/cpython/pull/386
vstinnerhttps://github.com/vstinner
Sep 28, 2017 https://github.com/python/cpython/pull/386#ref-commit-8b83687
https://github.com/vstinner
bpo-28129https://bugs.python.org/issue?@action=redirect&bpo=28129
: fix ctypes crashes (https://github.com/python/cpython/commit/8b83687bdf66d2d10afb78e46bcede399deaefde
#386https://github.com/python/cpython/pull/386
) (https://github.com/python/cpython/commit/8b83687bdf66d2d10afb78e46bcede399deaefde
#3800https://github.com/python/cpython/pull/3800
)https://github.com/python/cpython/commit/8b83687bdf66d2d10afb78e46bcede399deaefde
8b83687https://github.com/python/cpython/commit/8b83687bdf66d2d10afb78e46bcede399deaefde
1bea762https://github.com/python/cpython/commit/1bea762d9ec823544c530d567330a47f64d93d4f
vstinnerhttps://github.com/vstinner
Sep 28, 2017 https://github.com/python/cpython/pull/386#ref-commit-7d6ddb9
https://github.com/vstinner
bpo-28129https://bugs.python.org/issue?@action=redirect&bpo=28129
: fix ctypes crashes (https://github.com/python/cpython/commit/7d6ddb96b34b94c1cbdf95baa94492c48426404e
#386https://github.com/python/cpython/pull/386
) (https://github.com/python/cpython/commit/7d6ddb96b34b94c1cbdf95baa94492c48426404e
#3799https://github.com/python/cpython/pull/3799
)https://github.com/python/cpython/commit/7d6ddb96b34b94c1cbdf95baa94492c48426404e
7d6ddb9https://github.com/python/cpython/commit/7d6ddb96b34b94c1cbdf95baa94492c48426404e
1bea762https://github.com/python/cpython/commit/1bea762d9ec823544c530d567330a47f64d93d4f
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F386
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/386/files/bb75d81897084d4597f96d570a5d8c38e7bb2b0c
Please reload this pagehttps://github.com/python/cpython/pull/386
https://github.com/orenmn
https://github.com/the-knights-who-say-ni
https://github.com/vstinner
https://github.com/tiran
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.