René's URL Explorer Experiment


Title: bpo-31158: Fix nondeterministic read in test_pty by diekmann · Pull Request #3808 · python/cpython · GitHub

Open Graph Title: bpo-31158: Fix nondeterministic read in test_pty by diekmann · Pull Request #3808 · python/cpython

X Title: bpo-31158: Fix nondeterministic read in test_pty by diekmann · Pull Request #3808 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Sometimes, the test suite fails in test_pty.test_basic() https://bugs.python.org/issue31158 Acks to @Haypo !! https://bugs.python.org/issue31158

X Description: Sometimes, the test suite fails in test_pty.test_basic() https://bugs.python.org/issue31158 Acks to @Haypo !! https://bugs.python.org/issue31158

Opengraph URL: https://github.com/python/cpython/pull/3808

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c3555f70-00e7-70ae-aa47-dc85c7bb98e4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5F4:37E3D3:42BD127:5E3AAEC:6A4FB6C1
html-safe-nonce0695524084dd361769bca0a74078bbd523a47ce2ff8f4cc159a1acf0f99ccf50
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUY0OjM3RTNEMzo0MkJEMTI3OjVFM0FBRUM6NkE0RkI2QzEiLCJ2aXNpdG9yX2lkIjoiMTA1MjcyMjAxNDE5MTQyODQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb27de387f607c24f9b83c4ec8860445296a27c56814f0ed29c349da24a7cdc62
hovercard-subject-tagpull_request:143697663
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/3808/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6251884b090786e7d62e644209860b00f3838c5d802290baa2380d6e140e98eb/python/cpython/pull/3808
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6251884b090786e7d62e644209860b00f3838c5d802290baa2380d6e140e98eb/python/cpython/pull/3808
og:image:altSometimes, the test suite fails in test_pty.test_basic() https://bugs.python.org/issue31158 Acks to @Haypo !! https://bugs.python.org/issue31158
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamediekmann
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3808#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3808
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3808
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3808
Reloadhttps://github.com/python/cpython/pull/3808
Reloadhttps://github.com/python/cpython/pull/3808
Please reload this pagehttps://github.com/python/cpython/pull/3808
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3808
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
diekmann:fix-issue-31158https://github.com/diekmann/cpython/tree/fix-issue-31158
Conversationhttps://github.com/python/cpython/pull/3808
Commits3 (3)https://github.com/python/cpython/pull/3808/commits
Checkshttps://github.com/python/cpython/pull/3808/checks
Files changedhttps://github.com/python/cpython/pull/3808/files
bpo-31158: Fix nondeterministic read in test_ptyhttps://github.com/python/cpython/pull/3808#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
diekmann:fix-issue-31158https://github.com/diekmann/cpython/tree/fix-issue-31158
https://github.com/diekmann
diekmannhttps://github.com/diekmann
Sep 28, 2017https://github.com/python/cpython/pull/3808#issue-261383763
Please reload this pagehttps://github.com/python/cpython/pull/3808
https://bugs.python.org/issue31158https://bugs.python.org/issue31158
@Haypohttps://github.com/Haypo
https://bugs.python.org/issue31158https://bugs.python.org/issue31158
Please reload this pagehttps://github.com/python/cpython/pull/3808
https://github.com/diekmann
bpo-31158: Fix nondeterministic read in test_ptyhttps://github.com/python/cpython/pull/3808/commits/5ad0e356e04ae88eed4c80d78e01891b6ef1d408
5ad0e35https://github.com/python/cpython/pull/3808/commits/5ad0e356e04ae88eed4c80d78e01891b6ef1d408
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 28, 2017https://github.com/python/cpython/pull/3808#event-1270160812
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 28, 2017https://github.com/python/cpython/pull/3808#event-1270160813
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Sep 28, 2017https://github.com/python/cpython/pull/3808#issuecomment-332895725
Please reload this pagehttps://github.com/python/cpython/pull/3808
https://github.com/diekmann
diekmannhttps://github.com/diekmann
Sep 28, 2017https://github.com/python/cpython/pull/3808#issuecomment-332903088
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/3808
https://github.com/diekmann
Reuse existing readline implementation from io.https://github.com/python/cpython/pull/3808/commits/29ca53abef5383e4e64a337fe279bebed36f9526
29ca53ahttps://github.com/python/cpython/pull/3808/commits/29ca53abef5383e4e64a337fe279bebed36f9526
@pitrouhttps://github.com/pitrou
https://github.com/diekmann
diekmannhttps://github.com/diekmann
Sep 28, 2017https://github.com/python/cpython/pull/3808#issuecomment-332919640
Please reload this pagehttps://github.com/python/cpython/pull/3808
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Sep 28, 2017 https://github.com/python/cpython/pull/3808#pullrequestreview-65951557
View reviewed changes https://github.com/python/cpython/pull/3808/files/29ca53abef5383e4e64a337fe279bebed36f9526
Lib/test/test_pty.pyhttps://github.com/python/cpython/pull/3808/files/29ca53abef5383e4e64a337fe279bebed36f9526#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
pitrouhttps://github.com/pitrou
Sep 28, 2017https://github.com/python/cpython/pull/3808#discussion_r141695906
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3808
diekmannhttps://github.com/diekmann
Sep 28, 2017https://github.com/python/cpython/pull/3808#discussion_r141696862
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3808
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 28, 2017https://github.com/python/cpython/pull/3808#event-1270338358
https://github.com/diekmann
Updated commenthttps://github.com/python/cpython/pull/3808/commits/4f8137bb7ae41922ea8698a98c87823897eb48f5
4f8137bhttps://github.com/python/cpython/pull/3808/commits/4f8137bb7ae41922ea8698a98c87823897eb48f5
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Oct 2, 2017https://github.com/python/cpython/pull/3808#event-1273690670
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
e6f62f6https://github.com/python/cpython/commit/e6f62f69f07892b993910ff03c9db3ffa5cb9ca5
Oct 2, 2017https://github.com/python/cpython/pull/3808#event-1273690866
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Oct 2, 2017https://github.com/python/cpython/pull/3808#event-1273691743
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 2, 2017https://github.com/python/cpython/pull/3808#issuecomment-333487071
@diekmannhttps://github.com/diekmann
@Haypohttps://github.com/Haypo
Please reload this pagehttps://github.com/python/cpython/pull/3808
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 2, 2017https://github.com/python/cpython/pull/3808#issuecomment-333487155
GH-3852https://github.com/python/cpython/pull/3852
3.6 branchhttps://github.com/python/cpython/tree/3.6
Please reload this pagehttps://github.com/python/cpython/pull/3808
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Oct 2, 2017https://github.com/python/cpython/pull/3808#event-1273692352
miss-islingtonhttps://github.com/miss-islington
Oct 2, 2017 https://github.com/python/cpython/pull/3808#ref-commit-124a34a
https://github.com/diekmann
https://github.com/miss-islington
[3.6] bpo-31158: Fix nondeterministic read in test_pty (https://github.com/miss-islington/cpython/commit/124a34afa166b29aad251a04cf0c43f9374369b0
pythonGH-3808https://github.com/python/cpython/pull/3808
)https://github.com/miss-islington/cpython/commit/124a34afa166b29aad251a04cf0c43f9374369b0
124a34ahttps://github.com/miss-islington/cpython/commit/124a34afa166b29aad251a04cf0c43f9374369b0
@pitrouhttps://github.com/pitrou
e6f62f6https://github.com/miss-islington/cpython/commit/e6f62f69f07892b993910ff03c9db3ffa5cb9ca5
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 2, 2017https://github.com/python/cpython/pull/3808#issuecomment-333487492
Please reload this pagehttps://github.com/python/cpython/pull/3808
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 2, 2017 https://github.com/python/cpython/pull/3808#ref-pullrequest-261339669
bpo-31158: Fix test_pty.test_basic() #3802 https://github.com/python/cpython/pull/3802
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 2, 2017https://github.com/python/cpython/pull/3808#issuecomment-333488015
Please reload this pagehttps://github.com/python/cpython/pull/3808
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 2, 2017https://github.com/python/cpython/pull/3808#issuecomment-333488683
#3853https://github.com/python/cpython/pull/3853
Please reload this pagehttps://github.com/python/cpython/pull/3808
vstinnerhttps://github.com/vstinner
Oct 2, 2017 https://github.com/python/cpython/pull/3808#ref-commit-66fb5ef
https://github.com/miss-islington
https://github.com/vstinner
[3.6]https://github.com/python/cpython/commit/66fb5ef3bb9e36187a0e5052dfd99899447df671
bpo-31158https://bugs.python.org/issue?@action=redirect&bpo=31158
: Fix nondeterministic read in test_pty (https://github.com/python/cpython/commit/66fb5ef3bb9e36187a0e5052dfd99899447df671
GH-3808https://github.com/python/cpython/pull/3808
) (https://github.com/python/cpython/commit/66fb5ef3bb9e36187a0e5052dfd99899447df671
GH-…https://github.com/python/cpython/pull/3852
66fb5efhttps://github.com/python/cpython/commit/66fb5ef3bb9e36187a0e5052dfd99899447df671
…3852https://github.com/python/cpython/pull/3852
e6f62f6https://github.com/python/cpython/commit/e6f62f69f07892b993910ff03c9db3ffa5cb9ca5
vstinnerhttps://github.com/vstinner
Oct 2, 2017 https://github.com/python/cpython/pull/3808#ref-commit-20cbc1d
https://github.com/vstinner
bpo-31158https://bugs.python.org/issue?@action=redirect&bpo=31158
: Fix nondeterministic read in test_pty (https://github.com/python/cpython/commit/20cbc1d29facead32c2da06c81a09af0e057015c
#3808https://github.com/python/cpython/pull/3808
) (https://github.com/python/cpython/commit/20cbc1d29facead32c2da06c81a09af0e057015c
#3853https://github.com/python/cpython/pull/3853
)https://github.com/python/cpython/commit/20cbc1d29facead32c2da06c81a09af0e057015c
20cbc1dhttps://github.com/python/cpython/commit/20cbc1d29facead32c2da06c81a09af0e057015c
e6f62f6https://github.com/python/cpython/commit/e6f62f69f07892b993910ff03c9db3ffa5cb9ca5
https://github.com/Mariatta
Mariattahttps://github.com/Mariatta
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 4, 2017https://github.com/python/cpython/pull/3808#event-1278541619
https://github.com/diekmann
diekmannhttps://github.com/diekmann
Oct 29, 2017 https://github.com/python/cpython/pull/3808#ref-pullrequest-246385862
bpo-29070: Integration tests for pty module with patch from bpo-26228 #2932 https://github.com/python/cpython/pull/2932
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3808
https://github.com/pitrou
pitrou https://github.com/pitrou
https://github.com/python/cpython/pull/3808/files/29ca53abef5383e4e64a337fe279bebed36f9526
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/3808
https://github.com/diekmann
https://github.com/pitrou
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/vstinner
https://github.com/Mariatta
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.