René's URL Explorer Experiment


Title: bpo-25351: avoid activate failure on strict shells by ssbarnea · Pull Request #3804 · python/cpython · GitHub

Open Graph Title: bpo-25351: avoid activate failure on strict shells by ssbarnea · Pull Request #3804 · python/cpython

X Title: bpo-25351: avoid activate failure on strict shells by ssbarnea · Pull Request #3804 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Allows usage of activate on strict shells (set -uoe pipefail) https://bugs.python.org/issue25351

X Description: Allows usage of activate on strict shells (set -uoe pipefail) https://bugs.python.org/issue25351

Opengraph URL: https://github.com/python/cpython/pull/3804

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:614fb91c-9d62-d751-f373-d13de7b9801a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA94:16BCD3:5E76848:855886B:6A4FC5C9
html-safe-nonce6dc1357834ecfc0d98dccfa14a35b680c92267e92a5b92df8180268bd728917a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTk0OjE2QkNEMzo1RTc2ODQ4Ojg1NTg4NkI6NkE0RkM1QzkiLCJ2aXNpdG9yX2lkIjoiMzIyNjQ4MjQyMzU1OTYwMzY1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4a1fad5572239147b2ccfffa88ac1185accbe6e92515911aff35549c938debbb
hovercard-subject-tagpull_request:143675706
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/3804/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/63d8f43ed8d8bd45265a4c8081e3ce6305b7d6a08160d4b3f1280918cc533662/python/cpython/pull/3804
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/63d8f43ed8d8bd45265a4c8081e3ce6305b7d6a08160d4b3f1280918cc533662/python/cpython/pull/3804
og:image:altAllows usage of activate on strict shells (set -uoe pipefail) https://bugs.python.org/issue25351
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamessbarnea
hostnamegithub.com
expected-hostnamegithub.com
None60b2ae4c725f51e2dac275d0ac5e9233e5967a61cdfaebd732f63da67ff1b71c
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release06fb64e1cb36b9a7a2e3f0e6c14af40ef9f439d4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3804#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3804
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3804
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3804
Reloadhttps://github.com/python/cpython/pull/3804
Reloadhttps://github.com/python/cpython/pull/3804
Please reload this pagehttps://github.com/python/cpython/pull/3804
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3804
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vsajiphttps://github.com/vsajip
python:masterhttps://github.com/python/cpython/tree/master
ssbarnea:masterhttps://github.com/ssbarnea/cpython/tree/master
Conversationhttps://github.com/python/cpython/pull/3804
Commits1 (1)https://github.com/python/cpython/pull/3804/commits
Checkshttps://github.com/python/cpython/pull/3804/checks
Files changedhttps://github.com/python/cpython/pull/3804/files
bpo-25351: avoid activate failure on strict shellshttps://github.com/python/cpython/pull/3804#top
vsajiphttps://github.com/vsajip
python:masterhttps://github.com/python/cpython/tree/master
ssbarnea:masterhttps://github.com/ssbarnea/cpython/tree/master
https://github.com/ssbarnea
ssbarneahttps://github.com/ssbarnea
Sep 28, 2017https://github.com/python/cpython/pull/3804#issue-261354934
Please reload this pagehttps://github.com/python/cpython/pull/3804
https://bugs.python.org/issue25351https://bugs.python.org/issue25351
Please reload this pagehttps://github.com/python/cpython/pull/3804
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Sep 28, 2017https://github.com/python/cpython/pull/3804#event-1269996734
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 28, 2017https://github.com/python/cpython/pull/3804#event-1269996735
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
Sep 28, 2017https://github.com/python/cpython/pull/3804#issuecomment-332867497
PSF contributor agreementhttps://www.python.org/psf/contrib/contrib-form/
bugs.python.orghttp://bugs.python.org/
the steps outlined in the CPython devguidehttps://devguide.python.org/pullrequest/#licensing
Please reload this pagehttps://github.com/python/cpython/pull/3804
https://github.com/ssbarnea
ssbarneahttps://github.com/ssbarnea
force-pushedhttps://github.com/python/cpython/compare/63cf171c7912c3d0011fe04905979d78cc637edd..c13591dcc591d20e65dd2be07336ffaa6b7b94bd
63cf171https://github.com/python/cpython/commit/63cf171c7912c3d0011fe04905979d78cc637edd
c13591dhttps://github.com/python/cpython/commit/c13591dcc591d20e65dd2be07336ffaa6b7b94bd
Compare https://github.com/python/cpython/compare/63cf171c7912c3d0011fe04905979d78cc637edd..c13591dcc591d20e65dd2be07336ffaa6b7b94bd
September 28, 2017 16:01https://github.com/python/cpython/pull/3804#event-1270102401
https://github.com/ssbarnea
ssbarneahttps://github.com/ssbarnea
Sep 28, 2017https://github.com/python/cpython/pull/3804#event-1270103176
https://github.com/ssbarnea
ssbarneahttps://github.com/ssbarnea
force-pushedhttps://github.com/python/cpython/compare/c13591dcc591d20e65dd2be07336ffaa6b7b94bd..52210c2f361341fc5646ad75991883e0eec3294c
c13591dhttps://github.com/python/cpython/commit/c13591dcc591d20e65dd2be07336ffaa6b7b94bd
52210c2https://github.com/python/cpython/commit/52210c2f361341fc5646ad75991883e0eec3294c
Compare https://github.com/python/cpython/compare/c13591dcc591d20e65dd2be07336ffaa6b7b94bd..52210c2f361341fc5646ad75991883e0eec3294c
September 28, 2017 16:48https://github.com/python/cpython/pull/3804#event-1270184768
https://github.com/ssbarnea
bpo-25351: avoid activate failure on strict shellshttps://github.com/python/cpython/pull/3804/commits/3bedb570a32bf8a606ad9a8a318623749b2db6b3
3bedb57https://github.com/python/cpython/pull/3804/commits/3bedb570a32bf8a606ad9a8a318623749b2db6b3
https://github.com/ssbarnea
ssbarneahttps://github.com/ssbarnea
force-pushedhttps://github.com/python/cpython/compare/52210c2f361341fc5646ad75991883e0eec3294c..3bedb570a32bf8a606ad9a8a318623749b2db6b3
52210c2https://github.com/python/cpython/commit/52210c2f361341fc5646ad75991883e0eec3294c
3bedb57https://github.com/python/cpython/commit/3bedb570a32bf8a606ad9a8a318623749b2db6b3
Compare https://github.com/python/cpython/compare/52210c2f361341fc5646ad75991883e0eec3294c..3bedb570a32bf8a606ad9a8a318623749b2db6b3
September 28, 2017 22:12https://github.com/python/cpython/pull/3804#event-1270708676
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Sep 28, 2017https://github.com/python/cpython/pull/3804#event-1270708710
https://github.com/ssbarnea
ssbarneahttps://github.com/ssbarnea
Sep 29, 2017 https://github.com/python/cpython/pull/3804#ref-issue-215016854
activate may fails due to unbound variables when run with set -eu pypa/virtualenv#1029 https://github.com/pypa/virtualenv/issues/1029
https://github.com/vsajip
vsajiphttps://github.com/vsajip
90f1d98https://github.com/python/cpython/commit/90f1d989594f3340c5ffaa2cf9cef1876ac6bb89
Sep 29, 2017https://github.com/python/cpython/pull/3804#event-1271496179
https://github.com/vsajip
vsajiphttps://github.com/vsajip
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 29, 2017https://github.com/python/cpython/pull/3804#event-1271496872
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Sep 29, 2017https://github.com/python/cpython/pull/3804#event-1271512854
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 29, 2017https://github.com/python/cpython/pull/3804#issuecomment-333107864
@ssbarneahttps://github.com/ssbarnea
@vsajiphttps://github.com/vsajip
Please reload this pagehttps://github.com/python/cpython/pull/3804
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 29, 2017https://github.com/python/cpython/pull/3804#issuecomment-333107901
GH-3820https://github.com/python/cpython/pull/3820
3.6 branchhttps://github.com/python/cpython/tree/3.6
Please reload this pagehttps://github.com/python/cpython/pull/3804
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Sep 29, 2017https://github.com/python/cpython/pull/3804#event-1271513175
miss-islingtonhttps://github.com/miss-islington
Sep 29, 2017 https://github.com/python/cpython/pull/3804#ref-commit-28b58b9
https://github.com/ssbarnea
https://github.com/miss-islington
[3.6] bpo-25351: avoid activate failure on strict shells (https://github.com/miss-islington/cpython/commit/28b58b995e88a784b30696970187abf05f3b8a66
pythonGH-3804https://github.com/python/cpython/pull/3804
)https://github.com/miss-islington/cpython/commit/28b58b995e88a784b30696970187abf05f3b8a66
28b58b9https://github.com/miss-islington/cpython/commit/28b58b995e88a784b30696970187abf05f3b8a66
90f1d98https://github.com/miss-islington/cpython/commit/90f1d989594f3340c5ffaa2cf9cef1876ac6bb89
vstinnerhttps://github.com/vstinner
Sep 29, 2017 https://github.com/python/cpython/pull/3804#ref-commit-a5610e0
https://github.com/miss-islington
https://github.com/vstinner
[3.6]https://github.com/python/cpython/commit/a5610e07460a8df4b0923a32d37234cd535ec952
bpo-25351https://bugs.python.org/issue?@action=redirect&bpo=25351
: avoid activate failure on strict shells (https://github.com/python/cpython/commit/a5610e07460a8df4b0923a32d37234cd535ec952
GH-3804https://github.com/python/cpython/pull/3804
) (https://github.com/python/cpython/commit/a5610e07460a8df4b0923a32d37234cd535ec952
#…https://github.com/python/cpython/pull/3820
a5610e0https://github.com/python/cpython/commit/a5610e07460a8df4b0923a32d37234cd535ec952
…3820https://github.com/python/cpython/pull/3820
90f1d98https://github.com/python/cpython/commit/90f1d989594f3340c5ffaa2cf9cef1876ac6bb89
nicktimkohttps://github.com/nicktimko
Jan 5, 2018 https://github.com/python/cpython/pull/3804#ref-commit-7367d08
Ignore unset vars for venv activatehttps://github.com/ChameleonCloud/abracadabra/commit/7367d08db67e8325ee5d6ab8b808a5a899ec8482
https://github.com/ChameleonCloud/abracadabra/commit/7367d08db67e8325ee5d6ab8b808a5a899ec8482#comments
7367d08https://github.com/ChameleonCloud/abracadabra/commit/7367d08db67e8325ee5d6ab8b808a5a899ec8482
https://github.com/ackalker
ackalkerhttps://github.com/ackalker
Jan 29, 2022 https://github.com/python/cpython/pull/3804#ref-issue-1118250473
pyenv activate fails due to unbound variable when set -u is in effect pyenv/pyenv-virtualenv#422 https://github.com/pyenv/pyenv-virtualenv/issues/422
https://github.com/TomiBelan
TomiBelanhttps://github.com/TomiBelan
Nov 29, 2023 https://github.com/python/cpython/pull/3804#ref-pullrequest-2017064196
Support shells with "set -u" ekalinin/nodeenv#345 https://github.com/ekalinin/nodeenv/pull/345
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3804
Please reload this pagehttps://github.com/python/cpython/pull/3804
https://github.com/ssbarnea
https://github.com/the-knights-who-say-ni
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/vsajip
https://github.com/vstinner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.