René's URL Explorer Experiment


Title: bpo-31588: Prevent raising a SystemError in class creation in case of a metaclass with a bad __prepare__() method by orenmn · Pull Request #3764 · python/cpython · GitHub

Open Graph Title: bpo-31588: Prevent raising a SystemError in class creation in case of a metaclass with a bad __prepare__() method by orenmn · Pull Request #3764 · python/cpython

X Title: bpo-31588: Prevent raising a SystemError in class creation in case of a metaclass with a bad __prepare__() method by orenmn · Pull Request #3764 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: in bltinmodule.c: add a check whether __prepare__() returned a mapping. in test_types.py: add tests to verify that the SystemError is no more. https://bugs.python.org/issue31588

X Description: in bltinmodule.c: add a check whether __prepare__() returned a mapping. in test_types.py: add tests to verify that the SystemError is no more. https://bugs.python.org/issue31588

Opengraph URL: https://github.com/python/cpython/pull/3764

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:59759643-2552-7d38-7a41-166c38251743
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id94DE:20AA01:4C76AC0:60C57BE:6B0246F2
html-safe-nonce64146cdc41dd3625f7f9a4fa1587637db83b7ee73fae81dc806a715aaa6f0f0b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NERFOjIwQUEwMTo0Qzc2QUMwOjYwQzU3QkU6NkIwMjQ2RjIiLCJ2aXNpdG9yX2lkIjoiMjk4NTYzMDM0MTc0MDgwNzU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd2725c5b18152b9b5630e4580048c15743b5e6a2389fd0eab4a3f29f337c7ede
hovercard-subject-tagpull_request:143106416
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/3764/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c594cf5465478824ce8fd61476f4ddd79a2374f9ab06acb285952275517011f4/python/cpython/pull/3764
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c594cf5465478824ce8fd61476f4ddd79a2374f9ab06acb285952275517011f4/python/cpython/pull/3764
og:image:altin bltinmodule.c: add a check whether __prepare__() returned a mapping. in test_types.py: add tests to verify that the SystemError is no more. https://bugs.python.org/issue31588
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameorenmn
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/3764#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3764
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3764
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3764
Reloadhttps://github.com/python/cpython/pull/3764
Reloadhttps://github.com/python/cpython/pull/3764
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
ncoghlanhttps://github.com/ncoghlan
python:masterhttps://github.com/python/cpython/tree/master
orenmn:bpo31588-fix-sys-errhttps://github.com/orenmn/cpython/tree/bpo31588-fix-sys-err
Conversationhttps://github.com/python/cpython/pull/3764
Commits8 (8)https://github.com/python/cpython/pull/3764/commits
Checkshttps://github.com/python/cpython/pull/3764/checks
Files changedhttps://github.com/python/cpython/pull/3764/files
bpo-31588: Prevent raising a SystemError in class creation in case of a metaclass with a bad __prepare__() methodhttps://github.com/python/cpython/pull/3764#top
ncoghlanhttps://github.com/ncoghlan
python:masterhttps://github.com/python/cpython/tree/master
orenmn:bpo31588-fix-sys-errhttps://github.com/orenmn/cpython/tree/bpo31588-fix-sys-err
https://github.com/orenmn
orenmnhttps://github.com/orenmn
Sep 26, 2017https://github.com/python/cpython/pull/3764#issue-260586203
Please reload this pagehttps://github.com/python/cpython/pull/3764
https://bugs.python.org/issue31588https://bugs.python.org/issue31588
Please reload this pagehttps://github.com/python/cpython/pull/3764
orenmnhttps://github.com/orenmn
September 26, 2017 10:41https://github.com/python/cpython/pull/3764#commits-pushed-58df081
https://github.com/orenmn
init commithttps://github.com/python/cpython/pull/3764/commits/58df0812beb316ba6e05f4818babb36e983dc06c
58df081https://github.com/python/cpython/pull/3764/commits/58df0812beb316ba6e05f4818babb36e983dc06c
https://github.com/orenmn
added a NEWS.d item, and added a testhttps://github.com/python/cpython/pull/3764/commits/bff6f258675badce585d0b7a9cba7912f6dad94e
bff6f25https://github.com/python/cpython/pull/3764/commits/bff6f258675badce585d0b7a9cba7912f6dad94e
https://github.com/orenmn
cosmetic improvements to the test.https://github.com/python/cpython/pull/3764/commits/6c7ce6b4be7a581f5084bcd583576893951ff247
6c7ce6bhttps://github.com/python/cpython/pull/3764/commits/6c7ce6b4be7a581f5084bcd583576893951ff247
https://github.com/orenmn
improve a comment.https://github.com/python/cpython/pull/3764/commits/bf6f425c1d9e14eadbb343806abaae58a5e111ca
bf6f425https://github.com/python/cpython/pull/3764/commits/bf6f425c1d9e14eadbb343806abaae58a5e111ca
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 26, 2017https://github.com/python/cpython/pull/3764#event-1265504353
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 26, 2017https://github.com/python/cpython/pull/3764#event-1265504360
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 26, 2017 https://github.com/python/cpython/pull/3764#pullrequestreview-65202115
View reviewed changes https://github.com/python/cpython/pull/3764/files/bf6f425c1d9e14eadbb343806abaae58a5e111ca
Lib/test/test_types.pyhttps://github.com/python/cpython/pull/3764/files/bf6f425c1d9e14eadbb343806abaae58a5e111ca#diff-d5154ccf7a97612e4a8b06a6f0f48f15554e426e72e698f246d17d3dd8e3a75a
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 26, 2017https://github.com/python/cpython/pull/3764#discussion_r141045660
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
Python/bltinmodule.chttps://github.com/python/cpython/pull/3764/files/bf6f425c1d9e14eadbb343806abaae58a5e111ca#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 26, 2017https://github.com/python/cpython/pull/3764#discussion_r141052165
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
orenmnhttps://github.com/orenmn
Sep 26, 2017https://github.com/python/cpython/pull/3764#discussion_r141088869
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 26, 2017https://github.com/python/cpython/pull/3764#discussion_r141129941
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
orenmnhttps://github.com/orenmn
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141264195
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141265899
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
orenmnhttps://github.com/orenmn
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141286161
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141292480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
ncoghlanhttps://github.com/ncoghlan
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141300357
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
Misc/NEWS.d/next/Core and Builtins/2017-09-26-13-03-16.bpo-31588.wT9Iy7.rsthttps://github.com/python/cpython/pull/3764/files/bf6f425c1d9e14eadbb343806abaae58a5e111ca#diff-b1f40d06ce1cca03291f85e3b85d4e4fb09d176c5c597cb45a67892ca9f20f13
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 26, 2017https://github.com/python/cpython/pull/3764#discussion_r141052860
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
ncoghlanhttps://github.com/ncoghlan
September 26, 2017 13:31https://github.com/python/cpython/pull/3764#event-1265734064
https://github.com/orenmn
improve the test and the NEWS.d itemhttps://github.com/python/cpython/pull/3764/commits/1571f3b514fa73e565e31ebcbfaf8df9931f608f
1571f3bhttps://github.com/python/cpython/pull/3764/commits/1571f3b514fa73e565e31ebcbfaf8df9931f608f
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 26, 2017https://github.com/python/cpython/pull/3764#event-1265970234
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 27, 2017 https://github.com/python/cpython/pull/3764#pullrequestreview-65482436
View reviewed changes https://github.com/python/cpython/pull/3764/files/1571f3b514fa73e565e31ebcbfaf8df9931f608f
Python/bltinmodule.chttps://github.com/python/cpython/pull/3764/files/bf6f425c1d9e14eadbb343806abaae58a5e111ca#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141292480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
Lib/test/test_types.pyhttps://github.com/python/cpython/pull/3764/files/1571f3b514fa73e565e31ebcbfaf8df9931f608f#diff-d5154ccf7a97612e4a8b06a6f0f48f15554e426e72e698f246d17d3dd8e3a75a
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141294790
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Sep 27, 2017 https://github.com/python/cpython/pull/3764#pullrequestreview-65490662
View reviewed changes https://github.com/python/cpython/pull/3764/files/1571f3b514fa73e565e31ebcbfaf8df9931f608f
ncoghlanhttps://github.com/ncoghlan
https://github.com/python/cpython/pull/3764#pullrequestreview-65490662
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
Lib/test/test_types.pyhttps://github.com/python/cpython/pull/3764/files/1571f3b514fa73e565e31ebcbfaf8df9931f608f#diff-d5154ccf7a97612e4a8b06a6f0f48f15554e426e72e698f246d17d3dd8e3a75a
ncoghlanhttps://github.com/ncoghlan
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141299799
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
Misc/NEWS.d/next/Core and Builtins/2017-09-26-13-03-16.bpo-31588.wT9Iy7.rsthttps://github.com/python/cpython/pull/3764/files/1571f3b514fa73e565e31ebcbfaf8df9931f608f#diff-b1f40d06ce1cca03291f85e3b85d4e4fb09d176c5c597cb45a67892ca9f20f13
ncoghlanhttps://github.com/ncoghlan
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141300144
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
orenmnhttps://github.com/orenmn
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141319842
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://bugs.python.org/issue31588#msg303122https://bugs.python.org/issue31588#msg303122
Please reload this pagehttps://github.com/python/cpython/pull/3764
Python/bltinmodule.chttps://github.com/python/cpython/pull/3764/files/bf6f425c1d9e14eadbb343806abaae58a5e111ca#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1
ncoghlanhttps://github.com/ncoghlan
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141300357
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 27, 2017https://github.com/python/cpython/pull/3764#event-1267458557
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 27, 2017https://github.com/python/cpython/pull/3764#issuecomment-332475194
Please reload this pagehttps://github.com/python/cpython/pull/3764
orenmnhttps://github.com/orenmn
September 27, 2017 14:40https://github.com/python/cpython/pull/3764#commits-pushed-1462735
https://github.com/orenmn
improve the testshttps://github.com/python/cpython/pull/3764/commits/1462735928ee2e2c7a699659bdd2352b55f6fa49
1462735https://github.com/python/cpython/pull/3764/commits/1462735928ee2e2c7a699659bdd2352b55f6fa49
https://github.com/orenmn
fix the NEWS.d itemhttps://github.com/python/cpython/pull/3764/commits/7f70a1ed929fc9f288d66272f5f56aaf7eb0d055
7f70a1ehttps://github.com/python/cpython/pull/3764/commits/7f70a1ed929fc9f288d66272f5f56aaf7eb0d055
https://github.com/orenmn
orenmnhttps://github.com/orenmn
Sep 27, 2017 https://github.com/python/cpython/pull/3764#pullrequestreview-65516419
View reviewed changes https://github.com/python/cpython/pull/3764/files/7f70a1ed929fc9f288d66272f5f56aaf7eb0d055
Misc/NEWS.d/next/Core and Builtins/2017-09-26-13-03-16.bpo-31588.wT9Iy7.rsthttps://github.com/python/cpython/pull/3764/files/7f70a1ed929fc9f288d66272f5f56aaf7eb0d055#diff-b1f40d06ce1cca03291f85e3b85d4e4fb09d176c5c597cb45a67892ca9f20f13
orenmnhttps://github.com/orenmn
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141321387
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
ncoghlanhttps://github.com/ncoghlan
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141341021
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
https://github.com/orenmn
orenmnhttps://github.com/orenmn
Sep 27, 2017https://github.com/python/cpython/pull/3764#issuecomment-332502623
Please reload this pagehttps://github.com/python/cpython/pull/3764
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 27, 2017https://github.com/python/cpython/pull/3764#issuecomment-332502627
Nobody expects the Spanish Inquisition!https://youtu.be/Nf_Y4MbUCLY
@ncoghlanhttps://github.com/ncoghlan
Please reload this pagehttps://github.com/python/cpython/pull/3764
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Sep 27, 2017https://github.com/python/cpython/pull/3764#event-1267647952
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Sep 27, 2017 https://github.com/python/cpython/pull/3764#pullrequestreview-65539321
View reviewed changes https://github.com/python/cpython/pull/3764/files/7f70a1ed929fc9f288d66272f5f56aaf7eb0d055
Misc/NEWS.d/next/Core and Builtins/2017-09-26-13-03-16.bpo-31588.wT9Iy7.rsthttps://github.com/python/cpython/pull/3764/files/7f70a1ed929fc9f288d66272f5f56aaf7eb0d055#diff-b1f40d06ce1cca03291f85e3b85d4e4fb09d176c5c597cb45a67892ca9f20f13
ncoghlanhttps://github.com/ncoghlan
Sep 27, 2017https://github.com/python/cpython/pull/3764#discussion_r141341021
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3764
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
Sep 27, 2017https://github.com/python/cpython/pull/3764#event-1267762261
https://github.com/ncoghlan
Minor grammar fixhttps://github.com/python/cpython/pull/3764/commits/dcd522707817420a45450d217e5de807f41490bd
dcd5227https://github.com/python/cpython/pull/3764/commits/dcd522707817420a45450d217e5de807f41490bd
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
5837d04https://github.com/python/cpython/commit/5837d0418f47933b2e3c139bdee8a79c248a943c
Sep 27, 2017https://github.com/python/cpython/pull/3764#event-1267845823
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Sep 27, 2017https://github.com/python/cpython/pull/3764#event-1267847383
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 27, 2017https://github.com/python/cpython/pull/3764#issuecomment-332532108
@orenmnhttps://github.com/orenmn
@ncoghlanhttps://github.com/ncoghlan
Please reload this pagehttps://github.com/python/cpython/pull/3764
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 27, 2017https://github.com/python/cpython/pull/3764#issuecomment-332532228
GH-3790https://github.com/python/cpython/pull/3790
3.6 branchhttps://github.com/python/cpython/tree/3.6
Please reload this pagehttps://github.com/python/cpython/pull/3764
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Sep 27, 2017https://github.com/python/cpython/pull/3764#event-1267848205
miss-islingtonhttps://github.com/miss-islington
Sep 27, 2017 https://github.com/python/cpython/pull/3764#ref-commit-ab415c2
https://github.com/orenmn
https://github.com/miss-islington
[3.6] bpo-31588: Validate return value of __prepare__() methods (https://github.com/miss-islington/cpython/commit/ab415c2d31eeea3dbe5749024dbfc26c775455dc
pyth…https://github.com/python/cpython/pull/3764
ab415c2https://github.com/miss-islington/cpython/commit/ab415c2d31eeea3dbe5749024dbfc26c775455dc
…onGH-3764https://github.com/python/cpython/pull/3764
5837d04https://github.com/miss-islington/cpython/commit/5837d0418f47933b2e3c139bdee8a79c248a943c
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 27, 2017https://github.com/python/cpython/pull/3764#event-1267848993
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3764
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/3764/files/1571f3b514fa73e565e31ebcbfaf8df9931f608f
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/python/cpython/pull/3764/files/7f70a1ed929fc9f288d66272f5f56aaf7eb0d055
Please reload this pagehttps://github.com/python/cpython/pull/3764
Please reload this pagehttps://github.com/python/cpython/pull/3764
https://github.com/orenmn
https://github.com/bedevere-bot
https://github.com/miss-islington
https://github.com/ncoghlan
https://github.com/serhiy-storchaka
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.