René's URL Explorer Experiment


Title: [memory leak]bpo-16322, bpo-27426: Fix time zone names encoding issues in Windows by denis-osipov · Pull Request #3740 · python/cpython · GitHub

Open Graph Title: [memory leak]bpo-16322, bpo-27426: Fix time zone names encoding issues in Windows by denis-osipov · Pull Request #3740 · python/cpython

X Title: [memory leak]bpo-16322, bpo-27426: Fix time zone names encoding issues in Windows by denis-osipov · Pull Request #3740 · python/cpython

Description: Use Windows APIs to avoid wrong encoding of time zone names: bpo-16322 and bpo-27426. Switch back to using wcsftime because: replace wcsftime() with strftime() to fix encoding issues doesn't work anymore ( http://bugs.python.org/issue8304#msg255133 ); not to convert new time zone names from Windows API to char*. https://bugs.python.org/issue16322

Open Graph Description: Use Windows APIs to avoid wrong encoding of time zone names: bpo-16322 and bpo-27426. Switch back to using wcsftime because: replace wcsftime() with strftime() to fix encoding issues doesn't w...

X Description: Use Windows APIs to avoid wrong encoding of time zone names: bpo-16322 and bpo-27426. Switch back to using wcsftime because: replace wcsftime() with strftime() to fix encoding issues doesn&#39...

Opengraph URL: https://github.com/python/cpython/pull/3740

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:60b0c576-3216-859d-3417-22b45775e2b5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC468:38EE04:21240D6:2B949F7:6B023ECB
html-safe-nonceab20c32f0708426b0912914160baf2c5580f44137865aa834161d58665aebb96
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDY4OjM4RUUwNDoyMTI0MEQ2OjJCOTQ5Rjc6NkIwMjNFQ0IiLCJ2aXNpdG9yX2lkIjoiODA1ODMzNzM1NjE3Mzk1MDY2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac25fa2c17f839917ef00067cf3972dbaa68c42a13e4e4ffc326500f7ad7c26aeb
hovercard-subject-tagpull_request:142809182
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/3740/files
twitter:imagehttps://avatars.githubusercontent.com/u/24683226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/24683226?s=400&v=4
og:image:altUse Windows APIs to avoid wrong encoding of time zone names: bpo-16322 and bpo-27426. Switch back to using wcsftime because: replace wcsftime() with strftime() to fix encoding issues doesn't w...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3740/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3740%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3740%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3740/files
Reloadhttps://github.com/python/cpython/pull/3740/files
Reloadhttps://github.com/python/cpython/pull/3740/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
denis-osipovhttps://github.com/denis-osipov
python:masterhttps://github.com/python/cpython/tree/master
Conversation 15 https://github.com/python/cpython/pull/3740
Commits 21 https://github.com/python/cpython/pull/3740/commits
Checks 0 https://github.com/python/cpython/pull/3740/checks
Files changed https://github.com/python/cpython/pull/3740/files
Please reload this pagehttps://github.com/python/cpython/pull/3740/files
[memory leak]bpo-16322, bpo-27426: Fix time zone names encoding issues in Windows https://github.com/python/cpython/pull/3740/files#top
Show all changes 21 commits https://github.com/python/cpython/pull/3740/files
1badc2c Call native Windows APIs to get the timezone name. denis-osipov Sep 22, 2017 https://github.com/python/cpython/pull/3740/commits/1badc2c1afd3589741f22a1a5021cc7ca9baf796
ed05218 Call native Windows APIs to get the timezone name for time.localtime(… denis-osipov Sep 22, 2017 https://github.com/python/cpython/pull/3740/commits/ed05218bde3b716a2ccb2f705748834391f19fe0
f1a7b92 Add comment. denis-osipov Sep 22, 2017 https://github.com/python/cpython/pull/3740/commits/f1a7b9200c41d3800b8a644d53edd46a8e2fced7
1639cad Back to wcsftime. Convert tabs to space. denis-osipov Sep 22, 2017 https://github.com/python/cpython/pull/3740/commits/1639cad795ef88d4107042a64f90a0a82f2ec096
fb417ff Add time zone directive's replacement denis-osipov Sep 23, 2017 https://github.com/python/cpython/pull/3740/commits/fb417ffcaa3e95e0bbea76ee695df4bf42e0a8e8
90b6cdb Add function to get time zone name. denis-osipov Sep 24, 2017 https://github.com/python/cpython/pull/3740/commits/90b6cdb235b9fe26e72e60a35b4d5a88eed62e26
4bacd1e Add handling with '%%Z' denis-osipov Sep 24, 2017 https://github.com/python/cpython/pull/3740/commits/4bacd1eb55146387caac016e10c11acfc47b9296
92b2f45 Try to follow PEP 7 denis-osipov Sep 24, 2017 https://github.com/python/cpython/pull/3740/commits/92b2f45ece81824c3175fc99578fdad266b75802
8ecb774 Minor changes (one row less). denis-osipov Sep 25, 2017 https://github.com/python/cpython/pull/3740/commits/8ecb7742b5dea76f4965e83b0069abf0aa3addfc
52dc479 Add news entry in Misc/NEWS.d denis-osipov Sep 25, 2017 https://github.com/python/cpython/pull/3740/commits/52dc479c141e3ac6323fba2002cff5b513de5005
1492776 Move 'static void' on a separate line. denis-osipov Sep 26, 2017 https://github.com/python/cpython/pull/3740/commits/14927761e5468069a7ada61147a19fccf7825aa2
b515a62 Use named constants. Add error handling for TIME_ZONE_ID_INVALID. denis-osipov Sep 26, 2017 https://github.com/python/cpython/pull/3740/commits/b515a623fa94632411b08595ed2488feaef7221b
a898b3f Add PyMem_Free call if error occured. denis-osipov Sep 27, 2017 https://github.com/python/cpython/pull/3740/commits/a898b3fcc22654203abcb606de65985619c0b8ce
b129f62 Merge format checking for Windows, AIX and Solaris denis-osipov Sep 27, 2017 https://github.com/python/cpython/pull/3740/commits/b129f62daa0186baa9f1e110fb1ab4cdd811bfb6
fb68cbf Move %Z count to format checking block. Check for integer overflow. denis-osipov Sep 28, 2017 https://github.com/python/cpython/pull/3740/commits/fb68cbff4cf759aefd229b9b74d17297a5a3f5af
2231d72 PyMem_Free(format) added. Rewrite part replacing %Z. denis-osipov Sep 29, 2017 https://github.com/python/cpython/pull/3740/commits/2231d7240bf57ba0d8e7e42a0c400121fed3268e
2c1e468 Changed code for %Z replacement. denis-osipov Sep 30, 2017 https://github.com/python/cpython/pull/3740/commits/2c1e468641b62b3e5513d65ddd6c0d25edd9a923
3d64b76 Handle error in PyInit_timezone(). denis-osipov Sep 30, 2017 https://github.com/python/cpython/pull/3740/commits/3d64b76d89efd6ecff8e49fc66248f418a346413
4ae8592 Remove one empty line. denis-osipov Sep 30, 2017 https://github.com/python/cpython/pull/3740/commits/4ae8592d7e322ae6847b07bfafab895cf2ab83ef
8dcebff Merge branch 'master' into fix-time-3 denis-osipov Oct 10, 2017 https://github.com/python/cpython/pull/3740/commits/8dcebff22403827080fd530e6c5b307070c65c41
e393839 Merge branch 'master' into fix-time-3 denis-osipov Oct 13, 2017 https://github.com/python/cpython/pull/3740/commits/e3938395be91083c828d40b41b32a9018559d1ed
Clear filters https://github.com/python/cpython/pull/3740/files
Please reload this pagehttps://github.com/python/cpython/pull/3740/files
Please reload this pagehttps://github.com/python/cpython/pull/3740/files
2017-09-25-14-01-08.bpo-16322.hIaWkb.rst https://github.com/python/cpython/pull/3740/files#diff-9436e0d40bd8a9968c84796aca3f93a65cbbe2318126a75f989ed3669ec53a9e
timemodule.c https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
Misc/NEWS.d/next/Windows/2017-09-25-14-01-08.bpo-16322.hIaWkb.rsthttps://github.com/python/cpython/pull/3740/files#diff-9436e0d40bd8a9968c84796aca3f93a65cbbe2318126a75f989ed3669ec53a9e
View file https://github.com/python/cpython/blob/e3938395be91083c828d40b41b32a9018559d1ed/Misc/NEWS.d/next/Windows/2017-09-25-14-01-08.bpo-16322.hIaWkb.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3740/{{ revealButtonHref }}
Modules/timemodule.chttps://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
View file https://github.com/python/cpython/blob/e3938395be91083c828d40b41b32a9018559d1ed/Modules/timemodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3740/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/3740/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.