René's URL Explorer Experiment


Title: [memory leak]bpo-16322, bpo-27426: Fix time zone names encoding issues in Windows by denis-osipov · Pull Request #3740 · python/cpython · GitHub

Open Graph Title: [memory leak]bpo-16322, bpo-27426: Fix time zone names encoding issues in Windows by denis-osipov · Pull Request #3740 · python/cpython

X Title: [memory leak]bpo-16322, bpo-27426: Fix time zone names encoding issues in Windows by denis-osipov · Pull Request #3740 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Use Windows APIs to avoid wrong encoding of time zone names: bpo-16322 and bpo-27426. Switch back to using wcsftime because: replace wcsftime() with strftime() to fix encoding issues doesn't w...

X Description: Use Windows APIs to avoid wrong encoding of time zone names: bpo-16322 and bpo-27426. Switch back to using wcsftime because: replace wcsftime() with strftime() to fix encoding issues doesn&#39...

Opengraph URL: https://github.com/python/cpython/pull/3740

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:20d22ebf-5a20-34ef-41f7-c5a55ddb8b21
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBFA:10F057:4DD030:659434:6B023EDC
html-safe-nonce0d0673bf3e0f63e3a411defbd9711f031c5c22271c2f1d33e22e1426d5472e1f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkZBOjEwRjA1Nzo0REQwMzA6NjU5NDM0OjZCMDIzRURDIiwidmlzaXRvcl9pZCI6Ijc0MTUxMTExNDgyNzU2NDYxNzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac61f021b0d733e6d3460907eb360ca1a3faee7eec934b4214ce614f9bab1db901
hovercard-subject-tagpull_request:142809182
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/3740/commits
twitter:imagehttps://opengraph.githubassets.com/d845f89d715bb4594570a6987d8307df478c7fae500214ce0e872b0357302631/python/cpython/pull/3740
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d845f89d715bb4594570a6987d8307df478c7fae500214ce0e872b0357302631/python/cpython/pull/3740
og:image:altUse Windows APIs to avoid wrong encoding of time zone names: bpo-16322 and bpo-27426. Switch back to using wcsftime because: replace wcsftime() with strftime() to fix encoding issues doesn't w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedenis-osipov
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/3740/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3740%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3740%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3740/commits
Reloadhttps://github.com/python/cpython/pull/3740/commits
Reloadhttps://github.com/python/cpython/pull/3740/commits
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
denis-osipovhttps://github.com/denis-osipov
python:masterhttps://github.com/python/cpython/tree/master
Conversationhttps://github.com/python/cpython/pull/3740
Commits21 (21)https://github.com/python/cpython/pull/3740/commits
Checkshttps://github.com/python/cpython/pull/3740/checks
Files changedhttps://github.com/python/cpython/pull/3740/files
[memory leak]bpo-16322, bpo-27426: Fix time zone names encoding issues in Windowshttps://github.com/python/cpython/pull/3740/commits#top
denis-osipovhttps://github.com/denis-osipov
python:masterhttps://github.com/python/cpython/tree/master
Call native Windows APIs to get the timezone name.https://github.com/python/cpython/pull/3740/commits/1badc2c1afd3589741f22a1a5021cc7ca9baf796
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
1badc2chttps://github.com/python/cpython/pull/3740/commits/1badc2c1afd3589741f22a1a5021cc7ca9baf796
https://github.com/python/cpython/tree/1badc2c1afd3589741f22a1a5021cc7ca9baf796
Call native Windows APIs to get the timezone name for time.localtime(). Related changes in tmtotuple() and time.gmtime()https://github.com/python/cpython/pull/3740/commits/ed05218bde3b716a2ccb2f705748834391f19fe0
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
ed05218https://github.com/python/cpython/pull/3740/commits/ed05218bde3b716a2ccb2f705748834391f19fe0
https://github.com/python/cpython/tree/ed05218bde3b716a2ccb2f705748834391f19fe0
Add comment.https://github.com/python/cpython/pull/3740/commits/f1a7b9200c41d3800b8a644d53edd46a8e2fced7
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
f1a7b92https://github.com/python/cpython/pull/3740/commits/f1a7b9200c41d3800b8a644d53edd46a8e2fced7
https://github.com/python/cpython/tree/f1a7b9200c41d3800b8a644d53edd46a8e2fced7
Back to wcsftime. Convert tabs to space.https://github.com/python/cpython/pull/3740/commits/1639cad795ef88d4107042a64f90a0a82f2ec096
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
1639cadhttps://github.com/python/cpython/pull/3740/commits/1639cad795ef88d4107042a64f90a0a82f2ec096
https://github.com/python/cpython/tree/1639cad795ef88d4107042a64f90a0a82f2ec096
Add time zone directive's replacementhttps://github.com/python/cpython/pull/3740/commits/fb417ffcaa3e95e0bbea76ee695df4bf42e0a8e8
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
fb417ffhttps://github.com/python/cpython/pull/3740/commits/fb417ffcaa3e95e0bbea76ee695df4bf42e0a8e8
https://github.com/python/cpython/tree/fb417ffcaa3e95e0bbea76ee695df4bf42e0a8e8
Add function to get time zone name.https://github.com/python/cpython/pull/3740/commits/90b6cdb235b9fe26e72e60a35b4d5a88eed62e26
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
90b6cdbhttps://github.com/python/cpython/pull/3740/commits/90b6cdb235b9fe26e72e60a35b4d5a88eed62e26
https://github.com/python/cpython/tree/90b6cdb235b9fe26e72e60a35b4d5a88eed62e26
Add handling with '%%Z'https://github.com/python/cpython/pull/3740/commits/4bacd1eb55146387caac016e10c11acfc47b9296
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
4bacd1ehttps://github.com/python/cpython/pull/3740/commits/4bacd1eb55146387caac016e10c11acfc47b9296
https://github.com/python/cpython/tree/4bacd1eb55146387caac016e10c11acfc47b9296
Try to follow PEP 7https://github.com/python/cpython/pull/3740/commits/92b2f45ece81824c3175fc99578fdad266b75802
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
92b2f45https://github.com/python/cpython/pull/3740/commits/92b2f45ece81824c3175fc99578fdad266b75802
https://github.com/python/cpython/tree/92b2f45ece81824c3175fc99578fdad266b75802
Minor changes (one row less).https://github.com/python/cpython/pull/3740/commits/8ecb7742b5dea76f4965e83b0069abf0aa3addfc
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
8ecb774https://github.com/python/cpython/pull/3740/commits/8ecb7742b5dea76f4965e83b0069abf0aa3addfc
https://github.com/python/cpython/tree/8ecb7742b5dea76f4965e83b0069abf0aa3addfc
Add news entry in Misc/NEWS.dhttps://github.com/python/cpython/pull/3740/commits/52dc479c141e3ac6323fba2002cff5b513de5005
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
52dc479https://github.com/python/cpython/pull/3740/commits/52dc479c141e3ac6323fba2002cff5b513de5005
https://github.com/python/cpython/tree/52dc479c141e3ac6323fba2002cff5b513de5005
Move 'static void' on a separate line.https://github.com/python/cpython/pull/3740/commits/14927761e5468069a7ada61147a19fccf7825aa2
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
1492776https://github.com/python/cpython/pull/3740/commits/14927761e5468069a7ada61147a19fccf7825aa2
https://github.com/python/cpython/tree/14927761e5468069a7ada61147a19fccf7825aa2
Use named constants. Add error handling for TIME_ZONE_ID_INVALID.https://github.com/python/cpython/pull/3740/commits/b515a623fa94632411b08595ed2488feaef7221b
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
b515a62https://github.com/python/cpython/pull/3740/commits/b515a623fa94632411b08595ed2488feaef7221b
https://github.com/python/cpython/tree/b515a623fa94632411b08595ed2488feaef7221b
Add PyMem_Free call if error occured.https://github.com/python/cpython/pull/3740/commits/a898b3fcc22654203abcb606de65985619c0b8ce
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
a898b3fhttps://github.com/python/cpython/pull/3740/commits/a898b3fcc22654203abcb606de65985619c0b8ce
https://github.com/python/cpython/tree/a898b3fcc22654203abcb606de65985619c0b8ce
Merge format checking for Windows, AIX and Solarishttps://github.com/python/cpython/pull/3740/commits/b129f62daa0186baa9f1e110fb1ab4cdd811bfb6
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
b129f62https://github.com/python/cpython/pull/3740/commits/b129f62daa0186baa9f1e110fb1ab4cdd811bfb6
https://github.com/python/cpython/tree/b129f62daa0186baa9f1e110fb1ab4cdd811bfb6
Move %Z count to format checking block. Check for integer overflow.https://github.com/python/cpython/pull/3740/commits/fb68cbff4cf759aefd229b9b74d17297a5a3f5af
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
fb68cbfhttps://github.com/python/cpython/pull/3740/commits/fb68cbff4cf759aefd229b9b74d17297a5a3f5af
https://github.com/python/cpython/tree/fb68cbff4cf759aefd229b9b74d17297a5a3f5af
PyMem_Free(format) added. Rewrite part replacing %Z.https://github.com/python/cpython/pull/3740/commits/2231d7240bf57ba0d8e7e42a0c400121fed3268e
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
2231d72https://github.com/python/cpython/pull/3740/commits/2231d7240bf57ba0d8e7e42a0c400121fed3268e
https://github.com/python/cpython/tree/2231d7240bf57ba0d8e7e42a0c400121fed3268e
Changed code for %Z replacement.https://github.com/python/cpython/pull/3740/commits/2c1e468641b62b3e5513d65ddd6c0d25edd9a923
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
2c1e468https://github.com/python/cpython/pull/3740/commits/2c1e468641b62b3e5513d65ddd6c0d25edd9a923
https://github.com/python/cpython/tree/2c1e468641b62b3e5513d65ddd6c0d25edd9a923
Handle error in PyInit_timezone().https://github.com/python/cpython/pull/3740/commits/3d64b76d89efd6ecff8e49fc66248f418a346413
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
3d64b76https://github.com/python/cpython/pull/3740/commits/3d64b76d89efd6ecff8e49fc66248f418a346413
https://github.com/python/cpython/tree/3d64b76d89efd6ecff8e49fc66248f418a346413
Remove one empty line.https://github.com/python/cpython/pull/3740/commits/4ae8592d7e322ae6847b07bfafab895cf2ab83ef
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
4ae8592https://github.com/python/cpython/pull/3740/commits/4ae8592d7e322ae6847b07bfafab895cf2ab83ef
https://github.com/python/cpython/tree/4ae8592d7e322ae6847b07bfafab895cf2ab83ef
Merge branch 'master' into fix-time-3https://github.com/python/cpython/pull/3740/commits/8dcebff22403827080fd530e6c5b307070c65c41
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
8dcebffhttps://github.com/python/cpython/pull/3740/commits/8dcebff22403827080fd530e6c5b307070c65c41
https://github.com/python/cpython/tree/8dcebff22403827080fd530e6c5b307070c65c41
Merge branch 'master' into fix-time-3https://github.com/python/cpython/pull/3740/commits/e3938395be91083c828d40b41b32a9018559d1ed
https://github.com/denis-osipov
denis-osipovhttps://github.com/python/cpython/commits?author=denis-osipov
e393839https://github.com/python/cpython/pull/3740/commits/e3938395be91083c828d40b41b32a9018559d1ed
https://github.com/python/cpython/tree/e3938395be91083c828d40b41b32a9018559d1ed
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.