René's URL Explorer Experiment


Title: bpo-28411: Support other mappings in PyInterpreterState.modules. by ericsnowcurrently · Pull Request #3593 · python/cpython · GitHub

Open Graph Title: bpo-28411: Support other mappings in PyInterpreterState.modules. by ericsnowcurrently · Pull Request #3593 · python/cpython

X Title: bpo-28411: Support other mappings in PyInterpreterState.modules. by ericsnowcurrently · Pull Request #3593 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The concrete PyDict_* API is used to interact with PyInterpreterState.modules in a number of places. This isn't compatible with all dict subclasses, nor with other Mapping implementations. Th...

X Description: The concrete PyDict_* API is used to interact with PyInterpreterState.modules in a number of places. This isn't compatible with all dict subclasses, nor with other Mapping implementations....

Opengraph URL: https://github.com/python/cpython/pull/3593

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9f74b43c-5a36-2275-1398-5dd9a47644a9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE72E:23658B:58683:7BE35:6A4FB68C
html-safe-nonce1812c29c7042bed036e7b26f5bce271a6d1c162e680945b99f60a859ae058fdf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzJFOjIzNjU4Qjo1ODY4Mzo3QkUzNTo2QTRGQjY4QyIsInZpc2l0b3JfaWQiOiI0MjE0OTQwNDkwNzEyMjAwODQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac18203f196fd8ed1874b063dd2a0955e3d5a2d072016e7269b0961f9e3cae8857
hovercard-subject-tagpull_request:141199654
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/3593/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e8afa3be5b6a8360b80231b4ea53f808855edf02d1e81cee1c961a2e606146a0/python/cpython/pull/3593
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e8afa3be5b6a8360b80231b4ea53f808855edf02d1e81cee1c961a2e606146a0/python/cpython/pull/3593
og:image:altThe concrete PyDict_* API is used to interact with PyInterpreterState.modules in a number of places. This isn't compatible with all dict subclasses, nor with other Mapping implementations. Th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3593#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3593
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3593
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3593
Reloadhttps://github.com/python/cpython/pull/3593
Reloadhttps://github.com/python/cpython/pull/3593
Please reload this pagehttps://github.com/python/cpython/pull/3593
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3593
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:masterhttps://github.com/python/cpython/tree/master
ericsnowcurrently:sys-modules-any-mappinghttps://github.com/ericsnowcurrently/cpython/tree/sys-modules-any-mapping
Conversationhttps://github.com/python/cpython/pull/3593
Commits30 (30)https://github.com/python/cpython/pull/3593/commits
Checkshttps://github.com/python/cpython/pull/3593/checks
Files changedhttps://github.com/python/cpython/pull/3593/files
bpo-28411: Support other mappings in PyInterpreterState.modules.https://github.com/python/cpython/pull/3593#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:masterhttps://github.com/python/cpython/tree/master
ericsnowcurrently:sys-modules-any-mappinghttps://github.com/ericsnowcurrently/cpython/tree/sys-modules-any-mapping
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 14, 2017https://github.com/python/cpython/pull/3593#issue-257885852
Please reload this pagehttps://github.com/python/cpython/pull/3593
#1638https://github.com/python/cpython/pull/1638
https://bugs.python.org/issue28411https://bugs.python.org/issue28411
Please reload this pagehttps://github.com/python/cpython/pull/3593
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
September 14, 2017 18:20https://github.com/python/cpython/pull/3593#commits-pushed-8f3ecfc
https://github.com/ericsnowcurrently
Add _PyImport_GetModule*.https://github.com/python/cpython/pull/3593/commits/8f3ecfc676a6dacf71665fc54509b33a8f868198
8f3ecfchttps://github.com/python/cpython/pull/3593/commits/8f3ecfc676a6dacf71665fc54509b33a8f868198
https://github.com/ericsnowcurrently
Allow sys.modules to be any mapping.https://github.com/python/cpython/pull/3593/commits/9dc9dedfb821ee6e7b2d5d976619eccc580e381c
9dc9dedhttps://github.com/python/cpython/pull/3593/commits/9dc9dedfb821ee6e7b2d5d976619eccc580e381c
https://github.com/ericsnowcurrently
Add _PyImport_SetModule*.https://github.com/python/cpython/pull/3593/commits/f2a54b1169ad0ff363b438a3c40ece7b45c35446
f2a54b1https://github.com/python/cpython/pull/3593/commits/f2a54b1169ad0ff363b438a3c40ece7b45c35446
https://github.com/ericsnowcurrently
Add PyImport_GetModule().https://github.com/python/cpython/pull/3593/commits/502e1387d0c0a036035bf67924a9e87c80ac3d2e
502e138https://github.com/python/cpython/pull/3593/commits/502e1387d0c0a036035bf67924a9e87c80ac3d2e
https://github.com/ericsnowcurrently
Decref the module when done.https://github.com/python/cpython/pull/3593/commits/ec8c5043ef33c56a140aa1272fb85d56ec7e63e6
ec8c504https://github.com/python/cpython/pull/3593/commits/ec8c5043ef33c56a140aa1272fb85d56ec7e63e6
https://github.com/ericsnowcurrently
Fix ref counts.https://github.com/python/cpython/pull/3593/commits/a1546f6e969afa856c1627c28e11b82025c70486
a1546f6https://github.com/python/cpython/pull/3593/commits/a1546f6e969afa856c1627c28e11b82025c70486
https://github.com/ericsnowcurrently
Look up "new" modules in the given modules dict.https://github.com/python/cpython/pull/3593/commits/5a5fad1e01dfd680967d602a495e75d16f8aadd3
5a5fad1https://github.com/python/cpython/pull/3593/commits/5a5fad1e01dfd680967d602a495e75d16f8aadd3
https://github.com/ericsnowcurrently
Fix error checking.https://github.com/python/cpython/pull/3593/commits/db0a2471a3f79b1e72ebe8111b06e45fd5bb1590
db0a247https://github.com/python/cpython/pull/3593/commits/db0a2471a3f79b1e72ebe8111b06e45fd5bb1590
https://github.com/ericsnowcurrently
Use PyImport_GetModuleDict() in PyImport_GetModule().https://github.com/python/cpython/pull/3593/commits/7082b475ff5ccaabb756d9d9f7f9a9cf2d4b83c2
7082b47https://github.com/python/cpython/pull/3593/commits/7082b475ff5ccaabb756d9d9f7f9a9cf2d4b83c2
https://github.com/ericsnowcurrently
Add a missing incref.https://github.com/python/cpython/pull/3593/commits/5082c479790a02c44abb1e7d3c688ad32316db20
5082c47https://github.com/python/cpython/pull/3593/commits/5082c479790a02c44abb1e7d3c688ad32316db20
https://github.com/ericsnowcurrently
Add a Misc/NEWS entry.https://github.com/python/cpython/pull/3593/commits/bb03872912d62256ce1254a6f6d7d76ecaca9ed8
bb03872https://github.com/python/cpython/pull/3593/commits/bb03872912d62256ce1254a6f6d7d76ecaca9ed8
https://github.com/ericsnowcurrently
Make the docs for PyImport_GetModule() more clear.https://github.com/python/cpython/pull/3593/commits/2e07296f7853e84b5646a647a30d4882061c0739
2e07296https://github.com/python/cpython/pull/3593/commits/2e07296f7853e84b5646a647a30d4882061c0739
https://github.com/ericsnowcurrently
Fix style (bracket placement).https://github.com/python/cpython/pull/3593/commits/46311635ec97a293ebbbbe3287577e024f8ae1a5
4631163https://github.com/python/cpython/pull/3593/commits/46311635ec97a293ebbbbe3287577e024f8ae1a5
https://github.com/ericsnowcurrently
Drop _PyImport_GetModuleString().https://github.com/python/cpython/pull/3593/commits/5b154b3a71998e89c525a6a89186fea9a094f9fe
5b154b3https://github.com/python/cpython/pull/3593/commits/5b154b3a71998e89c525a6a89186fea9a094f9fe
https://github.com/ericsnowcurrently
Use PyDict_CheckExact() for sys.modules in fast case.https://github.com/python/cpython/pull/3593/commits/33174f36d7a097f09b0932b9e5e791793d7cf42c
33174f3https://github.com/python/cpython/pull/3593/commits/33174f36d7a097f09b0932b9e5e791793d7cf42c
https://github.com/ericsnowcurrently
Do not use PyMapping_HasKey() with an error set.https://github.com/python/cpython/pull/3593/commits/e50e258496d2dc7c312dea49c7b4ba92020e05b6
e50e258https://github.com/python/cpython/pull/3593/commits/e50e258496d2dc7c312dea49c7b4ba92020e05b6
https://github.com/ericsnowcurrently
Revert a code order change.https://github.com/python/cpython/pull/3593/commits/23cf4934e57691a92af7dcc52e722516425758f3
23cf493https://github.com/python/cpython/pull/3593/commits/23cf4934e57691a92af7dcc52e722516425758f3
https://github.com/ericsnowcurrently
Switch the code order back.https://github.com/python/cpython/pull/3593/commits/eed5e24d122263c46b0dbafb59db66bd07e0d966
eed5e24https://github.com/python/cpython/pull/3593/commits/eed5e24d122263c46b0dbafb59db66bd07e0d966
https://github.com/ericsnowcurrently
Only use PyDict_* for dicts.https://github.com/python/cpython/pull/3593/commits/bcc72a539c695a34501a581d72df9749db97ffe8
bcc72a5https://github.com/python/cpython/pull/3593/commits/bcc72a539c695a34501a581d72df9749db97ffe8
https://github.com/ericsnowcurrently
Add a reference while cleaning up.https://github.com/python/cpython/pull/3593/commits/981dbd2cbb8495c9e0d49aa908800b2cd50f6183
981dbd2https://github.com/python/cpython/pull/3593/commits/981dbd2cbb8495c9e0d49aa908800b2cd50f6183
https://github.com/ericsnowcurrently
Fix _pickle.https://github.com/python/cpython/pull/3593/commits/0fe1aff2874f5c2efe59dece058051ceb100265e
0fe1affhttps://github.com/python/cpython/pull/3593/commits/0fe1aff2874f5c2efe59dece058051ceb100265e
https://github.com/ericsnowcurrently
Fix the NEWS entry.https://github.com/python/cpython/pull/3593/commits/d4d9219d59069af71b6d01d7d8ea32443cc922d8
d4d9219https://github.com/python/cpython/pull/3593/commits/d4d9219d59069af71b6d01d7d8ea32443cc922d8
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
September 14, 2017 23:32https://github.com/python/cpython/pull/3593#event-1250194058
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 14, 2017https://github.com/python/cpython/pull/3593#event-1250194093
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 14, 2017https://github.com/python/cpython/pull/3593#event-1250194107
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
force-pushedhttps://github.com/python/cpython/compare/5a0b5900e01fc2c0c7476b689751b9c0babeccdb..d4d9219d59069af71b6d01d7d8ea32443cc922d8
5a0b590https://github.com/python/cpython/commit/5a0b5900e01fc2c0c7476b689751b9c0babeccdb
d4d9219https://github.com/python/cpython/commit/d4d9219d59069af71b6d01d7d8ea32443cc922d8
Compare https://github.com/python/cpython/compare/5a0b5900e01fc2c0c7476b689751b9c0babeccdb..d4d9219d59069af71b6d01d7d8ea32443cc922d8
September 14, 2017 23:33https://github.com/python/cpython/pull/3593#event-1250194623
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Sep 15, 2017 https://github.com/python/cpython/pull/3593#pullrequestreview-62927359
View reviewed changes https://github.com/python/cpython/pull/3593/files/d4d9219d59069af71b6d01d7d8ea32443cc922d8
Python/import.chttps://github.com/python/cpython/pull/3593/files/d4d9219d59069af71b6d01d7d8ea32443cc922d8#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
ncoghlanhttps://github.com/ncoghlan
Sep 15, 2017https://github.com/python/cpython/pull/3593#discussion_r139046649
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3593
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 15, 2017https://github.com/python/cpython/pull/3593#discussion_r139048413
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3593
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 15, 2017https://github.com/python/cpython/pull/3593#discussion_r139048682
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3593
ncoghlanhttps://github.com/ncoghlan
Sep 15, 2017https://github.com/python/cpython/pull/3593#discussion_r139059262
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3593
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 15, 2017https://github.com/python/cpython/pull/3593#discussion_r139250516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3593
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Sep 15, 2017 https://github.com/python/cpython/pull/3593#pullrequestreview-62927452
View reviewed changes https://github.com/python/cpython/pull/3593/files/d4d9219d59069af71b6d01d7d8ea32443cc922d8
Python/import.chttps://github.com/python/cpython/pull/3593/files/d4d9219d59069af71b6d01d7d8ea32443cc922d8#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
ncoghlanhttps://github.com/ncoghlan
Sep 15, 2017https://github.com/python/cpython/pull/3593#discussion_r139046735
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3593
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 15, 2017https://github.com/python/cpython/pull/3593#discussion_r139048440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3593
https://github.com/ericsnowcurrently
Return a borrowed reference from _PyImport_GetModuleWithError().https://github.com/python/cpython/pull/3593/commits/9c3929574c70f349c0d1029700a8e704064bd762
9c39295https://github.com/python/cpython/pull/3593/commits/9c3929574c70f349c0d1029700a8e704064bd762
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 15, 2017https://github.com/python/cpython/pull/3593#issuecomment-329655252
Please reload this pagehttps://github.com/python/cpython/pull/3593
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Sep 15, 2017 https://github.com/python/cpython/pull/3593#pullrequestreview-62940774
View reviewed changes https://github.com/python/cpython/pull/3593/files/9c3929574c70f349c0d1029700a8e704064bd762
ncoghlanhttps://github.com/ncoghlan
https://github.com/python/cpython/pull/3593#pullrequestreview-62940774
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3593
Modules/_pickle.chttps://github.com/python/cpython/pull/3593/files/9c3929574c70f349c0d1029700a8e704064bd762#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
ncoghlanhttps://github.com/ncoghlan
Sep 15, 2017https://github.com/python/cpython/pull/3593#discussion_r139059331
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3593
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 15, 2017https://github.com/python/cpython/pull/3593#discussion_r139222974
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3593
Python/import.chttps://github.com/python/cpython/pull/3593/files/9c3929574c70f349c0d1029700a8e704064bd762#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
ncoghlanhttps://github.com/ncoghlan
Sep 15, 2017https://github.com/python/cpython/pull/3593#discussion_r139059398
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3593
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
September 15, 2017 19:27https://github.com/python/cpython/pull/3593#commits-pushed-446acd5
https://github.com/ericsnowcurrently
Fix some ref leaks.https://github.com/python/cpython/pull/3593/commits/446acd530af879b37a5cfc9fa2a98caca43ab3f7
446acd5https://github.com/python/cpython/pull/3593/commits/446acd530af879b37a5cfc9fa2a98caca43ab3f7
https://github.com/ericsnowcurrently
Add a fast path for pickle.https://github.com/python/cpython/pull/3593/commits/540b99a38d300443d067b1e18130f386a742478a
540b99ahttps://github.com/python/cpython/pull/3593/commits/540b99a38d300443d067b1e18130f386a742478a
https://github.com/ericsnowcurrently
Ignore errors from PyObject_GetItem().https://github.com/python/cpython/pull/3593/commits/5f0735b431d4d06359793c782bbd6237f35f22f7
5f0735bhttps://github.com/python/cpython/pull/3593/commits/5f0735b431d4d06359793c782bbd6237f35f22f7
https://github.com/ericsnowcurrently
Factor out _checkmodule.https://github.com/python/cpython/pull/3593/commits/63beead2f37d4d9abdc1c20fcc7186d149cd3515
63beeadhttps://github.com/python/cpython/pull/3593/commits/63beead2f37d4d9abdc1c20fcc7186d149cd3515
https://github.com/ericsnowcurrently
Drop an extra INCREF.https://github.com/python/cpython/pull/3593/commits/00f3f24af469ceba80683c781f3e85fc46247f8e
00f3f24https://github.com/python/cpython/pull/3593/commits/00f3f24af469ceba80683c781f3e85fc46247f8e
https://github.com/ericsnowcurrently
Drop _PyImport_GetModule() and _PyImport_GetModuleWithError().https://github.com/python/cpython/pull/3593/commits/5a7bba299e18b32441a004081ba3f43a3d6c2260
5a7bba2https://github.com/python/cpython/pull/3593/commits/5a7bba299e18b32441a004081ba3f43a3d6c2260
https://github.com/ericsnowcurrently
tabs to spaceshttps://github.com/python/cpython/pull/3593/commits/3a73b521187204c37b9d2d863d141b3bbb4811f2
3a73b52https://github.com/python/cpython/pull/3593/commits/3a73b521187204c37b9d2d863d141b3bbb4811f2
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
3f9eee6https://github.com/python/cpython/commit/3f9eee6eb4b25fe1926eaa5f00e02344b126f54d
Sep 15, 2017https://github.com/python/cpython/pull/3593#event-1251920427
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
September 15, 2017 22:35https://github.com/python/cpython/pull/3593#event-1251920589
https://github.com/Mariatta
Mariattahttps://github.com/Mariatta
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 8, 2017https://github.com/python/cpython/pull/3593#event-1283082715
https://github.com/jeremycline
jeremyclinehttps://github.com/jeremycline
Jun 29, 2018 https://github.com/python/cpython/pull/3593#ref-pullrequest-336703227
bpo-28411: Fix redundant declaration of _PyImport_AddModuleObject #7992 https://github.com/python/cpython/pull/7992
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Feb 5, 2019 https://github.com/python/cpython/pull/3593#ref-pullrequest-356555255
bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.modules #9047 https://github.com/python/cpython/pull/9047
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Apr 10, 2022 https://github.com/python/cpython/pull/3593#ref-issue-1198960780
[subinterpreters] Eliminate PyInterpreterState.modules. #72597 https://github.com/python/cpython/issues/72597
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Nov 21, 2025 https://github.com/python/cpython/pull/3593#ref-pullrequest-3652151623
gh-137422: Fix race condition in PyImport_AddModuleRef #141822 https://github.com/python/cpython/pull/141822
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3593
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/python/cpython/pull/3593/files/9c3929574c70f349c0d1029700a8e704064bd762
Please reload this pagehttps://github.com/python/cpython/pull/3593
https://github.com/ericsnowcurrently
https://github.com/ncoghlan
https://github.com/Mariatta
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.