René's URL Explorer Experiment


Title: bpo-28411: Isolate PyInterpreterState.modules by ericsnowcurrently · Pull Request #3575 · python/cpython · GitHub

Open Graph Title: bpo-28411: Isolate PyInterpreterState.modules by ericsnowcurrently · Pull Request #3575 · python/cpython

X Title: bpo-28411: Isolate PyInterpreterState.modules by ericsnowcurrently · Pull Request #3575 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: A bunch of code currently uses PyInterpreterState.modules directly instead of PyImport_GetModuleDict(). This complicates efforts to make changes relative to sys.modules. This patch switches to us...

X Description: A bunch of code currently uses PyInterpreterState.modules directly instead of PyImport_GetModuleDict(). This complicates efforts to make changes relative to sys.modules. This patch switches to us...

Opengraph URL: https://github.com/python/cpython/pull/3575

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f6284414-a60b-c662-d9c2-50e185cca28f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB09E:320EB:561E99F:7900A38:6A4FA656
html-safe-nonce686d5a1fedb3eb666b3d65a60b9c65c0fa3c5bfb2f384c0653bc7d99b088c874
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDlFOjMyMEVCOjU2MUU5OUY6NzkwMEEzODo2QTRGQTY1NiIsInZpc2l0b3JfaWQiOiI4MDA2OTcyNjY5NzQzMzEwNDIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac431d2cadb8602a9949f470dfe7d7aee7528429c270aa56843f91b2e1b5ff8eaf
hovercard-subject-tagpull_request:141105133
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/3575/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1eaec68ed6d65f233894e428f8572e5ff0c5a6adea90bc85cabce77393171346/python/cpython/pull/3575
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1eaec68ed6d65f233894e428f8572e5ff0c5a6adea90bc85cabce77393171346/python/cpython/pull/3575
og:image:altA bunch of code currently uses PyInterpreterState.modules directly instead of PyImport_GetModuleDict(). This complicates efforts to make changes relative to sys.modules. This patch switches to us...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3575#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3575
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3575
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3575
Reloadhttps://github.com/python/cpython/pull/3575
Reloadhttps://github.com/python/cpython/pull/3575
Please reload this pagehttps://github.com/python/cpython/pull/3575
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3575
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:masterhttps://github.com/python/cpython/tree/master
ericsnowcurrently:isolate-interp-moduleshttps://github.com/ericsnowcurrently/cpython/tree/isolate-interp-modules
Conversationhttps://github.com/python/cpython/pull/3575
Commits18 (18)https://github.com/python/cpython/pull/3575/commits
Checkshttps://github.com/python/cpython/pull/3575/checks
Files changedhttps://github.com/python/cpython/pull/3575/files
bpo-28411: Isolate PyInterpreterState.moduleshttps://github.com/python/cpython/pull/3575#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:masterhttps://github.com/python/cpython/tree/master
ericsnowcurrently:isolate-interp-moduleshttps://github.com/ericsnowcurrently/cpython/tree/isolate-interp-modules
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 14, 2017https://github.com/python/cpython/pull/3575#issue-257760327
Please reload this pagehttps://github.com/python/cpython/pull/3575
#1638https://github.com/python/cpython/pull/1638
https://bugs.python.org/issue28411https://bugs.python.org/issue28411
Please reload this pagehttps://github.com/python/cpython/pull/3575
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
September 14, 2017 07:21https://github.com/python/cpython/pull/3575#commits-pushed-2ff5d7c
https://github.com/ericsnowcurrently
Add _PyImport_GetModuleDict().https://github.com/python/cpython/pull/3575/commits/2ff5d7ca7e6d9ee13cda08467e29a00c5812ae80
2ff5d7chttps://github.com/python/cpython/pull/3575/commits/2ff5d7ca7e6d9ee13cda08467e29a00c5812ae80
https://github.com/ericsnowcurrently
Import the sys module before any other imports.https://github.com/python/cpython/pull/3575/commits/79a84612247ddbf11b0c91fc03cd2c29a704e657
79a8461https://github.com/python/cpython/pull/3575/commits/79a84612247ddbf11b0c91fc03cd2c29a704e657
https://github.com/ericsnowcurrently
Pass the modules dict to _PyImport_FindBuiltin().https://github.com/python/cpython/pull/3575/commits/6f96d3a673f5a4d291c5d70c1654506a16a20e5d
6f96d3ahttps://github.com/python/cpython/pull/3575/commits/6f96d3a673f5a4d291c5d70c1654506a16a20e5d
https://github.com/ericsnowcurrently
Replace usage of interp->modules with PyImport_GetModuleDict().https://github.com/python/cpython/pull/3575/commits/ad8c082fa07bca377a5ea646bdaab17837bd5bb4
ad8c082https://github.com/python/cpython/pull/3575/commits/ad8c082fa07bca377a5ea646bdaab17837bd5bb4
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
September 14, 2017 15:25https://github.com/python/cpython/pull/3575#event-1249450101
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 14, 2017https://github.com/python/cpython/pull/3575#event-1249450172
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 14, 2017https://github.com/python/cpython/pull/3575#event-1249450219
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
September 14, 2017 17:09https://github.com/python/cpython/pull/3575#commits-pushed-12f55d3
https://github.com/ericsnowcurrently
Add _PyImport_EnsureInitialized().https://github.com/python/cpython/pull/3575/commits/12f55d30be0a66760cb0806e06093e08f43c60da
12f55d3https://github.com/python/cpython/pull/3575/commits/12f55d30be0a66760cb0806e06093e08f43c60da
https://github.com/ericsnowcurrently
Add _PyModule_Create2().https://github.com/python/cpython/pull/3575/commits/eb2d6f980179a61b7b667b3dafc13a591e3efef1
eb2d6f9https://github.com/python/cpython/pull/3575/commits/eb2d6f980179a61b7b667b3dafc13a591e3efef1
https://github.com/ericsnowcurrently
Use _PyModule_Create2() for key builtin modules.https://github.com/python/cpython/pull/3575/commits/6a04c1c2f68fe17b6c33a9274c26148d14106dab
6a04c1chttps://github.com/python/cpython/pull/3575/commits/6a04c1c2f68fe17b6c33a9274c26148d14106dab
https://github.com/ericsnowcurrently
Check sys.modules in _PyImport_EnsureInitialized().https://github.com/python/cpython/pull/3575/commits/26bdb7e65ca9eb481af4801c4ca7880360495e25
26bdb7ehttps://github.com/python/cpython/pull/3575/commits/26bdb7e65ca9eb481af4801c4ca7880360495e25
https://github.com/ericsnowcurrently
Pass the modules dict to _PyImport_FixupBuiltin().https://github.com/python/cpython/pull/3575/commits/eac74033ee09643f6f1369fffe2eb30d148d0892
eac7403https://github.com/python/cpython/pull/3575/commits/eac74033ee09643f6f1369fffe2eb30d148d0892
https://github.com/ericsnowcurrently
Pass PyInterpreterState to _PyImport_GetModuleDict().https://github.com/python/cpython/pull/3575/commits/1166c57254c0fdda066e6b5ddc6a88e9696d707f
1166c57https://github.com/python/cpython/pull/3575/commits/1166c57254c0fdda066e6b5ddc6a88e9696d707f
https://github.com/ericsnowcurrently
Drop _PyImport_GetModuleDict().https://github.com/python/cpython/pull/3575/commits/da3ce95e65e39be547753f39ba262b043159c929
da3ce95https://github.com/python/cpython/pull/3575/commits/da3ce95e65e39be547753f39ba262b043159c929
https://github.com/ericsnowcurrently
_PyModule_Create2 -> _PyModule_CreateInitializedhttps://github.com/python/cpython/pull/3575/commits/ef17b812f0a0d06f84bb7edef148c52f769a110b
ef17b81https://github.com/python/cpython/pull/3575/commits/ef17b812f0a0d06f84bb7edef148c52f769a110b
https://github.com/ericsnowcurrently
_PyImport_EnsureInitialized() -> _PyImport_IsInitialized()https://github.com/python/cpython/pull/3575/commits/a17d5ff9366aac6b5f2991e6b45968f6432595ac
a17d5ffhttps://github.com/python/cpython/pull/3575/commits/a17d5ff9366aac6b5f2991e6b45968f6432595ac
https://github.com/ericsnowcurrently
Add a Misc/NEWS entry.https://github.com/python/cpython/pull/3575/commits/acc270b2c2b126d8e55f9029a308f6753a33c4b9
acc270bhttps://github.com/python/cpython/pull/3575/commits/acc270b2c2b126d8e55f9029a308f6753a33c4b9
https://github.com/ericsnowcurrently
Fix style (bracket placement).https://github.com/python/cpython/pull/3575/commits/bc6a0f14b725590fc54ac02bb03f2e9823298b3e
bc6a0f1https://github.com/python/cpython/pull/3575/commits/bc6a0f14b725590fc54ac02bb03f2e9823298b3e
https://github.com/ericsnowcurrently
Drop _PyImport_FixupExtensionObjectEx().https://github.com/python/cpython/pull/3575/commits/c7a25242925afc5e6d9808463766cd8dfda22601
c7a2524https://github.com/python/cpython/pull/3575/commits/c7a25242925afc5e6d9808463766cd8dfda22601
https://github.com/ericsnowcurrently
Fix the NEWS entry.https://github.com/python/cpython/pull/3575/commits/aceaacda94c6a40a3952088664c4cc381ad4c374
aceaacdhttps://github.com/python/cpython/pull/3575/commits/aceaacda94c6a40a3952088664c4cc381ad4c374
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
force-pushedhttps://github.com/python/cpython/compare/6714fd9ef5c732d6d613763960e6ec413592762d..aceaacda94c6a40a3952088664c4cc381ad4c374
6714fd9https://github.com/python/cpython/commit/6714fd9ef5c732d6d613763960e6ec413592762d
aceaacdhttps://github.com/python/cpython/commit/aceaacda94c6a40a3952088664c4cc381ad4c374
Compare https://github.com/python/cpython/compare/6714fd9ef5c732d6d613763960e6ec413592762d..aceaacda94c6a40a3952088664c4cc381ad4c374
September 14, 2017 17:10https://github.com/python/cpython/pull/3575#event-1249646427
https://github.com/ericsnowcurrently
Drop commented-out code.https://github.com/python/cpython/pull/3575/commits/5b87111ba5359c84e3d2a027e70212ac00ef073c
5b87111https://github.com/python/cpython/pull/3575/commits/5b87111ba5359c84e3d2a027e70212ac00ef073c
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
d393c1bhttps://github.com/python/cpython/commit/d393c1b227f22fb9af66040b2b367c99a4d1fa9a
Sep 14, 2017https://github.com/python/cpython/pull/3575#event-1249759924
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
September 14, 2017 18:32https://github.com/python/cpython/pull/3575#event-1249784513
https://github.com/Mariatta
Mariattahttps://github.com/Mariatta
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 8, 2017https://github.com/python/cpython/pull/3575#event-1283082761
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Apr 10, 2022 https://github.com/python/cpython/pull/3575#ref-issue-1198960780
[subinterpreters] Eliminate PyInterpreterState.modules. #72597 https://github.com/python/cpython/issues/72597
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3575
Please reload this pagehttps://github.com/python/cpython/pull/3575
https://github.com/ericsnowcurrently
https://github.com/Mariatta
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.