René's URL Explorer Experiment


Title: bpo-16251: pickle special methods and custom __getattr__ by ambv · Pull Request #3508 · python/cpython · GitHub

Open Graph Title: bpo-16251: pickle special methods and custom __getattr__ by ambv · Pull Request #3508 · python/cpython

X Title: bpo-16251: pickle special methods and custom __getattr__ by ambv · Pull Request #3508 · python/cpython

Description: This PR doesn't change the lookup to types as the issue's title on BPO suggests. As Antoine and Raymond point out, there'd be significant danger of breaking existing code. Instead, we're doing the following: introducing a new function in copyreg called getcallable() that mimics getattr() but swallows all exceptions (like hasattr() on Python 2) and does some basic callability tests; switching all relevant usage of hasattr() and getattr() in copy and copyreg to use getcallable() instead. This fixes two common failure scenarios covered at length in bpo-16251, its duplicates, as well as on StackOverflow, etc. Worth fixing IMHO. Funnily enough, the recursion limit exceeded scenario happened to work on Python 2 since hasattr() there swallowed the RecursionError. https://bugs.python.org/issue16251

Open Graph Description: This PR doesn't change the lookup to types as the issue's title on BPO suggests. As Antoine and Raymond point out, there'd be significant danger of breaking existing code. Instead, we&...

X Description: This PR doesn't change the lookup to types as the issue's title on BPO suggests. As Antoine and Raymond point out, there'd be significant danger of breaking existing code. ...

Opengraph URL: https://github.com/python/cpython/pull/3508

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:af26a64f-1ffb-5316-baae-3ed24b5ce495
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8CC:23E48:2CF049:38A844:6B020809
html-safe-nonce592f40633d9e20203fdbecce8c5ded56735164c802aec2bd8abd71eed2cc6699
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOENDOjIzRTQ4OjJDRjA0OTozOEE4NDQ6NkIwMjA4MDkiLCJ2aXNpdG9yX2lkIjoiMTgwODQ1NjE0NTY3Nzk3NzYwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac471bb06321a549d58c8dd8a1e4016730e0b3946be48a4aa5b7f6e547c25892de
hovercard-subject-tagpull_request:140478237
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/3508/files
twitter:imagehttps://avatars.githubusercontent.com/u/55281?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55281?s=400&v=4
og:image:altThis PR doesn't change the lookup to types as the issue's title on BPO suggests. As Antoine and Raymond point out, there'd be significant danger of breaking existing code. Instead, we&...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3508/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3508%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3508%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3508/files
Reloadhttps://github.com/python/cpython/pull/3508/files
Reloadhttps://github.com/python/cpython/pull/3508/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:masterhttps://github.com/python/cpython/tree/master
ambv:bpo-16251https://github.com/ambv/cpython/tree/bpo-16251
Conversation 4 https://github.com/python/cpython/pull/3508
Commits 1 https://github.com/python/cpython/pull/3508/commits
Checks 0 https://github.com/python/cpython/pull/3508/checks
Files changed https://github.com/python/cpython/pull/3508/files
Please reload this pagehttps://github.com/python/cpython/pull/3508/files
bpo-16251: pickle special methods and custom __getattr__ https://github.com/python/cpython/pull/3508/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/3508/files
61706b0 bpo-16251: pickle special methods and custom __getattr__ Sep 12, 2017 https://github.com/python/cpython/pull/3508/commits/61706b0c1c0565bead10b6fcea5a271d77b0dc53
Clear filters https://github.com/python/cpython/pull/3508/files
Please reload this pagehttps://github.com/python/cpython/pull/3508/files
Please reload this pagehttps://github.com/python/cpython/pull/3508/files
copy.py https://github.com/python/cpython/pull/3508/files#diff-a06198e13686594114a45e7863b954a226ce08d43f724079faa7fe8b3c931703
copyreg.py https://github.com/python/cpython/pull/3508/files#diff-3fd2e552779d3d96e7c1f2d80f4b8fd88752ef5437f42201037ed7c76bba2779
test_copy.py https://github.com/python/cpython/pull/3508/files#diff-e523221c4331dc96024d5c3a51a1c0d8ef2d11aa4ff0429d9fa286d054189bbb
Lib/copy.pyhttps://github.com/python/cpython/pull/3508/files#diff-a06198e13686594114a45e7863b954a226ce08d43f724079faa7fe8b3c931703
View file https://github.com/ambv/cpython/blob/61706b0c1c0565bead10b6fcea5a271d77b0dc53/Lib/copy.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3508/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3508/files#diff-a06198e13686594114a45e7863b954a226ce08d43f724079faa7fe8b3c931703
https://github.com/python/cpython/pull/3508/files#diff-a06198e13686594114a45e7863b954a226ce08d43f724079faa7fe8b3c931703
https://github.com/python/cpython/pull/3508/files#diff-a06198e13686594114a45e7863b954a226ce08d43f724079faa7fe8b3c931703
https://github.com/python/cpython/pull/3508/files#diff-a06198e13686594114a45e7863b954a226ce08d43f724079faa7fe8b3c931703
ambvhttps://github.com/ambv
Sep 12, 2017https://github.com/python/cpython/pull/3508/files#r138242699
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3508/files
https://github.com/python/cpython/pull/3508/files#diff-a06198e13686594114a45e7863b954a226ce08d43f724079faa7fe8b3c931703
https://github.com/python/cpython/pull/3508/files#diff-a06198e13686594114a45e7863b954a226ce08d43f724079faa7fe8b3c931703
https://github.com/python/cpython/pull/3508/files#diff-a06198e13686594114a45e7863b954a226ce08d43f724079faa7fe8b3c931703
https://github.com/python/cpython/pull/3508/files#diff-a06198e13686594114a45e7863b954a226ce08d43f724079faa7fe8b3c931703
https://github.com/python/cpython/pull/3508/files#diff-a06198e13686594114a45e7863b954a226ce08d43f724079faa7fe8b3c931703
https://github.com/python/cpython/pull/3508/files#diff-a06198e13686594114a45e7863b954a226ce08d43f724079faa7fe8b3c931703
Lib/copyreg.pyhttps://github.com/python/cpython/pull/3508/files#diff-3fd2e552779d3d96e7c1f2d80f4b8fd88752ef5437f42201037ed7c76bba2779
View file https://github.com/ambv/cpython/blob/61706b0c1c0565bead10b6fcea5a271d77b0dc53/Lib/copyreg.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3508/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3508/files#diff-3fd2e552779d3d96e7c1f2d80f4b8fd88752ef5437f42201037ed7c76bba2779
https://github.com/python/cpython/pull/3508/files#diff-3fd2e552779d3d96e7c1f2d80f4b8fd88752ef5437f42201037ed7c76bba2779
https://github.com/python/cpython/pull/3508/files#diff-3fd2e552779d3d96e7c1f2d80f4b8fd88752ef5437f42201037ed7c76bba2779
https://github.com/python/cpython/pull/3508/files#diff-3fd2e552779d3d96e7c1f2d80f4b8fd88752ef5437f42201037ed7c76bba2779
Lib/test/test_copy.pyhttps://github.com/python/cpython/pull/3508/files#diff-e523221c4331dc96024d5c3a51a1c0d8ef2d11aa4ff0429d9fa286d054189bbb
View file https://github.com/ambv/cpython/blob/61706b0c1c0565bead10b6fcea5a271d77b0dc53/Lib/test/test_copy.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3508/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3508/files#diff-e523221c4331dc96024d5c3a51a1c0d8ef2d11aa4ff0429d9fa286d054189bbb
ambvhttps://github.com/ambv
Sep 12, 2017https://github.com/python/cpython/pull/3508/files#r138242560
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3508/files
ambvhttps://github.com/ambv
Sep 12, 2017https://github.com/python/cpython/pull/3508/files#r138242593
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3508/files
https://github.com/python/cpython/pull/3508/files#diff-e523221c4331dc96024d5c3a51a1c0d8ef2d11aa4ff0429d9fa286d054189bbb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.