René's URL Explorer Experiment


Title: bpo-28638: Optimize namedtuple() creation time by minimizing use of exec() by rhettinger · Pull Request #3454 · python/cpython · GitHub

Open Graph Title: bpo-28638: Optimize namedtuple() creation time by minimizing use of exec() by rhettinger · Pull Request #3454 · python/cpython

X Title: bpo-28638: Optimize namedtuple() creation time by minimizing use of exec() by rhettinger · Pull Request #3454 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Current version passes tests but doesn't not support the _source attribute or the verbose option. Obtains a 5x creation time speed-up and with small positive impacts on post creation performanc...

X Description: Current version passes tests but doesn't not support the _source attribute or the verbose option. Obtains a 5x creation time speed-up and with small positive impacts on post creation perfor...

Opengraph URL: https://github.com/python/cpython/pull/3454

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ec30e5e4-108b-3ccb-e389-19dd2ac46b6e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB00E:9B4C9:103B18C:16ACA82:6A4E9705
html-safe-nonce94cb0fb1e8705e8717e09dd3fb49a1d556b47f5da681f30510bf6db03f4349e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDBFOjlCNEM5OjEwM0IxOEM6MTZBQ0E4Mjo2QTRFOTcwNSIsInZpc2l0b3JfaWQiOiI0ODEyODEzOTgyODU4Mzg1MTU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf2f0d17c2443e139c946f139ba8f04728605e0596c821e48681daab0753ca7d9
hovercard-subject-tagpull_request:139969979
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/3454/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6c41100a37e5876e2bfbd844d7657490019d031dd7f901db6b1d618393539ae1/python/cpython/pull/3454
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6c41100a37e5876e2bfbd844d7657490019d031dd7f901db6b1d618393539ae1/python/cpython/pull/3454
og:image:altCurrent version passes tests but doesn't not support the _source attribute or the verbose option. Obtains a 5x creation time speed-up and with small positive impacts on post creation performanc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerhettinger
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3454#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3454
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3454
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3454
Reloadhttps://github.com/python/cpython/pull/3454
Reloadhttps://github.com/python/cpython/pull/3454
Please reload this pagehttps://github.com/python/cpython/pull/3454
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3454
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
rhettingerhttps://github.com/rhettinger
python:masterhttps://github.com/python/cpython/tree/master
rhettinger:optimize-namedtuplehttps://github.com/rhettinger/cpython/tree/optimize-namedtuple
Conversationhttps://github.com/python/cpython/pull/3454
Commits23 (23)https://github.com/python/cpython/pull/3454/commits
Checkshttps://github.com/python/cpython/pull/3454/checks
Files changedhttps://github.com/python/cpython/pull/3454/files
bpo-28638: Optimize namedtuple() creation time by minimizing use of exec()https://github.com/python/cpython/pull/3454#top
rhettingerhttps://github.com/rhettinger
python:masterhttps://github.com/python/cpython/tree/master
rhettinger:optimize-namedtuplehttps://github.com/rhettinger/cpython/tree/optimize-namedtuple
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
Sep 8, 2017https://github.com/python/cpython/pull/3454#issue-256162179
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://bugs.python.org/issue28638https://bugs.python.org/issue28638
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/rhettinger
Working draft without _sourcehttps://github.com/python/cpython/pull/3454/commits/baca675956bab1c58c393a223d55c31ffc56e310
baca675https://github.com/python/cpython/pull/3454/commits/baca675956bab1c58c393a223d55c31ffc56e310
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
Sep 8, 2017https://github.com/python/cpython/pull/3454#event-1240267555
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
Sep 8, 2017https://github.com/python/cpython/pull/3454#event-1240267560
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Sep 8, 2017https://github.com/python/cpython/pull/3454#event-1240267621
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 8, 2017https://github.com/python/cpython/pull/3454#event-1240267623
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 8, 2017https://github.com/python/cpython/pull/3454#event-1240267624
rhettingerhttps://github.com/rhettinger
September 8, 2017 01:06https://github.com/python/cpython/pull/3454#commits-pushed-3a2aa41
https://github.com/rhettinger
Re-use itemgetter() instanceshttps://github.com/python/cpython/pull/3454/commits/3a2aa415618ef45af68f21afbd1ce56f95693c9c
3a2aa41https://github.com/python/cpython/pull/3454/commits/3a2aa415618ef45af68f21afbd1ce56f95693c9c
https://github.com/rhettinger
Speed-up calls to __new__() with a pre-bound tuple.__new__()https://github.com/python/cpython/pull/3454/commits/e24ef4beb1cbb90639af13bc09a367bf54c7a48c
e24ef4bhttps://github.com/python/cpython/pull/3454/commits/e24ef4beb1cbb90639af13bc09a367bf54c7a48c
https://github.com/rhettinger
Add note regarding string interninghttps://github.com/python/cpython/pull/3454/commits/49aa967264c56110863bf87acb5c2303c4c61c01
49aa967https://github.com/python/cpython/pull/3454/commits/49aa967264c56110863bf87acb5c2303c4c61c01
https://github.com/methane
methanehttps://github.com/methane
Sep 8, 2017 https://github.com/python/cpython/pull/3454#pullrequestreview-61480430
View reviewed changes https://github.com/python/cpython/pull/3454/files/49aa967264c56110863bf87acb5c2303c4c61c01
Lib/collections/__init__.pyhttps://github.com/python/cpython/pull/3454/files/49aa967264c56110863bf87acb5c2303c4c61c01#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
methanehttps://github.com/methane
Sep 8, 2017https://github.com/python/cpython/pull/3454#discussion_r137768742
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
rhettingerhttps://github.com/rhettinger
Sep 8, 2017https://github.com/python/cpython/pull/3454#discussion_r137884776
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
rhettingerhttps://github.com/rhettinger
September 8, 2017 09:51https://github.com/python/cpython/pull/3454#commits-pushed-c34b444
https://github.com/rhettinger
Remove unnecessary create function wrappershttps://github.com/python/cpython/pull/3454/commits/c34b44488feb94901b5c224989d72bbddb1d9786
c34b444https://github.com/python/cpython/pull/3454/commits/c34b44488feb94901b5c224989d72bbddb1d9786
https://github.com/rhettinger
Minor sync-ups with PR-2736. Mostly formatting and f-stringshttps://github.com/python/cpython/pull/3454/commits/0c7f16393c33350809396cc6c3491c1e767f0805
0c7f163https://github.com/python/cpython/pull/3454/commits/0c7f16393c33350809396cc6c3491c1e767f0805
https://github.com/rhettinger
Bring-in qualname/__module fix-ups from PR-2736https://github.com/python/cpython/pull/3454/commits/5de0b7fd80bf9db74ea136b4d16d1cfb5a2aff28
5de0b7fhttps://github.com/python/cpython/pull/3454/commits/5de0b7fd80bf9db74ea136b4d16d1cfb5a2aff28
https://github.com/rhettinger
Formally remove the verbose flag and _source attributehttps://github.com/python/cpython/pull/3454/commits/ca643f4acb542c64cb6aae58ce06b5d4e11f6e7c
ca643f4https://github.com/python/cpython/pull/3454/commits/ca643f4acb542c64cb6aae58ce06b5d4e11f6e7c
https://github.com/rhettinger
Restore a test of potentially problematic field nameshttps://github.com/python/cpython/pull/3454/commits/e18b92ed04e43b914ddc0f3acf69e5dbef848ef8
e18b92ehttps://github.com/python/cpython/pull/3454/commits/e18b92ed04e43b914ddc0f3acf69e5dbef848ef8
https://github.com/rhettinger
Restore kwonly_args test but without the verbose optionhttps://github.com/python/cpython/pull/3454/commits/0851fc76dbdeef765ca070208f505e29b7b8d1e8
0851fc7https://github.com/python/cpython/pull/3454/commits/0851fc76dbdeef765ca070208f505e29b7b8d1e8
https://github.com/rhettinger
Adopt Inada's idea to reuse the docstrings for the itemgettershttps://github.com/python/cpython/pull/3454/commits/3ac1151fda5bbfb8da18c7c44b56477fbe71293a
3ac1151https://github.com/python/cpython/pull/3454/commits/3ac1151fda5bbfb8da18c7c44b56477fbe71293a
https://github.com/rhettinger
Neaten-up a bithttps://github.com/python/cpython/pull/3454/commits/b31f0639f3f83ca4a7a98715a2693742a97bf8f6
b31f063https://github.com/python/cpython/pull/3454/commits/b31f0639f3f83ca4a7a98715a2693742a97bf8f6
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
Sep 8, 2017 https://github.com/python/cpython/pull/3454#ref-pullrequest-243270044
bpo-28638: speed up namedtuple creation by avoiding exec #2736 https://github.com/python/cpython/pull/2736
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
Sep 8, 2017https://github.com/python/cpython/pull/3454#issuecomment-328213920
#2736https://github.com/python/cpython/pull/2736
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/rhettinger
Add news blurbhttps://github.com/python/cpython/pull/3454/commits/deb30a2fe688832de98c2ebfd962d060d54d5ef6
deb30a2https://github.com/python/cpython/pull/3454/commits/deb30a2fe688832de98c2ebfd962d060d54d5ef6
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
Sep 8, 2017https://github.com/python/cpython/pull/3454#event-1241538929
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
September 8, 2017 21:52https://github.com/python/cpython/pull/3454#event-1241560404
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 8, 2017 https://github.com/python/cpython/pull/3454#pullrequestreview-61632653
View reviewed changes https://github.com/python/cpython/pull/3454/files/deb30a2fe688832de98c2ebfd962d060d54d5ef6
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/3454#pullrequestreview-61632653
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
Lib/collections/__init__.pyhttps://github.com/python/cpython/pull/3454/files/deb30a2fe688832de98c2ebfd962d060d54d5ef6#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 8, 2017https://github.com/python/cpython/pull/3454#discussion_r137898304
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
Sep 8, 2017 https://github.com/python/cpython/pull/3454#pullrequestreview-61641606
View reviewed changes https://github.com/python/cpython/pull/3454/files/deb30a2fe688832de98c2ebfd962d060d54d5ef6
Lib/collections/__init__.pyhttps://github.com/python/cpython/pull/3454/files/deb30a2fe688832de98c2ebfd962d060d54d5ef6#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
emmatypinghttps://github.com/emmatyping
Sep 8, 2017https://github.com/python/cpython/pull/3454#discussion_r137906152
Please reload this pagehttps://github.com/python/cpython/pull/3454
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
rhettingerhttps://github.com/rhettinger
Sep 8, 2017https://github.com/python/cpython/pull/3454#discussion_r137907524
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
emmatypinghttps://github.com/emmatyping
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137913268
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
rhettingerhttps://github.com/rhettinger
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137919291
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
emmatypinghttps://github.com/emmatyping
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137920747
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 8, 2017https://github.com/python/cpython/pull/3454#event-1241626151
https://github.com/methane
methanehttps://github.com/methane
Sep 9, 2017 https://github.com/python/cpython/pull/3454#pullrequestreview-61647259
View reviewed changes https://github.com/python/cpython/pull/3454/files/deb30a2fe688832de98c2ebfd962d060d54d5ef6
Lib/collections/__init__.pyhttps://github.com/python/cpython/pull/3454/files/deb30a2fe688832de98c2ebfd962d060d54d5ef6#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
methanehttps://github.com/methane
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137911290
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
rhettingerhttps://github.com/rhettinger
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137919239
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
methanehttps://github.com/methane
Sep 10, 2017https://github.com/python/cpython/pull/3454#discussion_r137939156
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/rhettinger
Merge branch 'master' of github.com:python/cpython into optimize-name…https://github.com/python/cpython/pull/3454/commits/f402cb3a1a890e0bd5451680a3c78ebff868f448
f402cb3https://github.com/python/cpython/pull/3454/commits/f402cb3a1a890e0bd5451680a3c78ebff868f448
https://github.com/rhettinger
Serhiy pointed-out the need for interninghttps://github.com/python/cpython/pull/3454/commits/86cef9e8ef80217dcb93e2f11821683a91930faa
86cef9ehttps://github.com/python/cpython/pull/3454/commits/86cef9e8ef80217dcb93e2f11821683a91930faa
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Sep 9, 2017 https://github.com/python/cpython/pull/3454#pullrequestreview-61655683
View reviewed changes https://github.com/python/cpython/pull/3454/files/86cef9e8ef80217dcb93e2f11821683a91930faa
Lib/collections/__init__.pyhttps://github.com/python/cpython/pull/3454/files/86cef9e8ef80217dcb93e2f11821683a91930faa#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
JelleZijlstrahttps://github.com/JelleZijlstra
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137918939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
rhettingerhttps://github.com/rhettinger
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137919399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/rhettinger
Jelle noticed as missing f on an f-stringhttps://github.com/python/cpython/pull/3454/commits/83b5e93876ea47b81a476c79767306cb474b9152
83b5e93https://github.com/python/cpython/pull/3454/commits/83b5e93876ea47b81a476c79767306cb474b9152
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 9, 2017 https://github.com/python/cpython/pull/3454#pullrequestreview-61656628
View reviewed changes https://github.com/python/cpython/pull/3454/files/83b5e93876ea47b81a476c79767306cb474b9152
Lib/collections/__init__.pyhttps://github.com/python/cpython/pull/3454/files/83b5e93876ea47b81a476c79767306cb474b9152#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137919839
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
rhettingerhttps://github.com/rhettinger
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137931708
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137932798
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
rhettingerhttps://github.com/rhettinger
September 9, 2017 10:50https://github.com/python/cpython/pull/3454#commits-pushed-0168317
https://github.com/rhettinger
Add whatsnew entry for feature removalhttps://github.com/python/cpython/pull/3454/commits/0168317c6ebf19be74990479003eb8d81faf7694
0168317https://github.com/python/cpython/pull/3454/commits/0168317c6ebf19be74990479003eb8d81faf7694
https://github.com/rhettinger
Accede to request for dict literals instead keyword argumentshttps://github.com/python/cpython/pull/3454/commits/dadafc06fd0ff8fc9f78511d73ca6b1485b17791
dadafc0https://github.com/python/cpython/pull/3454/commits/dadafc06fd0ff8fc9f78511d73ca6b1485b17791
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 9, 2017 https://github.com/python/cpython/pull/3454#pullrequestreview-61668776
View reviewed changes https://github.com/python/cpython/pull/3454/files/0168317c6ebf19be74990479003eb8d81faf7694
Lib/collections/__init__.pyhttps://github.com/python/cpython/pull/3454/files/83b5e93876ea47b81a476c79767306cb474b9152#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137932798
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
Doc/whatsnew/3.7.rsthttps://github.com/python/cpython/pull/3454/files/0168317c6ebf19be74990479003eb8d81faf7694#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137932902
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
rhettingerhttps://github.com/rhettinger
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137933344
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
methanehttps://github.com/methane
Sep 10, 2017https://github.com/python/cpython/pull/3454#discussion_r137939162
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
Doc/whatsnew/3.7.rsthttps://github.com/python/cpython/pull/3454/files/0168317c6ebf19be74990479003eb8d81faf7694#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137932939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
rhettingerhttps://github.com/rhettinger
Sep 9, 2017https://github.com/python/cpython/pull/3454#discussion_r137933306
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/rhettinger
Leave the method.__module__ attribute pointing the actual location of…https://github.com/python/cpython/pull/3454/commits/483d08c4e9b949703a3bc2eae73095b4cdc739b1
483d08chttps://github.com/python/cpython/pull/3454/commits/483d08c4e9b949703a3bc2eae73095b4cdc739b1
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 9, 2017 https://github.com/python/cpython/pull/3454#pullrequestreview-61669718
View reviewed changes https://github.com/python/cpython/pull/3454/files/483d08c4e9b949703a3bc2eae73095b4cdc739b1
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/3454#pullrequestreview-61669718
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 9, 2017https://github.com/python/cpython/pull/3454#event-1241969950
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
Sep 10, 2017https://github.com/python/cpython/pull/3454#issuecomment-328313763
Please reload this pagehttps://github.com/python/cpython/pull/3454
rhettingerhttps://github.com/rhettinger
September 9, 2017 21:57https://github.com/python/cpython/pull/3454#commits-pushed-bc6852c
https://github.com/rhettinger
Improve variable names and add a micro-optimization for an non-public…https://github.com/python/cpython/pull/3454/commits/bc6852c014cda6be19d8f39daca1966a9b9d5536
bc6852chttps://github.com/python/cpython/pull/3454/commits/bc6852c014cda6be19d8f39daca1966a9b9d5536
https://github.com/rhettinger
Simplify by in-lining reuse_itemgetter()https://github.com/python/cpython/pull/3454/commits/c8976744fc3ac2f03c25d942c02271b29cb6352c
c897674https://github.com/python/cpython/pull/3454/commits/c8976744fc3ac2f03c25d942c02271b29cb6352c
https://github.com/rhettinger
Arrange steps in more logical orderhttps://github.com/python/cpython/pull/3454/commits/bd4ea4ece39fd46a953e7c284e4ee6cc4bfc72dd
bd4ea4ehttps://github.com/python/cpython/pull/3454/commits/bd4ea4ece39fd46a953e7c284e4ee6cc4bfc72dd
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 10, 2017 https://github.com/python/cpython/pull/3454#pullrequestreview-61677981
View reviewed changes https://github.com/python/cpython/pull/3454/files/bd4ea4ece39fd46a953e7c284e4ee6cc4bfc72dd
Lib/collections/__init__.pyhttps://github.com/python/cpython/pull/3454/files/bd4ea4ece39fd46a953e7c284e4ee6cc4bfc72dd#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 10, 2017https://github.com/python/cpython/pull/3454#discussion_r137942569
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
rhettingerhttps://github.com/rhettinger
Sep 10, 2017https://github.com/python/cpython/pull/3454#discussion_r137942701
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 10, 2017https://github.com/python/cpython/pull/3454#discussion_r137943001
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/rhettinger
Save docstring in local cache instead of interninghttps://github.com/python/cpython/pull/3454/commits/ffb78c991e6c2d1719e73ae6b9900fe143f97467
ffb78c9https://github.com/python/cpython/pull/3454/commits/ffb78c991e6c2d1719e73ae6b9900fe143f97467
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 10, 2017 https://github.com/python/cpython/pull/3454#pullrequestreview-61688155
View reviewed changes https://github.com/python/cpython/pull/3454/files/ffb78c991e6c2d1719e73ae6b9900fe143f97467
Lib/collections/__init__.pyhttps://github.com/python/cpython/pull/3454/files/ffb78c991e6c2d1719e73ae6b9900fe143f97467#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
8b57d73https://github.com/python/cpython/commit/8b57d7363916869357848e666d03fa7614c47897
Sep 10, 2017https://github.com/python/cpython/pull/3454#event-1242269698
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
September 10, 2017 17:23https://github.com/python/cpython/pull/3454#event-1242269773
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 10, 2017https://github.com/python/cpython/pull/3454#issuecomment-328363905
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/methane
methanehttps://github.com/methane
Sep 11, 2017https://github.com/python/cpython/pull/3454#issuecomment-328414696
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/Mariatta
Mariattahttps://github.com/Mariatta
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 8, 2017https://github.com/python/cpython/pull/3454#event-1283082879
https://github.com/yan12125
yan12125https://github.com/yan12125
Jul 10, 2018 https://github.com/python/cpython/pull/3454#ref-pullrequest-337244036
[postponed] tox/Travis: test against Python 3.7 davidhalter/jedi#1161 https://github.com/davidhalter/jedi/pull/1161
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3454
https://github.com/methane
methane https://github.com/methane
https://github.com/python/cpython/pull/3454/files/0168317c6ebf19be74990479003eb8d81faf7694
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/cpython/pull/3454/files/86cef9e8ef80217dcb93e2f11821683a91930faa
https://github.com/emmatyping
emmatyping https://github.com/emmatyping
https://github.com/python/cpython/pull/3454/files/deb30a2fe688832de98c2ebfd962d060d54d5ef6
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/3454/files/ffb78c991e6c2d1719e73ae6b9900fe143f97467
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
Please reload this pagehttps://github.com/python/cpython/pull/3454
https://github.com/rhettinger
https://github.com/gvanrossum
https://github.com/methane
https://github.com/JelleZijlstra
https://github.com/serhiy-storchaka
https://github.com/emmatyping
https://github.com/Mariatta
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.